use std::format

Remove use of fmt and replace with the std::format version.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ib89de0b3d10866276964db7b3fa8d97991df410d

span: switch to std

Reduce the dependency on stdplus' version of span now that we are using
C++20 and use the one out of the STL instead.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-

span: switch to std

Reduce the dependency on stdplus' version of span now that we are using
C++20 and use the one out of the STL instead.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I040ba1796d6f278353fbc990ea6b62314927951e

show more ...

tools: Support empty image file and ignore the fileSize check

Removed the unit test for checking file size of zero.

Tested:

Sending `/dev/null` and still works fine.

tools: Support empty image file and ignore the fileSize check

Removed the unit test for checking file size of zero.

Tested:

Sending `/dev/null` and still works fine.

Change-Id: Ibbde4fd430d9550fb7b75b6a583a53d4425d8075
Signed-off-by: Willy Tu <wltu@google.com>

show more ...

catch exceptions as const

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ic72f02ce23c85436f61f593e14e75ab34e99fabe

tools/progress: Add finish and abort functions

We have external progress handlers which would like to implement these
functions, in order to update the screen upon completion or error.

tools/progress: Add finish and abort functions

We have external progress handlers which would like to implement these
functions, in order to update the screen upon completion or error.

Change-Id: I2df4654d5e2092407a83d2c8bbb020dcce84ac50
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

Add option to skip p2a bridge disable

Add a new constructor for P2aDataHandler with skipBridgeDisable bool to
enable an option to skip disableBridge() in AspeedPciBridge and
NuvotonP

Add option to skip p2a bridge disable

Add a new constructor for P2aDataHandler with skipBridgeDisable bool to
enable an option to skip disableBridge() in AspeedPciBridge and
NuvotonPciBridge.

Signed-off-by: Willy Tu <wltu@google.com>
Change-Id: I439bbaa2b7295adc54a8aa98157db60a7e820837

show more ...

tools/pci: refactor PCI bridge

Use polymorphism to handle the differences between Aspeed and Nuvoton
PCI devices.

Add unit tests (now at 100% line coverage for tools/pci.cpp).

tools/pci: refactor PCI bridge

Use polymorphism to handle the differences between Aspeed and Nuvoton
PCI devices.

Add unit tests (now at 100% line coverage for tools/pci.cpp).

Signed-off-by: Benjamin Fair <benjaminfair@google.com>
Change-Id: I43e63ec5eb9fce5fb0fc74e0e69667dd13b7433f

show more ...

update gcc10 and clang-format10

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I72239b884615d26b2c4311c49a26e2eced0a1fb0

tools: implement pci support for Nuvoton

Note: burn_my_bmc will detect the PCI device at runtime
as Aspeed vs Nuvoton
Tested: Verified this works for a Nuvoton BMC.

Si

tools: implement pci support for Nuvoton

Note: burn_my_bmc will detect the PCI device at runtime
as Aspeed vs Nuvoton
Tested: Verified this works for a Nuvoton BMC.

Signed-off-by: Medad CChien <ctcchien@nuvoton.com>
Change-Id: Ifb253dee301f4d39582269f7d3e9b4f423fdfde3

show more ...

tools: p2a: enable bridge on host side

Enable the PCI-to-AHB bridge from the host-side.

Note: On my test system, this didn't seem to be required, it's possible
the bit was stuck

tools: p2a: enable bridge on host side

Enable the PCI-to-AHB bridge from the host-side.

Note: On my test system, this didn't seem to be required, it's possible
the bit was stuck on when enabled.
Tested: Not tested.
Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: Idbea0e9d378ee108f24240d64b43b6a3c0eea799

show more ...

bugfix: tools: p2a: read returns bool

The read method returns bool, therefore if this returns 0, it's false,
and therefore the read failed.

Signed-off-by: Patrick Venture <ventu

bugfix: tools: p2a: read returns bool

The read method returns bool, therefore if this returns 0, it's false,
and therefore the read failed.

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I365f9edf49a79ca5ea3c13090d6b8a11b9598e53

show more ...

tools: add progress implementation

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I9da1674d6cbc688efc7bab0e033788d6ee4694f7

tools: remove phosphor-ipmi-blobs dependency

The host tool depended on the BMC header: firmware_handler.hpp because
it defined the flags. This header depends on phosphor-ipmi-blobs,

tools: remove phosphor-ipmi-blobs dependency

The host tool depended on the BMC header: firmware_handler.hpp because
it defined the flags. This header depends on phosphor-ipmi-blobs,
therefore the host-tool depends on this. Move the flags into a separate
common header file and snip this dependency.

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: Id2ad33a1611c02605a1ed5c695429d0451eb98d4

show more ...

tools: scope of the variable 'bytesRead' can be reduced.

(style) The scope of the variable 'bytesRead' can be reduced.
[tools/bt.cpp:21]
[tools/p2a.cpp:111]

Signed-off-by: P

tools: scope of the variable 'bytesRead' can be reduced.

(style) The scope of the variable 'bytesRead' can be reduced.
[tools/bt.cpp:21]
[tools/p2a.cpp:111]

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I6b96247a02cd35d073b424501bb161e80aedf3b4

show more ...

bmc: move away from blobs namespace

The blobs namespace is really owned by phosphor-ipmi-blobs. Move all
phosphor-ipmi-flash objects into ipmi_flash namespace.

Signed-off-by: P

bmc: move away from blobs namespace

The blobs namespace is really owned by phosphor-ipmi-blobs. Move all
phosphor-ipmi-flash objects into ipmi_flash namespace.

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I51b721ad4f3cdc4cc43846c942967ed2e5f16589

show more ...

bugfix: tools: use pci member

Tool worked by declaring its own pci utility object instead of using the
one provided. There are not yet unit-tests associated with the
P2aDataHandler

bugfix: tools: use pci member

Tool worked by declaring its own pci utility object instead of using the
one provided. There are not yet unit-tests associated with the
P2aDataHandler that would have caught this.

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I62cdeb17d298f1db51d8f513c59bfd299fc2884a

show more ...

pci: implement sending firmware image over p2a

Implement sending firmware image over p2a via the aspeed-p2a-ctrl
driver.

Test configuration:
# Image is static, uses the PCI

pci: implement sending firmware image over p2a

Implement sending firmware image over p2a via the aspeed-p2a-ctrl
driver.

Test configuration:
# Image is static, uses the PCI bridge, and requires the ASPEED
# PCI-to-AHB hardware implementation.
EXTRA_OECONF_append_quanta-q71l = " --enable-static-layout"
EXTRA_OECONF_append_quanta-q71l = " --enable-pci-bridge"
EXTRA_OECONF_append_quanta-q71l = " --enable-aspeed-p2a"
EXTRA_OECONF_append_quanta-q71l = " MAPPED_ADDRESS=0x47FF0000"

Tested: Verified via md5sum the image-bmc file sent from the host via
this tool matches the hash of /run/initramfs/bmc-image. This code can
be used to send any file down, but was only tested with a "static"
layout build.

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I430bc7444f06f4f93a63e3bf2646bd195eaa2e52

show more ...

tools: p2a: read the PCI configuration

Read the PCI configuration from the blob handler itself. Don't use this
yet, but read it.

Tested: Verified with a bugfix in ipmi-blob-too

tools: p2a: read the PCI configuration

Read the PCI configuration from the blob handler itself. Don't use this
yet, but read it.

Tested: Verified with a bugfix in ipmi-blob-tool that it was able to
read back and print the value configured into the BMC image.

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I49a8c93508e64a65fd37b50ec2b437f0016272f2

show more ...

bugfix: result.bars[1] may be used uninitialized

Tools bugfix where if the result isn't assigned, it's still used.
Therefore, add a proper exit condition. This was developed on a system

bugfix: result.bars[1] may be used uninitialized

Tools bugfix where if the result isn't assigned, it's still used.
Therefore, add a proper exit condition. This was developed on a system
with the device, and interestingly, this compilation warning->error
wasn't hit during CI, only with bitbake. Therefore, different flags
must be involved between the two.

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: Ifca7046657b65a425b0c3bf4fe05dd42bd7a8a14

show more ...

tools: p2a: check aspeed bridge

Check whether the pci-to-ahb bridge is enabled. It should be enabled
because this comes after the firmware blob is opened for writing.

Tested: V

tools: p2a: check aspeed bridge

Check whether the pci-to-ahb bridge is enabled. It should be enabled
because this comes after the firmware blob is opened for writing.

Tested: Verified it reports the correct state of the value.
Change-Id: I04bd21fdbf65938164f5845c0ec46e2231b17bd9
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

p2a: add initial p2a support (empty)

Add initial pci-to-ahb host-side support, by just listing the aspeed pci
devices.

Tested: This dumped the aspeed PCI device listed on my tes

p2a: add initial p2a support (empty)

Add initial pci-to-ahb host-side support, by just listing the aspeed pci
devices.

Tested: This dumped the aspeed PCI device listed on my test platform.
Change-Id: I6dc4aeb3b38ec2f95bfd716bda2d8eb4786328ab
Signed-off-by: Patrick Venture <venture@google.com>

show more ...