clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda forma

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda formatting also changed, so we have made changes to the
organization default style format to better handle lambda formatting.

See I5e08687e696dd240402a2780158664b7113def0e for updated style.
See Iea0776aaa7edd483fa395e23de25ebf5a6288f71 for clang-18 enablement.

Change-Id: I09e19a126d456dc184fd70e82d4e4e4217fa8ee7
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

build: remove autotool

Change-Id: I662c8a5d29453622744f44c1984416f1303354e6
Signed-off-by: Willy Tu <wltu@google.com>

build: Remove unused phosphor-logging dependency

Change-Id: I4f4e5efc998ed9738a548a353a6bd315ebe5f47c
Signed-off-by: William A. Kennington III <wak@google.com>

build: Add meson build

Changes to note,
- `with_systemdsystemunitdir` and `with_tmpfilesdir` is removed since it
is not being documented nor used in OpenBMC.
- Removed the Code coverage feature wi

build: Add meson build

Changes to note,
- `with_systemdsystemunitdir` and `with_tmpfilesdir` is removed since it
is not being documented nor used in OpenBMC.
- Removed the Code coverage feature with `-DDHAVE_GCOV`, since it is not
used and meson covers it.
- Removed `--enable-oe-sdk` for using the OpenBMC SDK. It should work
directly with no change required.

Tested:
```
Jan 01 00:01:54 ipmid[709]: Try loading blob from persistent data
Jan 01 00:01:54 ipmid[709]: Stale blob data, resetting internals...
Jan 01 00:01:56 ipmid[709]: config loaded: /flash/bios
Jan 01 00:01:56 ipmid[709]: config loaded: /flash/image
Jan 01 00:01:56 ipmid[709]: config loaded: /flash/dummy
...
```

```
$ ls /usr/lib/blob-ipmid/
libfirmwareblob.so
libfirmwarecleanupblob.so libversionblob.so
```

Testing the service,
```
$ echo "hello" > /tmp/test.txt
$ burn_my_bmc -command update -layout dummy -image /tmp/test.txt
Sending over the firmware image.
Opening the verification file
Committing to /flash/verify to trigger service
Calling stat on /flash/verify session to check status
running
success
Returned success
succeeded
```

On the BMC.
```
/run/initramfs$ cat dummy
hello
```

Change-Id: I21c7c33bd62c0ee40681cb40da90125c125bea2f
Signed-off-by: Willy Tu <wltu@google.com>

show more ...

phosphor-ipmi-flash: Fix all C++ warnings

Change-Id: I89236b2dab88ca725e269bb8f5b2cbfd271e807a
Signed-off-by: Willy Tu <wltu@google.com>

test: Replace the C++ MOCK_METHOD<n> macros with the new MOCK_METHOD

Change-Id: I5099c727e9e918f19fa61acc91ef75250ebc6fa6
Signed-off-by: Willy Tu <wltu@google.com>

cleanup: coverage: add missing coverage

The uninteresting blob methods did not receive unit-tests. This adds
those missing unit-tests.

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id:

cleanup: coverage: add missing coverage

The uninteresting blob methods did not receive unit-tests. This adds
those missing unit-tests.

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: Ib5885e3f3fa9e4e708fbf578bcaaa8bc85ff3993

show more ...

util: use constexpr string instead of string objects

This handles an initialization order issue found with address
santization testing.

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id

util: use constexpr string instead of string objects

This handles an initialization order issue found with address
santization testing.

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I7b3b6e980e378855e8bda8209dba18c20b67a000

show more ...

cleanup: let the handler own the file system implementation

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: Ic7c31237bd5440b2cfa171df93545a63708e404c

cleanup: drop default filesystem handler

Drop the default file system handler from the constructor and just pass
it in to the one place it's needed.

Signed-off-by: Patrick Venture <venture@google.c

cleanup: drop default filesystem handler

Drop the default file system handler from the constructor and just pass
it in to the one place it's needed.

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I356adccbca583c20097e4e8977ce157ecd706f81

show more ...

cleanup: drop inclusion of unused filesystem header

The filesystem header is included and referenced but never used.

This is a leftover from before the filesystem calls where handled
through an int

cleanup: drop inclusion of unused filesystem header

The filesystem header is included and referenced but never used.

This is a leftover from before the filesystem calls where handled
through an interface.

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I69e5ba22ea853b2582cf99b679e72d81f30ee74e

show more ...

bmc+cleanup: drop remaining log includes

Drop remaining references to phosphor-logging.

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I6bbfdbf9e1b32ed206e784814f389e916c4ac786

log consistently via stderr

Most log messages in this codebase use stderr, while a few used
phosphor-logging. Transition all to use stderr.

Signed-off-by: Patrick Venture <venture@google.com>
Chan

log consistently via stderr

Most log messages in this codebase use stderr, while a few used
phosphor-logging. Transition all to use stderr.

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: Ic4cf619950275a2752f646f00974047092757010

show more ...

update gcc10 and clang-format10

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I72239b884615d26b2c4311c49a26e2eced0a1fb0

bmc : add config-static-bmc-with-update-status.json.in

Add a default json file with update status (file path defined with
UPDATE_STATUS_FILENAME) enabled with --enable-update-status flag.

Change-Id

bmc : add config-static-bmc-with-update-status.json.in

Add a default json file with update status (file path defined with
UPDATE_STATUS_FILENAME) enabled with --enable-update-status flag.

Change-Id: I62d3b547d91840451906e26cbec55dfa74934b5e
Signed-off-by: Brandon Kim <brandonkim@google.com>

show more ...

bmc: add cleanup blob handler

Add a cleanup blob handler, such that there is a new blob id present
named "/flash/cleanup" that will delete temporary files. This blob
handler expects a client to ope

bmc: add cleanup blob handler

Add a cleanup blob handler, such that there is a new blob id present
named "/flash/cleanup" that will delete temporary files. This blob
handler expects a client to open/commit/close the blob. This blob
handler will delete files that are specified as temporary. The host
client may use this to clean up artifacts on verification or update
failure.

This can be extended later to handle calling a service or doing anything
else to cleanup. The cleanup handler will be added if
--enable-cleanup-delete. The recipe will automatically add this blob
handler if that configure variable is set.

Tested: Not tested on real hardware.
Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I4502b2613e38f0a947d7235d084287376c6b0ce1

show more ...