bmc: use string literals instead of variables

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: Iedde0738bbe3bf77fd1b63d2d45f65acc256e45c

bmc: require blob ids to start with /flash/

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: Ib6a0db91d4e2ecd7e7cc3c51ddc1953d9fd8da3c

bmc: buildjson: provide helper for common filesystemd type

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: If0c106301538a6a11e199c8033cf7328f21575e6

bmc: cleanup verification language and symbols

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: Ife4d7e519e44aff60441c5909346ca6d7e2aa090

bmc: s/SystemdVerification/SystemdWithStatusFile/g

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I5da0ca9e3ae53df957647b19446df4196248fd31

bmc: allow update to use systemd with path

Verification provides a mechanism that has a systemd unit and mode, and
also a path to check the result. This object can be used for updates,
and will be

bmc: allow update to use systemd with path

Verification provides a mechanism that has a systemd unit and mode, and
also a path to check the result. This object can be used for updates,
and will be renamed in a later patchset to be more generically named.

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I0a995af0aefff76592247775f22fc84189d14903

show more ...

bmc: add mode json option for verification systemd

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: Ibe5764c4e2ad7dd938177c813c8c6706886258a2

bmc: move verify systemd mode to parameter

Move the mode for the trigger service to a parameter instead of
hard-coding it. This isn't yet a json configuration option, that'll be
next.

Signed-off-b

bmc: move verify systemd mode to parameter

Move the mode for the trigger service to a parameter instead of
hard-coding it. This isn't yet a json configuration option, that'll be
next.

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I59564320015c22be1ec3a4701479d0ee93b9f1f7

show more ...

bmc: json configuration: update: add mode parameter

Add the mode parameter as an optional configuration option for the
update systemd approach. Previously this was hard-coded as "replace"
but now t

bmc: json configuration: update: add mode parameter

Add the mode parameter as an optional configuration option for the
update systemd approach. Previously this was hard-coded as "replace"
but now the user can specify something else.

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I2bcb61bd9ac5733df6da70f901516d26bd31e2a9

show more ...

bugfix: bmc: update service requires mode

Systemd startunit requires a job-mode. Default it to "replace." In a
later patchset, the update systemd and verify system will collapse into
one object, b

bugfix: bmc: update service requires mode

Systemd startunit requires a job-mode. Default it to "replace." In a
later patchset, the update systemd and verify system will collapse into
one object, but this fix applies to the current implementation.

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: Ia6465abac9979501ea7149933394d8c452b2f315

show more ...

bmc: use json for configuration

Use a json file for configuration of the flash image.

Tested: Verified that /flash/image worked as expected.
Signed-off-by: Patrick Venture <venture@google.com>
Chan

bmc: use json for configuration

Use a json file for configuration of the flash image.

Tested: Verified that /flash/image worked as expected.
Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I205978203360140870f0e68208912a894e00a6fc

show more ...

bmc: implement search for json files

Tested: Verified it prints out the blobs expected.
Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I1ba6af8b2ca066e6eb1699cb4214ce32f148005d

bmc: consolidate action pack code slightly

Consolidate the code slightly as part of moving towards using the json
configuration.

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: Ic24e

bmc: consolidate action pack code slightly

Consolidate the code slightly as part of moving towards using the json
configuration.

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: Ic24e02973101b9b0d6cd120e761a7e25e1203fd9

show more ...

bmc: move from data section objs to owned

Move from objects created ahead of purpose to owned objects. This is a
step towards integrating with the json support.

Signed-off-by: Patrick Venture <ven

bmc: move from data section objs to owned

Move from objects created ahead of purpose to owned objects. This is a
step towards integrating with the json support.

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I738a5edd40724f17245911af1080c350f029fef1

show more ...

bmc: provide disabled json support

Provide support such that a json configuration file can define a firmware
handler and its behavior. This is not yet enabled.

Signed-off-by: Patrick Venture <vent

bmc: provide disabled json support

Provide support such that a json configuration file can define a firmware
handler and its behavior. This is not yet enabled.

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: If21f4e97951b3bb91a8afc53bee493d8600a04b7

show more ...

build: add option --enable-host-bios

Add option to enable building in support for the host bios.

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I324fc071f07cd364fd39c7df1ccfd9f0fd50

build: add option --enable-host-bios

Add option to enable building in support for the host bios.

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I324fc071f07cd364fd39c7df1ccfd9f0fd509a46

show more ...

bmc: add ActionPack notion to bundle actions

Each firmware type will provide its own set of action implementations
for each step, preparation, verification, and update.

Signed-off-by: Patrick Ventu

bmc: add ActionPack notion to bundle actions

Each firmware type will provide its own set of action implementations
for each step, preparation, verification, and update.

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: Id6409ac356a74e9094272b37709861e2a33d9862

show more ...

bmc: only add verifyBlobId if data sent for image

If data was sent to the hash only, don't add verify until they've at
least opened the image blob id.

Signed-off-by: Patrick Venture <venture@google

bmc: only add verifyBlobId if data sent for image

If data was sent to the hash only, don't add verify until they've at
least opened the image blob id.

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: Ifc03ac7090e7edbceeac414e908bc5aedb7ad1c3

show more ...

build: install three targets to handle bmc updates

Transition from three service files to three targets installed by the
BMC library:
- phosphor-ipmi-flash-bmc-prepare.target
- phosphor-ipmi-flash

build: install three targets to handle bmc updates

Transition from three service files to three targets installed by the
BMC library:
- phosphor-ipmi-flash-bmc-prepare.target
- phosphor-ipmi-flash-bmc-verify.target
- phosphor-ipmi-flash-bmc-update.target

The prepare target is started each time the firmware update state
machine changes from notYetStarted to uploadInProgress and can be
leveraged to free memory (flush caches) or anything else required.

The verify target is started when the verify blob is committed. The
implementation of services within this target are such that they are
expected to output a status value that's readable (typically via a
file).

The update target is started when the update blob is committed.

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I1e838de954a3cf8956ff4b72d090e253b832efe7

show more ...

build: drop --enable-lpc-bridge option

Tested: Not tested beyond build verification.
Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I56581665b5f12b2c00dd1debca42a75758a46d94

build: drop --enable-pci-bridge option

Now if you enable aspeed-p2a it'll enable that for you.

Tested: Only build verified, did not perform testing.
Signed-off-by: Patrick Venture <venture@google.c

build: drop --enable-pci-bridge option

Now if you enable aspeed-p2a it'll enable that for you.

Tested: Only build verified, did not perform testing.
Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I5d9bbd3ac62a9260efaec8035aaed9fd747e9f99

show more ...

bmc: split out service objects

Split out the service objects from being declaring inline as parameters
into objects created and then moved. This is a step towards supporting
adding another firmware

bmc: split out service objects

Split out the service objects from being declaring inline as parameters
into objects created and then moved. This is a step towards supporting
adding another firmware type of bios.

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I4e41c0fa1376d364251ea2aebc17a7eb4db37b51

show more ...

build: use a common library for shared pieces

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: Ic4b645091c71f270ba3b2f290f7206ebe3222f1d

tools: remove phosphor-ipmi-blobs dependency

The host tool depended on the BMC header: firmware_handler.hpp because
it defined the flags. This header depends on phosphor-ipmi-blobs,
therefore the h

tools: remove phosphor-ipmi-blobs dependency

The host tool depended on the BMC header: firmware_handler.hpp because
it defined the flags. This header depends on phosphor-ipmi-blobs,
therefore the host-tool depends on this. Move the flags into a separate
common header file and snip this dependency.

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: Id2ad33a1611c02605a1ed5c695429d0451eb98d4

show more ...

move bmc code into bmc folder

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I2407359461a1a2f0e733ff8cd0cb1744b6304c32