clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda forma

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda formatting also changed, so we have made changes to the
organization default style format to better handle lambda formatting.

See I5e08687e696dd240402a2780158664b7113def0e for updated style.
See Iea0776aaa7edd483fa395e23de25ebf5a6288f71 for clang-18 enablement.

Change-Id: I09e19a126d456dc184fd70e82d4e4e4217fa8ee7
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

Fix MD001 warnings

The following warnings are generated by using markdownlint analysis:
```
bmc/README.md:6 MD001/heading-increment Heading levels should only increment by one level at a time [Expec

Fix MD001 warnings

The following warnings are generated by using markdownlint analysis:
```
bmc/README.md:6 MD001/heading-increment Heading levels should only increment by one level at a time [Expected: h2; Actual: h3]
```
Refer to markdown-lint [1] to fix MD001
[1]: https://github.com/updownpress/markdown-lint/blob/master/rules/001-header-increment.md

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: I511b66da543dd2bfb40ea4910d2d74416fd0ccb9

show more ...

Fix MD034 warnings

The following warnings are generated by using markdownlint analysis:
```
bmc/README.md:84:13 MD034/no-bare-urls Bare URL used [Context: "adm1266-read-blackbox-log@sink..."]
bmc/RE

Fix MD034 warnings

The following warnings are generated by using markdownlint analysis:
```
bmc/README.md:84:13 MD034/no-bare-urls Bare URL used [Context: "adm1266-read-blackbox-log@sink..."]
bmc/README.md:89:15 MD034/no-bare-urls Bare URL used [Context: "adm1266-clear-blackbox-data@si..."]
```
Refer to markdown-lint [1] to fix MD034
[1]: https://github.com/updownpress/markdown-lint/blob/master/rules/034-no-bare-urls.md

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: Ib4a113a7d7463e79dd5ab93476bbc95aa391230a

show more ...

Fix MD040 warnings

The following warnings are generated by using markdownlint analysis:
```
MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"]
```
Refer

Fix MD040 warnings

The following warnings are generated by using markdownlint analysis:
```
MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"]
```
Refer to markdown-lint [1] to fix MD040
[1]: https://github.com/updownpress/markdown-lint/blob/master/rules/040-fenced-code-language.md

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: Ie984f706001b77f1f791b53a9801b595f775ec09

show more ...

Fix spelling mistakes using codespell

This commit corrects various spelling mistakes throughout the
repository. The corrections were made automatically using `codespell`[1]
tool.

[1]: https://githu

Fix spelling mistakes using codespell

This commit corrects various spelling mistakes throughout the
repository. The corrections were made automatically using `codespell`[1]
tool.

[1]: https://github.com/codespell-project/codespell

Change-Id: I0ffaae547bff9679343b36c337436af0260c8f73
Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>

show more ...

meson: adjust nlohmann-json dependency

Simplify the dependency logic and align wrap file directives with
other repositories.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I61209bcd

meson: adjust nlohmann-json dependency

Simplify the dependency logic and align wrap file directives with
other repositories.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I61209bcd25995ef447c790e59ad717c1192acbc2

show more ...

clang-format: copy latest and re-format

clang-format-17 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-17 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: Ie6154ef3394b8e652a8cb1ac33d68e3c3cec8cd8
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

use std::move_only_function

C++23 has a replacement for function2 in std::move_only_function.
Leverage that and remove the extra dependency.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Chan

use std::move_only_function

C++23 has a replacement for function2 in std::move_only_function.
Leverage that and remove the extra dependency.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I69fa59627b91fc1f640f7a688926bed7f138ca19

show more ...

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: I2ee8cbc4581d0c3ccdc130b646357c45fa0373db
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

meson: remove deprecated get_pkgconfig_variable

Since meson 0.56, the `get_pkgconfig_variable` has been deprecated. In
meson 0.58 the `get_variable` was enhanced to no longer require the
`pkgconfig

meson: remove deprecated get_pkgconfig_variable

Since meson 0.56, the `get_pkgconfig_variable` has been deprecated. In
meson 0.58 the `get_variable` was enhanced to no longer require the
`pkgconfig` keyword argument. Ensure meson 0.58 is required and update
the usage of all `get_pkgconfig_variable` and `get_variable` to be the
modern variant.

Change-Id: I9d6c273f740a62fdbea64cb29ae6db29b8af19da
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

Use 'type' of delete action in the log_handler builder

This was a bug where the 'type' of the open action was being used rather
than using the 'type' in the delete action config.

Tested:
- Created

Use 'type' of delete action in the log_handler builder

This was a bug where the 'type' of the open action was being used rather
than using the 'type' in the delete action config.

Tested:
- Created LogHandler with the following config.
```
{
"blob": "/log/log-blob-name",
"handler": {
"type": "file",
"path": "/var/run/log-blob-file.log"
},
"actions": {
"open": {
"type": "skip"
},
"delete": {
"type": "systemd",
"unit": "log-blob-delete.service"
}
},
```
- Checked log-blob-delete.service was run when blob was deleted

Change-Id: I2e4c783d9b159ad269ef06721d872bb8052af81c
Signed-off-by: Brennan Swanton <brennanswanton@google.com>

show more ...

prettier: re-format

Prettier is enabled in openbmc-build-scripts on Markdown, JSON, and YAML
files to have consistent formatting for these file types. Re-run the
formatter on the whole repository.

prettier: re-format

Prettier is enabled in openbmc-build-scripts on Markdown, JSON, and YAML
files to have consistent formatting for these file types. Re-run the
formatter on the whole repository.

Change-Id: I5a9a4baad65867173cddcd86872e33ab5fb29128
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

meson: Fix meson builds

When building the project from scratch (from a new workstation without
docker) I found that there were dependencies missing. Fixed them up.

Tested: Was able to build " tools

meson: Fix meson builds

When building the project from scratch (from a new workstation without
docker) I found that there were dependencies missing. Fixed them up.

Tested: Was able to build " tools/" and "bmc/"

Signed-off-by: Brandon Kim <brandonkim@google.com>
Change-Id: Id2250c481a37d3cd4ed6915b1b2b0978df6e4649

show more ...

Fix check of onDeleteType in log_handler builder

its a bug in current check, even for delete type we
are checking for `onOpenType`

Signed-off-by: Gaurav Gandhi <gauravgandhi@google.com>
Change-Id:

Fix check of onDeleteType in log_handler builder

its a bug in current check, even for delete type we
are checking for `onOpenType`

Signed-off-by: Gaurav Gandhi <gauravgandhi@google.com>
Change-Id: I8d7b4291d3e2ab9028f3d2f52c1b2ac9e1210b3d

show more ...

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are for:
* bus_t
* exception_t
* manager_t
* match_t
* message_t
* object_t
* slot_t

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ie8ecdadfa03f1f7a4a369b6981a360009fe71420

show more ...

Fix double free issue with global+static variable

Setting defaultConfigPaths as constexpr and std::array allow it to be
destructed cleaning with no issue. Without this the ipmid will triggered
doubl

Fix double free issue with global+static variable

Setting defaultConfigPaths as constexpr and std::array allow it to be
destructed cleaning with no issue. Without this the ipmid will triggered
double free error on cleanups.

Change-Id: I689ce51ecb9a051891e31c50d44d15d74add47ab
Signed-off-by: Willy Tu <wltu@google.com>

show more ...

phosphor-ipmi-flash: Code Health Cleanup

Removed the following warning.
- using decl '*' is unused
- 'push_back' is called inside a loop; consider pre-allocating the
container capacity before th

phosphor-ipmi-flash: Code Health Cleanup

Removed the following warning.
- using decl '*' is unused
- 'push_back' is called inside a loop; consider pre-allocating the
container capacity before the loop
- function '*' defined in a header file; function
definitions in header files can lead to ODR violations

Change-Id: I44e4b0f8056a853fb45b690394be1a8ebec45b20
Signed-off-by: Willy Tu <wltu@google.com>

show more ...

Add support for log-handler

This handler is based off of version handler with major differences in
handler_builder

Tested:
created the blackbox blob successfully using this lib.
Read the data from

Add support for log-handler

This handler is based off of version handler with major differences in
handler_builder

Tested:
created the blackbox blob successfully using this lib.
Read the data from the blob using a host side tool

Signed-off-by: Gaurav Gandhi <gauravgandhi@google.com>
Change-Id: I9ef775af752156a1647453ff3831ef4c0449d546

show more ...

bmc: version: Skip version if it does not exist in the config

Change-Id: I1ea876183ff12dab8fc479c45f7b3a9eba50b56f
Signed-off-by: Willy Tu <wltu@google.com>

build: remove autotool

Change-Id: I662c8a5d29453622744f44c1984416f1303354e6
Signed-off-by: Willy Tu <wltu@google.com>

build: Remove unused phosphor-logging dependency

Change-Id: I4f4e5efc998ed9738a548a353a6bd315ebe5f47c
Signed-off-by: William A. Kennington III <wak@google.com>

build: Add meson build

Changes to note,
- `with_systemdsystemunitdir` and `with_tmpfilesdir` is removed since it
is not being documented nor used in OpenBMC.
- Removed the Code coverage feature wi

build: Add meson build

Changes to note,
- `with_systemdsystemunitdir` and `with_tmpfilesdir` is removed since it
is not being documented nor used in OpenBMC.
- Removed the Code coverage feature with `-DDHAVE_GCOV`, since it is not
used and meson covers it.
- Removed `--enable-oe-sdk` for using the OpenBMC SDK. It should work
directly with no change required.

Tested:
```
Jan 01 00:01:54 ipmid[709]: Try loading blob from persistent data
Jan 01 00:01:54 ipmid[709]: Stale blob data, resetting internals...
Jan 01 00:01:56 ipmid[709]: config loaded: /flash/bios
Jan 01 00:01:56 ipmid[709]: config loaded: /flash/image
Jan 01 00:01:56 ipmid[709]: config loaded: /flash/dummy
...
```

```
$ ls /usr/lib/blob-ipmid/
libfirmwareblob.so
libfirmwarecleanupblob.so libversionblob.so
```

Testing the service,
```
$ echo "hello" > /tmp/test.txt
$ burn_my_bmc -command update -layout dummy -image /tmp/test.txt
Sending over the firmware image.
Opening the verification file
Committing to /flash/verify to trigger service
Calling stat on /flash/verify session to check status
running
success
Returned success
succeeded
```

On the BMC.
```
/run/initramfs$ cat dummy
hello
```

Change-Id: I21c7c33bd62c0ee40681cb40da90125c125bea2f
Signed-off-by: Willy Tu <wltu@google.com>

show more ...

bmc: remove redundant ‘std::move’ call

```
../bmc/file_handler.cpp:70:21: error: redundant move in return statement [-Werror=redundant-move]
70 | return std::move(ret);
| ~~~

bmc: remove redundant ‘std::move’ call

```
../bmc/file_handler.cpp:70:21: error: redundant move in return statement [-Werror=redundant-move]
70 | return std::move(ret);
| ~~~~~~~~~^~~~~
../bmc/file_handler.cpp:70:21: note: remove ‘std::move’ call
cc1plus: all warnings being treated as errors
```

Change-Id: I07b7ac5c715a53fc5d78cba5dba4aa5b7407304c
Signed-off-by: Willy Tu <wltu@google.com>

show more ...

bmc: Simplify file handler

This greatly reduces the number of checks made against file operations
and fixes an issue with reading 0 length files.

Change-Id: I3d63ad0a3a49d6efbd047baadff3c0fe363b417

bmc: Simplify file handler

This greatly reduces the number of checks made against file operations
and fixes an issue with reading 0 length files.

Change-Id: I3d63ad0a3a49d6efbd047baadff3c0fe363b4174
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

phosphor-ipmi-flash: Fix all C++ warnings

Change-Id: I89236b2dab88ca725e269bb8f5b2cbfd271e807a
Signed-off-by: Willy Tu <wltu@google.com>