clang-tidy: remove pessimizing moves on temporaries

Eliminate std::move calls applied to prvalues returned by builder
functions (e.g., buildSystemd/buildFileSystemd). Moving temporaries
prevents cop

clang-tidy: remove pessimizing moves on temporaries

Eliminate std::move calls applied to prvalues returned by builder
functions (e.g., buildSystemd/buildFileSystemd). Moving temporaries
prevents copy/move elision and triggers -Wpessimizing-move under
-Werror. Assign temporaries directly to enable elision. No functional
changes.

Example error
'''
../bmc/version-handler/version_handlers_builder.cpp:91:32: error: moving a temporary object prevents copy elision [-Werror,-Wpessimizing-move]
91 | pack->onOpen = std::move(buildSystemd(onOpen));
| ^
../bmc/version-handler/version_handlers_builder.cpp:91:32: note: remove std::move call here
91 | pack->onOpen = std::move(buildSystemd(onOpen));
| ^~~~~~~~~~ ~
'''

Change-Id: I9db5e5dbe079a954239475bf12f740fb3d38a2f8
Signed-off-by: Jayanth Othayoth <ojayanth@gmail.com>

show more ...

meson: reformat with meson formatter

Apply the `meson format` results.

Change-Id: I116103d8e0994e09ecb6381f5bb7d564608826b2
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

build: use allowed over enabled or not-disabled

Meson feature options are typically in a tri-state of enabled, disabled,
or auto. The enabled and disabled functions on an option (from
`get_option`)

build: use allowed over enabled or not-disabled

Meson feature options are typically in a tri-state of enabled, disabled,
or auto. The enabled and disabled functions on an option (from
`get_option`) no longer return true for auto features. Instead, the
expectation is to use `allowed()` which is true for both enabled and
auto.

Switch all uses of `enabled` to `allowed`.
Switch all uses of `not disabled` to `allowed`.

Change-Id: Ia942d083f4ddab68acbbb40699ea1971e09db771
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda forma

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda formatting also changed, so we have made changes to the
organization default style format to better handle lambda formatting.

See I5e08687e696dd240402a2780158664b7113def0e for updated style.
See Iea0776aaa7edd483fa395e23de25ebf5a6288f71 for clang-18 enablement.

Change-Id: I09e19a126d456dc184fd70e82d4e4e4217fa8ee7
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: I2ee8cbc4581d0c3ccdc130b646357c45fa0373db
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

phosphor-ipmi-flash: Code Health Cleanup

Removed the following warning.
- using decl '*' is unused
- 'push_back' is called inside a loop; consider pre-allocating the
container capacity before th

phosphor-ipmi-flash: Code Health Cleanup

Removed the following warning.
- using decl '*' is unused
- 'push_back' is called inside a loop; consider pre-allocating the
container capacity before the loop
- function '*' defined in a header file; function
definitions in header files can lead to ODR violations

Change-Id: I44e4b0f8056a853fb45b690394be1a8ebec45b20
Signed-off-by: Willy Tu <wltu@google.com>

show more ...

bmc: version: Skip version if it does not exist in the config

Change-Id: I1ea876183ff12dab8fc479c45f7b3a9eba50b56f
Signed-off-by: Willy Tu <wltu@google.com>

build: remove autotool

Change-Id: I662c8a5d29453622744f44c1984416f1303354e6
Signed-off-by: Willy Tu <wltu@google.com>

build: Add meson build

Changes to note,
- `with_systemdsystemunitdir` and `with_tmpfilesdir` is removed since it
is not being documented nor used in OpenBMC.
- Removed the Code coverage feature wi

build: Add meson build

Changes to note,
- `with_systemdsystemunitdir` and `with_tmpfilesdir` is removed since it
is not being documented nor used in OpenBMC.
- Removed the Code coverage feature with `-DDHAVE_GCOV`, since it is not
used and meson covers it.
- Removed `--enable-oe-sdk` for using the OpenBMC SDK. It should work
directly with no change required.

Tested:
```
Jan 01 00:01:54 ipmid[709]: Try loading blob from persistent data
Jan 01 00:01:54 ipmid[709]: Stale blob data, resetting internals...
Jan 01 00:01:56 ipmid[709]: config loaded: /flash/bios
Jan 01 00:01:56 ipmid[709]: config loaded: /flash/image
Jan 01 00:01:56 ipmid[709]: config loaded: /flash/dummy
...
```

```
$ ls /usr/lib/blob-ipmid/
libfirmwareblob.so
libfirmwarecleanupblob.so libversionblob.so
```

Testing the service,
```
$ echo "hello" > /tmp/test.txt
$ burn_my_bmc -command update -layout dummy -image /tmp/test.txt
Sending over the firmware image.
Opening the verification file
Committing to /flash/verify to trigger service
Calling stat on /flash/verify session to check status
running
success
Returned success
succeeded
```

On the BMC.
```
/run/initramfs$ cat dummy
hello
```

Change-Id: I21c7c33bd62c0ee40681cb40da90125c125bea2f
Signed-off-by: Willy Tu <wltu@google.com>

show more ...

phosphor-ipmi-flash: Fix all C++ warnings

Change-Id: I89236b2dab88ca725e269bb8f5b2cbfd271e807a
Signed-off-by: Willy Tu <wltu@google.com>

version-handler: remove unused tests

Those tests are repeated in "version_json_unittest.cpp" and never built.

Signed-off-by: Jie Yang <jjy@google.com>
Change-Id: I004237307ef0581f47e8517d5988b755f7

version-handler: remove unused tests

Those tests are repeated in "version_json_unittest.cpp" and never built.

Signed-off-by: Jie Yang <jjy@google.com>
Change-Id: I004237307ef0581f47e8517d5988b755f7d56935

show more ...

bmc/ver.../test/.close_unittest: add missing header

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I836986ee7108caa651a374c3f08e96029d01cd9c

buildjson: Support multiple configuration paths

This will allow us to parse configurations from multiple paths in the
filesystem when they are added.

Right now this does not enable new behavior, bu

buildjson: Support multiple configuration paths

This will allow us to parse configurations from multiple paths in the
filesystem when they are added.

Right now this does not enable new behavior, but a future change will
enable a non-persistent configuration location.

Change-Id: Ifa9bc5eff9cfca84c923be381ec9927c62c2a2e5
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

version-handler/test: Remove unused declarations

Change-Id: If9bc7dd4c58bd9ba3430ffee6319da5ed194cb9f
Signed-off-by: William A. Kennington III <wak@google.com>

handler_config: Split out from buildjson

This allows us to build the version-handler without the json
infrastructure.

Change-Id: I8c0a5715cb66f6cbb3e72cb714759f6e11e3f409
Signed-off-by: William A.

handler_config: Split out from buildjson

This allows us to build the version-handler without the json
infrastructure.

Change-Id: I8c0a5715cb66f6cbb3e72cb714759f6e11e3f409
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

version-handler: Produce errors for unavailable data

We want to make it clear to the reader that the data is actually
unavailable vs reading outside the bounds of the data space.

Change-Id: Ifb63df

version-handler: Produce errors for unavailable data

We want to make it clear to the reader that the data is actually
unavailable vs reading outside the bounds of the data space.

Change-Id: Ifb63dfe600c268af9e7df24397c28e20316dbb8f
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

version-handler: Add session stat

We need to be able to inform the blob user of the readiness of blob data
and how large the contents are.

Change-Id: Ic90f6e344160b48e7e58cb009558586c7c2fab9b
Signe

version-handler: Add session stat

We need to be able to inform the blob user of the readiness of blob data
and how large the contents are.

Change-Id: Ic90f6e344160b48e7e58cb009558586c7c2fab9b
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

version_handler: Support multiple sessions

We want to be able to support multiple concurrent readers of version
information. Otherwise, upstream version checks might fail if they end
up being sequen

version_handler: Support multiple sessions

We want to be able to support multiple concurrent readers of version
information. Otherwise, upstream version checks might fail if they end
up being sequenced concurrently.

Change-Id: I5420ad667622b7906e633562a5373e0be042c0c1
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

version_handler: Read doesn't need to catch missing sessions

The read() interface from phosphor-ipmi-blobs will never call read with
an invalid session, so we don't need to catch the exception if th

version_handler: Read doesn't need to catch missing sessions

The read() interface from phosphor-ipmi-blobs will never call read with
an invalid session, so we don't need to catch the exception if the
session doesn't exist.

Change-Id: I2ccb351b85d18a6eb96d4f92cfb3167a95f0509e
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

version_handler: Expire shouldn't fail

We want to make sure any sessions which expire are successfully removed,
even if we don't have the session in our map.

Change-Id: I50c7f74509945e29ab3c04ecbcf

version_handler: Expire shouldn't fail

We want to make sure any sessions which expire are successfully removed,
even if we don't have the session in our map.

Change-Id: I50c7f74509945e29ab3c04ecbcf583a1a9ce0c92
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

version_handler: Don't store session information immediately

This can cause spurious trigger aborts when open's fail and cleanup is
called on the failed session.

Change-Id: I1c49f248b6f56bbecc0d51f

version_handler: Don't store session information immediately

This can cause spurious trigger aborts when open's fail and cleanup is
called on the failed session.

Change-Id: I1c49f248b6f56bbecc0d51fafaabe871d23b1d7d
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

version-handler: Remove superfluous open session check

The phosphor-ipmi-flash API guarantees that calls to open() will not
happen with duplicate session IDs.

Change-Id: Ife88b2743322387e5cc6ebe2b3

version-handler: Remove superfluous open session check

The phosphor-ipmi-flash API guarantees that calls to open() will not
happen with duplicate session IDs.

Change-Id: Ife88b2743322387e5cc6ebe2b34567c3d2d2957a
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

version-handler: Refactor maps to simplify accesses

This reduces the number of map lookups needed for read() and close()
operations and the number of stored strings by referencing the pinned
blobId.

version-handler: Refactor maps to simplify accesses

This reduces the number of map lookups needed for read() and close()
operations and the number of stored strings by referencing the pinned
blobId.

Change-Id: I8c6af5749b8cc8415eedeba484bf4a39a98f0286
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

version-handler: Refactor handler construction

Instead of requiring callers to build maps and info blobs, take the
minimal required amount of information about the blob configuration and
build requi

version-handler: Refactor handler construction

Instead of requiring callers to build maps and info blobs, take the
minimal required amount of information about the blob configuration and
build required datastructures internally.

This reduces the amount of code, and nearly eliminates all of the
untested code in main.cpp.

Change-Id: Iaa398eb404814e9263e6707b71b38a9831d96697
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

Makefile: Consistently use tabs

Change-Id: I312c81a2ceba88c925ef268ca3bc8d74f264768e
Signed-off-by: William A. Kennington III <wak@google.com>