Fix double free issue with global+static variable

Setting defaultConfigPaths as constexpr and std::array allow it to be
destructed cleaning with no issue. Without this the ipmid will triggered
doubl

Fix double free issue with global+static variable

Setting defaultConfigPaths as constexpr and std::array allow it to be
destructed cleaning with no issue. Without this the ipmid will triggered
double free error on cleanups.

Change-Id: I689ce51ecb9a051891e31c50d44d15d74add47ab
Signed-off-by: Willy Tu <wltu@google.com>

show more ...

buildjson: Add a non-persistent path

This allows users to generate configuration that don't persist to the
SPI or conflict with configs shipped as part of the firmware.

Change-I

buildjson: Add a non-persistent path

This allows users to generate configuration that don't persist to the
SPI or conflict with configs shipped as part of the firmware.

Change-Id: I7de362565387e2739c09fa4c60ecedd8a7dea5d8
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

buildjson: Support multiple configuration paths

This will allow us to parse configurations from multiple paths in the
filesystem when they are added.

Right now this does not ena

buildjson: Support multiple configuration paths

This will allow us to parse configurations from multiple paths in the
filesystem when they are added.

Right now this does not enable new behavior, but a future change will
enable a non-persistent configuration location.

Change-Id: Ifa9bc5eff9cfca84c923be381ec9927c62c2a2e5
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

buildjson: Reduce include scope as needed

Change-Id: I8dfa600680fb253cd828f284ff217f35f76c0b46
Signed-off-by: William A. Kennington III <wak@google.com>

json builder: fix error with buildHandlerConfigs

Problem: mistakenly defined the implementation of buildHandlerConfigs in
a separate cpp file. This breaks calling buildHandlerConfigs fro

json builder: fix error with buildHandlerConfigs

Problem: mistakenly defined the implementation of buildHandlerConfigs in
a separate cpp file. This breaks calling buildHandlerConfigs from a
derived class.

Solution: move implementation of buildHandlerConfigs into the header.

unit tests added:
firmware_json_unittest.cpp * add a test to parse json from file
* add a test to parse an invalid json file

Signed-off-by: Jason Ling <jasonling@google.com>
Change-Id: I5cd93ad01a329850a8ee516fae8a35339c991ae0

show more ...

make building handlers from json more generic

Problem: version-handler, a new feature that will be added to this
repository will also parse json files from the same directory ipmi-flash

make building handlers from json more generic

Problem: version-handler, a new feature that will be added to this
repository will also parse json files from the same directory ipmi-flash
does. Currently buildjson is a mix of some code that can be reused and
other code that is pretty specific to firmware updates; this makes it
hard to reuse the code.

Solution: factor out the generic parts and place it in bmc and then
leave the specific parts in firmware-handler. Also code changes have
been made to buildjson: wrap functions in a templated class that leaves
feature specific parsing as a pure virtual method.

Tested:
Ran the unit tests, which do test the parsing functionality.

Signed-off-by: Jason Ling <jasonling@google.com>
Change-Id: I021dc829a82d1719b4cb862cdfb224eca629a44d

show more ...

bmc+cleanup: drop remaining log includes

Drop remaining references to phosphor-logging.

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I6bbfdbf9e1b32ed206e784814

bmc+cleanup: drop remaining log includes

Drop remaining references to phosphor-logging.

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I6bbfdbf9e1b32ed206e784814f389e916c4ac786

show more ...

log consistently via stderr

Most log messages in this codebase use stderr, while a few used
phosphor-logging. Transition all to use stderr.

Signed-off-by: Patrick Venture <vent

log consistently via stderr

Most log messages in this codebase use stderr, while a few used
phosphor-logging. Transition all to use stderr.

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: Ic4cf619950275a2752f646f00974047092757010

show more ...

update gcc10 and clang-format10

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I72239b884615d26b2c4311c49a26e2eced0a1fb0

bmc: config: add skip action

If you specify the action for one of the three fields as "skip" it'll
create a handler object for that action that always returns success and
has no effe

bmc: config: add skip action

If you specify the action for one of the three fields as "skip" it'll
create a handler object for that action that always returns success and
has no effect. This action therefore "skips" the step, moving the state
machine forward as though it was a successful real action.

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: Ib4c1091745eb96b8381a332bbeb0562625d3bfbe

show more ...

bmc/buildjson: Allow for systemd verification services

Now that we can inspect the status of systemd units, this is a perfectly
valid configuration.

Tested:
Modified scr

bmc/buildjson: Allow for systemd verification services

Now that we can inspect the status of systemd units, this is a perfectly
valid configuration.

Tested:
Modified scripting to use systemd type services in place of their
fileSystem variants and their status was correctly reported through
the verification and update phases.

Change-Id: I46ab0da1f71a1098d49de9feb24d7e26c1c4bf68
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

bmc: merge update and prepare systemd

The update systemd and prepare systemd were effectively the same, and
this makes the systemd action generic.

Tested: Not tested beyond unit

bmc: merge update and prepare systemd

The update systemd and prepare systemd were effectively the same, and
this makes the systemd action generic.

Tested: Not tested beyond unit-tests continuing to pass.
Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I8070731e53bfd6cdafb1d74d9db652f20341985e

show more ...

bmc: add mode to systemd preparation action

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: If29311cfa9eddecdd81781867598a73789225bc5

bmc: use string literals instead of variables

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: Iedde0738bbe3bf77fd1b63d2d45f65acc256e45c

bmc: require blob ids to start with /flash/

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: Ib6a0db91d4e2ecd7e7cc3c51ddc1953d9fd8da3c

bmc: buildjson: provide helper for common filesystemd type

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: If0c106301538a6a11e199c8033cf7328f21575e6

bmc: cleanup verification language and symbols

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: Ife4d7e519e44aff60441c5909346ca6d7e2aa090

bmc: s/SystemdVerification/SystemdWithStatusFile/g

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I5da0ca9e3ae53df957647b19446df4196248fd31

bmc: allow update to use systemd with path

Verification provides a mechanism that has a systemd unit and mode, and
also a path to check the result. This object can be used for updates,

bmc: allow update to use systemd with path

Verification provides a mechanism that has a systemd unit and mode, and
also a path to check the result. This object can be used for updates,
and will be renamed in a later patchset to be more generically named.

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I0a995af0aefff76592247775f22fc84189d14903

show more ...

bmc: add mode json option for verification systemd

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: Ibe5764c4e2ad7dd938177c813c8c6706886258a2

bmc: move verify systemd mode to parameter

Move the mode for the trigger service to a parameter instead of
hard-coding it. This isn't yet a json configuration option, that'll be
nex

bmc: move verify systemd mode to parameter

Move the mode for the trigger service to a parameter instead of
hard-coding it. This isn't yet a json configuration option, that'll be
next.

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I59564320015c22be1ec3a4701479d0ee93b9f1f7

show more ...

bmc: json configuration: update: add mode parameter

Add the mode parameter as an optional configuration option for the
update systemd approach. Previously this was hard-coded as "replac

bmc: json configuration: update: add mode parameter

Add the mode parameter as an optional configuration option for the
update systemd approach. Previously this was hard-coded as "replace"
but now the user can specify something else.

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I2bcb61bd9ac5733df6da70f901516d26bd31e2a9

show more ...

bugfix: bmc: update service requires mode

Systemd startunit requires a job-mode. Default it to "replace." In a
later patchset, the update systemd and verify system will collapse into

bugfix: bmc: update service requires mode

Systemd startunit requires a job-mode. Default it to "replace." In a
later patchset, the update systemd and verify system will collapse into
one object, but this fix applies to the current implementation.

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: Ia6465abac9979501ea7149933394d8c452b2f315

show more ...

bmc: implement search for json files

Tested: Verified it prints out the blobs expected.
Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I1ba6af8b2ca066e6eb1699cb4214ce

bmc: implement search for json files

Tested: Verified it prints out the blobs expected.
Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I1ba6af8b2ca066e6eb1699cb4214ce32f148005d

show more ...

bmc: provide disabled json support

Provide support such that a json configuration file can define a firmware
handler and its behavior. This is not yet enabled.

Signed-off-by: P

bmc: provide disabled json support

Provide support such that a json configuration file can define a firmware
handler and its behavior. This is not yet enabled.

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: If21f4e97951b3bb91a8afc53bee493d8600a04b7

show more ...