meson: Fix meson builds

When building the project from scratch (from a new workstation without
docker) I found that there were dependencies missing. Fixed them up.

Tested: Was able to build " tools

meson: Fix meson builds

When building the project from scratch (from a new workstation without
docker) I found that there were dependencies missing. Fixed them up.

Tested: Was able to build " tools/" and "bmc/"

Signed-off-by: Brandon Kim <brandonkim@google.com>
Change-Id: Id2250c481a37d3cd4ed6915b1b2b0978df6e4649

show more ...

build: remove autotool

Change-Id: I662c8a5d29453622744f44c1984416f1303354e6
Signed-off-by: Willy Tu <wltu@google.com>

build: Add meson build

Changes to note,
- `with_systemdsystemunitdir` and `with_tmpfilesdir` is removed since it
is not being documented nor used in OpenBMC.
- Removed the Code

build: Add meson build

Changes to note,
- `with_systemdsystemunitdir` and `with_tmpfilesdir` is removed since it
is not being documented nor used in OpenBMC.
- Removed the Code coverage feature with `-DDHAVE_GCOV`, since it is not
used and meson covers it.
- Removed `--enable-oe-sdk` for using the OpenBMC SDK. It should work
directly with no change required.

Tested:
```
Jan 01 00:01:54 ipmid[709]: Try loading blob from persistent data
Jan 01 00:01:54 ipmid[709]: Stale blob data, resetting internals...
Jan 01 00:01:56 ipmid[709]: config loaded: /flash/bios
Jan 01 00:01:56 ipmid[709]: config loaded: /flash/image
Jan 01 00:01:56 ipmid[709]: config loaded: /flash/dummy
...
```

```
$ ls /usr/lib/blob-ipmid/
libfirmwareblob.so
libfirmwarecleanupblob.so libversionblob.so
```

Testing the service,
```
$ echo "hello" > /tmp/test.txt
$ burn_my_bmc -command update -layout dummy -image /tmp/test.txt
Sending over the firmware image.
Opening the verification file
Committing to /flash/verify to trigger service
Calling stat on /flash/verify session to check status
running
success
Returned success
succeeded
```

On the BMC.
```
/run/initramfs$ cat dummy
hello
```

Change-Id: I21c7c33bd62c0ee40681cb40da90125c125bea2f
Signed-off-by: Willy Tu <wltu@google.com>

show more ...

bmc: provide disabled json support

Provide support such that a json configuration file can define a firmware
handler and its behavior. This is not yet enabled.

Signed-off-by: P

bmc: provide disabled json support

Provide support such that a json configuration file can define a firmware
handler and its behavior. This is not yet enabled.

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: If21f4e97951b3bb91a8afc53bee493d8600a04b7

show more ...

build: install three targets to handle bmc updates

Transition from three service files to three targets installed by the
BMC library:
- phosphor-ipmi-flash-bmc-prepare.target
-

build: install three targets to handle bmc updates

Transition from three service files to three targets installed by the
BMC library:
- phosphor-ipmi-flash-bmc-prepare.target
- phosphor-ipmi-flash-bmc-verify.target
- phosphor-ipmi-flash-bmc-update.target

The prepare target is started each time the firmware update state
machine changes from notYetStarted to uploadInProgress and can be
leveraged to free memory (flush caches) or anything else required.

The verify target is started when the verify blob is committed. The
implementation of services within this target are such that they are
expected to output a status value that's readable (typically via a
file).

The update target is started when the update blob is committed.

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I1e838de954a3cf8956ff4b72d090e253b832efe7

show more ...

autotools: Fix for autoconf-archive 2019.01.19

The code coverage macros from the archive changed in a backward
incompatible way. This adds a workaround to autodetect either version
a

autotools: Fix for autoconf-archive 2019.01.19

The code coverage macros from the archive changed in a backward
incompatible way. This adds a workaround to autodetect either version
and do the right thing.

Change-Id: I71627d62a41d2c3cc07764cd0901354680092f07
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

.gitignore: add autom4te.cache

Add autom4te.cache to .gitignore file.

Change-Id: I4b246860edc94dd31e844badc7ddfa54febe50fb
Signed-off-by: Patrick Venture <venture@google.com>

tools: start burn_my_bmc tool

Start implementation of burn_my_bmc host tool, the purpose of which is
to upload the firmware image and trigger the verification process.

The utili

tools: start burn_my_bmc tool

Start implementation of burn_my_bmc host tool, the purpose of which is
to upload the firmware image and trigger the verification process.

The utility will accept four parameters:
1) command - the command to run, initially only "update"
2) interface - the data interface to use, e.g. lpc or pci
3) image - the path to the image file
4) sig - the path to the image's signature file

Change-Id: Ifbab7df947f37dd3a6fddddcf523c0fa724c9551
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

test: fixup unit-test naming

Fixup naming convention for unit-test files and add to gitignore.

Change-Id: I0fe5d167e52c4a05d1c89dfd996afdde4b48a4c9
Signed-off-by: Patrick Ventur

test: fixup unit-test naming

Fixup naming convention for unit-test files and add to gitignore.

Change-Id: I0fe5d167e52c4a05d1c89dfd996afdde4b48a4c9
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

gitignore: Add test-driver

Add test-driver object to gitignore.

Change-Id: I0395e9a95a977831fa995b4bd0bf400901b46d70
Signed-off-by: Patrick Venture <venture@google.com>

update gitignore for more artifacts

Add more autotools artifacts to gitignore file.

Change-Id: Ib935e247a7acba3eedd4c1f7b2bad30bbe04134f
Signed-off-by: Patrick Venture <venture@

update gitignore for more artifacts

Add more autotools artifacts to gitignore file.

Change-Id: Ib935e247a7acba3eedd4c1f7b2bad30bbe04134f
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

Add gitignore to repo

Add gitignore to repo.

Change-Id: I61b99b40c03d96bf49b48358a1b357c3f7d2311d
Signed-off-by: Patrick Venture <venture@google.com>

Revert original implementation in favor of blob-based approach

Revert original implementation of the in-band firmware update to
pivot to using a blob-based implementation.

Blob-

Revert original implementation in favor of blob-based approach

Revert original implementation of the in-band firmware update to
pivot to using a blob-based implementation.

Blob-based design is under review here:
https://gerrit.openbmc-project.xyz/14444

Revert "tools: starting burn_my_bmc host utility"
This reverts commit 7dc4670d4be4884e0c6486ca4f0e799116935096.

Revert "phosphor-ipmi-flash: main: move to iana header"
This reverts commit e39f2b3a9a19b8e788a7225a0d291716325b77ee.

Revert "update clang-format"
This reverts commit 1aedab2391cd883e95ebde0129fcaf88d7f16233.

Revert "Build as c++17"
This reverts commit 004fb909202e39b34cb72d31390facd525b04c9b.

Revert "clang-format: always break template declarations"
This reverts commit ff0ee70f0fb8e0c2173f826f4d96fbfced09ca14.

Revert "clang-format-6.0 bump fixes"
This reverts commit 8f378c927a5789f30ba625595153bc1422d511dc.

Revert "flash-ipmi: implement flashAbort"
This reverts commit 605f75f7c026b5c2f454de155f6f211b2c3b187f.

Revert "flash-ipmi: implement flashDataVerify"
This reverts commit 9c6baad43fe7d1db8e449766eed35865ce6a2e4b.

Revert "flash-ipmi: implement flashVerifyCheck"
This reverts commit 7fc66de0d5465f4d25033d6baf48b6489f843331.

Revert "ipmi: start implementing flashVerifyCheck"
This reverts commit fdc65b2524bee544d35a6e2cbeef4c2f68aeb8fd.

Revert "flash-ipmi: implement flashHashFinish"
This reverts commit d5f590f955a67715e7903a04c3a8028f1d4f2664.

Revert "flash-ipmi: implement flashHashData"
This reverts commit cbe51498953d7bd29f516cdfcdb654706b463d2e.

Revert "flash-ipmi: implement flashStartHash"
This reverts commit 6f17bd2220d723fd349077ccd96845a5652403e0.

Revert "flash-ipmi: implement flashDataFinish"
This reverts commit 57703664cd76c2744adf4c5fa504388909efa824.

Revert "flash-ipmi: implement flashDataBlock"
This reverts commit 3c086f2f649d1c4cc7926cbd9375a39dd23e6997.

Revert "update copyright year"
This reverts commit 514f648b76c1a855a356e5a4ca83fd5bf6c53b3f.

Revert "flash-ipmi: implement flashStartTransfer"
This reverts commit 8ec019fdc15cb021f2c7d4cefb85a8ccd3581159.

Revert "ipmi: start implementing flashAbort"
This reverts commit 5c251ca550f56722280dcf17b8c48832ace07142.

Revert "ipmi: start implementing flashDataVerify"
This reverts commit 1cb87d25f79cfb905611b81348fbccb362f5e29a.

Revert "main: cleanup command handling"
This reverts commit 9a5a79a0797294ba9f5c7b2ab79e4dcbacac0c44.

Revert "test: rework ipmi validate test as table"
This reverts commit 39b3a82609511e2d855a2182f22361cc1332bb25.

Revert "ipmi: start implementing flashHashFinish"
This reverts commit fbc7d191eb6d49ff93379e90f372960b799b25c4.

Revert "ipmi: start implementing flashHashData"
This reverts commit cfe66877a5d7cc64bcce5c8789ca164edf9f1c56.

Revert "ipmi: start implementing flashStartHash"
This reverts commit 8d9f7322f46afaab81e32d1999f5bc000f1ba9a6.

Revert "ipmi: start implementing flashDataFinish"
This reverts commit 2c1205db94647c196c154bae0e106933b9ff526e.

Revert "ipmi: promote min length check to earlier"
This reverts commit a53a7b35085ddd41ef3cc47b084d29a1f413e818.

Revert "ipmi: start implementing flashDataBlock"
This reverts commit 79e131fce6e308f7e0f96bc71b07a7f0ebeeffcd.

Revert "ipmi: start implementing flashStartTransfer"
This reverts commit 54c3b53c0d0c7991469ab1be97bdf4e3f301e8f5.

Revert "add flash-ipmi header defining sub-commands"
This reverts commit 3d1786bcd038e4d042d268737a9b874fd667bf84.

Revert "main: start with no-op handler"
This reverts commit accc91799d6a1de4726313b907e5dfa7555bf919.

Change-Id: I1c4dc9dcd2bf7d110240a028a329fcb1e01a4e5b
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

tools: starting burn_my_bmc host utility

burn_my_bmc is a host-run utility that in cooperation with the
phosphor-ipmi-flash library, attempts to send a BMC firmware image and
signatu

tools: starting burn_my_bmc host utility

burn_my_bmc is a host-run utility that in cooperation with the
phosphor-ipmi-flash library, attempts to send a BMC firmware image and
signature file to the BMC and trigger verification of said image.

The program's current design and use were tailored towards the legacy
OpenBMC image and not UBI. Therefore, changes to support the UBI
process will get addressed as it all takes shape.

The overall process is:
1) Attempts to send firmware image over an interface.
2) Attempts to send signature file contents over an interface*.
3) Triggers a verification step.
4) Reboots the BMC**.

* The only interface in the initial version here is the blocktransfer
interface. It's technically also possibly KCS. It's sending the data
over the same communications channel as the normal IPMI packets. A
later patchset will enable sending the data bytes over an LPC memory
region or the PCI P2A region.

** The 4th step is done by a separate call to the 'reboot' command.
The 'reboot' and 'ping' commands will come in a later patchset.

Change-Id: I62d725274e56c55ca414fa6c2a3eab6c500066ed
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

ipmi: start implementing flashStartTransfer

Change-Id: I1f8b1498d517c0661e98b1ba895e7152f7a9ed8e
Signed-off-by: Patrick Venture <venture@google.com>

main: start with no-op handler

Change-Id: I0504ad186687535966179757cef68c3b4eca754f
Signed-off-by: Patrick Venture <venture@google.com>