manager: typo fix available

Typo fix in manager_cpp for word "available"

Change-Id: I0c4382023fef63f332d4cd677d82ad30e0a44b26
Signed-off-by: Patrick Venture <venture@google.com>

build: cleanup configure script PKG_CHECK_MODULES

Cleanup the configure script package include lines. There isn't a set
style for this yet, but this is an attempt to improve readability
whereas it'

build: cleanup configure script PKG_CHECK_MODULES

Cleanup the configure script package include lines. There isn't a set
style for this yet, but this is an attempt to improve readability
whereas it's often one long line per library. The CI will fail if there
aren't backslashes on lines for the AC_CHECK_HEADER.

Change-Id: I07be3e9c4ac7cd70a9e0d03299d25dcce6910cef
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

gitignore: add m4 directory

New autotools directory: m4, add to .gitignore.

Change-Id: Idc6d0f7c53927c62602a5caa16010941d5a75b33
Signed-off-by: Patrick Venture <venture@google.com>

bugfix: ipmi: set dataLen to zero when appropriate

On failures (or some silent success), set the return
buffer length to 0.

Change-Id: I118788ffddd2bfc031b3392db4cf13ab04b49287
Signed-off-by: Patri

bugfix: ipmi: set dataLen to zero when appropriate

On failures (or some silent success), set the return
buffer length to 0.

Change-Id: I118788ffddd2bfc031b3392db4cf13ab04b49287
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

main: receive blob handler path from configure

Add blob handler path to configure_ac and use this
path for searching.

Change-Id: Ie0e33e93822bc6e95ace2fed5abe66f42dae5ca5
Signed-off-by: Patrick Ven

main: receive blob handler path from configure

Add blob handler path to configure_ac and use this
path for searching.

Change-Id: Ie0e33e93822bc6e95ace2fed5abe66f42dae5ca5
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

build: apply autoconf suggestions

add -I m4 to Makefile for ACLOCAL_AMFLAGS
add macro dirs to configure_ac

Change-Id: Ied5ca518fedab65c63d0c89bcd0f21c3d32265e1
Signed-off-by: Patrick Venture <ventu

build: apply autoconf suggestions

add -I m4 to Makefile for ACLOCAL_AMFLAGS
add macro dirs to configure_ac

Change-Id: Ied5ca518fedab65c63d0c89bcd0f21c3d32265e1
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

add dynamic library interface to enable testing

Add interface defining the methods for dynamic linking to enable
testing.

Change-Id: If4d090d3cedc019b426435a1f651191803bfc1a9
Signed-off-by: Patrick

add dynamic library interface to enable testing

Add interface defining the methods for dynamic linking to enable
testing.

Change-Id: If4d090d3cedc019b426435a1f651191803bfc1a9
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

main: add missing header: blobs-ipmid/manager.hpp

Add missing header: blobs-ipmid/manager.hpp. The code receives this
header through another header. However, it should declare this
inclusion requi

main: add missing header: blobs-ipmid/manager.hpp

Add missing header: blobs-ipmid/manager.hpp. The code receives this
header through another header. However, it should declare this
inclusion requirement itself.

Change-Id: Ib82909681a45a18489f65ec42b74a1824285efa1
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

copyright: add missing copyright headers

Add missing copyright headers to the source files. Originally, left
off. Reviewing other new sources acted as a reminder.

Change-Id: I7ac612fbea731885b93c

copyright: add missing copyright headers

Add missing copyright headers to the source files. Originally, left
off. Reviewing other new sources acted as a reminder.

Change-Id: I7ac612fbea731885b93cb13346afcddda54bdec3
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

drop explicit command entry

The command entry for blobTransferCmd was accepted into
phosphor-host-ipmid's oem header. Therefore, no longer specify it
locally.

Change-Id: Ib5879cb31f855c5b5662e659d

drop explicit command entry

The command entry for blobTransferCmd was accepted into
phosphor-host-ipmid's oem header. Therefore, no longer specify it
locally.

Change-Id: Ib5879cb31f855c5b5662e659d71c21e5fd6c50a3
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

bugfix: load handlers and use factory symbol

Use a predefined factory symbol to build each handler after loading the
library.

Change-Id: I0369c6e46a57c2e8533409d8b06eb74a3962434c
Signed-off-by: Pat

bugfix: load handlers and use factory symbol

Use a predefined factory symbol to build each handler after loading the
library.

Change-Id: I0369c6e46a57c2e8533409d8b06eb74a3962434c
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

bugfix: add -export-dynamic to Makefile linker flags

Add -export-dynamic to Makefile linker flags so that blob handlers can
access getBlobManager() when they're loaded.

Tested: The symbols are now

bugfix: add -export-dynamic to Makefile linker flags

Add -export-dynamic to Makefile linker flags so that blob handlers can
access getBlobManager() when they're loaded.

Tested: The symbols are now exported, however, blob handlers still
cannot resolve blobs::getBlobManager().
Change-Id: I025fdbd701133fc59356e3a0ed8881b2cdd0f2a0
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

bugfix: flip library search logic

Fix library search logic to load libraries installed of the format:
libname.so.? versus libname.so because the recipe creates a symlink of
the form libname.so.? onl

bugfix: flip library search logic

Fix library search logic to load libraries installed of the format:
libname.so.? versus libname.so because the recipe creates a symlink of
the form libname.so.? only.

Tested: Now it finds and loads the handlers.
Change-Id: Ie7280f41a678bf78db226bb458c02396e352da56
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

bugfix: skip 0'd crc bytes on reply computation

Skip the 0'd CRC bytes on reply computation, mirroring the skipping
during request validation.

Tested: Verified via client the CRC for the reply now

bugfix: skip 0'd crc bytes on reply computation

Skip the 0'd CRC bytes on reply computation, mirroring the skipping
during request validation.

Tested: Verified via client the CRC for the reply now matches
expectations.
Change-Id: I18da28604a388fb4210c55f3e54410a067b9f10a
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

process: add IPMI error return mechanism and update errors

The IPMI packet validation code must return specific IPMI errors
corresponding to what error has occurred instead of the invalid command
er

process: add IPMI error return mechanism and update errors

The IPMI packet validation code must return specific IPMI errors
corresponding to what error has occurred instead of the invalid command
error.

Update all IPMI handler pieces to return more specific errors.

Change-Id: I8d21e92015d84cc0880e3b83991aed7288e19eab
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

build: Add -flto to CXXFLAGS

Add -flto to CXXFLAGS to allow build optimization.

Change-Id: Icc7bd996bd512a0d84a35b6a0449f69611a69de1
Signed-off-by: Patrick Venture <venture@google.com>

build: cleanup Makefile

Cleanup spaces from the Makefile. Automake is ok with spaces, but for a
cleaner file, use tabs.

Change-Id: Ie18f80a5e65a05611472e61801b669e1564b17e1
Signed-off-by: Patrick

build: cleanup Makefile

Cleanup spaces from the Makefile. Automake is ok with spaces, but for a
cleaner file, use tabs.

Change-Id: Ie18f80a5e65a05611472e61801b669e1564b17e1
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

main: s/blobs-ipmid/blob-ipmid/ for library path

Fixup a typo in the library path. The library path will be specified in
a later patchset from the configure.ac by default, but that typo would
have

main: s/blobs-ipmid/blob-ipmid/ for library path

Fixup a typo in the library path. The library path will be specified in
a later patchset from the configure.ac by default, but that typo would
have just lived there instead.

Change-Id: Ia9f95fc46e3835781e4dbe3b3fdb2d9d36b7e565
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

manager: fixup to use find_if

[manager.cpp:150]: (style) Consider using std::find_if algorithm
instead of a raw loop.

Note: Amusingly switching to a const iterator allowed cppcheck to find
this cle

manager: fixup to use find_if

[manager.cpp:150]: (style) Consider using std::find_if algorithm
instead of a raw loop.

Note: Amusingly switching to a const iterator allowed cppcheck to find
this cleanup.

Change-Id: I16d87d4dde165fbb226259d1abc8deaa51569af1
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

cleanup: apply const to read-only iterators

Apply const to read-only iterators.

Change-Id: Ib58f98596cb9f185d3b16a0b1fbd895dd37d3fd6
Signed-off-by: Patrick Venture <venture@google.com>

main: catch exceptions when loading blob handlers

If an error occurs while attempting to load the blob handlers (such as a
filesystem error), the uncaught exception will crash the entire IPMI
daemon

main: catch exceptions when loading blob handlers

If an error occurs while attempting to load the blob handlers (such as a
filesystem error), the uncaught exception will crash the entire IPMI
daemon. Instead, catch the exception and print an error message.

Tested: ipmid doesn't crash when /usr/lib/blobs-ipmid is missing
Signed-off-by: Benjamin Fair <benjaminfair@google.com>
Change-Id: Ic316f6e5aa3c4bc6eba4fa2e561b338f4b20f606

show more ...

manager: reduce scope of variable

The lsess variable can have a smaller scope.

Change-Id: I79aa84b25b52708c8c35ed1a56dbfe89dabd29fb
Signed-off-by: Patrick Venture <venture@google.com>

new command: BmcBlobWriteMeta

Implement new command BmcBlobWriteMeta.

Change-Id: I2e148f4bde4ef5d24db7e30bb02bdde024d9166a
Signed-off-by: Patrick Venture <venture@google.com>

build: fixup paths to leverage ipmiprovider symlinks

Add a comment and fix up the destination folder for the example handler.

Change-Id: Idc3bfbb77d4d103092b49c7cc63d462fe23a5f61
Signed-off-by: Pat

build: fixup paths to leverage ipmiprovider symlinks

Add a comment and fix up the destination folder for the example handler.

Change-Id: Idc3bfbb77d4d103092b49c7cc63d462fe23a5f61
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

process: rework lookup to use map for handlers

Switches lookup to use a map as adding another command makes the list
too long.

Change-Id: I35257ff5ae8c4c14c88aa2fa7d866642370ef38f
Signed-off-by: Pa

process: rework lookup to use map for handlers

Switches lookup to use a map as adding another command makes the list
too long.

Change-Id: I35257ff5ae8c4c14c88aa2fa7d866642370ef38f
Signed-off-by: Patrick Venture <venture@google.com>

show more ...