meson: reformat with meson formatter

Apply the `meson format` results.

Change-Id: I317fd198ddb8247b4836cba2f61228e7b13aae94
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

clang-format: update latest spec and reformat

Copy the latest format file from the docs repository and apply.

Change-Id: I4685454a66a0a4832d138d6b4df649e804fa25d0
Signed-off-by: Patrick Williams <p

clang-format: update latest spec and reformat

Copy the latest format file from the docs repository and apply.

Change-Id: I4685454a66a0a4832d138d6b4df649e804fa25d0
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

build: use allowed over enabled or not-disabled

Meson feature options are typically in a tri-state of enabled, disabled,
or auto. The enabled and disabled functions on an option (from
`get_option`)

build: use allowed over enabled or not-disabled

Meson feature options are typically in a tri-state of enabled, disabled,
or auto. The enabled and disabled functions on an option (from
`get_option`) no longer return true for auto features. Instead, the
expectation is to use `allowed()` which is true for both enabled and
auto.

Switch all uses of `enabled` to `allowed`.
Switch all uses of `not disabled` to `allowed`.

Change-Id: I86623dd968ce368a5349faf3e97728c02549c2bd
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

clang-tidy: Initial commit

The clang-tidy configuration file has been initialized with all
recommended C++ category checks. These category checks are currently
disabled, except for one, which has be

clang-tidy: Initial commit

The clang-tidy configuration file has been initialized with all
recommended C++ category checks. These category checks are currently
disabled, except for one, which has been enabled for initial
validation. This strategy allows developers to progressively
enable the necessary checks over time.

Tested: verified build.

Change-Id: I57a9e3dc575f2841cec044a95a7537a00a399981
Signed-off-by: Jayanth Othayoth <ojayanth@gmail.com>

show more ...

clang-tidy: Suppress C-linkage warning

Used `#pragma clang diagnostic` directives to suppress the
`-Wreturn-type-c-linkage` warning for the `createHandler` function
when compiling with Clang. This e

clang-tidy: Suppress C-linkage warning

Used `#pragma clang diagnostic` directives to suppress the
`-Wreturn-type-c-linkage` warning for the `createHandler` function
when compiling with Clang. This ensures compatibility with C++ types,
specifically `std::unique_ptr`, while maintaining C linkage for other
functions.

Tested: Build verified

Change-Id: I7fd4e98a75dc537cbf60c085de0a074511b2bd7d
Signed-off-by: Jayanth Othayoth <ojayanth@gmail.com>

show more ...

clang-tidy: Replace NULL with nullptr

Replaced all instances of NULL with nullptr to improve type safety
and clarity, as nullptr is the modern C++ standard for null pointers.

Tested: Build verified

clang-tidy: Replace NULL with nullptr

Replaced all instances of NULL with nullptr to improve type safety
and clarity, as nullptr is the modern C++ standard for null pointers.

Tested: Build verified

Change-Id: Ib39f49b2a1239082eeac355234a65d7257031f10
Signed-off-by: Jayanth Othayoth <ojayanth@gmail.com>

show more ...

clang-format: re-format for clang-19

clang-format-19 isn't compatible with the clang-format-18 output, so we
need to reformat the code with the latest version. A few parameters
in clang-tidy have b

clang-format: re-format for clang-19

clang-format-19 isn't compatible with the clang-format-18 output, so we
need to reformat the code with the latest version. A few parameters
in clang-tidy have been deprecated, so adjust the style file
accordingly.

See Ie2f6eb3b043f2d655c9df806815afd7971fd0947 for updated style.
See I88192b41ab7a95599a90915013579608af7bc56f for clang-19 enablement.

Change-Id: I0353e691399a71669a4387b72b8b93573b76f6a0
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda forma

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda formatting also changed, so we have made changes to the
organization default style format to better handle lambda formatting.

See I5e08687e696dd240402a2780158664b7113def0e for updated style.
See Iea0776aaa7edd483fa395e23de25ebf5a6288f71 for clang-18 enablement.

Change-Id: I7c1a903d0b8fe5df2da9a73bda2d84113e9d854d
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

clang-format: copy latest and re-format

clang-format-17 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-17 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: I35d3ba19f100c4f2f0a924af86454a5fabeae03c
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

test: Return from validateReply if no reply

Return early if actualReply doesn't have value instead of getting the
data even after has_value() failed.

Change-Id: I339324d76a704f8b7bce98cfdf881225e46

test: Return from validateReply if no reply

Return early if actualReply doesn't have value instead of getting the
data even after has_value() failed.

Change-Id: I339324d76a704f8b7bce98cfdf881225e46c5aca
Signed-off-by: Willy Tu <wltu@google.com>

show more ...

meson_options.txt: Support for reading options from meson.options

Support has been added for reading options from meson.options instead
of meson_options.txt[1]. These are equivalent, but not using t

meson_options.txt: Support for reading options from meson.options

Support has been added for reading options from meson.options instead
of meson_options.txt[1]. These are equivalent, but not using the .txt
extension for a build file has a few advantages, chief among them
many tools and text editors expect a file with the .txt extension to
be plain text files, not build scripts.

[1] https://mesonbuild.com/Release-notes-for-1-1-0.html#support-for-reading-options-from-mesonoptions

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I8de384af89124656bd8e8aa125483df7cdb74c36

show more ...

Enable non unit-test.py docker build

Add subproject wraps for dependencies that aren't pre-built in the CI
docker image. Trying to make things easier to build with less CI
infrastructure.

Change-Id

Enable non unit-test.py docker build

Add subproject wraps for dependencies that aren't pre-built in the CI
docker image. Trying to make things easier to build with less CI
infrastructure.

Change-Id: Ic5aff12e1bc98f6c2fed1b1fdc4ae0c46197622e
Signed-off-by: Jonathan Doman <jonathan.doman@intel.com>

show more ...

build: upgrade to C++23

Meson 1.1.1 and GCC-13 both support C++23 and a sufficient portion of
the standard has been implemented. Upgrade the build to leverage it.

Change-Id: Iab54922e22722f7dbd4b0

build: upgrade to C++23

Meson 1.1.1 and GCC-13 both support C++23 and a sufficient portion of
the standard has been implemented. Upgrade the build to leverage it.

Change-Id: Iab54922e22722f7dbd4b01b09fce35c4a8ea6d17
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: I86d194886a4dcd325364041d4c7745f4ea22fd65
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

test: Remove unneeded header

Signed-off-by: Willy Tu <wltu@google.com>
Change-Id: I1a6f6fdd4de59a8f6682a0c7609d380c4bc493e1

markdownlint: fix all warnings

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I3f330148b65c0f5ace2253bc203be3890f211266

prettier: re-format

Prettier is enabled in openbmc-build-scripts on Markdown, JSON, and YAML
files to have consistent formatting for these file types. Re-run the
formatter on the whole repository.

prettier: re-format

Prettier is enabled in openbmc-build-scripts on Markdown, JSON, and YAML
files to have consistent formatting for these file types. Re-run the
formatter on the whole repository.

Change-Id: I5563d8a1a92828c12bf932d8b7ebd4968bdc05b2
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

Recover Add ipmi response buffer size check for all commands

Use the ipmi::Context channel to get the max transfer size to make sure
that we select the right size.

Also remove maximumReadSize since

Recover Add ipmi response buffer size check for all commands

Use the ipmi::Context channel to get the max transfer size to make sure
that we select the right size.

Also remove maximumReadSize since the max reply size is checked instead

We already check the max reply size so maximumReadSize is not needed
anymore. This will result in a bit of a different behavior when the size
exceed the max. It will not fail - instead, it will return up to the
max size.

Tested:
Work with ipmi config that doesn't support the default interface (13).
```
cat /usr/share/ipmi-providers/channel_config.json
{
"0": {
"name": "usb0",
"is_valid": true,
"active_sessions": 0,
"channel_info": {
"medium_type": "lan-802.3",
"protocol_type": "ipmb-1.0",
"session_supported": "multi-session",
"is_ipmi": true
}
},
"8": {
"name": "INTRABMC",
"is_valid": true,
"active_sessions": 0,
"channel_info": {
"medium_type": "oem",
"protocol_type": "oem",
"session_supported": "session-less",
"is_ipmi": true
}
},
"11": {
"name": "gbmcbr",
"is_valid": true,
"active_sessions": 0,
"channel_info": {
"medium_type": "lan-802.3",
"protocol_type": "ipmb-1.0",
"session_supported": "multi-session",
"is_ipmi": true
}
}
}
```

This read the blob count and always works now since it uses the right
interface to get the max transfer size.
```
ipmitool raw 46 128 207 194 0 0
cf c2 00 4a ac 0e 00 00 00
```

Change-Id: Ia65f80719a819e7d642eb7425463a56c179935ac
Signed-off-by: Willy Tu <wltu@google.com>

show more ...

Refactor to use new version of OEM IPMI Handler

Using the new version of ipmi handler provide a higher level wrapper
over the same functionalities. It helps us parse the input and output to
have mor

Refactor to use new version of OEM IPMI Handler

Using the new version of ipmi handler provide a higher level wrapper
over the same functionalities. It helps us parse the input and output to
have more control of the input/output we see.

Changes to note,
- All cmd are removed from the request data. That is automatically
extracted now.

Tested:
Unit Test Passed.

All IPMI OEM command still works the same as before this change.

```
$ burn_my_bmc -command stage -image /tmp/test.txt -interface ipmipci
Set up ipmi flash updater with /flash/dummy
Received failure on delete: Received IPMI_CC: 255
Sending over the firmware image.
Find [0x1050 0x750]
bar0[0x94000000]
Upload to BMC 100% |Goooooooooooooooooooooooooooooooooooooooooooooooooooooooogle| Time: 00:00:00
Opening the verification file
Committing to /flash/verify to trigger service
Calling stat on /flash/verify session to check status
success
succeeded
```

Also tested gBMC Update workflow which worked fine.

Change-Id: Ib2bfeab0c2ec5aa72ede1ff457ef5f90e488053c
Signed-off-by: Willy Tu <wltu@google.com>

show more ...

MAINTAINERS: remove file

The MAINTAINERS file is deprecated in favor of OWNERS.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ibffec0de549e0cee2e0b9f4234d31b7f39eafbbe

OWNERS: switch 'matches' to 'matchers'

The original OWNERS template had a mistake which used 'matches' instead
of the field supported by the Gerrit plugin 'matchers'. Update the
OWNERS file to have

OWNERS: switch 'matches' to 'matchers'

The original OWNERS template had a mistake which used 'matches' instead
of the field supported by the Gerrit plugin 'matchers'. Update the
OWNERS file to have the correct field.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I2da5f3ed981f65122908255662c02fbc8dffe388

show more ...

Revert "Add ipmi response buffer size check for all commands"

This reverts commit 88ca532a74375cc99bd979fbb037d07e5ee76cce.

Reason for revert: ipmi::getChannelMaxTransferSize is only using the
defa

Revert "Add ipmi response buffer size check for all commands"

This reverts commit 88ca532a74375cc99bd979fbb037d07e5ee76cce.

Reason for revert: ipmi::getChannelMaxTransferSize is only using the
default channel and may fail when using a different channel.

Change-Id: Ic080de6f51c05f86807b81dfd3dd38a87fc2dbf5
Signed-off-by: Willy Tu <wltu@google.com>

show more ...

Add ipmi response buffer size check for all commands

Add a response size check for all Blob command using the max transfer
buffer size for the default ipmi channel.

The max size is fetched at the b

Add ipmi response buffer size check for all commands

Add a response size check for all Blob command using the max transfer
buffer size for the default ipmi channel.

The max size is fetched at the beginning and assumed that it won't
change. This is done instead of fetching it for all request to limit the
amount of refactoring needed to make it work with existing codebase.

Change-Id: I66c506cab9c92a120e9fc75da4b6b74d5677120b
Signed-off-by: Willy Tu <wltu@google.com>

show more ...

meson: add phosphor-logging wrapfile

There are still autotools-based dependencies which don't currently have
a wrapfile option, but at least add the wrapfile for phosphor-logging.

Signed-off-by: Pa

meson: add phosphor-logging wrapfile

There are still autotools-based dependencies which don't currently have
a wrapfile option, but at least add the wrapfile for phosphor-logging.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I8a8e4a4d4e6de83ce1a932dc6381cd0095d0db69

show more ...

phosphor-ipmi-blobs: Code Health Cleanup

Removed the following errors.
- the 'empty' method should be used to check for emptiness instead of
comparing to an empty object
- using decl '*' is unus

phosphor-ipmi-blobs: Code Health Cleanup

Removed the following errors.
- the 'empty' method should be used to check for emptiness instead of
comparing to an empty object
- using decl '*' is unused
- redundant return statement at the end of a function with a void return
type
- variable 'managerReturned' defined in a header file; variable
definitions in header files can lead to ODR violations
- function 'getBlobManager' defined in a header file; function
definitions in header files can lead to ODR violations

Change-Id: I70c3db92c81b1f1b2468814605e0b2dfd358b401
Signed-off-by: Willy Tu <wltu@google.com>

show more ...