test: Add unit tests for session expiration

Add simple tests to ensure the session expire method is called when
the timeout is set to zero.

Signed-off-by: Kun Yi <kunyi731@gmail.com>
Change-Id: Ic6

test: Add unit tests for session expiration

Add simple tests to ensure the session expire method is called when
the timeout is set to zero.

Signed-off-by: Kun Yi <kunyi731@gmail.com>
Change-Id: Ic6e973ede760a6a6f15726d5b6c93a892d858c8b

show more ...

Implement session expiration

If the caller opens sessions but doesn't close them, either
intentionally or unintentionally, session IDs will leak. Once the
maximum number of sessions are reached, no

Implement session expiration

If the caller opens sessions but doesn't close them, either
intentionally or unintentionally, session IDs will leak. Once the
maximum number of sessions are reached, no new session can be opened.

Implement a cleanup procedure to automatically remove stale sessions. If
a session hasn't seen activity for a while, call the expire()
functions on the handler, and remove the session from tracking table.
For handlers that haven't implemented the expire() call this change will
be a no-op.

Signed-off-by: Kun Yi <kunyi731@gmail.com>
Change-Id: I895ae19b4003d2d6f7a0b2e73370fe5aa664adee

show more ...

Store the last action time in session info

Add a timestamp member in SessionStat to capture when the session
sees activity last, and update it with every action. The timestamp
will be used to check

Store the last action time in session info

Add a timestamp member in SessionStat to capture when the session
sees activity last, and update it with every action. The timestamp
will be used to check when the session should expire.

Signed-off-by: Kun Yi <kunyi731@gmail.com>
Change-Id: Ic781d54173099bff76b3c37dd296521680fe7986

show more ...

Refactor various methods to get session or blob handler

Use a single method to fetch the handler, if it can be found using
session ID.

Signed-off-by: Kun Yi <kunyi731@gmail.com>
Change-Id: I648cbc4

Refactor various methods to get session or blob handler

Use a single method to fetch the handler, if it can be found using
session ID.

Signed-off-by: Kun Yi <kunyi731@gmail.com>
Change-Id: I648cbc48ebfae479f63d34e8f2465d2c8cbe9d64

show more ...

blobs: s/struct BlobMeta/BlobMeta/g

Because this structure is not anything special, simply use the cpp
idiomatic way of referencing the object.

Consistently, structures that are packed still have "

blobs: s/struct BlobMeta/BlobMeta/g

Because this structure is not anything special, simply use the cpp
idiomatic way of referencing the object.

Consistently, structures that are packed still have "struct" used in
declarations. However, this distinction is only clear through its usage
and nothing in the language. Perhaps a better approach would be
notational naming struct PackedXYZ {};. However, that can get out of
control quickly.

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I3b7e48e4b6687ef2e15e9d07c0eeba96eb5d2552

show more ...

README: add delete blob contract note

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: Iac2768eebcf1ab28e28cdba601574dbede4fc9ec

README: add calling contract details

Provide contract details for what handlers can expect from the blob
manager. This saves extra checks within the handler.

Incidental markdown cleanup.

Signed-o

README: add calling contract details

Provide contract details for what handlers can expect from the blob
manager. This saves extra checks within the handler.

Incidental markdown cleanup.

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I572fdfb9e726d9f4d1ba89bb92b38c67cd7f07e2

show more ...

blobs-ipmid: use enum class for BlobOEMCommands

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: Ic5aa3e38b4df33a2cfa29c575f17097e38d06605

blobs-ipmid: blobs: add equality operator for BlobMeta

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I22ac3b8c5ad49e2fa3424ef6d9f03a3d5dc7bf51

build: split object to enable coverage

Split the object into two pieces so we can pass part of it to the
unit-tests.

Tested: Verified the coverage output processed the files.
Change-Id: Idf1bdf9d21

build: split object to enable coverage

Split the object into two pieces so we can pass part of it to the
unit-tests.

Tested: Verified the coverage output processed the files.
Change-Id: Idf1bdf9d21eb1324395eb9a2c09ff8f1b4ecad6b
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

autotools: Fix for autoconf-archive 2019.01.19

The code coverage macros from the archive changed in a backward
incompatible way. This adds a workaround to autodetect either version
and do the right

autotools: Fix for autoconf-archive 2019.01.19

The code coverage macros from the archive changed in a backward
incompatible way. This adds a workaround to autodetect either version
and do the right thing.

Change-Id: I09b88e6b4792c99140a73a4ceb11d2896ee13562
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

use ipmiblob library from ipmi-blob-tool

Drop all code that is now handled by the ipmiblob library provided by
the new ipmi-blob-tool. This is a library that can be included on the
BMC if necessary

use ipmiblob library from ipmi-blob-tool

Drop all code that is now handled by the ipmiblob library provided by
the new ipmi-blob-tool. This is a library that can be included on the
BMC if necessary, but relies on nothing that is strictly meant for the
BMC.

Change-Id: I2b02ae0d432e84c08e598d27eef85b57c06a70fc
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

build: add dependency on ipmiblob

ipmiblob is the library provided by ipmi-blob-tool.

Change-Id: Ic58065eb280e8628f36764bd40f973be10f114ca
Signed-off-by: Patrick Venture <venture@google.com>

use filesystem instead of experimental

Use filesystem now that it should be available instead of
experimental::filesystem.

Change-Id: Ia9b17f33ced70fe2f1f12f11d8708d15ff422bfa
Signed-off-by: Patric

use filesystem instead of experimental

Use filesystem now that it should be available instead of
experimental::filesystem.

Change-Id: Ia9b17f33ced70fe2f1f12f11d8708d15ff422bfa
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

build: enable valgrind

Enable valgrind tests.

Change-Id: Ib5ec22a19c043ef45f5274e4716e2abbae9c19da
Signed-off-by: Patrick Venture <venture@google.com>

build: enable code coverage

Enable code coverage for the project. Valgrind not enabled in this
step.

Change-Id: I439d58b23d2bc29d6f602600319074c8fd8c04d6
Signed-off-by: Patrick Venture <venture@go

build: enable code coverage

Enable code coverage for the project. Valgrind not enabled in this
step.

Change-Id: I439d58b23d2bc29d6f602600319074c8fd8c04d6
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

build: rework gtest checks

Rework gtest checks to be modeled after openbmc/gpioplus.

Change-Id: I263bf12c0323ebee5d95b569ce28da2042bd3c1d
Signed-off-by: Patrick Venture <venture@google.com>

build: pkg anti-pattern: use defaults

Use the defaults in the pkg check where the default error message is
sufficient to identify which package is missing.

Change-Id: I420f4702c9cf78af58854fba06e73

build: pkg anti-pattern: use defaults

Use the defaults in the pkg check where the default error message is
sufficient to identify which package is missing.

Change-Id: I420f4702c9cf78af58854fba06e731e49e1ec5f2
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

readme: add the OEN used

The openbmc oem number is used within the code, but not specified in the
readme. Add this number to the readme.

Change-Id: I3db669fb347cee6596bd973a09910a962eb03570
Signed

readme: add the OEN used

The openbmc oem number is used within the code, but not specified in the
readme. Add this number to the readme.

Change-Id: I3db669fb347cee6596bd973a09910a962eb03570
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

Convert host-ipmid -> libipmid

phosphor-host-ipmid now exposes a library along with headers for
interfacing with the ipmi daemon. Compile and link against the new
library.

Change-Id: I663e6607f711b

Convert host-ipmid -> libipmid

phosphor-host-ipmid now exposes a library along with headers for
interfacing with the ipmi daemon. Compile and link against the new
library.

Change-Id: I663e6607f711bc8bae0a2127db524868f6d4cc32
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

move blob command enum to installed header

Move the blob command enum to an installed header to improve cross-use.

Change-Id: I2093bf993f76a2b87f8e7fdbdfcbaf2dfc012af9
Signed-off-by: Patrick Ventur

move blob command enum to installed header

Move the blob command enum to an installed header to improve cross-use.

Change-Id: I2093bf993f76a2b87f8e7fdbdfcbaf2dfc012af9
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

manager: add hard-coded read checks

The host-client cannot try to read back more than this number of bytes
without hitting a memory overflow in phosphor-host-ipmid. The method we
can call to dynami

manager: add hard-coded read checks

The host-client cannot try to read back more than this number of bytes
without hitting a memory overflow in phosphor-host-ipmid. The method we
can call to dynamically receive that number isn't currently linking out
of the userlayer library.

Note: Once the configure_ac can find and provide the userlayer library
from phosphor-host-ipmid, we can remove the hard-coded 64 and 0xe.

Change-Id: I08f6bb59ce44279f76a494dccaa477ae75d532c4
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

blobs-ipmid: blobs header: add prototype all handlers need

All blob handlers need to implement this prototype. It's called by the
blob manager when it's loading the various blob handler objects.

C

blobs-ipmid: blobs header: add prototype all handlers need

All blob handlers need to implement this prototype. It's called by the
blob manager when it's loading the various blob handler objects.

Change-Id: I62329baeb536a624abeb17995bb778ec1c11ca8f
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

stop installing manager header

Stop installing the manager header as it is no longer meant to be
exported, but rather used only internally within this repository.

Change-Id: I2ab21a31fd745e1b3e36fc

stop installing manager header

Stop installing the manager header as it is no longer meant to be
exported, but rather used only internally within this repository.

Change-Id: I2ab21a31fd745e1b3e36fc39ffea5e26d373ff51
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

bugfix: process: can be only crc

The read command, if returning 0 bytes of data, does return the CRC.

Tested: Verified via a client implementation that it now behaves as
expected on returning 0 byt

bugfix: process: can be only crc

The read command, if returning 0 bytes of data, does return the CRC.

Tested: Verified via a client implementation that it now behaves as
expected on returning 0 bytes from a read (returns only the CRC).
Change-Id: I84200c0fbe8400cc9234b55991fee750cb84faa2
Signed-off-by: Patrick Venture <venture@google.com>

show more ...