| fda41789 | 06-Oct-2021 |
Patrick Williams <patrick@stwcx.xyz> |
build: switch to C++20
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ic4293a225b9fa30c358e79c095a9c27da97147a1 |
| 88c23f40 | 25-Oct-2021 |
Willy Tu <wltu@google.com> |
phosphor-ipmi-blobs: Update Maintainers and Reviewers
Signed-off-by: Willy Tu <wltu@google.com>
Change-Id: I519dacc4dbf5497a68dccc86e9169396c62ea213 |
| f39e668c | 16-Jun-2021 |
William A. Kennington III <wak@google.com> |
build: Remove autotools
No longer needed with meson being adopted.
Change-Id: Ia9e86fa29ece20dadce854d4c3f06b894af13f96
Signed-off-by: William A. Kennington III <wak@google.com> |
| d5ed4099 | 16-Jun-2021 |
William A. Kennington III <wak@google.com> |
meson: Install headers
This was missed when creating the initial meson build.
Change-Id: I7bf85413d779d99e21e8cc2b5294ee4700d1d4fa
Signed-off-by: William A. Kennington III <wak@google.com> |
| d963adb5 | 15-Jun-2021 |
William A. Kennington III <wak@google.com> |
build: Add meson
Change-Id: I9b6bf99113a4fbfb92b0b8b6c4e3feff0c070421
Signed-off-by: William A. Kennington III <wak@google.com> |
| 117912d2 | 15-Jun-2021 |
William A. Kennington III <wak@google.com> |
ipmi: Remove non-standard c++ array syntax
Change-Id: I1c62222ab8584ffc5af6d99c80b93f5e93b4e26f
Signed-off-by: William A. Kennington III <wak@google.com> |
| 993f5419 | 15-Jun-2021 |
William A. Kennington III <wak@google.com> |
treewide: Remove unused variables
Change-Id: I946716e87ff95c3775d2802b83de565b6b2ac0a3
Signed-off-by: William A. Kennington III <wak@google.com> |
| 3ccee07b | 15-Jun-2021 |
William A. Kennington III <wak@google.com> |
utils: Make loader more lenient
Loaded modules tend to be unversioned, so we shouldn't enforce that they
have a version suffix.
Change-Id: I9e7a02ea841b7c0634c84718c46707f087ee86ae
Signed-off-by: W
utils: Make loader more lenient
Loaded modules tend to be unversioned, so we shouldn't enforce that they
have a version suffix.
Change-Id: I9e7a02ea841b7c0634c84718c46707f087ee86ae
Signed-off-by: William A. Kennington III <wak@google.com>
show more ...
|
| 766beb3f | 16-Jun-2021 |
William A. Kennington III <wak@google.com> |
utils: Deduplicate library loading
This prevents us from accidentally initializing a blob module twice.
Change-Id: Iee4dea66962f3a5a376a72ae22f3fca69b33264f
Signed-off-by: William A. Kennington III
utils: Deduplicate library loading
This prevents us from accidentally initializing a blob module twice.
Change-Id: Iee4dea66962f3a5a376a72ae22f3fca69b33264f
Signed-off-by: William A. Kennington III <wak@google.com>
show more ...
|
| 52b75fb3 | 24-Apr-2021 |
Willy Tu <wltu@google.com> |
test: Replace the C++ MOCK_METHOD<n> macros with the new MOCK_METHOD
Change-Id: I1667c6edd37447dbb6e868e853eb5ac05f348f89
Signed-off-by: Willy Tu <wltu@google.com> |
| a533a375 | 13-Apr-2021 |
Patrick Williams <patrick@stwcx.xyz> |
bootstrap: fix shellcheck warnings
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I86ef079c9632e5563a1a56d6a2e23aad59ecbc57 |
| 485e54ae | 24-Nov-2020 |
Sui Chen <suichen@google.com> |
Add prefix to pkgconfig
The pkg-config program used in the CI expects the `prefix` variable to
be set in the pkgconfig file. As such, this variable is added so that
the CI can pass.
This may not af
Add prefix to pkgconfig
The pkg-config program used in the CI expects the `prefix` variable to
be set in the pkgconfig file. As such, this variable is added so that
the CI can pass.
This may not affect bitbake since the pkg-config program used by bitbake
may accept a pkgconfig file without a prefix variable in it.
Signed-off-by: Sui Chen <suichen@google.com>
Change-Id: I9672597bf54044f2261f8cdc63bd21c5ebfba007
show more ...
|
| c7c941d9 | 08-Dec-2020 |
Patrick Venture <venture@google.com> |
continue loading libraries if factory excepts
If one of the blob handler factories throws an exception, it would stop
processing. If the first one it tried failed, then none would load.
This change
continue loading libraries if factory excepts
If one of the blob handler factories throws an exception, it would stop
processing. If the first one it tried failed, then none would load.
This changes that behavior such that such errors are logged. If a
platform is using a blob handler for firmware updates and the firmware
update breaks the ability for future updates by breaking a library that
loads before it, that is now avoided.
Tested: Ran on qemu with broken blob handler factory and before no blobs
were listed, and now all the other blobs were listed.
Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: Ief2999a200708cfab0442aacb5a9056f3aa07260
show more ...
|
| 7bda17a7 | 06-Oct-2020 |
Sui Chen <suichen@google.com> |
Add pkgconfig
Generate pkgconfig for phosphor-ipmi-blobs so that the library can be
found by Meson.
When used as a dependency, phosphor-ipmi-blobs provides only a header
file and no libraries to li
Add pkgconfig
Generate pkgconfig for phosphor-ipmi-blobs so that the library can be
found by Meson.
When used as a dependency, phosphor-ipmi-blobs provides only a header
file and no libraries to link against, so the pkgconfig file has no
linker flags.
Tested: added phosphor-ipmi-blobs as a dependency in
phosphor-health-monitor's meson.build file and built successfully.
signed-off-by: Sui Chen <suichen@google.com>
Change-Id: I126c66dbd65ddbd99f921297d813e7a0f9981f22
show more ...
|
| 99f25beb | 28-Sep-2020 |
Patrick Venture <venture@google.com> |
test/utils: stop using local variable with global return
Removes warnings about returning a local variable's address. The code
was "safe" because it was always returned before the stack was returne
test/utils: stop using local variable with global return
Removes warnings about returning a local variable's address. The code
was "safe" because it was always returned before the stack was returned
from, but this change makes it "safer."
Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I675dfd1ae348dcf6a3bc47b9c1ca904da11238af
show more ...
|
| b6ed5626 | 28-Sep-2020 |
Patrick Venture <venture@google.com> |
test: flexible array member cannot go into lambda
The flexible array member cannot be captured in a lambda expression.
Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: Ia2a8942d6e9c0c
test: flexible array member cannot go into lambda
The flexible array member cannot be captured in a lambda expression.
Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: Ia2a8942d6e9c0c3f58a9bf966a0100785a8b6c91
show more ...
|
| 03fd5b8b | 07-May-2020 |
Patrick Venture <venture@google.com> |
move entry point handler to process
Move the entry point handler for IPMI messages to process for two
reasons:
1) this lets one build pieces of this library without including the
constructor
2) this
move entry point handler to process
Move the entry point handler for IPMI messages to process for two
reasons:
1) this lets one build pieces of this library without including the
constructor
2) this code is part of the command processing, and as such should be
with its kin.
Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I10ab19b1868a29b158570109b4211e9c8b01be18
show more ...
|
| 9cd8f76d | 22-Nov-2019 |
Kun Yi <kunyi731@gmail.com> |
Various cleanups
* Move functions to private as appropriate
* Reorder functions to match declaration order
* Declare arguments as const when appropriate
* Rename to getActionHandler() to match previ
Various cleanups
* Move functions to private as appropriate
* Reorder functions to match declaration order
* Declare arguments as const when appropriate
* Rename to getActionHandler() to match previous method name
Signed-off-by: Kun Yi <kunyi731@gmail.com>
Change-Id: I7d3b5bbb07c218c6c2d6277a1f19d8a0299bd6e6
show more ...
|
| beee9e54 | 22-Nov-2019 |
Kun Yi <kunyi731@gmail.com> |
cleanup: remove getPath
The getPath call is only used once. Getting rid of it makes it easier to
understand.
Signed-off-by: Kun Yi <kunyi731@gmail.com>
Change-Id: Ifc8859f5fc68bb594003a6db7f7e80b1c
cleanup: remove getPath
The getPath call is only used once. Getting rid of it makes it easier to
understand.
Signed-off-by: Kun Yi <kunyi731@gmail.com>
Change-Id: Ifc8859f5fc68bb594003a6db7f7e80b1c1dfed28
show more ...
|
| cd833aa1 | 22-Nov-2019 |
Kun Yi <kunyi731@gmail.com> |
Fix openFiles refcount
The old code deletes session from the session map before doing a lookup
of the path. Fix the order and add a unit test to catch the error case.
(The unit test would fail witho
Fix openFiles refcount
The old code deletes session from the session map before doing a lookup
of the path. Fix the order and add a unit test to catch the error case.
(The unit test would fail without this fix).
Signed-off-by: Kun Yi <kunyi731@gmail.com>
Change-Id: If043d6aad7bbaafa19ae3b63a6d9cc7a836d25b5
show more ...
|
| fea1d811 | 14-Nov-2019 |
Kun Yi <kunyi731@gmail.com> |
cleanup: Use scoped initializers; move implementation to source file
Simplify code and address comments from
http://gerrit.openbmc-project.xyz/c/openbmc/phosphor-ipmi-blobs/+/27399:
* Use C++17 syn
cleanup: Use scoped initializers; move implementation to source file
Simplify code and address comments from
http://gerrit.openbmc-project.xyz/c/openbmc/phosphor-ipmi-blobs/+/27399:
* Use C++17 syntax of intializers in conditionals to simplify code.
* Move getActionHandle() implementation to .cpp
* return false explicitly
Tested:
Unit tests still pass.
Signed-off-by: Kun Yi <kunyi731@gmail.com>
Change-Id: I08a78125206f284d8c748822912e11828fb39968
show more ...
|
| 9ce83482 | 14-Nov-2019 |
Kun Yi <kunyi731@gmail.com> |
cleanup: Operate on members directly and allow empty paths in the lookup table
Instead of using private methods to change data, directly operate on
it. Currently no test depends on these methods.
T
cleanup: Operate on members directly and allow empty paths in the lookup table
Instead of using private methods to change data, directly operate on
it. Currently no test depends on these methods.
There is also a minor bug fix: the previous code will not increment or
decrement the open session count if the blobId is an empty string,
however there is no check on the manager side. If empty blobIds are
disallowed they should be checked earlier.
Signed-off-by: Kun Yi <kunyi731@gmail.com>
Change-Id: I8d97e098bed2d5c27a204a86ed688d0d9a98f0a2
show more ...
|
| aa17bdaf | 14-Nov-2019 |
Kun Yi <kunyi731@gmail.com> |
test: Add unit tests for session expiration
Add simple tests to ensure the session expire method is called when
the timeout is set to zero.
Signed-off-by: Kun Yi <kunyi731@gmail.com>
Change-Id: Ic6
test: Add unit tests for session expiration
Add simple tests to ensure the session expire method is called when
the timeout is set to zero.
Signed-off-by: Kun Yi <kunyi731@gmail.com>
Change-Id: Ic6e973ede760a6a6f15726d5b6c93a892d858c8b
show more ...
|
| b61a88ba | 13-Nov-2019 |
Kun Yi <kunyi731@gmail.com> |
Implement session expiration
If the caller opens sessions but doesn't close them, either
intentionally or unintentionally, session IDs will leak. Once the
maximum number of sessions are reached, no
Implement session expiration
If the caller opens sessions but doesn't close them, either
intentionally or unintentionally, session IDs will leak. Once the
maximum number of sessions are reached, no new session can be opened.
Implement a cleanup procedure to automatically remove stale sessions. If
a session hasn't seen activity for a while, call the expire()
functions on the handler, and remove the session from tracking table.
For handlers that haven't implemented the expire() call this change will
be a no-op.
Signed-off-by: Kun Yi <kunyi731@gmail.com>
Change-Id: I895ae19b4003d2d6f7a0b2e73370fe5aa664adee
show more ...
|
| 7fc52c8f | 19-Nov-2019 |
Kun Yi <kunyi731@gmail.com> |
Store the last action time in session info
Add a timestamp member in SessionStat to capture when the session
sees activity last, and update it with every action. The timestamp
will be used to check
Store the last action time in session info
Add a timestamp member in SessionStat to capture when the session
sees activity last, and update it with every action. The timestamp
will be used to check when the session should expire.
Signed-off-by: Kun Yi <kunyi731@gmail.com>
Change-Id: Ic781d54173099bff76b3c37dd296521680fe7986
show more ...
|