Refactor to use new version of OEM IPMI Handler

Using the new version of ipmi handler provide a higher level wrapper
over the same functionalities. It helps us parse the input and output to
have mor

Refactor to use new version of OEM IPMI Handler

Using the new version of ipmi handler provide a higher level wrapper
over the same functionalities. It helps us parse the input and output to
have more control of the input/output we see.

Changes to note,
- All cmd are removed from the request data. That is automatically
extracted now.

Tested:
Unit Test Passed.

All IPMI OEM command still works the same as before this change.

```
$ burn_my_bmc -command stage -image /tmp/test.txt -interface ipmipci
Set up ipmi flash updater with /flash/dummy
Received failure on delete: Received IPMI_CC: 255
Sending over the firmware image.
Find [0x1050 0x750]
bar0[0x94000000]
Upload to BMC 100% |Goooooooooooooooooooooooooooooooooooooooooooooooooooooooogle| Time: 00:00:00
Opening the verification file
Committing to /flash/verify to trigger service
Calling stat on /flash/verify session to check status
success
succeeded
```

Also tested gBMC Update workflow which worked fine.

Change-Id: Ib2bfeab0c2ec5aa72ede1ff457ef5f90e488053c
Signed-off-by: Willy Tu <wltu@google.com>

show more ...

phosphor-ipmi-blobs: Code Health Cleanup

Removed the following errors.
- the 'empty' method should be used to check for emptiness instead of
comparing to an empty object
- using decl '*' is unus

phosphor-ipmi-blobs: Code Health Cleanup

Removed the following errors.
- the 'empty' method should be used to check for emptiness instead of
comparing to an empty object
- using decl '*' is unused
- redundant return statement at the end of a function with a void return
type
- variable 'managerReturned' defined in a header file; variable
definitions in header files can lead to ODR violations
- function 'getBlobManager' defined in a header file; function
definitions in header files can lead to ODR violations

Change-Id: I70c3db92c81b1f1b2468814605e0b2dfd358b401
Signed-off-by: Willy Tu <wltu@google.com>

show more ...

ipmi: Remove non-standard c++ array syntax

Change-Id: I1c62222ab8584ffc5af6d99c80b93f5e93b4e26f
Signed-off-by: William A. Kennington III <wak@google.com>

blobs-ipmid: use enum class for BlobOEMCommands

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: Ic5aa3e38b4df33a2cfa29c575f17097e38d06605

stop installing manager header

Stop installing the manager header as it is no longer meant to be
exported, but rather used only internally within this repository.

Change-Id: I2a

stop installing manager header

Stop installing the manager header as it is no longer meant to be
exported, but rather used only internally within this repository.

Change-Id: I2ab21a31fd745e1b3e36fc39ffea5e26d373ff51
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

process: add IPMI error return mechanism and update errors

The IPMI packet validation code must return specific IPMI errors
corresponding to what error has occurred instead of the invali

process: add IPMI error return mechanism and update errors

The IPMI packet validation code must return specific IPMI errors
corresponding to what error has occurred instead of the invalid command
error.

Update all IPMI handler pieces to return more specific errors.

Change-Id: I8d21e92015d84cc0880e3b83991aed7288e19eab
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

header: install test mock headers

IPMI Blob handlers will need to include these mocks when building
unit-tests. Therefore, they must be installed.

Change-Id: I4c8ed0fa1a4a89128

header: install test mock headers

IPMI Blob handlers will need to include these mocks when building
unit-tests. Therefore, they must be installed.

Change-Id: I4c8ed0fa1a4a8912853c024206ef5e61f87707d8
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

initial drop of phosphor-ipmi-blobs

This implements a majority of the OEM IPMI BLOBS protocol. The only
piece missing from this is the timed expiration of sessions.

Change-Id:

initial drop of phosphor-ipmi-blobs

This implements a majority of the OEM IPMI BLOBS protocol. The only
piece missing from this is the timed expiration of sessions.

Change-Id: I82c9d17b625c94fc3340edcfabbbf1ffeb5ad7ac
Signed-off-by: Patrick Venture <venture@google.com>

show more ...