Add the association functionality to the README

Explain how to add association information to a JSON
file so that the inventory manager will create associations
for its objects.

Change-Id: Ibd4aa14

Add the association functionality to the README

Explain how to add association information to a JSON
file so that the inventory manager will create associations
for its objects.

Change-Id: Ibd4aa14e476b379b830e8eebef17b8c01ed97eb8
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

show more ...

serialization: adapt to filesystem API changes

The behavior of std::filesystem::path::append changed on its journey
from experimental:: to std::
Add a testcase and adapt to the behavior change.

Fix

serialization: adapt to filesystem API changes

The behavior of std::filesystem::path::append changed on its journey
from experimental:: to std::
Add a testcase and adapt to the behavior change.

Fixes: e6b21c74581c30ea635aabbbc08d0a56f8e27063
Change-Id: I4bdb43ea9b85933ec12ae0f4b609ec3a33d77d01
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

serialization: Add cereal support for tuples

Add cereal/types/tuple.hpp to our pimgen generated serialization code so
we can serialize xyz.openbmc_project.Association.Definitions

Change-Id: I0fff8e

serialization: Add cereal support for tuples

Add cereal/types/tuple.hpp to our pimgen generated serialization code so
we can serialize xyz.openbmc_project.Association.Definitions

Change-Id: I0fff8eb7c07cbc427aeb6dd65c557b773a9592c2
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

serialization: use the same inflection as sdbus++

When generating code sdbus++ uses python inflection to normalize names.
Use the sdbus++ module that does this when we generate the code that
calls m

serialization: use the same inflection as sdbus++

When generating code sdbus++ uses python inflection to normalize names.
Use the sdbus++ module that does this when we generate the code that
calls methods in code generated by sdbus++. This avoids build failures
like:

gen_serialization.hpp:22:68: error: ‘const class
sdbusplus::xyz::openbmc_project::Example::server::Iface2’ has no member
named ‘example_Property4’; did you mean ‘exampleProperty4’?

Change-Id: I4b6dbb1f977465ea176f27d021ed2633ae40c37b
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

cleanup: Use filesystem instead of experimental

With Thud(Yocto 2.6) bumping gcc version, std::filesystem
is available.

Change-Id: I1837df14e52be3e2007b941c3f9c0d3efc687027
Signed-off-by: Kun Yi <k

cleanup: Use filesystem instead of experimental

With Thud(Yocto 2.6) bumping gcc version, std::filesystem
is available.

Change-Id: I1837df14e52be3e2007b941c3f9c0d3efc687027
Signed-off-by: Kun Yi <kunyi731@gmail.com>

show more ...

build: install into bin instead of sbin

Installs into bin instead of sbin per guidelines.

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I6477001b736d2ca6a137591ae05e83b6aaab5ee4

build: pkg anti-pattern: use defaults

Use the defaults in the pkg check where the default error message is
sufficient to identify which package is missing.

Change-Id: Ie8279e319c33bdbb9425c2d1a3d0e

build: pkg anti-pattern: use defaults

Use the defaults in the pkg check where the default error message is
sufficient to identify which package is missing.

Change-Id: Ie8279e319c33bdbb9425c2d1a3d0e50b6a5150c1
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

build: Don't build tests unless asked

This was attempted previously but didn't get the logic quite right.

Include pthread unconditionally since it is needed by the 'all' target.

Change-Id: I9db7fb

build: Don't build tests unless asked

This was attempted previously but didn't get the logic quite right.

Include pthread unconditionally since it is needed by the 'all' target.

Change-Id: I9db7fb15280357b53a748f1c385a5523e37e34a4
Fixes: 35aba2347fd0ffbbaf704d4cc067304881348182
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

manager: Add build testcase

Add a basic compile time test that ensures manager.hpp can build on
its own.

Change-Id: Id10cdd8135fd4a41ebf2a76bc1e0da2d1916c6fa
Signed-off-by: Brad Bishop <bradleyb@fu

manager: Add build testcase

Add a basic compile time test that ensures manager.hpp can build on
its own.

Change-Id: Id10cdd8135fd4a41ebf2a76bc1e0da2d1916c6fa
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

manager: switch to refactored internal APIs

Switch the manager over to the new serialization concept API
implementation and the new interface operations API - introduced
previously.

Change-Id: I756

manager: switch to refactored internal APIs

Switch the manager over to the new serialization concept API
implementation and the new interface operations API - introduced
previously.

Change-Id: I756021e4c42c0f61d269dccfd9ff0c489d91c0c7
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

manager: refactor interface templates

Many of the templates in manager.hpp are _almost_ testable. Enable
testing by porting to a new header - interface_ops.hpp - to be activated
later.

Enhancement

manager: refactor interface templates

Many of the templates in manager.hpp are _almost_ testable. Enable
testing by porting to a new header - interface_ops.hpp - to be activated
later.

Enhancements include:

Dropped 'PropertiesVariant' wrapper template for reduced comprehensional
complexity.

More intuitive HasProperties implementation. HasProperties is a type
traits template that simply checks for the presence of a nested
PropertiesVariant typename. These are provided by sdbusplus generated
server bindings for dbus interfaces that have properties.

Standalone templates for make, assign, serialize and deserialize
interface. There was no good reason to couple these, and the
resulting types and method names are more intuitive.

Templated serialize/deserialize operations so the dependency on
cereal can be abstracted away.

Change-Id: Ia449628eeaa9732bbbc51b0609bd449f43ebcb7c
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

serialize: Add build testcase

Add a basic compile time test that ensures serialize.hpp can build on
its own.

Change-Id: Ib83e9fa73fd44c00884299b48b896f1fe53752c7
Signed-off-by: Brad Bishop <bradley

serialize: Add build testcase

Add a basic compile time test that ensures serialize.hpp can build on
its own.

Change-Id: Ib83e9fa73fd44c00884299b48b896f1fe53752c7
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

serialize: add concept API

Wrap serialization methods in a struct to match a yet to be consumed
serialization template concept API.

Change-Id: I4be1749f693ea5fe116bbac581428972e7670791
Signed-off-b

serialize: add concept API

Wrap serialization methods in a struct to match a yet to be consumed
serialization template concept API.

Change-Id: I4be1749f693ea5fe116bbac581428972e7670791
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

build: Don't build tests unless asked

Introduce --enable-tests so that packagers don't need gtest installed
to produce a package.

Change-Id: Ic17f46f2535d0426d05f05d4ff32711d0a2847d1

utils: Add unit tests

Ensure utils.hpp can build on its own, and add some unit tests.

Change-Id: Ia147b699105ff4497d9226630ef19e57d91de3c3
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

utils: Add missing headers

Add a few missing headers from utils.hpp.

Change-Id: I6efbceac3f583349e1db5b9135bd05da0270878e
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

types: Add build testcase

Add a basic compile time test that ensures types.hpp can build on its
own.

Change-Id: Idbf8a68feb1bf30b4fb573d254edf3a2f0a6f0cc
Signed-off-by: Brad Bishop <bradleyb@fuzzie

types: Add build testcase

Add a basic compile time test that ensures types.hpp can build on its
own.

Change-Id: Idbf8a68feb1bf30b4fb573d254edf3a2f0a6f0cc
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

types: minor build improvements

We don't need all of message.hpp to be included from types.hpp since
all we need is the variant definition. Instead, just get
sdbusplus/message/types.hpp, which has

types: minor build improvements

We don't need all of message.hpp to be included from types.hpp since
all we need is the variant definition. Instead, just get
sdbusplus/message/types.hpp, which has the variant definition.

message.hpp picks up <memory> so add that where it is now missing
(events.hpp).

Add a missing cstdint include.

Change-Id: Ic033ceafcd982dba3e39592a4d8f64e5b4e65f2e
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

test: Add test-driver, minor refactoring

Add the test driver so we can run unit tests with the check target.

Drop GTEST_CPPFLAGS - gtest has proper pkg-config support now.

Default not-found messag

test: Add test-driver, minor refactoring

Add the test driver so we can run unit tests with the check target.

Drop GTEST_CPPFLAGS - gtest has proper pkg-config support now.

Default not-found messages are sufficient - use those.

Change-Id: I887f6bc46a029b6b23254da7508745952f865869
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

Replace std::experimental::any with std::any

This is possible and preferrable now with the switch to c++17.

Change-Id: I0c314ae9a85c8c34274cc971e63b17988db31a2b
Signed-off-by: Brad Bishop <bradleyb

Replace std::experimental::any with std::any

This is possible and preferrable now with the switch to c++17.

Change-Id: I0c314ae9a85c8c34274cc971e63b17988db31a2b
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

Fix std::variant usage

This change makes it possible to use std::variant as a drop in
replacement for mapbox::variant.

Change-Id: Ia729c3a7832eec4dd6cddadba9bc160b6ba9ad90
Signed-off-by: William A.

Fix std::variant usage

This change makes it possible to use std::variant as a drop in
replacement for mapbox::variant.

Change-Id: Ia729c3a7832eec4dd6cddadba9bc160b6ba9ad90
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

Generate functor to read a property

Given the dbus member class for an interface and property hosted by
inventory manager, generate the getProperty functor for retrieving that
property from inventor

Generate functor to read a property

Given the dbus member class for an interface and property hosted by
inventory manager, generate the getProperty functor for retrieving that
property from inventory. This ability is only supported when using the
`PropertyIs` functor to compare a property within inventory to a given
value before triggering an action.

Example yaml:
filters:
- name: propertyIs
service: xyz.openbmc_project.Inventory.Manager
path: /system/chassis
interface: xyz.openbmc_project.Inventory.Decorator.CoolingType
property: WaterCooled
value:
value: true
type: boolean
dbusMember: "sdbusplus::xyz::openbmc_project::Inventory::\
Decorator::server::CoolingType"

Generates:
make_filter(functor::propertyIs(
"/system/chassis",
"xyz.openbmc_project.Inventory.Decorator.CoolingType",
"WaterCooled",
true,
"xyz.openbmc_project.Inventory.Manager",
make_get_property<>
(
functor::getProperty<sdbusplus::xyz::openbmc_project::
Inventory::Decorator::server::CoolingType>
(
"/system/chassis",
"xyz.openbmc_project.Inventory.Decorator.CoolingType",
&sdbusplus::xyz::openbmc_project::Inventory::
Decorator::server::CoolingType::getPropertyByName,
"WaterCooled"
)
)
))

Tested:
Code generated as expected with service name given
Code generated as expected without service name given

Resolves: openbmc/phosphor-inventory-manager#1

Change-Id: I5600854a1b0b9ce3e1511d3bcd9a452d6b1107ba
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

Get an inventory property's value

Adds support for inventory manager to retrieve a property's value that
it hosts as input to condition tests. Utilizing a provided sdbusplus
server binding member fu

Get an inventory property's value

Adds support for inventory manager to retrieve a property's value that
it hosts as input to condition tests. Utilizing a provided sdbusplus
server binding member function to get a property from the inventory
hosted interface, a property can be read from that interface within
inventory manager. After the property is read, the condition test is
performed and the resulting action(s) occur.

The only currently supported condition test for using a property from
within inventory manager is the `propertyIs` condition.

This is an example of the expected generated source to get a property
from within inventory manager:

make_filter(functor::propertyIs(
"/system/chassis",
"xyz.openbmc_project.Inventory.Decorator.CoolingType",
"WaterCooled",
true,
"xyz.openbmc_project.Inventory.Manager",
make_get_property<sdbusplus::xyz::openbmc_project::Inventory::
Decorator::server::CoolingType::PropertiesVariant>
(
functor::getProperty<sdbusplus::xyz::openbmc_project::
Inventory::Decorator::server::CoolingType>
(
"/system/chassis",
"xyz.openbmc_project.Inventory.Decorator.CoolingType",
&sdbusplus::xyz::openbmc_project::Inventory::
Decorator::server::CoolingType::getPropertyByName,
"WaterCooled"
)
)
))

Tested:
Manually edited generated code to use property within inventory
and actions occurred when condition passed
Manually edited generated code to use property within inventory
and actions did not run when condition failed
Actions not run when get property function omitted

Change-Id: I094bbacbcdeb239d33cac343b2daeb5f86e0a58a
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

Update .gitignore

Change-Id: I116aaf2ccc4ce6a68cff19ee5ed785bcfacccad5
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

phosphor-inventory-manager: use c++17

Update configure.ac to choose the c++17 standard

Change-Id: Ib2437abc26c9e1a0b177e3f95c73dd61ceb468b8
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.c

phosphor-inventory-manager: use c++17

Update configure.ac to choose the c++17 standard

Change-Id: Ib2437abc26c9e1a0b177e3f95c73dd61ceb468b8
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

show more ...