clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda forma

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda formatting also changed, so we have made changes to the
organization default style format to better handle lambda formatting.

See I5e08687e696dd240402a2780158664b7113def0e for updated style.
See Iea0776aaa7edd483fa395e23de25ebf5a6288f71 for clang-18 enablement.

Change-Id: I8078c8196a2d5706179dc10bf20c0af1a69ec962
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

meson: Provide missing dependencies for the local build

Currently local meson build fails because tests don't require the
necessary dependencies.
Provide missing dependencies to fix the issue.

Test

meson: Provide missing dependencies for the local build

Currently local meson build fails because tests don't require the
necessary dependencies.
Provide missing dependencies to fix the issue.

Tested:
"meson setup build && cd build && meson compile" finishes successfully.

Change-Id: Icaab5b5a5d2ec23e9adc76ff2df5ec07d1a87cc7
Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>

show more ...

meson: Provide sdbusplus env for gen* custom targets

Currently local meson build fails with the following errors:
"""
[345/756] Generating generated.cpp with a custom command
FAILED: generated.cpp
.

meson: Provide sdbusplus env for gen* custom targets

Currently local meson build fails with the following errors:
"""
[345/756] Generating generated.cpp with a custom command
FAILED: generated.cpp
...
import sdbusplus.property
ModuleNotFoundError: No module named 'sdbusplus'

[346/756] Generating gen_serialization.hpp with a custom command
FAILED: gen_serialization.hpp
...
import sdbusplus.property
ModuleNotFoundError: No module named 'sdbusplus'
"""
This is happening because 'pimgen.py' script used in gen* custom
targets refers to python modules from the external 'sdbusplus' project.
Therefore in case of a local build it is necessary to provide search
path to the relevant sdbusplus subproject folder. Fix this with the
help of 'PYTHONPATH' environment variable.

Tested:
Local meson build no longer fails with the 'ModuleNotFoundError's.

Change-Id: Ic65c30cacc516a083dfa44a4b5736e2efbacf617
Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>

show more ...

meson: Fix local cereal build

Currently local build is failing with a message:
"""
cereal| Exception: Failed to configure the CMake subproject: Could NOT
find Boost (missing: Boost_INCLUDE_DIR seria

meson: Fix local cereal build

Currently local build is failing with a message:
"""
cereal| Exception: Failed to configure the CMake subproject: Could NOT
find Boost (missing: Boost_INCLUDE_DIR serialization)
Subproject subprojects/cereal is buildable: NO (disabling)
"""
Since cereal requires boost only for the sandbox build and this
functionality is not needed, add option to skip building performance
sandbox comparison to solve the issue.

Tested:
"meson setup build" no longer fails with the cereal error.

Change-Id: I021ee1e3a634c0abc43aa61496fb1831dacab572
Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>

show more ...

meson: adjust nlohmann-json dependency

Simplify nlohmann-json dependency logic and use wrap file name aligned
with other repositories.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id:

meson: adjust nlohmann-json dependency

Simplify nlohmann-json dependency logic and use wrap file name aligned
with other repositories.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ie6082726a567e0876e5f8b9d941ed1101e056d2f

show more ...

build: use allowed over enabled

Meson feature options are typically in a tri-state of enabled, disabled,
or auto. The enabled and disabled functions on an option (from
`get_option`) no longer retur

build: use allowed over enabled

Meson feature options are typically in a tri-state of enabled, disabled,
or auto. The enabled and disabled functions on an option (from
`get_option`) no longer return true for auto features. Instead, the
expectation is to use `allowed()` which is true for both enabled and auto.

Switch all uses of `enabled` to `allowed`.

Change-Id: Iaf683f8589b9348184ad75bdf2d62a9ef8a776c2
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

serialization: Add support for std::set

xyz.openbmc_project.Common.Threshold interface has added a property of
type `set` (which sdbusplus maps to a std::set). Add Cereal support for
serializing std

serialization: Add support for std::set

xyz.openbmc_project.Common.Threshold interface has added a property of
type `set` (which sdbusplus maps to a std::set). Add Cereal support for
serializing std::set.

Tested:
Build that was earlier failing for the Threshold type now passes.

Change-Id: Ic22bfe94f902dc7fc4ffd0ef0fcdfa6565620f60
Signed-off-by: Santosh Puranik <santosh.puranik.ibm@gmail.com>

show more ...

clang-format: copy latest and re-format

clang-format-17 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-17 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: I8b9d9b18d7df09bc6632fdd16c834d11688e7c6c
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

README: update instructions for meson

The repository uses meson now but the README was still referencing
autotools scripts. Replace them with the standard meson incantation.

Fixes openbmc/phosphor

README: update instructions for meson

The repository uses meson now but the README was still referencing
autotools scripts. Replace them with the standard meson incantation.

Fixes openbmc/phosphor-inventory-manager#9.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Idaed67bd60a6d4042d48f1ff3e391264598e2abf

show more ...

meson_options.txt: Support for reading options from meson.options

Support has been added for reading options from meson.options instead
of meson_options.txt[1]. These are equivalent, but not using t

meson_options.txt: Support for reading options from meson.options

Support has been added for reading options from meson.options instead
of meson_options.txt[1]. These are equivalent, but not using the .txt
extension for a build file has a few advantages, chief among them
many tools and text editors expect a file with the .txt extension to
be plain text files, not build scripts.

[1] https://mesonbuild.com/Release-notes-for-1-1-0.html#support-for-reading-options-from-mesonoptions

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I3c37ded542fcf0a135fe7487915a69a5fdb38768

show more ...

build: upgrade to C++23

Meson 1.1.1 and GCC-13 both support C++23 and a sufficient portion of
the standard has been implemented. Upgrade the build to leverage it.

Change-Id: I5c7aa4fb4a136332a812d

build: upgrade to C++23

Meson 1.1.1 and GCC-13 both support C++23 and a sufficient portion of
the standard has been implemented. Upgrade the build to leverage it.

Change-Id: I5c7aa4fb4a136332a812d1c6d3f0e00dc3812a79
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: I657f0cb5283a0b4177332d94a88af660f3de8f11
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

meson: remove deprecated get_pkgconfig_variable

Since meson 0.56, the `get_pkgconfig_variable` has been deprecated. In
meson 0.58 the `get_variable` was enhanced to no longer require the
`pkgconfig

meson: remove deprecated get_pkgconfig_variable

Since meson 0.56, the `get_pkgconfig_variable` has been deprecated. In
meson 0.58 the `get_variable` was enhanced to no longer require the
`pkgconfig` keyword argument. Ensure meson 0.58 is required and update
the usage of all `get_pkgconfig_variable` and `get_variable` to be the
modern variant.

Change-Id: I98e42b3ac19670c2ff882b03702bffff74957f04
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

Pick up Control Host interface

This commit enables pimgen.py to pick up
com/ibm interface(s).

Signed-off-by: Sunny Srivastava <sunnsr25@in.ibm.com>
Change-Id: I578de811c512e6df5082893f83a8986dabcbb

Pick up Control Host interface

This commit enables pimgen.py to pick up
com/ibm interface(s).

Signed-off-by: Sunny Srivastava <sunnsr25@in.ibm.com>
Change-Id: I578de811c512e6df5082893f83a8986dabcbb9d0

show more ...

Change in IBM Ownership

Taking ownership in lieu of Santosh for IBM

Change-Id: I9543d911138b115e028a650805c320c6997287e4
Signed-off-by: jinuthomas <jinu.joy.thomas@in.ibm.com>

Add additional variant types to InterfaceVariantType

Add uint16 and vector<string> to InterfaceVariantType
to support for the Notify D-Bus method.

Change-Id: I39e717270b5f01af801ecc4ac6f0bece48b25c

Add additional variant types to InterfaceVariantType

Add uint16 and vector<string> to InterfaceVariantType
to support for the Notify D-Bus method.

Change-Id: I39e717270b5f01af801ecc4ac6f0bece48b25cca
Signed-off-by: Pavithra Barithaya <pavithra.b@ibm.com>

show more ...

meson: Fix BUSNAME argument to pimgen.py

Meson does not support querying environment variables. The old automake
build systems used the $BUSNAME environment variable to compile PIM with
the busname

meson: Fix BUSNAME argument to pimgen.py

Meson does not support querying environment variables. The old automake
build systems used the $BUSNAME environment variable to compile PIM with
the busname it needs to request.

Since moving to meson, this does not work as intended and was causing
pimgen to generate bad C++ code.

BUSNAME is now setup as a configuration data. This commit queries the
configuration data for the BUSNAME and passes it on as an argument to
pimgen.py.

Tested:

Tested by bitbaking a witherspoon image. PIM now compiles cleanly.

Change-Id: I567841231c8f295442e6d372d2a758737fcf70c8
Signed-off-by: Santosh Puranik <santosh.puranik@gmail.com>

show more ...

markdownlint: fix all warnings

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ie0ff09bdecb6b949dbd782e8659168698e58d6ff

prettier: re-format

Prettier is enabled in openbmc-build-scripts on Markdown, JSON, and YAML
files to have consistent formatting for these file types. Re-run the
formatter on the whole repository.

prettier: re-format

Prettier is enabled in openbmc-build-scripts on Markdown, JSON, and YAML
files to have consistent formatting for these file types. Re-run the
formatter on the whole repository.

Change-Id: If06b0aed2cee53bcc5789e56eb6c30ca245394e7
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

utils: Fix bad conversion for enumerations

When an interface contains both a string and an enumeration (or multiple
of each), the variant visitor matches the wrong make specialization.

This is beca

utils: Fix bad conversion for enumerations

When an interface contains both a string and an enumeration (or multiple
of each), the variant visitor matches the wrong make specialization.

This is because a string is convertible to variant<string, enum, ...>.
Fix this by moving out all conversions from a string to the template
specialization that first checks if the string can be converted to
an enumeration.

This still leaves a hole where trying to set a fully-qualified
enumeration name to a string property will fail, but I am not sure what
to do about that within the current PIM framework.

Tested: Tested Notify with enumerations on interfaces that contain both
a string and an enumeration.

Signed-off-by: Santosh Puranik <santosh.puranik@in.ibm.com>
Change-Id: I58b93a225ccf0b6b70317b2a2050a4dfa2b1b6f7

show more ...

python: fix flake8 warnings and format with black

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I0e6426b593fcf1eb44c3902af53bdd85514e2e8e

MAINTAINERS: remove file

The MAINTAINERS file is deprecated in favor of OWNERS.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ib6ac3245a1ffb917b2776c28fd4c0493ce0d96dc

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are for:
* bus_t
* exception_t
* manager_t
* match_t
* message_t
* object_t
* slot_t

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ic63a70d32f4683e0bd92b625cc36c836aa8395a8

show more ...

OWNERS: switch 'matches' to 'matchers'

The original OWNERS template had a mistake which used 'matches' instead
of the field supported by the Gerrit plugin 'matchers'. Update the
OWNERS file to have

OWNERS: switch 'matches' to 'matchers'

The original OWNERS template had a mistake which used 'matches' instead
of the field supported by the Gerrit plugin 'matchers'. Update the
OWNERS file to have the correct field.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I0e70389a19f0aa9a864d60381e999c84505eca62

show more ...

Handle D-Bus exceptions

The is_method_error method is deprecated, remove and add try-catch
to handler D-Bus exceptions around mapper call.

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id:

Handle D-Bus exceptions

The is_method_error method is deprecated, remove and add try-catch
to handler D-Bus exceptions around mapper call.

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I1a40b6550b51059e13a71676f5daeb3f637f9182

show more ...