clang-tidy: Initial commit

Added initial .clang-tidy configuration file with recommended C++ checks
aligned with the OpenBMC-approved checklist. This setup enforces modern
C++ best practices and hel

clang-tidy: Initial commit

Added initial .clang-tidy configuration file with recommended C++ checks
aligned with the OpenBMC-approved checklist. This setup enforces modern
C++ best practices and helps catch common issues early in development.

Change-Id: I6eb1452acdf58d31fa1f4af2fa032252523e4cef
Signed-off-by: Jayanth Othayoth <ojayanth@gmail.com>

show more ...

clang-tidy: Relax -Werror for unused parameters

Auto-generated headers often include parameters required by templates
but unused in practice, triggering -Wunused-parameter and failing builds
under w

clang-tidy: Relax -Werror for unused parameters

Auto-generated headers often include parameters required by templates
but unused in practice, triggering -Wunused-parameter and failing builds
under werror=true. Fixing these in generators is complex and low-value
compared to enabling clang-tidy now.

Use [[maybe_unused]] on unused parameters as a pragmatic workaround.
This keeps warnings visible, avoids manual edits to generated files,
and allows us to integrate clang-tidy.

Example of previous errors:
'''
./gen_serialization.hpp:5947:20: error: unused parameter 'a' [-Werror,-Wunused-parameter]
5947 | void save(Archive& a,
| ^
./gen_serialization.hpp:5948:96: error: unused parameter 'object' [-Werror,-Wunused-parameter]
5948 | const sdbusplus::xyz::openbmc_project::Inventory::Decorator::server::VoltageControl& object,
| ^
./gen_serialization.hpp:5955:90: error: unused parameter 'object' [-Werror,-Wunused-parameter]
5955 | sdbusplus::xyz::openbmc_project::Inventory::Decorator::server::VoltageControl& object,
| ^
./gen_serialization.hpp:6597:20: error: unused parameter 'a' [-Werror,-Wunused-parameter]
6597 | void save(Archive& a,
| ^
./gen_serialization.hpp:6598:80: error: unused parameter 'object' [-Werror,-Wunused-parameter]
6598 | const sdbusplus::xyz::openbmc_project::Inventory::Item::server::Bmc& object,
| ^
'''

Change-Id: I4441f0f3f3538b55c446d7c8441e6bdef4531c09
Signed-off-by: Jayanth Othayoth <ojayanth@gmail.com>

show more ...

clang-tidy: rename Mako templates to avoid format

Meson auto-generates a 'ninja clang-format' target when .clang-format
exists, which reformats any file ending in .cpp or .hpp. Our Mako
templates we

clang-tidy: rename Mako templates to avoid format

Meson auto-generates a 'ninja clang-format' target when .clang-format
exists, which reformats any file ending in .cpp or .hpp. Our Mako
templates were named foo.mako.cpp, causing them to be picked up by
this target during clang-tidy enablement. Rename templates to
foo.cpp.mako so Meson ignores them. No functional changes.

Change-Id: I7551acdaf26dace4720277142d8576566779b841
Signed-off-by: Jayanth Othayoth <ojayanth@gmail.com>

show more ...

clang-tidy: delete default constructor

Default constructor was invalid for class semantics and caused
clang-tidy/Clang diagnostics. Mark the default constructor as
`=delete` to prevent accidental de

clang-tidy: delete default constructor

Default constructor was invalid for class semantics and caused
clang-tidy/Clang diagnostics. Mark the default constructor as
`=delete` to prevent accidental default construction and keep
-Werror builds green. No functional changes.

Fixed below errors
'''
../manager.hpp:53:5: error: explicitly defaulted move constructor is implicitly deleted [-Werror,-Wdefaulted-function-deleted]
53 | Manager(Manager&&) = default;
../manager.hpp:54:14: error: explicitly defaulted move assignment operator is implicitly deleted [-Werror,-Wdefaulted-function-deleted]
54 | Manager& operator=(Manager&&) = default;

Change-Id: Iaf1c39e91448b43a3f6c0149a71b58889d71195c
Signed-off-by: Jayanth Othayoth <ojayanth@gmail.com>

show more ...

use sdbusplus unpack syntax

Rather than defining a variable and then reading it from a message,
sdbusplus also supports directly unpack-ing from the message. Use
this syntax instead as it is more e

use sdbusplus unpack syntax

Rather than defining a variable and then reading it from a message,
sdbusplus also supports directly unpack-ing from the message. Use
this syntax instead as it is more efficient and succinct.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ic6aac8ff7c37f79f082363cf8ae59aafc5bc4831

show more ...

Update owner list

Currently openpower-vpd-parser extensievely makes use of PIM to host
the data that it collects.
Also, with most of community moving to Entity Manager, leaves
openpower-vpd-parser a

Update owner list

Currently openpower-vpd-parser extensievely makes use of PIM to host
the data that it collects.
Also, with most of community moving to Entity Manager, leaves
openpower-vpd-parser among the few making use of it.

Keeping all that together, I would like to propose an update in the
OWNERS document.

Change-Id: I7e140a3734d3f2e9a6337dd23362efe2ed13d507
Signed-off-by: Sunny Srivastava <sunnsr25@in.ibm.com>

show more ...

maintainers: Remove Devender as maintainer

Removing myself (Devender) as a maintainer of this repository, as I am
no longer contributing to or maintaining this project.

Change-Id: I9c74ae23ccce5ab7

maintainers: Remove Devender as maintainer

Removing myself (Devender) as a maintainer of this repository, as I am
no longer contributing to or maintaining this project.

Change-Id: I9c74ae23ccce5ab784a4ed016ada127bbfc6fe9f
Signed-off-by: Marri Devender Rao <devenrao@in.ibm.com>

show more ...

pimgen: reduce the dbus interfaces

The phosphor-inventory-manager is about 4MB now, because it pulls in
every dbus interface that could possibly exist. Looking at real usage
of PIM, it seems like w

pimgen: reduce the dbus interfaces

The phosphor-inventory-manager is about 4MB now, because it pulls in
every dbus interface that could possibly exist. Looking at real usage
of PIM, it seems like we pretty much only use Inventory and State.
Explicitly add those to reduce the executable size (now around 2MB on
x86).

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I5293c129c843d7caad661fca64ab5919218ef232

show more ...

meson: regenerate files when pimgen.py changes

Add appropriate meson custom_target directives so that pimgen.py is
considered a dependency for the custom_target outputs it creates. This
allows easi

meson: regenerate files when pimgen.py changes

Add appropriate meson custom_target directives so that pimgen.py is
considered a dependency for the custom_target outputs it creates. This
allows easier testing of pimgen.py changes without needing a `clean`.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I1563f01f707a3740e309b169086bac121fecc804

show more ...

Update OWNERS file

Requesting review notification on the repository as PIM is being
used actievely with openpower vpd parser to host the inventory.

Change-Id: I3f475e316755d86a0e175bb55b0e624d87004

Update OWNERS file

Requesting review notification on the repository as PIM is being
used actievely with openpower vpd parser to host the inventory.

Change-Id: I3f475e316755d86a0e175bb55b0e624d870043f6
Signed-off-by: Sunny Srivastava <sunnsr25@in.ibm.com>

show more ...

clang-format: update latest spec and reformat

Copy the latest format file from the docs repository and apply.

Change-Id: I70b8c852ae068e5d000fbf1fdfcd8a728ade9a16
Signed-off-by: Patrick Williams <p

clang-format: update latest spec and reformat

Copy the latest format file from the docs repository and apply.

Change-Id: I70b8c852ae068e5d000fbf1fdfcd8a728ade9a16
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

meson: reformat with meson formatter

Apply the `meson format` results.

Change-Id: I2d6e8260c540442f622b9f7174c1edd9b72a3161
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

build: use allowed over enabled or not-disabled

Meson feature options are typically in a tri-state of enabled, disabled,
or auto. The enabled and disabled functions on an option (from
`get_option`)

build: use allowed over enabled or not-disabled

Meson feature options are typically in a tri-state of enabled, disabled,
or auto. The enabled and disabled functions on an option (from
`get_option`) no longer return true for auto features. Instead, the
expectation is to use `allowed()` which is true for both enabled and
auto.

Switch all uses of `enabled` to `allowed`.
Switch all uses of `not disabled` to `allowed`.

Change-Id: I5d1aa5958ee3e905ffebc00197162e526f483c01
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

clang-format: re-format for clang-19

clang-format-19 isn't compatible with the clang-format-18 output, so we
need to reformat the code with the latest version. A few parameters
in clang-tidy have b

clang-format: re-format for clang-19

clang-format-19 isn't compatible with the clang-format-18 output, so we
need to reformat the code with the latest version. A few parameters
in clang-tidy have been deprecated, so adjust the style file
accordingly.

See Ie2f6eb3b043f2d655c9df806815afd7971fd0947 for updated style.
See I88192b41ab7a95599a90915013579608af7bc56f for clang-19 enablement.

Change-Id: Ibd2cbdb1ff546b6648f5dfc25867410ebee97882
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

pimgen to pick VPD Collection interface

This commit enables pimgen.py to pick
com.ibm.VPD.Collection interface.

Change-Id: I88134953588bffdca6edcbc7bdfcca6d60990f07
Signed-off-by: Priyanga Ramasamy

pimgen to pick VPD Collection interface

This commit enables pimgen.py to pick
com.ibm.VPD.Collection interface.

Change-Id: I88134953588bffdca6edcbc7bdfcca6d60990f07
Signed-off-by: Priyanga Ramasamy <priyanga24@in.ibm.com>

show more ...

Remove vim mode lines

Editor settings aren't needed in source files.

Change-Id: Ieb0229b6fe0bb14f128b6946a29a3283a53f0b90
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda forma

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda formatting also changed, so we have made changes to the
organization default style format to better handle lambda formatting.

See I5e08687e696dd240402a2780158664b7113def0e for updated style.
See Iea0776aaa7edd483fa395e23de25ebf5a6288f71 for clang-18 enablement.

Change-Id: I8078c8196a2d5706179dc10bf20c0af1a69ec962
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

meson: Provide missing dependencies for the local build

Currently local meson build fails because tests don't require the
necessary dependencies.
Provide missing dependencies to fix the issue.

Test

meson: Provide missing dependencies for the local build

Currently local meson build fails because tests don't require the
necessary dependencies.
Provide missing dependencies to fix the issue.

Tested:
"meson setup build && cd build && meson compile" finishes successfully.

Change-Id: Icaab5b5a5d2ec23e9adc76ff2df5ec07d1a87cc7
Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>

show more ...

meson: Provide sdbusplus env for gen* custom targets

Currently local meson build fails with the following errors:
"""
[345/756] Generating generated.cpp with a custom command
FAILED: generated.cpp
.

meson: Provide sdbusplus env for gen* custom targets

Currently local meson build fails with the following errors:
"""
[345/756] Generating generated.cpp with a custom command
FAILED: generated.cpp
...
import sdbusplus.property
ModuleNotFoundError: No module named 'sdbusplus'

[346/756] Generating gen_serialization.hpp with a custom command
FAILED: gen_serialization.hpp
...
import sdbusplus.property
ModuleNotFoundError: No module named 'sdbusplus'
"""
This is happening because 'pimgen.py' script used in gen* custom
targets refers to python modules from the external 'sdbusplus' project.
Therefore in case of a local build it is necessary to provide search
path to the relevant sdbusplus subproject folder. Fix this with the
help of 'PYTHONPATH' environment variable.

Tested:
Local meson build no longer fails with the 'ModuleNotFoundError's.

Change-Id: Ic65c30cacc516a083dfa44a4b5736e2efbacf617
Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>

show more ...

meson: Fix local cereal build

Currently local build is failing with a message:
"""
cereal| Exception: Failed to configure the CMake subproject: Could NOT
find Boost (missing: Boost_INCLUDE_DIR seria

meson: Fix local cereal build

Currently local build is failing with a message:
"""
cereal| Exception: Failed to configure the CMake subproject: Could NOT
find Boost (missing: Boost_INCLUDE_DIR serialization)
Subproject subprojects/cereal is buildable: NO (disabling)
"""
Since cereal requires boost only for the sandbox build and this
functionality is not needed, add option to skip building performance
sandbox comparison to solve the issue.

Tested:
"meson setup build" no longer fails with the cereal error.

Change-Id: I021ee1e3a634c0abc43aa61496fb1831dacab572
Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>

show more ...

meson: adjust nlohmann-json dependency

Simplify nlohmann-json dependency logic and use wrap file name aligned
with other repositories.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id:

meson: adjust nlohmann-json dependency

Simplify nlohmann-json dependency logic and use wrap file name aligned
with other repositories.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ie6082726a567e0876e5f8b9d941ed1101e056d2f

show more ...

build: use allowed over enabled

Meson feature options are typically in a tri-state of enabled, disabled,
or auto. The enabled and disabled functions on an option (from
`get_option`) no longer retur

build: use allowed over enabled

Meson feature options are typically in a tri-state of enabled, disabled,
or auto. The enabled and disabled functions on an option (from
`get_option`) no longer return true for auto features. Instead, the
expectation is to use `allowed()` which is true for both enabled and auto.

Switch all uses of `enabled` to `allowed`.

Change-Id: Iaf683f8589b9348184ad75bdf2d62a9ef8a776c2
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

serialization: Add support for std::set

xyz.openbmc_project.Common.Threshold interface has added a property of
type `set` (which sdbusplus maps to a std::set). Add Cereal support for
serializing std

serialization: Add support for std::set

xyz.openbmc_project.Common.Threshold interface has added a property of
type `set` (which sdbusplus maps to a std::set). Add Cereal support for
serializing std::set.

Tested:
Build that was earlier failing for the Threshold type now passes.

Change-Id: Ic22bfe94f902dc7fc4ffd0ef0fcdfa6565620f60
Signed-off-by: Santosh Puranik <santosh.puranik.ibm@gmail.com>

show more ...

clang-format: copy latest and re-format

clang-format-17 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-17 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: I8b9d9b18d7df09bc6632fdd16c834d11688e7c6c
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

README: update instructions for meson

The repository uses meson now but the README was still referencing
autotools scripts. Replace them with the standard meson incantation.

Fixes openbmc/phosphor

README: update instructions for meson

The repository uses meson now but the README was still referencing
autotools scripts. Replace them with the standard meson incantation.

Fixes openbmc/phosphor-inventory-manager#9.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Idaed67bd60a6d4042d48f1ff3e391264598e2abf

show more ...