dbus-sdr: switch to lg2

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: I076cb6429a56cf9b5123420f36daf6328c2d64b9

app: switch to lg2

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: Id55c91667a7bd0184ec4d55d6e1c15844d9ffb50

softoff: switch to lg2

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: I9b4071a8647182278b25b044355c707a908b4338

Permit dynamic insertion of sensor type codes

The existing sensorTypes flat_map is an immutable data structure. This
makes adding OEM style sensor types difficult. New entries, that may
not be gener

Permit dynamic insertion of sensor type codes

The existing sensorTypes flat_map is an immutable data structure. This
makes adding OEM style sensor types difficult. New entries, that may
not be general purpose either need to be pushed upstream for all, or
they have to be updated by carrying a patch. Keeping a patch up to
date is an undesirable method.

Instead of using either of the prior methods, make the flat_map a
writable object. Adding new entries can be done at run time using the
flat_map emplace() function. Adding new sensor types is recommended to
be done by overriding the weak linked getOtherSensorsCount(), placed
in the sensorcommands_oem.cpp file. Using a GCC 'constructor' style
function does not work due to uncertainty of initialization order.

See commit 777cfaf2b3:bb6667fbbea7612255137970c3dbdb
Enable OEM creation of non-Type1 SDRs

Tested:
Added an emplace() call into the strong linked getOtherSensorCommands
Used 'ipmitool sdr dump sdrs.bin'
Inspected the resulting SDR data and confirmed the sensors of interest
had an OEM type code as dictated by the sensorTypes map

Change-Id: Ifcf6297a8b161b720651bc6411409014c37ce88c
Signed-off-by: Johnathan Mantey <johnathanx.mantey@intel.com>

show more ...

do not shift kcs-passed software ID

When the software ID is passed in over KCS, the LSBit is required to be
set and the software ID is already in the correct format to be used as
the generatorID for

do not shift kcs-passed software ID

When the software ID is passed in over KCS, the LSBit is required to be
set and the software ID is already in the correct format to be used as
the generatorID for SEL data.

Credit: Vernon Mauery <vernon.mauery@linux.intel.com>
intel-ipmi-oem: do not shift kcs-passed software ID
SHA: 5d24dda2d60dfc91ee44b99e8aeb8dbb003e90a7

Change-Id: Id4bd913683897d61c24be16b25cafeca39ce6e38
Signed-off-by: Johnathan Mantey <johnathanx.mantey@intel.com>

show more ...

Handle NaN in threshold interface

dbus-sensor threshold has been changed to always create high and low
interfaces. Threshold value is set to NaN when there is no actual limit.

When creating thresho

Handle NaN in threshold interface

dbus-sensor threshold has been changed to always create high and low
interfaces. Threshold value is set to NaN when there is no actual limit.

When creating threshold attributes in SDR, verify that sensor threshold
value is not NaN.

When getting min and max from threshold interfaces, use std::fmin and
std::fmax instead of std::min and std::max. If one of the two arguments
is NaN, the value of the other argument is returned. Since sensors are
always created with default min/max values, the other argument is not
going to be NaN.

Tested:
ipmitool sensor list returns without error.
Sensor limit is na when threshold interface value is NaN.

Credit: Signed-off-by: Zhikui Ren <zhikui.ren@intel.com>
Migrated from intel-ipmi-oem:
SHA: 41a6e9f336aa1161cd0680bfab5a5fe1effbe976

Change-Id: I51451aab12d9bf5cc5f2d61ff2e603839910afe0
Signed-off-by: Johnathan Mantey <johnathanx.mantey@intel.com>

show more ...

OWNERS: update Ratan email

Looking through the gerrit logs is difficult as it will log lots and
lots of these whenever a review in this repo is ongoing:

```
WARN com.googlesource.gerrit.owners.co

OWNERS: update Ratan email

Looking through the gerrit logs is difficult as it will log lots and
lots of these whenever a review in this repo is ongoing:

```
WARN com.googlesource.gerrit.owners.common.AccountsImpl :
User 'ratagupt@linux.vnet.ibm.com' does not resolve to any account
```

Change-Id: Iea7e0756fa56194085c958fa368fa52607002319
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>

show more ...

dbus-sdr: Remove unused IPMINetfnSensorCmds

Since IPMINetfnSensorCmds is never used after the declaration, and
ipmi::sensor_event in ipmid/api-types.hpp is used uniformly, this
commit removes IPMINe

dbus-sdr: Remove unused IPMINetfnSensorCmds

Since IPMINetfnSensorCmds is never used after the declaration, and
ipmi::sensor_event in ipmid/api-types.hpp is used uniformly, this
commit removes IPMINetfnSensorCmds.

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: I59d5c4ef437e47e78371d8606f3399b678e77415

show more ...

Fixed restartCause interface and object path

- Fixed interface and object path according to phosphor-dbus-interface.
- Format file with clang-format-17.

Change-Id: I5d6265024646f2acaa0758a7aefe49ad

Fixed restartCause interface and object path

- Fixed interface and object path according to phosphor-dbus-interface.
- Format file with clang-format-17.

Change-Id: I5d6265024646f2acaa0758a7aefe49adf67f67a8
Signed-off-by: Orit Kashany <okashany@nvidia.com>

show more ...

OWNERS: Add George Liu as a reviewer

I have been actively contributing to openbmc/phosphor-host-ipmid
for quite some time now. Attached is a summary of my contributions
to the repository [1].

[1]:

OWNERS: Add George Liu as a reviewer

I have been actively contributing to openbmc/phosphor-host-ipmid
for quite some time now. Attached is a summary of my contributions
to the repository [1].

[1]: https://github.com/openbmc/phosphor-host-ipmid/commits?author=lxwinspur

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: If65f0245b5473ced311821cde58f1d60474eadea

show more ...

convert ipmid-new.cpp to use lg2

Change-Id: I0ebb51a11032c5925c0f2c2f949dd064bc5a8673
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

convert chassishandler.cpp to use lg2

Change-Id: Ie01500cecc206ba4d197322ce8544a46bdcf52c5
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

Add ability to add 'energy' sensor Type 01 records

Allow the getSensorTypeFromPath to create Type 01 records for D-Bus
entries with 'energy' in their path name.

Energy sensors are 'Other Unit-based

Add ability to add 'energy' sensor Type 01 records

Allow the getSensorTypeFromPath to create Type 01 records for D-Bus
entries with 'energy' in their path name.

Energy sensors are 'Other Unit-based sensors' and are considered to be
'threshold' sensors. The unit of measure is 'joules'.

Tested:
Confirmed sensors with the 'energy' string preceding the sensor name
generated a Type 01 record with the Sensor Type == 0xb, and the Event
Reading type set to 0x01. The record also set the Sensor Units 2 entry
to 0x07 to indicate the unit of measure is in joules.

Change-Id: I6ca9027e1ff2a8ad58640f851a9bd9f102ba55e9
Signed-off-by: Johnathan Mantey <johnathanx.mantey@intel.com>

show more ...

Add initiateErase check for clear SEL command

Add the check of the byte initiateErase (0xAA) for clear SEL command.

Tested:
After modifying, ipmitool can report the error of invalid data request
wh

Add initiateErase check for clear SEL command

Add the check of the byte initiateErase (0xAA) for clear SEL command.

Tested:
After modifying, ipmitool can report the error of invalid data request
when erase operation is not 0x00 or 0xAA.

Change-Id: Ie450755ade00c6f20197d4f28c899aeb8002fb5e
Signed-off-by: Xiaoyu Ma <maxiaoyu@ieisystem.com>

show more ...

convert channel_mgmt.cpp to use lg2

Change-Id: I4bd78d3aa3bf3c5717fcf3e2a9186888587456d1
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

Refactor to call the getProperty method

Uniformly use the getProperty method of utils.hpp to obtain values

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: I9eae6bba6806215b51090637a7e

Refactor to call the getProperty method

Uniformly use the getProperty method of utils.hpp to obtain values

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: I9eae6bba6806215b51090637a7e42c8c8d90be87

show more ...

Refactor to call the GetSubTree method

Uniformly use the getSubTree method of utils.hpp to obtain objectTree

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: I20204745a01c50f053db74a57

Refactor to call the GetSubTree method

Uniformly use the getSubTree method of utils.hpp to obtain objectTree

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: I20204745a01c50f053db74a5749a070bc8193d39

show more ...

Fix for invalid VLAN id

Issue: Set LAN configuration, allowing invalid VLAN ID's and giving
exception when user trying to set VLAN.

Fix: Add condition to return proper error for invalid VLAN ID's a

Fix for invalid VLAN id

Issue: Set LAN configuration, allowing invalid VLAN ID's and giving
exception when user trying to set VLAN.

Fix: Add condition to return proper error for invalid VLAN ID's and
add a condition to skip exception temporarily.

Tested:
Verified using ipmitool raw commands.
Command: ipmitool raw 0x0c 0x01 0x1 0x14 0x00 0x80 //Set vlan id=0
Response: Unable to send RAW command (channel=0x0 netfn=0xc lun=0x0
cmd=0x1 rsp=0xcc): Invalid data field in request
//Set Lan, vlan id=4095
Command: ipmitool raw 0x0c 0x01 0x1 0x14 0xff 0x8f
Response: Unable to send RAW command (channel=0x0 netfn=0xc lun=0x0
cmd=0x1 rsp=0xcc): Invalid data field in request

Signed-off-by: poram srinivasa rao <poramx.srinivasa.rao@intel.com>
Signed-off-by: Jayaprakash Mutyala <mutyalax.jayaprakash@intel.com>
Change-Id: I0071cae443029a03d8e6fb64f770fee3db695dfe

show more ...

Correct missed application of getOtherSensorsCount function

There was still a hard coded calculation of the number of SDR's.
Removed the hard coded calculation and replaced it with the weak
linked g

Correct missed application of getOtherSensorsCount function

There was still a hard coded calculation of the number of SDR's.
Removed the hard coded calculation and replaced it with the weak
linked getOtherSensorsCount() function.

Tested:
Not tested.

Change-Id: I8f46ec498b044c095e0da8fd626c1dea945e5705
Signed-off-by: Johnathan Mantey <johnathanx.mantey@intel.com>

show more ...

Enable OEM creation of non-Type1 SDRs

Enabling the dbus-sdrs feature is useful for managing Type 1 SDR's
using D-Bus. What doesn't work quite as well in the model is creating
non-Type 1 records. The

Enable OEM creation of non-Type1 SDRs

Enabling the dbus-sdrs feature is useful for managing Type 1 SDR's
using D-Bus. What doesn't work quite as well in the model is creating
non-Type 1 records. The current method works alright for Type 11 FRU
records. Any other SDR's beyond the FRU are problematic because the
code depends on manually defining custom 'if' clauses to compare the
incoming SDR ID, and determining what kind of SDR to create. It is a
fixed process that is inflexible, and assumes every BMC vendor wants
the same SDR arrangement.

This commit creates a model that allows the each OEM to customize
creating each SDR using their own algorithm. The OEM creates a
sensorcommands_oem.cpp/hpp file containing code for handling the
creation of custom SDRs. The code here is compiled and linked based on
enabling a Meson build switch.

The code follows the model that was already present in
dbus-sdr/sensorcommands.cpp. There are two functions that maintain the
original inflexible code, which is now expected to be primarily used
as a template for the OEM cpp/hpp contents.

Tested:
Created sensorcommands_oem.cpp/hpp files with OEM functionality
Enabled the original code, and compiled
Used ipmitool sdr dump sdrs.bin in the BMC Console
Confirmed the SDRs matched the values prior to this commit.
Enabled the OEM code and compiled
Used ipmitool sdr dump sdrs.bin in the BMC console
Confirmed the contents of the BIN file contained the SDRs generated by
the sensorcommands_oem.cpp source.

Change-Id: I100e747b52677be53b499713d51c6c1126411570
Signed-off-by: Johnathan Mantey <johnathanx.mantey@intel.com>

show more ...

utils: Unused methods are marked as deprecated

The getAllAncestors and deleteAllDbusObjects methods in utils.hpp are
not used and are not used in the reops. This commit marks these
methods as deprec

utils: Unused methods are marked as deprecated

The getAllAncestors and deleteAllDbusObjects methods in utils.hpp are
not used and are not used in the reops. This commit marks these
methods as deprecated marked for removal after 2025-03-30 unless
disputed.

Tested: ipmitool works fine with this patch.

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: Icd53a9effc53c12b5db05b90b75c3addf6c02d5b

show more ...

prevent logspam from getObjectInterfaces

prevent logspam from "Failed to GetObject".

The function does not print anymore and its caller can print an error
if needed.

The error defaults to phosphor

prevent logspam from getObjectInterfaces

prevent logspam from "Failed to GetObject".

The function does not print anymore and its caller can print an error
if needed.

The error defaults to phosphor::logging::level::DEBUG since it's
looping over the associations.

Therefore, failure in one codepath does not constitute an error.

Tested: logspam is gone.

Change-Id: Ie800181ff80ed56846815ea377f347a784d49521
Signed-off-by: Alexander Hansen <alexander.hansen@9elements.com>

show more ...

meson: Use boost as a dependency

Currently boost library is found via the 'cpp.find_library' call. With
this method local build of the project requires host to have the boost
libraries installed.
Si

meson: Use boost as a dependency

Currently boost library is found via the 'cpp.find_library' call. With
this method local build of the project requires host to have the boost
libraries installed.
Since the meson have a subproject system to download missing
dependencies, rewrite boost requirement to a 'dependency' object. This
way it would be possible to build the project locally on the system
without the boost library installed.

Tested:
Both local meson build and Yocto build are performed successfully.

Change-Id: I082aeb1d6c09627ea53f58cb6cd375f080401d57
Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>

show more ...

meson: Add missing boost dependency to message test

Since message test utilizes boost library add it to the dependencies.

Change-Id: Ib027e34931d00ec288f0d5dba4b38911fd8affc3
Signed-off-by: Konstan

meson: Add missing boost dependency to message test

Since message test utilizes boost library add it to the dependencies.

Change-Id: Ib027e34931d00ec288f0d5dba4b38911fd8affc3
Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>

show more ...

chassis: Switch NMI handling to Control.Host.NMI interface

Nothing in mainline OpenBMC appears to implement a service for the
Chassis.Control.NMISource interface as far as I can tell, so 'ipmitool
c

chassis: Switch NMI handling to Control.Host.NMI interface

Nothing in mainline OpenBMC appears to implement a service for the
Chassis.Control.NMISource interface as far as I can tell, so 'ipmitool
chassis power diag' had no way of working. With this change we switch
ipmid to use the same interface that bmcweb uses to handle a POST of
'{"ResetType":"Nmi"}' to the ComputerSystem.Reset endpoint (which
x86-power-control implements and thus actually works).

Tested: 'ipmitool chassis power diag' now successfully triggers an NMI
on the host via x86-power-control instead of simply logging an error on
the BMC.

Signed-off-by: Zev Weiss <zev@bewilderbeest.net>
Change-Id: Ic4c6cb2546cbd3877953fac9dd04ea752810c46c

show more ...