History log of /openbmc/phosphor-host-ipmid/ (Results 1 – 25 of 1269)
Revision Date Author Comments
(<<< Hide modified files)
(Show modified files >>>)
af4a775002-Jul-2024 Vernon Mauery <vernon.mauery@linux.intel.com>

update transporthandler.cpp to use lg2

Change-Id: Ib77057c5bccba62473a981451ae79f1b2c19cc28
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

531223fb11-Nov-2024 Jayanth Othayoth <ojayanth@gmail.com>

boost version 1.86 support

Added fix for boost::asio::spawn overload issue reported similar
to chriskohlhoff/asio#1524, during boost 1.86 migration build.

Proposed fix is to use default completion

boost version 1.86 support

Added fix for boost::asio::spawn overload issue reported similar
to chriskohlhoff/asio#1524, during boost 1.86 migration build.

Proposed fix is to use default completion token.

Tested: verified build

Change-Id: Ie3ebcf963f998fd6064e8efab49d1fe584d4b587
Signed-off-by: Jayanth Othayoth <ojayanth@gmail.com>

show more ...

8bd9a9bc08-Nov-2024 Chanh Nguyen <chanh@os.amperecomputing.com>

transporthandler: Synchronous get IP address and IP address source

In case both DHCP and static IP addresses are assigned, the IPMI
code just returns one of them. The IPMI code always returns the
fi

transporthandler: Synchronous get IP address and IP address source

In case both DHCP and static IP addresses are assigned, the IPMI
code just returns one of them. The IPMI code always returns the
first object dbus on the interface by the fixed index, which is
always 0. That may cause a mismatch between the IP address and
IP address source.

This patch will check if the DHCP or static mode is enabling,
then return the IP address accordingly.

Tested:
1. Change to static source
ipmitool lan set 1 ipsrc static

2. Set a static IP address.
ipmitool lan set 1 ipaddr xx.xx.xx.xx

3. Back to DHCP source
ipmitool lan set 1 ipsrc dhcp

4. Check the IP Lan print.
Expect the IP address and IP source address report accordingly.

ipmitool lan print 1

Fixes openbmc/phosphor-host-ipmid#207

Change-Id: If1d2bcfb9e3ab79e02ebf78682e3ac5638c18b0c
Signed-off-by: Chanh Nguyen <chanh@os.amperecomputing.com>

show more ...

402024a816-Jul-2024 George Liu <liuxiwei@ieisystem.com>

sensorhandler: Support NonRecoverable in getSensorThresholds method

There are actually three types of threshold interfaces (Warning,
Critical, and NonRecoverable). This patch supports the NonRecover

sensorhandler: Support NonRecoverable in getSensorThresholds method

There are actually three types of threshold interfaces (Warning,
Critical, and NonRecoverable). This patch supports the NonRecoverable
interface in the getSensorThresholds method.

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: Ie9a7ff44b4e58702c5522a308d8128fcfb1161ef

show more ...

a809fa5508-Aug-2024 Thang Tran <thuutran@amperecomputing.com>

support reading System Firmware Version

This commit implements reading System Firmware Version as below steps:
- Find all object path that include xyz.openbmc_project.Software.Version
interface.
- G

support reading System Firmware Version

This commit implements reading System Firmware Version as below steps:
- Find all object path that include xyz.openbmc_project.Software.Version
interface.
- Get the Purpose property of above object paths.
- If the Purpose is Host then get the Version property.

Tested:
1. Read system firmware version
$ipmitool mc getsysinfo system_fw_version
2. The version of firmware is shown

Change-Id: I84e25572253ddc7c2a48da9f6046920e55c8ccd4
Signed-off-by: Huy Le <hule@amperecomputing.com>
Signed-off-by: Thang Tran <thuutran@amperecomputing.com>

show more ...

b4b4091817-Jul-2024 George Liu <liuxiwei@ieisystem.com>

ipmid: switch to lg2

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: I838587b2d564f3c00b78ce37e175d7e8ace51142

3808e55825-Jul-2024 George Liu <liuxiwei@ieisystem.com>

Optimize the response value of ipmiSetUserPassword method

ipmiCCPasswdFailMismatch has been declared in usercommands.hpp, so
there is no need to declare a static variable.

Signed-off-by: George Li

Optimize the response value of ipmiSetUserPassword method

ipmiCCPasswdFailMismatch has been declared in usercommands.hpp, so
there is no need to declare a static variable.

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: I1989c4674392544aaf736823c8b5f9b2ac7acefa

show more ...

7a34a6ca12-Sep-2024 George Liu <liuxiwei@ieisystem.com>

sensorhandler: Fix failed to obtain sensor threshold

If the getSensorThresholds method is called and the threshold fails
to be obtained, resp should not be updated to sensorThresholdMap,
otherwise t

sensorhandler: Fix failed to obtain sensor threshold

If the getSensorThresholds method is called and the threshold fails
to be obtained, resp should not be updated to sensorThresholdMap,
otherwise this sensor will never be able to obtain the threshold.

This commit intends to update resp to sensorThresholdMap only when
the getSensorThresholds method is successfully called.

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: Ia944879f0c19f744ae9b2be3aa7f4c7f73c3e5bb

show more ...

b1d4518c10-Sep-2024 George Liu <liuxiwei@ieisystem.com>

transporthandler: Fix out_of_range exception caused by using at

When using the .at method to get the value in std::map, if the key
does not exist, an out_of_range exception will be thrown.

This com

transporthandler: Fix out_of_range exception caused by using at

When using the .at method to get the value in std::map, if the key
does not exist, an out_of_range exception will be thrown.

This commit moves this logic to the try method and catches the
exception.

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: Ia9479bd3ce53d32515bef13db1bba7b3fe6e0429

show more ...

d386fba609-Sep-2024 Hieu Huynh <hieuh@os.amperecomputing.com>

Get UUID from inventory subtree

Currently, the UUID is getting from the first object path that
includes "Common.UUID" interface. But the UUID can be obtained
from the MCTP/FRU...
The system UUID sho

Get UUID from inventory subtree

Currently, the UUID is getting from the first object path that
includes "Common.UUID" interface. But the UUID can be obtained
from the MCTP/FRU...
The system UUID should be got from the object path that has the
prefix "xyz/openbmc_project/inventory". This commit updates
subtreepath parameter from "/" to "/xyz/openbmc_project/inventory"
to fix the issue.

Tested:
1. Get UUID via Redfish
/redfish/v1/Systems/system
2. Get UUID via IPMI command
$ ipmitool mc guid
The UUID obtained in steps #1 and #2 is same.

Signed-off-by: Hieu Huynh <hieuh@os.amperecomputing.com>
Change-Id: Ib22bf1ace489c0152a0f3eaa38f68ee35be7c64c

show more ...

e7ef94d318-Jun-2024 Johnathan Mantey <johnathanx.mantey@intel.com>

Refactor Get SDR Device Info function

The Get SDR Device Info function can be simplified by taking advantage
of the code changes for managing non-Type 01 SDR's.

Tested:
ipmitool raw 4 0x20 // exp

Refactor Get SDR Device Info function

The Get SDR Device Info function can be simplified by taking advantage
of the code changes for managing non-Type 01 SDR's.

Tested:
ipmitool raw 4 0x20 // expect sensor count
ipmitool raw 4 0x20 0 // expect sensor count
ipmitool raw 4 0x20 1 // expect SDR count
ipimtool raw 4 0x20 2 // expect invalid parameter err

All of the ipmitool commands returned the expected results

Change-Id: I6f73a521c4273a29990fcc2b0cc725ad593db348
Signed-off-by: Johnathan Mantey <johnathanx.mantey@intel.com>

show more ...

8513411723-Aug-2024 George Liu <liuxiwei@ieisystem.com>

Fix defaulted-function-deleted

warning error:
```
../settings.hpp:29:42: note: replace 'default' with 'delete'
29 | Objects& operator=(const Objects&) = default;
|

Fix defaulted-function-deleted

warning error:
```
../settings.hpp:29:42: note: replace 'default' with 'delete'
29 | Objects& operator=(const Objects&) = default;
| ^~~~~~~
| delete
```

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: Ib2326f58aad1b8c296668a69ac8fa165954ea942

show more ...

656ae3c523-Aug-2024 George Liu <liuxiwei@ieisystem.com>

Remove unused variables

Using clang-tidy, it was detected that some variables are no longer
in use. This commit remove unused variables.

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id

Remove unused variables

Using clang-tidy, it was detected that some variables are no longer
in use. This commit remove unused variables.

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: I382e6ce07e66dc5ad082be9b36d217a037e609b5

show more ...

1318a5ed16-Aug-2024 Patrick Williams <patrick@stwcx.xyz>

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda forma

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda formatting also changed, so we have made changes to the
organization default style format to better handle lambda formatting.

See I5e08687e696dd240402a2780158664b7113def0e for updated style.
See Iea0776aaa7edd483fa395e23de25ebf5a6288f71 for clang-18 enablement.

Change-Id: I01547e98d27910919e09ebf7907c86292a6c825d
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

29a7478826-Jul-2024 George Liu <liuxiwei@ieisystem.com>

app: remove unused commands

Since the implementations of commands ipmi_app_channel_info,
ipmi_get_channel_access, and ipmi_set_channel_access have been
removed in a previous patch [1], this commit r

app: remove unused commands

Since the implementations of commands ipmi_app_channel_info,
ipmi_get_channel_access, and ipmi_set_channel_access have been
removed in a previous patch [1], this commit removes the
declarations in hpp.

[1]: https://github.com/openbmc/phosphor-host-ipmid/commit/d2a57decf383eb3faf3587739ad0b3181b7bb2d6

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: Ice8b824abba4126d373cdfcf63364b6257d045ac

show more ...

9479e3d605-Aug-2024 George Liu <liuxiwei@ieisystem.com>

docs/configuration.md: Fix MD025 warnings

The following warnings are generated by using markdownlint analysis:
```
docs/configuration.md:25 MD025/single-title/single-h1 Multiple top-level headings i

docs/configuration.md: Fix MD025 warnings

The following warnings are generated by using markdownlint analysis:
```
docs/configuration.md:25 MD025/single-title/single-h1 Multiple top-level headings in the same document [Context: "# IPMI D-Bus Sensor Filtering"]
```
Refer to markdown-lint [1] to fix MD025
[1]: https://github.com/updownpress/markdown-lint/blob/master/rules/025-single-h1.md

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: I2cda186ec6ec17ae049649761cd2b8bc81c3306e

show more ...


bdbf7a1605-Aug-2024 George Liu <liuxiwei@ieisystem.com>

scripts/entity-example.md: Fix MD041 warnings

The following warnings are generated by using markdownlint analysis:
```
scripts/entity-example.md:1 MD041/first-line-heading/first-line-h1 First line i

scripts/entity-example.md: Fix MD041 warnings

The following warnings are generated by using markdownlint analysis:
```
scripts/entity-example.md:1 MD041/first-line-heading/first-line-h1 First line in a file should be a top-level heading [Context: "If your platform requires the ..."]
```
Refer to markdown-lint [1] to fix MD041
[1]: https://github.com/updownpress/markdown-lint/blob/master/rules/041-first-line-h1.md

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: Ie58bdbff68235b348fe82432614fd351ba1c6141

show more ...


5e84c7c505-Aug-2024 George Liu <liuxiwei@ieisystem.com>

Fix MD034 warnings

The following warnings are generated by using markdownlint analysis:
```
docs/configuration.md:12:15 MD034/no-bare-urls Bare URL used [Context: "https://github.com/openbmc/ope..."

Fix MD034 warnings

The following warnings are generated by using markdownlint analysis:
```
docs/configuration.md:12:15 MD034/no-bare-urls Bare URL used [Context: "https://github.com/openbmc/ope..."]
```
Refer to markdown-lint [1] to fix MD034
[1]: https://github.com/updownpress/markdown-lint/blob/master/rules/034-no-bare-urls.md

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: I7a59e3789cd549beca1e167c53ddacd97e96c86e

show more ...

6ea922fd05-Aug-2024 George Liu <liuxiwei@ieisystem.com>

Fix MD056 warnings

The following warnings are generated by using markdownlint analysis:
```
docs/oem-extension-numbering.md:118:33 MD056/table-column-count Table column count [Expected: 4; Actual: 3

Fix MD056 warnings

The following warnings are generated by using markdownlint analysis:
```
docs/oem-extension-numbering.md:118:33 MD056/table-column-count Table column count [Expected: 4; Actual: 3; Too few cells, row will be missing data]
docs/oem-extension-numbering.md:121:33 MD056/table-column-count Table column count [Expected: 4; Actual: 3; Too few cells, row will be missing data]
```

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: If6f30b974831325b14b783b3339ddcf5c186bc83

show more ...

7768857f05-Aug-2024 George Liu <liuxiwei@ieisystem.com>

Fix MD001 warnings

The following warnings are generated by using markdownlint analysis:
```
docs/oem-extension-numbering.md:6 MD001/heading-increment Heading levels should only increment by one leve

Fix MD001 warnings

The following warnings are generated by using markdownlint analysis:
```
docs/oem-extension-numbering.md:6 MD001/heading-increment Heading levels should only increment by one level at a time [Expected: h2; Actual: h3]
```
Refer to markdown-lint [1] to fix MD001
[1]: https://github.com/updownpress/markdown-lint/blob/master/rules/001-header-increment.md

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: I7d08a0b7b3f22cef58f22d56b97293688c09da53

show more ...

43dda5ed05-Aug-2024 George Liu <liuxiwei@ieisystem.com>

Fix MD025 warnings

The following warnings are generated by using markdownlint analysis:
```
docs/testing.md:140 MD025/single-title/single-h1 Multiple top-level headings in the same document [Context

Fix MD025 warnings

The following warnings are generated by using markdownlint analysis:
```
docs/testing.md:140 MD025/single-title/single-h1 Multiple top-level headings in the same document [Context: "# Writing Tests"]
docs/testing.md:427 MD025/single-title/single-h1 Multiple top-level headings in the same document [Context: "# Reviewing Tests"]
docs/testing.md:470 MD025/single-title/single-h1 Multiple top-level headings in the same document [Context: "# Credits"]
docs/configuration.md:25 MD025/single-title/single-h1 Multiple top-level headings in the same document [Context: "# IPMI D-Bus Sensor Filtering"]
```
Refer to markdown-lint [1] to fix MD025
[1]: https://github.com/updownpress/markdown-lint/blob/master/rules/025-single-h1.md

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: I0e59219d9327db7a2589ada84615f9dc345373d5

show more ...

fae0f1b605-Aug-2024 George Liu <liuxiwei@ieisystem.com>

Fix MD040 warnings

The following warnings are generated by using markdownlint analysis:
```
MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"]
```
Refer

Fix MD040 warnings

The following warnings are generated by using markdownlint analysis:
```
MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"]
```
Refer to markdown-lint [1] to fix MD040
[1]: https://github.com/updownpress/markdown-lint/blob/master/rules/040-fenced-code-language.md

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: I3bcd15ed9ef26177daed8e5fdfe252e0d37f4ed0

show more ...

797776c105-Aug-2024 George Liu <liuxiwei@ieisystem.com>

Fix MD026 warnings

The following warnings are generated by using markdownlint analysis:
```
MD026/no-trailing-punctuation Trailing punctuation in heading [Punctuation: ':']
MD026/no-trailing-punctua

Fix MD026 warnings

The following warnings are generated by using markdownlint analysis:
```
MD026/no-trailing-punctuation Trailing punctuation in heading [Punctuation: ':']
MD026/no-trailing-punctuation Trailing punctuation in heading [Punctuation: '.']
```
Refer to markdown-lint [1] to fix MD026
[1]: https://github.com/updownpress/markdown-lint/blob/master/rules/026-no-trailing-punctuation.md

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: I1b6aa54e010140a2a6c42b7f900611a204df587a

show more ...

40a6660305-Aug-2024 George Liu <liuxiwei@ieisystem.com>

Fix MD041 warnings

The following warnings are generated by using markdownlint analysis:
```
README.md:1 MD041/first-line-heading/first-line-h1 First line in a file should be a top-level heading [Con

Fix MD041 warnings

The following warnings are generated by using markdownlint analysis:
```
README.md:1 MD041/first-line-heading/first-line-h1 First line in a file should be a top-level heading [Context: "### Compile ipmid with default..."]
scripts/entity-example.md:1 MD041/first-line-heading/first-line-h1 First line in a file should be a top-level heading [Context: "If your platform requires the ..."]
docs/ipmi-network-format.md:1 MD041/first-line-heading/first-line-h1 First line in a file should be a top-level heading [Context: "On platforms running AMI BMC f..."]
```
Refer to markdown-lint [1] to fix MD041
[1]: https://github.com/updownpress/markdown-lint/blob/master/rules/041-first-line-h1.md

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: I28d2121e54e078e701d35071cd4088fefcdd4a58

show more ...

ffd5f04218-Jul-2024 George Liu <liuxiwei@ieisystem.com>

convert globalhandler.cpp to use lg2

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: I813779ee83fa19df01afd0b5c1cfd6294d3be777

12345678910>>...51