phosphor-host-ipmid: Fix typos in comments and log messages

Correct spelling mistakes in comments and error logs across
apphandler.cpp, sensorcommands.cpp, and storagecommands.cpp.
No functional cha

phosphor-host-ipmid: Fix typos in comments and log messages

Correct spelling mistakes in comments and error logs across
apphandler.cpp, sensorcommands.cpp, and storagecommands.cpp.
No functional changes.

Change-Id: I79763fbc0d3db1d34b700b2ba30dddd61451e9c2
Signed-off-by: Nagavarapu Sai Pavan <saipavann@ami.com>

show more ...

phosphor-host-ipmid: Fix typos in comments and log messages

Correct spelling mistakes in comments and error logs across
sbmrhandler.cpp, sensorhandler.hpp, storagehandler.cpp,
systemintfcmds.hpp, tr

phosphor-host-ipmid: Fix typos in comments and log messages

Correct spelling mistakes in comments and error logs across
sbmrhandler.cpp, sensorhandler.hpp, storagehandler.cpp,
systemintfcmds.hpp, transportconstants.hpp, transporthandler.cpp,
transporthandler.hpp and whitelist-filter.cpp.
No functional changes.

Change-Id: I014628b64b6ebe5324cdd4308d107e7f1956c4b6
Signed-off-by: Nagavarapu Sai Pavan <saipavann@ami.com>

show more ...

meson: reformat with meson formatter

Apply the `meson format` results.

Change-Id: I1f08bc9fa052380952c577144914b0b905ba9793
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

chassis handler: use PDI constants

Use PDI constants throughout this file instead of local definitions.

Tested: Inspection only.

Change-Id: Ifc50c7032cc3ea9bcd245b2dca4fb9abcd751a85
Signed-off-by:

chassis handler: use PDI constants

Use PDI constants throughout this file instead of local definitions.

Tested: Inspection only.

Change-Id: Ifc50c7032cc3ea9bcd245b2dca4fb9abcd751a85
Signed-off-by: Alexander Hansen <alexander.hansen@9elements.com>

show more ...

settings: add serviceMap to cache Path-Service mapping

Previously, the cache only stored Interface-Paths mapping, without
retaining the service associated with each object path. This required
an ext

settings: add serviceMap to cache Path-Service mapping

Previously, the cache only stored Interface-Paths mapping, without
retaining the service associated with each object path. This required
an extra DBus call whenever the service name was needed.

This change introduces a new `std::map<Path, Service> serviceMap` to
store the first encountered service for each path. Duplicate paths are
skipped to avoid unnecessary overwrites. This allows subsequent code
to directly access the service corresponding to a path without extra
DBus queries, improving efficiency and reducing communication overhead.

Change-Id: If165713202218449941eff7c22ae957cd79b0fc9
Signed-off-by: George Liu <liuxiwei@ieisystem.com>

show more ...

sensordatahandler: clarify reserved bits and signed units handling

- Replace magic value 0xC0 with a named constexpr for the reserved
bits [7:6].
- Keep the MSB→LSB ordering of the bitfield; only

sensordatahandler: clarify reserved bits and signed units handling

- Replace magic value 0xC0 with a named constexpr for the reserved
bits [7:6].
- Keep the MSB→LSB ordering of the bitfield; only adjust shift
positions.

This addresses review feedback and improves clarity of the bitfield
layout.

Tested: build ok; threshold packing and units format checked locally.

Change-Id: I728fa87ee7366b00761748e3401e030cc723ebc1
Signed-off-by: You Peng Wu <twpeng50606@gmail.com>

show more ...

Reject unallowlisted controller write-read requests

The whitelist check for the Controller Write Read command only logs a
blocked message but still proceeds with i2cWriteRead,
so unapproved I2C tran

Reject unallowlisted controller write-read requests

The whitelist check for the Controller Write Read command only logs a
blocked message but still proceeds with i2cWriteRead,
so unapproved I2C transactions go through.

Change-Id: Id8a62045d53cdf77bd7252aff93b3d2851fcdad6
Signed-off-by: Farheen Iqbal <iqbalfarheen@gmail.com>

show more ...

oem/example: use PDI constants

Refactor the example code to use PDI definitions.

Tested: Inspection only.

Change-Id: Ibe34fb924c5b581f4703d0c0b0c30e820296fdaf
Signed-off-by: Alexander Hansen <alex

oem/example: use PDI constants

Refactor the example code to use PDI definitions.

Tested: Inspection only.

Change-Id: Ibe34fb924c5b581f4703d0c0b0c30e820296fdaf
Signed-off-by: Alexander Hansen <alexander.hansen@9elements.com>

show more ...

Network.IP: use PDI constants

Use PDI constants instead of local definitions.

Tested: Inspection only.

Change-Id: If4c3c657be0d97658eb400a59ec2833c6df1c131
Signed-off-by: Alexander Hansen <alexand

Network.IP: use PDI constants

Use PDI constants instead of local definitions.

Tested: Inspection only.

Change-Id: If4c3c657be0d97658eb400a59ec2833c6df1c131
Signed-off-by: Alexander Hansen <alexander.hansen@9elements.com>

show more ...

Sensor.Threshold.*: use PDI constants

Use PDI constants instead of local definitions.

Tested: Inspection only.

Change-Id: Ibb878bc15ac7fa5ec2cae45c5327d2a396e435a0
Signed-off-by: Alexander Hansen

Sensor.Threshold.*: use PDI constants

Use PDI constants instead of local definitions.

Tested: Inspection only.

Change-Id: Ibb878bc15ac7fa5ec2cae45c5327d2a396e435a0
Signed-off-by: Alexander Hansen <alexander.hansen@9elements.com>

show more ...

Sensor.Value: use PDI constants

Use PDI constants instead of local definitions.

Tested: Inspection only.

Change-Id: I42c4f33a7e2f98a1adbac5a92aea4df952442990
Signed-off-by: Alexander Hansen <alexa

Sensor.Value: use PDI constants

Use PDI constants instead of local definitions.

Tested: Inspection only.

Change-Id: I42c4f33a7e2f98a1adbac5a92aea4df952442990
Signed-off-by: Alexander Hansen <alexander.hansen@9elements.com>

show more ...

use PDI constants for State.Chassis

Tested: Inspection only.

Change-Id: I00e4fc48e0c993c960dcbe7c38e544159496a742
Signed-off-by: Alexander Hansen <alexander.hansen@9elements.com>

use PDI constants for State.Host

Tested: Inspection only.

Change-Id: I0be6d281b49f30814dd40309cc9af540d7d6ea86
Signed-off-by: Alexander Hansen <alexander.hansen@9elements.com>

use PDI constants for State.BMC

Tested: Inspection only.

Change-Id: I7ba48d7f5f856d5f284b68f8344b982da08c58df
Signed-off-by: Alexander Hansen <alexander.hansen@9elements.com>

use PDI constants for State.Watchdog

Tested: Inspection only.

Change-Id: Ie317d798e5e3ecd762fa59a481d34b59ac5ece47
Signed-off-by: Alexander Hansen <alexander.hansen@9elements.com>

use PDI constants for ObjectMapper

PDI already defines the constants we need here, use those instead of
duplicating.

Tested: Inspection only.

Change-Id: I86ad46a4aac757aa7b377b1e1709088a1e457102
S

use PDI constants for ObjectMapper

PDI already defines the constants we need here, use those instead of
duplicating.

Tested: Inspection only.

Change-Id: I86ad46a4aac757aa7b377b1e1709088a1e457102
Signed-off-by: Alexander Hansen <alexander.hansen@9elements.com>

show more ...

Revert "Align MetaPassStruct for cross-arch consistency"

This patch broke the upgrade for 32-bit systems. Any system with an
existing password file won't be able to use the same password file
after

Revert "Align MetaPassStruct for cross-arch consistency"

This patch broke the upgrade for 32-bit systems. Any system with an
existing password file won't be able to use the same password file
after this upgrade. We need to implement a backward-compatible fix in
the phosphor-host-ipmid repository.

This reverts commit 1241052b53be928fed70c33a03ad5a99d51e8ffa.

Change-Id: I1124f291265858d7a8015f25c79401483dbb45d6
Signed-off-by: George Liu <liuxiwei@ieisystem.com>

show more ...

Align MetaPassStruct for cross-arch consistency

Increase reserved field from 2 to 6 bytes to ensure natural alignment of
subsequent size_t fields on both 32-bit and 64-bit architectures.
This avoids

Align MetaPassStruct for cross-arch consistency

Increase reserved field from 2 to 6 bytes to ensure natural alignment of
subsequent size_t fields on both 32-bit and 64-bit architectures.
This avoids compiler-inserted padding and ensures consistent
struct layout for serialization and IPC.

No functional changes beyond layout fix

Change-Id: Icc53e2fdd6cceac33f63343f5be537b704742eaa
Signed-off-by: Vijaysankar R <vijaysankarr@ami.com>

show more ...

use sdbusplus unpack syntax

Rather than defining a variable and then reading it from a message,
sdbusplus also supports directly unpack-ing from the message. Use
this syntax instead as it is more e

use sdbusplus unpack syntax

Rather than defining a variable and then reading it from a message,
sdbusplus also supports directly unpack-ing from the message. Use
this syntax instead as it is more efficient and succinct.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I23902026dee367a8cbf0c2725725c4ed3ca4d2bb

show more ...

Fix cppcheck errors

dbus-sdr/sensorcommands.cpp:927:17: error: Uninitialized variable:
operation [uninitvar]
operation |= static_cast<uint8_t>(

dbus-sdr/sensorcommands.cpp:1623:13: error: Uninitial

Fix cppcheck errors

dbus-sdr/sensorcommands.cpp:927:17: error: Uninitialized variable:
operation [uninitvar]
operation |= static_cast<uint8_t>(

dbus-sdr/sensorcommands.cpp:1623:13: error: Uninitialized variable:
sensorEventStatus [uninitvar]
sensorEventStatus |= static_cast<uint8_t>(

Change-Id: I43d68e7660eb35d375e59b3f17909e8349cc622a
Signed-off-by: Hariharan Rangasamy <hariharanr@ami.com>

show more ...

sensorhandler: Fix Get Sensor Reading threshold bit mapping

IPMI v2.0 (Spec rev 1.1), Table 35 "Get Sensor Reading" defines the
Present threshold comparison status byte as:
[7:6] = 1b (reserved, m

sensorhandler: Fix Get Sensor Reading threshold bit mapping

IPMI v2.0 (Spec rev 1.1), Table 35 "Get Sensor Reading" defines the
Present threshold comparison status byte as:
[7:6] = 1b (reserved, must read as 1)
[5] = >= Upper Non-Recoverable (UNR)
[4] = >= Upper Critical (UC)
[3] = >= Upper Non-Critical (UNC)
[2] = <= Lower Non-Recoverable (LNR)
[1] = <= Lower Critical (LC)
[0] = <= Lower Non-Critical (LNC)

Previous implementation packed UC/UNC/LC/LNC into bits [3:0] and left
[7:6] unset. This is out of spec and causes the IPMI raw Get Sensor
Reading response to return an incorrect threshold status byte, leading
to misinterpretation by clients.

This change:
* Sets bits [7:6] to 1 as required by the spec.
* Maps UC/UNC/LC/LNC to bits [4]/[3]/[1]/[0], respectively.
* Leaves UNR/LNR ([5]/[2]) as 0 for now (unused in OpenBMC).

Impact: fixes the byte returned by IPMI raw Get Sensor Reading and
makes threshold status reporting spec compliant. No D-Bus or API change.

Testing:
- bitbake phosphor-host-ipmid builds successfully
- on target, ipmitool raw 0x04 0x2d <sensor#> and ipmitool sensor get
show [7:6] = 11b and expected UC, UNC, LC, LNC bit positions

Change-Id: I0a0b07e8fe82357d39329054fed7966bb67f6f91
Signed-off-by: You Peng Wu <twpeng50606@gmail.com>

show more ...

meson: fix option descriptions

Change-Id: Ifd869d24c13812eb4c4958e6da1b586c90651e19
Signed-off-by: Brad Bishop <bradbish@qti.qualcomm.com>

meson: format meson.options

Apply the meson formatter to meson.options.

Change-Id: Ie90fdd7c1219502f19dc299d0acb93d6febf91e7
Signed-off-by: Brad Bishop <bradbish@qti.qualcomm.com>

Fix for Set Chassis Capability Command

- Current IPMI Set Chassis Capability command
does not have support for excluding the
Chassis Bridge Device Address which is optional.
- Added support to m

Fix for Set Chassis Capability Command

- Current IPMI Set Chassis Capability command
does not have support for excluding the
Chassis Bridge Device Address which is optional.
- Added support to make Chassis Bridge Device
Address as optional.
- Tested and verified
Set and Get Chassis Capability commands.

Change-Id: I1035667a4faad5402beb2fad7d062bdfacbdb19f
Signed-off-by: Nikhila D <nikhilad@ami.com>

show more ...

Fix SPDX identifiers

Make them match the standard.

Change-Id: Iadd06d2a00fad012a4c75652eaf3e0945bd94b9f
Signed-off-by: Ed Tanous <etanous@nvidia.com>