37de2e1a | 29-Jan-2025 |
Konstantin Aladyshev <aladyshev22@gmail.com> |
Fix typo in PFail fail log message argument
Currently typo in the PFail fail log message prevents argument substitution. Correct typo to fix the issue.
Change-Id: I29fcdf954776f98389e78954c943145d5
Fix typo in PFail fail log message argument
Currently typo in the PFail fail log message prevents argument substitution. Correct typo to fix the issue.
Change-Id: I29fcdf954776f98389e78954c943145d59f8661d Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>
show more ...
|
deeceae3 | 28-Jan-2025 |
Konstantin Aladyshev <aladyshev22@gmail.com> |
Fix bug in the name of array of whitelisted commands
The commit 68d9d40530351e3f3db2c00a25969b0efc9fbe3f ("Update terminology used within repo") has changed the name of the array of whitelisted IPMI
Fix bug in the name of array of whitelisted commands
The commit 68d9d40530351e3f3db2c00a25969b0efc9fbe3f ("Update terminology used within repo") has changed the name of the array of whitelisted IPMI commands from 'whitelist' to 'allowlist' in the .hpp code, but didn't do it in the "generate_whitelist.sh" script that generates the .cpp file with the relevant array. This leads to the following error message at the service start: """ ipmid[363]: ERROR opening IPMI provider /usr/lib/ipmid-providers/libwhitelist.so.0.1: /usr/lib/ipmid-providers/libwhitelist.so.0.1: undefined symbol: allowlist """ Correct array name to fix the issue.
Change-Id: I6d2fe94d0712181db13bb71cf2bd71e2db54d6c0 Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>
show more ...
|
62ce1594 | 03-Feb-2025 |
Patrick Williams <patrick@stwcx.xyz> |
meson: reformat with meson formatter
Apply the `meson format` results.
Change-Id: I1dbf4ae74d383552995432add3d2f548eb844ee5 Signed-off-by: Patrick Williams <patrick@stwcx.xyz> |
3b301a3a | 03-Feb-2025 |
Patrick Williams <patrick@stwcx.xyz> |
Revert "drop sdevents hack"
This reverts commit d2dd5bc2eddc73504734112c0d6f745202b1b3a0.
The commit was inadvertently merged upstream.
Signed-off-by: Patrick Williams <patrick@stwcx.xyz> Change-I
Revert "drop sdevents hack"
This reverts commit d2dd5bc2eddc73504734112c0d6f745202b1b3a0.
The commit was inadvertently merged upstream.
Signed-off-by: Patrick Williams <patrick@stwcx.xyz> Change-Id: Icf03e2ca476271b4606500846593e36fe326f3c5
show more ...
|
d2dd5bc2 | 10-Jun-2024 |
Patrick Williams <patrick@stwcx.xyz> |
drop sdevents hack
Signed-off-by: Patrick Williams <patrick@stwcx.xyz> Change-Id: I04833cc2a39c032a4d9c29079ee92fdf24c89245 |
32aece1a | 24-Jan-2025 |
Patrick Williams <patrick@stwcx.xyz> |
storagehandler: fix compile without open-power
When the `open-power` meson option is disabled, the code fails with the following compile failure:
``` ../storagehandler.cpp: In function ‘ipmi::RspTy
storagehandler: fix compile without open-power
When the `open-power` meson option is disabled, the code fails with the following compile failure:
``` ../storagehandler.cpp: In function ‘ipmi::RspType<short unsigned int> ipmiStorageAddSEL(uint16_t, uint8_t, uint32_t, uint16_t, uint8_t, uint8_t, uint8_t, uint8_t, std::array<unsigned char, 3>)’: ../storagehandler.cpp:685:27: error: unused variable ‘procedureType’ [-Werror=unused-variable] 685 | static constexpr auto procedureType = 0xDE; | ^~~~~~~~~~~~~ ../storagehandler.cpp:677:64: error: unused parameter ‘sensorType’ [-Werror=unused-parameter] 677 | [[maybe_unused]] uint8_t evmRev, uint8_t sensorType, ```
Add trivial changes to fix.
Signed-off-by: Patrick Williams <patrick@stwcx.xyz> Change-Id: Ia7cc8dab700381c78461899bfc8c33d43cab3625
show more ...
|
f62ad6fc | 03-Sep-2024 |
Patrick Williams <patrick@stwcx.xyz> |
meson: switch code dependency to libsystemd
For a while now systemd has packaged a separate `libsystemd`. For meson dependency, `systemd` should be used when looking for systemd service file paths
meson: switch code dependency to libsystemd
For a while now systemd has packaged a separate `libsystemd`. For meson dependency, `systemd` should be used when looking for systemd service file paths and `libsystemd` should be used for `sd_*` functions.
Update the dependency accordingly.
Signed-off-by: Patrick Williams <patrick@stwcx.xyz> Change-Id: I9768dd66c4180085f201a0b77385d696bdd1680f
show more ...
|
0c6561da | 15-Jan-2025 |
Potin Lai <potin.lai@quantatw.com> |
selutility: Fix service crash when constructing SEL
The type `additionalDataMap` has been replaced with `AdditionalData`. However, the map `m` is not populated by any functions, which causes `assert
selutility: Fix service crash when constructing SEL
The type `additionalDataMap` has been replaced with `AdditionalData`. However, the map `m` is not populated by any functions, which causes `assert()` to be triggered in both `constructOEMSEL()` and `constructSEL()` due to `m` being an empty map.
This patch removes the code referencing `additionalDataMap` and fully switch to using `AdditionalData`, ensuring that the SEL construction process works correctly.
Change-Id: Ib917feaabfc255c635bf2ee96c092386e0faa16b Signed-off-by: Potin Lai <potin.lai@quantatw.com>
show more ...
|
39deff2d | 11-Dec-2024 |
Patrick Williams <patrick@stwcx.xyz> |
Logging.Entry: use AdditionalData property again
Change I7cc9591895f219471ac098387f72a35c18e6c750 finished the migration in phosphor-logging so that AdditionalData is now a dictionary (as is Additio
Logging.Entry: use AdditionalData property again
Change I7cc9591895f219471ac098387f72a35c18e6c750 finished the migration in phosphor-logging so that AdditionalData is now a dictionary (as is AdditionalData2). Use AdditionalData so that phosphor-logging is free to delete AdditionalData2.
Signed-off-by: Patrick Williams <patrick@stwcx.xyz> Change-Id: Ibfa1af5b27a3da9bacc6f795a22b4eb98d25a013
show more ...
|
99db6885 | 18-Dec-2024 |
Patrick Williams <patrick@stwcx.xyz> |
clang-format: re-format for clang-19
clang-format-19 isn't compatible with the clang-format-18 output, so we need to reformat the code with the latest version. A few parameters in clang-tidy have b
clang-format: re-format for clang-19
clang-format-19 isn't compatible with the clang-format-18 output, so we need to reformat the code with the latest version. A few parameters in clang-tidy have been deprecated, so adjust the style file accordingly.
See Ie2f6eb3b043f2d655c9df806815afd7971fd0947 for updated style. See I88192b41ab7a95599a90915013579608af7bc56f for clang-19 enablement.
Change-Id: I0f8e47d0f6826f64f44c7fa17541e1752d1c3147 Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
show more ...
|
be5a2e0b | 22-Nov-2024 |
Patrick Williams <patrick@stwcx.xyz> |
Logging.Entry: use AdditionalData2 metadata dict
phosphor-logging's dbus entries now expose the metadata as a `dict<string,string>` rather than requiring additional processing by callers to split th
Logging.Entry: use AdditionalData2 metadata dict
phosphor-logging's dbus entries now expose the metadata as a `dict<string,string>` rather than requiring additional processing by callers to split the metadata. Support this property in selutility and eliminate the string processing code.
Tested: Compile test.
(There is no Tested statements in the git-log that explain how to use this code. I do not have a system that uses these OEM SELs. The code as-is is broken when the phosphor-logging commit is merged because there is a new property type which will fail to parse in the dbus message unpacking call.)
Signed-off-by: Patrick Williams <patrick@stwcx.xyz> Change-Id: I81e7e612abe25bdf29a961f6c9b33813bb523479
show more ...
|
af4a7750 | 02-Jul-2024 |
Vernon Mauery <vernon.mauery@linux.intel.com> |
update transporthandler.cpp to use lg2
Change-Id: Ib77057c5bccba62473a981451ae79f1b2c19cc28 Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com> |
531223fb | 11-Nov-2024 |
Jayanth Othayoth <ojayanth@gmail.com> |
boost version 1.86 support
Added fix for boost::asio::spawn overload issue reported similar to chriskohlhoff/asio#1524, during boost 1.86 migration build.
Proposed fix is to use default completion
boost version 1.86 support
Added fix for boost::asio::spawn overload issue reported similar to chriskohlhoff/asio#1524, during boost 1.86 migration build.
Proposed fix is to use default completion token.
Tested: verified build
Change-Id: Ie3ebcf963f998fd6064e8efab49d1fe584d4b587 Signed-off-by: Jayanth Othayoth <ojayanth@gmail.com>
show more ...
|
8bd9a9bc | 08-Nov-2024 |
Chanh Nguyen <chanh@os.amperecomputing.com> |
transporthandler: Synchronous get IP address and IP address source
In case both DHCP and static IP addresses are assigned, the IPMI code just returns one of them. The IPMI code always returns the fi
transporthandler: Synchronous get IP address and IP address source
In case both DHCP and static IP addresses are assigned, the IPMI code just returns one of them. The IPMI code always returns the first object dbus on the interface by the fixed index, which is always 0. That may cause a mismatch between the IP address and IP address source.
This patch will check if the DHCP or static mode is enabling, then return the IP address accordingly.
Tested: 1. Change to static source ipmitool lan set 1 ipsrc static
2. Set a static IP address. ipmitool lan set 1 ipaddr xx.xx.xx.xx
3. Back to DHCP source ipmitool lan set 1 ipsrc dhcp
4. Check the IP Lan print. Expect the IP address and IP source address report accordingly.
ipmitool lan print 1
Fixes openbmc/phosphor-host-ipmid#207
Change-Id: If1d2bcfb9e3ab79e02ebf78682e3ac5638c18b0c Signed-off-by: Chanh Nguyen <chanh@os.amperecomputing.com>
show more ...
|
402024a8 | 16-Jul-2024 |
George Liu <liuxiwei@ieisystem.com> |
sensorhandler: Support NonRecoverable in getSensorThresholds method
There are actually three types of threshold interfaces (Warning, Critical, and NonRecoverable). This patch supports the NonRecover
sensorhandler: Support NonRecoverable in getSensorThresholds method
There are actually three types of threshold interfaces (Warning, Critical, and NonRecoverable). This patch supports the NonRecoverable interface in the getSensorThresholds method.
Signed-off-by: George Liu <liuxiwei@ieisystem.com> Change-Id: Ie9a7ff44b4e58702c5522a308d8128fcfb1161ef
show more ...
|
a809fa55 | 08-Aug-2024 |
Thang Tran <thuutran@amperecomputing.com> |
support reading System Firmware Version
This commit implements reading System Firmware Version as below steps: - Find all object path that include xyz.openbmc_project.Software.Version interface. - G
support reading System Firmware Version
This commit implements reading System Firmware Version as below steps: - Find all object path that include xyz.openbmc_project.Software.Version interface. - Get the Purpose property of above object paths. - If the Purpose is Host then get the Version property.
Tested: 1. Read system firmware version $ipmitool mc getsysinfo system_fw_version 2. The version of firmware is shown
Change-Id: I84e25572253ddc7c2a48da9f6046920e55c8ccd4 Signed-off-by: Huy Le <hule@amperecomputing.com> Signed-off-by: Thang Tran <thuutran@amperecomputing.com>
show more ...
|
b4b40918 | 17-Jul-2024 |
George Liu <liuxiwei@ieisystem.com> |
ipmid: switch to lg2
Signed-off-by: George Liu <liuxiwei@ieisystem.com> Change-Id: I838587b2d564f3c00b78ce37e175d7e8ace51142 |
3808e558 | 25-Jul-2024 |
George Liu <liuxiwei@ieisystem.com> |
Optimize the response value of ipmiSetUserPassword method
ipmiCCPasswdFailMismatch has been declared in usercommands.hpp, so there is no need to declare a static variable.
Signed-off-by: George Li
Optimize the response value of ipmiSetUserPassword method
ipmiCCPasswdFailMismatch has been declared in usercommands.hpp, so there is no need to declare a static variable.
Signed-off-by: George Liu <liuxiwei@ieisystem.com> Change-Id: I1989c4674392544aaf736823c8b5f9b2ac7acefa
show more ...
|
7a34a6ca | 12-Sep-2024 |
George Liu <liuxiwei@ieisystem.com> |
sensorhandler: Fix failed to obtain sensor threshold
If the getSensorThresholds method is called and the threshold fails to be obtained, resp should not be updated to sensorThresholdMap, otherwise t
sensorhandler: Fix failed to obtain sensor threshold
If the getSensorThresholds method is called and the threshold fails to be obtained, resp should not be updated to sensorThresholdMap, otherwise this sensor will never be able to obtain the threshold.
This commit intends to update resp to sensorThresholdMap only when the getSensorThresholds method is successfully called.
Signed-off-by: George Liu <liuxiwei@ieisystem.com> Change-Id: Ia944879f0c19f744ae9b2be3aa7f4c7f73c3e5bb
show more ...
|
b1d4518c | 10-Sep-2024 |
George Liu <liuxiwei@ieisystem.com> |
transporthandler: Fix out_of_range exception caused by using at
When using the .at method to get the value in std::map, if the key does not exist, an out_of_range exception will be thrown.
This com
transporthandler: Fix out_of_range exception caused by using at
When using the .at method to get the value in std::map, if the key does not exist, an out_of_range exception will be thrown.
This commit moves this logic to the try method and catches the exception.
Signed-off-by: George Liu <liuxiwei@ieisystem.com> Change-Id: Ia9479bd3ce53d32515bef13db1bba7b3fe6e0429
show more ...
|
d386fba6 | 09-Sep-2024 |
Hieu Huynh <hieuh@os.amperecomputing.com> |
Get UUID from inventory subtree
Currently, the UUID is getting from the first object path that includes "Common.UUID" interface. But the UUID can be obtained from the MCTP/FRU... The system UUID sho
Get UUID from inventory subtree
Currently, the UUID is getting from the first object path that includes "Common.UUID" interface. But the UUID can be obtained from the MCTP/FRU... The system UUID should be got from the object path that has the prefix "xyz/openbmc_project/inventory". This commit updates subtreepath parameter from "/" to "/xyz/openbmc_project/inventory" to fix the issue.
Tested: 1. Get UUID via Redfish /redfish/v1/Systems/system 2. Get UUID via IPMI command $ ipmitool mc guid The UUID obtained in steps #1 and #2 is same.
Signed-off-by: Hieu Huynh <hieuh@os.amperecomputing.com> Change-Id: Ib22bf1ace489c0152a0f3eaa38f68ee35be7c64c
show more ...
|
e7ef94d3 | 18-Jun-2024 |
Johnathan Mantey <johnathanx.mantey@intel.com> |
Refactor Get SDR Device Info function
The Get SDR Device Info function can be simplified by taking advantage of the code changes for managing non-Type 01 SDR's.
Tested: ipmitool raw 4 0x20 // exp
Refactor Get SDR Device Info function
The Get SDR Device Info function can be simplified by taking advantage of the code changes for managing non-Type 01 SDR's.
Tested: ipmitool raw 4 0x20 // expect sensor count ipmitool raw 4 0x20 0 // expect sensor count ipmitool raw 4 0x20 1 // expect SDR count ipimtool raw 4 0x20 2 // expect invalid parameter err
All of the ipmitool commands returned the expected results
Change-Id: I6f73a521c4273a29990fcc2b0cc725ad593db348 Signed-off-by: Johnathan Mantey <johnathanx.mantey@intel.com>
show more ...
|
85134117 | 23-Aug-2024 |
George Liu <liuxiwei@ieisystem.com> |
Fix defaulted-function-deleted
warning error: ``` ../settings.hpp:29:42: note: replace 'default' with 'delete' 29 | Objects& operator=(const Objects&) = default; |
Fix defaulted-function-deleted
warning error: ``` ../settings.hpp:29:42: note: replace 'default' with 'delete' 29 | Objects& operator=(const Objects&) = default; | ^~~~~~~ | delete ```
Signed-off-by: George Liu <liuxiwei@ieisystem.com> Change-Id: Ib2326f58aad1b8c296668a69ac8fa165954ea942
show more ...
|
656ae3c5 | 23-Aug-2024 |
George Liu <liuxiwei@ieisystem.com> |
Remove unused variables
Using clang-tidy, it was detected that some variables are no longer in use. This commit remove unused variables.
Signed-off-by: George Liu <liuxiwei@ieisystem.com> Change-Id
Remove unused variables
Using clang-tidy, it was detected that some variables are no longer in use. This commit remove unused variables.
Signed-off-by: George Liu <liuxiwei@ieisystem.com> Change-Id: I382e6ce07e66dc5ad082be9b36d217a037e609b5
show more ...
|
1318a5ed | 16-Aug-2024 |
Patrick Williams <patrick@stwcx.xyz> |
clang-format: re-format for clang-18
clang-format-18 isn't compatible with the clang-format-17 output, so we need to reformat the code with the latest version. The way clang-18 handles lambda forma
clang-format: re-format for clang-18
clang-format-18 isn't compatible with the clang-format-17 output, so we need to reformat the code with the latest version. The way clang-18 handles lambda formatting also changed, so we have made changes to the organization default style format to better handle lambda formatting.
See I5e08687e696dd240402a2780158664b7113def0e for updated style. See Iea0776aaa7edd483fa395e23de25ebf5a6288f71 for clang-18 enablement.
Change-Id: I01547e98d27910919e09ebf7907c86292a6c825d Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
show more ...
|