dbus-sdr: define the global const LUN parameter

- Define global const LUN number parameter to make code more readable

Signed-off-by: Harvey Wu <Harvey.Wu@quantatw.com>
Change-Id: Iea513b5e10d2be9cb

dbus-sdr: define the global const LUN parameter

- Define global const LUN number parameter to make code more readable

Signed-off-by: Harvey Wu <Harvey.Wu@quantatw.com>
Change-Id: Iea513b5e10d2be9cba3c24f5374c8934ad563d91

show more ...

fix sdr count when number > 255

- After PR-60906, it will count the fru data and type 12 sensors.
But when SDR count > 255, there are some problems.

- If the lun of cmd isn't 0, the start positio

fix sdr count when number > 255

- After PR-60906, it will count the fru data and type 12 sensors.
But when SDR count > 255, there are some problems.

- If the lun of cmd isn't 0, the start position of recordID need to be
updated.
- Using if condition to add type 12 sensors. Because if sensor number
+ fru device is 254, it will overflow after adding 2 type 12 sensors.
- The type of sdrCount is uint8, which means the maximum value is 255,
so it needs to break while loop if the count reaches 255.

refs:
https://gerrit.openbmc.org/c/openbmc/phosphor-host-ipmid/+/60906

TEST:
root@bmc:~# ipmitool sdr elist | wc -l
281 => 0x119
root@bmc:~# ipmitool sdr elist all | wc -l
295 => 0x127

Before:
root@bmc:~# ipmitool raw -l 0 0x04 0x20 0x00
ff 83 c8 56 a2 63
root@bmc:~# ipmitool raw -l 0 0x04 0x20 0x01 ERROR
27 83 c8 56 a2 63
=> count overflow
root@bmc:~# ipmitool raw -l 1 0x04 0x20 0x00
1a 83 c8 56 a2 63
root@bmc:~# ipmitool raw -l 1 0x04 0x20 0x01 ERROR
1c 83 c8 56 a2 63
=> doesn't count the fru data

After:
root@bmc:~# ipmitool raw -l 0 0x04 0x20 0x00
ff 83 3e 2c a3 63
root@bmc:~# ipmitool raw -l 0 0x04 0x20 0x01
ff 83 3e 2c a3 63
root@bmc:~# ipmitool raw -l 1 0x04 0x20 0x00
1a 83 3e 2c a3 63
root@bmc:~# ipmitool raw -l 1 0x04 0x20 0x01
28 83 3e 2c a3 63

If count < 255,
root@bmc:~# ipmitool sdr elist | wc -l
151
root@bmc:~# ipmitool sdr elist all | wc -l
165
root@bmc:~# ipmitool raw -l 0 0x04 0x20 0x00
97 81 f0 2b a2 63
root@bmc:~# ipmitool raw -l 0 0x04 0x20 0x01
a5 81 f0 2b a2 63

Signed-off-by: Harvey Wu <Harvey.Wu@quantatw.com>
Change-Id: Ic4645c82d85e154bea5dc7fdd6b54d1331e58c36

show more ...

chassishandler: Read chassis intrusion status

This patch supports reading chassis intrusion status from "Status"
property under xyz.openbmc_project.Chassis.Intrusion on Dbus and
shows it to "Chassis

chassishandler: Read chassis intrusion status

This patch supports reading chassis intrusion status from "Status"
property under xyz.openbmc_project.Chassis.Intrusion on Dbus and
shows it to "Chassis Intrusion" field of ipmi command "chassis status".
This is corresponding to patch:
https://gerrit.openbmc.org/c/openbmc/dbus-sensors/+/61433 which modifies
dbus-sensors intrusionsensor object path.

Tested:
$ ipmitool chassis status | grep -i "Chassis Intrusion"
Chassis Intrusion: active means "HardwareIntrusion"
Chassis Intrusion: inactive means "Normal"

Signed-off-by: Chau Ly <chaul@amperecomputing.com>
Change-Id: Ieef0d8d7a70bbb7472125cdf04d3687926b333c5

show more ...

Correct the dhcp object path

Due to the path of the dhcp has been changed from
`/xyz/openbmc_project/network/config/dhcp` to
`/xyz/openbmc_project/network/dhcp`.

See:
https: //gerrit.openbmc.org/c/

Correct the dhcp object path

Due to the path of the dhcp has been changed from
`/xyz/openbmc_project/network/config/dhcp` to
`/xyz/openbmc_project/network/dhcp`.

See:
https: //gerrit.openbmc.org/c/openbmc/phosphor-networkd/+/58725
Change-Id: I90c8acbbb532fae2a50c56a255a2236a9faa051f
Signed-off-by: Jian Zhang <zhangjian.3032@bytedance.com>

show more ...

apphandler: add firmware version aux bytes parsing

Default regex string only tries to match Major and Minor version.

To match more firmware version info, platforms need to define it own
regex strin

apphandler: add firmware version aux bytes parsing

Default regex string only tries to match Major and Minor version.

To match more firmware version info, platforms need to define it own
regex string to match more strings, and assign correct mapping index in
matches array.

matches[0]: matched index for major ver
matches[1]: matched index for minor ver
matches[2]: matched index for aux[0] (set 0 to skip)
matches[3]: matched index for aux[1] (set 0 to skip)
matches[4]: matched index for aux[2] (set 0 to skip)
matches[5]: matched index for aux[3] (set 0 to skip)

Test Results:
```
regex = "([\d]+).([\d]+).([\d]+)-dev-([\d]+)-g([0-9a-fA-F]{2})([0-9a-fA-F]{2})([0-9a-fA-F]{2})([0-9a-fA-F]{2})"
matches = {1,2,5,6,7,8}
version = 2.14.0-dev-750-g37a7c5ad1-dirty
^ ^ ^ ^ ^ ^ ^ ^
| | | | | | | |
| | | | | | | |-- Aux byte 3 (0xAD), index 8
| | | | | | |---- Aux byte 2 (0xC5), index 7
| | | | | |------ Aux byte 1 (0xA7), index 6
| | | | |-------- Aux byte 0 (0x37), index 5
| | | |------------- Not used, index 4
| | |------------------- Not used, index 3
| |---------------------- Minor (14), index 2
|------------------------ Major (2), index 1
```

rev.major: 2
rev.minor: 14
rev.aux[0]: 55 (0x37)
rev.aux[1]: 167 (0xA7)
rev.aux[2]: 197 (0xC5)
rev.aux[3]: 173 (0xAD)

Change-Id: I01c4d6b7468cea04d5046bbc4a60c4db20a7f2a9
Signed-off-by: Potin Lai <potin.lai@quantatw.com>

show more ...

apphandler: fix wrong usage of regex_search()

Original intension of doing regex_search in `while` loop was tring to
found all possibile matchies, but it require move the begining of
string each time

apphandler: fix wrong usage of regex_search()

Original intension of doing regex_search in `while` loop was tring to
found all possibile matchies, but it require move the begining of
string each time manually, and it also hard to decide how long need to
moved.

Change to use `if` to only convert the first matchies found, and return
when any convertion failed.

Change-Id: I050d7f0457b36632c5c8a827f53082542c5f6691
Signed-off-by: Potin Lai <potin.lai@quantatw.com>

show more ...

Add compact sensor data record and fix sdr count

Description
- Commit added compact sensor data record structure
- Total sdr count from get sdr list and get device sdr
info mismatch
- Fixed by added

Add compact sensor data record and fix sdr count

Description
- Commit added compact sensor data record structure
- Total sdr count from get sdr list and get device sdr
info mismatch
- Fixed by added condtion to check fru data record,
type12 record and sdrcount increamented
- Also added condition for compact sensor data record count
- get device sdr info command, keep reading record in while. As
"getSensorDataRecord" handler function adds record in end, everytime
record vector keeps growing. So get device info command keep reading the
same record and end up with wrong sdr count
- Changed code to add record in begin everytime

Tested
Successfully built and tested in reference platform. SDR count from
both get sdr list and get device sdr info matches.

$ ipmitool raw 0x04 0x20 0x01
e6 81 7d 01 00 00
$ ipmitool sdr elist all | wc -l
230

$ ipmitool raw 0x04 0x20 0x00
c8 81 7d 01 00 00
$ ipmitool sensor list | wc -l
200

Change-Id: Ifd76a53485de8d92af955e2bb4d4268b3e891110
Signed-off-by: selvaganapathi <selvaganapathim@ami.com>

show more ...

update return type of getDHCPEnabled function

In the phosphor-dbus-interfaces, the DHCPEnabled property has been
changed from bool to enum type. Therefore, the getDHCPEnabled function
has to be upda

update return type of getDHCPEnabled function

In the phosphor-dbus-interfaces, the DHCPEnabled property has been
changed from bool to enum type. Therefore, the getDHCPEnabled function
has to be updated to adapt to phosphor-dbus-interfaces.

Tested:
1. Request to active dhcp successfully
$ipmitool dcmi set_conf_param activate_dhcp

Change-Id: I0cd2ce3ab78c3e4d2f376a99ab1ebf33b0ea39d3
Signed-off-by: Thang Tran <thuutran@amperecomputing.com>

show more ...

apphandler: use regex to parse firmware version

1. Use regular expression to parse firmware major & minor version.
2. Add meson option to modify regex string by platform layer.

Tested result:

- pa

apphandler: use regex to parse firmware version

1. Use regular expression to parse firmware major & minor version.
2. Add meson option to modify regex string by platform layer.

Tested result:

- parsing result of version 1: v0.6-19-gf363f61-dirty
rev.major = 0
rev.minor = 6

- parsing result of version 2: v1.99.10-113-g65edf7d-r3-0-g9e4f715
rev.major = 1
rev.minor = 99

- parsing result of version 3: 2.14.0-dev
rev.major = 2
rev.minor = 14

Change-Id: I1a5ebd592e3078d38182926a6a9ee98a129c3ee4
Signed-off-by: Potin Lai <potin.lai@quantatw.com>

show more ...

dbus-sdr: Look for ObjectManagers on /xyz/openbmc_project/vr

There are event-only voltage regular control sensors using the code
merged in https://gerrit.openbmc.org/q/hashtag:dbus-sdr-vr-sensors
th

dbus-sdr: Look for ObjectManagers on /xyz/openbmc_project/vr

There are event-only voltage regular control sensors using the code
merged in https://gerrit.openbmc.org/q/hashtag:dbus-sdr-vr-sensors
that install ObjectManagers at /xyz/openbmc_project/vr.

In commit 9a9ac0bcfc2df48873ca0f9725eb5255f7191d84, dbus-sdr was updated
to only look for ObjectManagers located at and under
/xyz/openbmc_project/sensors. This broke the VR daemon as the VR
controls now do not appear in `ipmitool sdr elist event`.

The reason is, before the above commit, dbus-sdr looked for
ObjectManagers located at and under the root path, which involved
both /xyz/openbmc_project/sensors and /xyz/openbmc_project/vr. After the
move, /vr got left out.

This change adds /vr back, so dbus-sdr looks for ObjectManagers on both
paths.

Tested: `ipmitool sdr elist event` makes the VR daemon's event-only IPMI
sensors show up again.

Signed-off-By: Sui Chen <suichen@google.com>
Change-Id: Icab98137a0115e1c5a482cc97598f7dd66d26bfc

show more ...

Revoking the GetUserAccess privilege for Operator

In IPMITOOL, operator can see all the accounts for "user list 3" command. This
poses a security issue. It not consistent with Redfish beheviour wher

Revoking the GetUserAccess privilege for Operator

In IPMITOOL, operator can see all the accounts for "user list 3" command. This
poses a security issue. It not consistent with Redfish beheviour where the
Operator user is unable to view other users. This change revokes the Operator
to see other users over IPMITOOL.

Tested: Operator unable to view the users through IPMI
ipmitool -I lanplus -H <ip-address> -U <userid> -P <password> -L Operator -C 17 user list 3
IPMI command failed: Insufficient privilege level

Change-Id: I5b200a85662a05bfdf1fce395e7acff6bbf1a22e
Signed-off-by: Ankita Prasad <ankita.prasad@intel.com>

show more ...

channel-config: reduce logspam

If a channel isn't configured in the channel_config, it is initialized
with `isChValid = false`, which effectively disables it. Unfortunately,
the code was also emitt

channel-config: reduce logspam

If a channel isn't configured in the channel_config, it is initialized
with `isChValid = false`, which effectively disables it. Unfortunately,
the code was also emitting a warning log for every possible channel.
On Bletchley I was observing tens of these log messages every few
seconds, which is not particularly helpful. Delete the logspam.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ie130c8eb891476e26f25cafce94cb6522bc3a66e

show more ...

dbus-sdr: Revert sensor name modifications partially

With commit [1] the leaf of the D-Bus object path was stripped of
well known suffixes, in addition to that `_` was replaced by space.

Replacing

dbus-sdr: Revert sensor name modifications partially

With commit [1] the leaf of the D-Bus object path was stripped of
well known suffixes, in addition to that `_` was replaced by space.

Replacing `_` with space is not needed to solve the problem statement
[2]. For sensor names which are less than 16 characters, this creates
expectation differences on scripts which tried to validate the ipmitool
output.

[1] https://github.com/openbmc/phosphor-host-ipmid/commit/d950f410b71e0ac4650519eb5bf7ea683e98684d
[2] https://github.com/openbmc/intel-ipmi-oem/issues/4

Change-Id: If7028e517385ebfc1fc3541a6c23d559ad0c8d69
Signed-off-by: Tom Joseph <rushtotom@gmail.com>

show more ...

Update instructions for SetLanOem and GetLanOem

Refreshed the comment describing how to add OEM commands to the Set
Lan Configuration and Get Lan Configuration functions.

Changing to the Meson buil

Update instructions for SetLanOem and GetLanOem

Refreshed the comment describing how to add OEM commands to the Set
Lan Configuration and Get Lan Configuration functions.

Changing to the Meson build system altered the method.

Tested:
Nothing to test with regard to this commit as it is only altering
documentaton.

Change-Id: I4ec36b5f8b211cf3f1bcec0422e8f1fa71124dc4
Signed-off-by: Johnathan Mantey <johnathanx.mantey@intel.com>

show more ...

sensorhander: Create overrides for SensorDataEventRecordBody

set_id_strlen + set_id_type does not have function to support
SensorDataEventRecordBody, but is currently being used.

Without it the bui

sensorhander: Create overrides for SensorDataEventRecordBody

set_id_strlen + set_id_type does not have function to support
SensorDataEventRecordBody, but is currently being used.

Without it the build failed like the following
```
../dbus-sdr/sensorcommands.cpp: In function 'bool ipmi::constructVrSdr(Context::ptr, const std::unordered_set<std::__cxx11::basic_string<char> >&, uint16_t, uint16_t, const std::string&, const std::string&, get_sdr::SensorDataEventRecord&)':
../dbus-sdr/sensorcommands.cpp:1916:44: error: cannot convert 'get_sdr::SensorDataEventRecordBody*' to 'get_sdr::SensorDataFullRecordBody*'
1916 | get_sdr::body::set_id_strlen(nameSize, &record.body);
| ^~~~~~~~~~~~
| |
| get_sdr::SensorDataEventRecordBody*
In file included from ../include/dbus-sdr/storagecommands.hpp:18,
from ../dbus-sdr/sensorcommands.cpp:21:
../sensorhandler.hpp:572:66: note: initializing argument 2 of 'void get_sdr::body::set_id_strlen(uint8_t, get_sdr::SensorDataFullRecordBody*)'
572 | inline void set_id_strlen(uint8_t len, SensorDataFullRecordBody* body)
| ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~
../dbus-sdr/sensorcommands.cpp:1917:35: error: cannot convert 'get_sdr::SensorDataEventRecordBody*' to 'get_sdr::SensorDataFullRecordBody*'
1917 | get_sdr::body::set_id_type(3, &record.body); // "8-bit ASCII + Latin 1"
| ^~~~~~~~~~~~
| |
| get_sdr::SensorDataEventRecordBody*
../sensorhandler.hpp:581:65: note: initializing argument 2 of 'void get_sdr::body::set_id_type(uint8_t, get_sdr::SensorDataFullRecordBody*)'
581 | inline void set_id_type(uint8_t type, SensorDataFullRecordBody* body
```

Change-Id: Ic780a1f848a9e6bcea79fd9822539184d1d985cf
Signed-off-by: Willy Tu <wltu@google.com>

show more ...

Specify "8-bit ASCII + Latin 1" SDR encoding

Applications using OpenSolaris libipmi can't handle "Unicode" (type 0)
encoding for the sensor names [0].

This results in issues with VMWare ESXi which

Specify "8-bit ASCII + Latin 1" SDR encoding

Applications using OpenSolaris libipmi can't handle "Unicode" (type 0)
encoding for the sensor names [0].

This results in issues with VMWare ESXi which uses IPMI to fetch sensor
data from the BMC, all the names are shown as "Unspecified 1" (if
default EntityId is used), so status page, SEL entries and the logs
become very confusing.

Fix this by telling it to process all bytes as is by using "8-bit ASCII
+ Latin 1" type.

The patch is untested however similar changes to intel-ipmi-oem were
tried with VMWare ESXi 7.0 Update 2 and regular ipmitool (using GNU
FreeIPMI), both show names correctly.

[0] https://github.com/kofemann/opensolaris/blob/master/usr/src/lib/libipmi/common/ipmi_util.c#L258

Signed-off-by: Paul Fertser <fercerpav@gmail.com>
Change-Id: Idf19833e4877af1acb32f016e85e93c6f58df27e

show more ...

Report IPMI session IDs for active IPMI sessions

The Get Session Info command failed to return the session ID for the
session requested. Instead it always returned the value of the last
record proce

Report IPMI session IDs for active IPMI sessions

The Get Session Info command failed to return the session ID for the
session requested. Instead it always returned the value of the last
record processed.

This commit returns the correct session ID for the requested record.

Tested:
Created multiple 'ipmitool shell' or 'ipmitool sol' sessions
Used 'ipmitool raw 6 0x3d <rec-num>' to iterate over each session.
0 to <rec-num>
Used 'ipmitool session info all' to get a human friendly output.

Prior to this commit 'session info all' returned a single session ID
value for all records:
session handle : 1

Now the session handle reports the value created by the BMC:
session handle : 129
The session handle is unique for each active 'shell'/'sol'

Change-Id: Ied35f021a18ca302b5285d56bf9b51b3ebc52543
Signed-off-by: Johnathan Mantey <johnathanx.mantey@intel.com>

show more ...

prettier: re-format

Prettier is enabled in openbmc-build-scripts on Markdown, JSON, and YAML
files to have consistent formatting for these file types. Re-run the
formatter on the whole repository.

prettier: re-format

Prettier is enabled in openbmc-build-scripts on Markdown, JSON, and YAML
files to have consistent formatting for these file types. Re-run the
formatter on the whole repository.

Change-Id: I2e1710e269896e36a8bd864cfc81ff3b1c033222
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

beautysh: re-format

beautysh is enabled in the openbmc-build-scripts on Bash/Zsh/POSIX-sh
files to have a consistent formatting. Re-run the formatter on the
whole repository.

Change-Id: I9c071e3f5

beautysh: re-format

beautysh is enabled in the openbmc-build-scripts on Bash/Zsh/POSIX-sh
files to have a consistent formatting. Re-run the formatter on the
whole repository.

Change-Id: I9c071e3f54f64275284bcaa78966226bd05eb665
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

black: re-format

black and isort are enabled in the openbmc-build-scripts on Python files
to have a consistent formatting. Re-run the formatter on the whole
repository.

Change-Id: I6c39862420de0e0

black: re-format

black and isort are enabled in the openbmc-build-scripts on Python files
to have a consistent formatting. Re-run the formatter on the whole
repository.

Change-Id: I6c39862420de0e038e69e2409f9f9e70cac4e6b9
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

python: fix flake8 warnings and format with black

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I1b29b18431abc3985c8a2ebe8c0632e39776f5ae

shellcheck: fix minor issues

A few scripts were missing the proper #! which identified them
as shell scripts. Fixed this and the shellcheck errors that ended
up being raised.

Signed-off-by: Patric

shellcheck: fix minor issues

A few scripts were missing the proper #! which identified them
as shell scripts. Fixed this and the shellcheck errors that ended
up being raised.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I867786c5821b4bd0ef4b50de03c893a71301142b

show more ...

Extended support for 16bit logic bus

This commit will add the support of 16 bit logical bus.

Tested :
all EEPROM fru getting listed Successfully which were connected
to 8 and 16 bit logical bus.

d

Extended support for 16bit logic bus

This commit will add the support of 16 bit logical bus.

Tested :
all EEPROM fru getting listed Successfully which were connected
to 8 and 16 bit logical bus.

dependent commit:-
https://gerrit.openbmc.org/c/openbmc/entity-manager/+/58634

Signed-off-by: krishnar4 <krishnar@ami.com>
Change-Id: I547ef8a27fdc74ec34a421c4cf5949c29fcc77b4

show more ...

Revert "user_mgmt: Fix SEGV on 64bit"

This reverts commit 05703adfe2bf70945d2befa8a7beda4ce5e5182a.

Due to we found that root cause about SEGV on 64bit and after modify
in pam-ipmit then SEGV on 64

Revert "user_mgmt: Fix SEGV on 64bit"

This reverts commit 05703adfe2bf70945d2befa8a7beda4ce5e5182a.

Due to we found that root cause about SEGV on 64bit and after modify
in pam-ipmit then SEGV on 64bit will not happen anymore.

Thus, we submitted this commit in gerrit in pam-ipmi as below:
https://gerrit.openbmc.org/c/openbmc/pam-ipmi/+/58579

Root cause:
There is default ipmi_pass file be created and encrypted in 32bit
environment from pam-ipmi original design before.
According the failed message, we found that PAM_AUTHTOK_ERR return
from update_pass_special_file() function that cause ipmid got bad
authentication token. Seems this file cannot be used in 64bit
environment by default that will cause ipmitool user set password
got failed.

Solution:
According current pam-ipmi design that already consider if this file
does not exist then BMC will create it once a user in the ipmi group
has been added. There should not be any file there by default.
Thus, there is no need for this file.
Without install this file by default then ipmitool command successful.

Thus, this default ipmi_pass file that will cause SEGV in host-ipmid on
64 bit project. After remove this default file, SEGV crash issue in
host-ipmid symptom was gone.

BTW, there is another issue we found that
“ipmitool user set password 1 0penBmc0” command failed.
Due to pam-ipmi still use size_t structure, but host-ipmid already
change to use uint32_t structure for MetaPassStruct.

Thus, we need to revert your commit and remove ipmi_pass file in
pam-ipmi for fixing two issues.

Verified:
root@evb-npcm845:~# ipmitool user set password 1 0penBmc0
Set User Password command successful (user 1)

Signed-off-by: Tim Lee <timlee660101@gmail.com>
Change-Id: I03ba57a9006694a09b75c16d897377b1b57051e5

show more ...

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are for:
* bus_t
* exception_t
* manager_t
* match_t
* message_t
* object_t
* slot_t

Change-Id: I2284ffdeafce8f319fe6d00417954c6fc80a37d1
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...