Watchdog: Add Notlog setting function

Add function to set Notlog property to implement the function of
the watchdog not recording logs.

Related commit:
https://gerrit.openbmc.org/c/openbmc/phosphor

Watchdog: Add Notlog setting function

Add function to set Notlog property to implement the function of
the watchdog not recording logs.

Related commit:
https://gerrit.openbmc.org/c/openbmc/phosphor-dbus-interfaces/+/66240
https://gerrit.openbmc.org/c/openbmc/phosphor-watchdog/+/66242

Change-Id: Ia90c345a72f8f877aa8f8216337a1267f09b839a
Signed-off-by: Tim Chao <Tim.Chao@quantatw.com>

show more ...

dcmi: fix Get/Set Power Limit issues

Get Power Limit command:
Issue: The completion code byte always is 0x00
Root cause: In the getPowerLimit function, it is checking "pcapEnable"
is valid or

dcmi: fix Get/Set Power Limit issues

Get Power Limit command:
Issue: The completion code byte always is 0x00
Root cause: In the getPowerLimit function, it is checking "pcapEnable"
is valid or not instead checking the value of "pcapEnable".
Solution: checking the value of "pcapEnable" is true or false.

Set Power Limit command:
Issue: The length of command always false.
Root cause: the first reserved parameter is 3 bytes, not 2 bytes.
Solution: Add one more reserved byte.

Tested:
IPMI dcmi set/get power limit commands work well.

Change-Id: I3c97411d9e9c39498c0db64d37e6ca4458161b43
Signed-off-by: Thang Tran <thuutran@amperecomputing.com>

show more ...

apphandler: avoid aux version overwriteen by dev_id.json

Aux bytes are supportted get from software version by setting
`matches-map`. If matches-map defines Aux bytes indexes (not 0), then
skip aux

apphandler: avoid aux version overwriteen by dev_id.json

Aux bytes are supportted get from software version by setting
`matches-map`. If matches-map defines Aux bytes indexes (not 0), then
skip aux bytes assigned from dev_id.json.

Change-Id: I3cc5ca9b6fb19a81a1a0341ee5af5c70156b0976
Signed-off-by: Potin Lai <potin.lai@quantatw.com>

show more ...

more debug logs for ipmi OEM commands

- log IANA as unpacked from request
- log if the request was filtered
- log sucessful / unsucessful registering of OEM Command Handler

Tested: ipmid logs the e

more debug logs for ipmi OEM commands

- log IANA as unpacked from request
- log if the request was filtered
- log sucessful / unsucessful registering of OEM Command Handler

Tested: ipmid logs the expected messages.

Change-Id: If4387d2d1927768f697e29d2230d9e3491e8ed48
Signed-off-by: Alexander Hansen <alexander.hansen@9elements.com>

show more ...

Fix std::optional maybe-uninitialized (maybe?)

Attempt to fix the GCC waybe-uninitialized warning for unpackArgs. It
only triggers on compilation of one command handler
(ipmiSensorGetDeviceSdrInfo)

Fix std::optional maybe-uninitialized (maybe?)

Attempt to fix the GCC waybe-uninitialized warning for unpackArgs. It
only triggers on compilation of one command handler
(ipmiSensorGetDeviceSdrInfo) with a single std::optional<uint8_t> param.

The warning is a false positive (I think) but GCC seems to like it if we
get rid of the empty emplace() call in the underlying std::optional
unpack function.

Tested: Compiles in the unit-test docker environment when configured
with `meson setup --reconfigure build -Dwerror=true -Dwarning_level=3
--buildtype=debugoptimized`

Change-Id: Ida8b82dbf2227d3b5339cd4b5756729eeeea9e1d
Signed-off-by: Jonathan Doman <jonathan.doman@intel.com>

show more ...

Silence false positive for uninitialized variable

g++ sometimes complains that *inputArgs might be uninitialized
This is never the case. If the unpacker fails to fill every
item in unpackArgs, this

Silence false positive for uninitialized variable

g++ sometimes complains that *inputArgs might be uninitialized
This is never the case. If the unpacker fails to fill every
item in unpackArgs, this function returns early. So this is
just to silence the build.

Change-Id: Ic1e25127227e0b00ee962ba9949de534bdb8a6a2
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

show more ...

meson: add option for open-power functions

This repository has long had an open-power only function that ends
up compiled into all systems. We cannot use the phosphor-logging
generated errors, unle

meson: add option for open-power functions

This repository has long had an open-power only function that ends
up compiled into all systems. We cannot use the phosphor-logging
generated errors, unless we are able to disable this code on
non-open-power systems. Add necessary meson options.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Icd5b2f4cdec206597029930790ef2b10170d232a

show more ...

remove generated elog-errors.hpp

Remove the generated file and rely on the ones directly in
phosphor-logging.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ib56e3caadeabb0a7afdd2d7

remove generated elog-errors.hpp

Remove the generated file and rely on the ones directly in
phosphor-logging.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ib56e3caadeabb0a7afdd2d784dc2eb3fc8d1252c

show more ...

Fix for g++-13

g++-13 is complaining about a variable that may be getting
used prior to initialization. This is a false alarm, since
the only 'using' that the variable gets is assignment, but
it is

Fix for g++-13

g++-13 is complaining about a variable that may be getting
used prior to initialization. This is a false alarm, since
the only 'using' that the variable gets is assignment, but
it is simple enough to provide a default constructor to
get rid of the warning.

Change-Id: I3312149f32a9a605b522eb6f1f8d9afb982fb3c6
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

show more ...

ipmid: fru-reader: Use timegm instead of mktime

timegm is the inverse of gmtime. Currently, we are missing UTC time with
localtime when converting between timestamp and time string. This is not
an i

ipmid: fru-reader: Use timegm instead of mktime

timegm is the inverse of gmtime. Currently, we are missing UTC time with
localtime when converting between timestamp and time string. This is not
an issue when the localtime is the same as UTC.

This issue is detected when we change the timezone to PST/PDT with
https://gerrit.openbmc.org/c/openbmc/openbmc/+/58293
and the FRU EEPROM time does not match the expected Mfg Date anymore.

Required:
https://gerrit.openbmc.org/c/openbmc/ipmi-fru-parser/+/58446

Tested:
Fru EEPROM Mfg Time now is in the same (after timezone conversion)
between the raw data and FRU output.

Change-Id: I4c636b0044e1b2a6dd2c078b62f65665d4b1108c
Signed-off-by: Willy Tu <wltu@google.com>

show more ...

sensorcommands: avoid stringop-truncation warning

When compiling ipmi-fru-parser with GCC 13.2.0, I observed the
following:

```
../subprojects/phosphor-host-ipmid/dbus-sdr/sensorcommands.cpp:1748:1

sensorcommands: avoid stringop-truncation warning

When compiling ipmi-fru-parser with GCC 13.2.0, I observed the
following:

```
../subprojects/phosphor-host-ipmid/dbus-sdr/sensorcommands.cpp:1748:17: error: ‘char* __builtin_strncpy(char*, const char*, long unsigned int)’ specified bound 16 equals destination size [-Werror=stringop-truncation]
1748 | std::strncpy(record.body.id_string, name.c_str(),
```

Switch to a memcpy instead of a strncpy to avoid the warning.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I43d5cddd74cf1ad2d686e9529e87ec416e2bb6a0

show more ...

multiple ipmi shortname implementations

As ipmi subsystem requires short names, and there are multiple
ways to implement that, this patch provides compile-time configuration
options.

- shortname-r

multiple ipmi shortname implementations

As ipmi subsystem requires short names, and there are multiple
ways to implement that, this patch provides compile-time configuration
options.

- shortname-remove-suffix
- shortname-replace-words

Previously, PSU Sensor Names were stripped of some
suffixes, some of which uniquely identified the sensor.

e.g. "_Input_Voltage", "_Output_Voltage".
Without the suffix, the sensor cannot be uniquely identified.

Example: "PSU0_Input_Voltage", "PSU0_Output_Voltage"
both become "PSU0".

Tested:
- with both configurations turned off, name is only trucated
- with nothing configured, default config is applied and suffix is
removed (current behavior)
- word replacement enabled and suffix removal disabled: expected
behavior
- word replacement disabled and suffix removal enabled: expected
behavior

Change-Id: I01dd35f31e75df3c31733e9818884813a241440a
Signed-off-by: Alexander Hansen <alexander.hansen@9elements.com>

show more ...

Update DCMI Get/Set Config Parameters commands

DCMI Configuration Parameters commands were still using the old
IPMI API and blocking dbus calls. This updates them to use the new API
and yielding dbu

Update DCMI Get/Set Config Parameters commands

DCMI Configuration Parameters commands were still using the old
IPMI API and blocking dbus calls. This updates them to use the new API
and yielding dbus calls.

Tested: 'ipmitool dcmi get_conf_param' and
'ipmitool dcmi set_conf_param' work the same as before

Change-Id: Ib50118c2dd515c134c3206ee128be2d3e7ea7c81
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

show more ...

Update DCMI Get Sensor Reading command

DCMI Get Sensor Reading command was still using the old IPMI API and
blocking dbus calls. This updates it to use the new API and yielding
dbus calls.

Tested:

Update DCMI Get Sensor Reading command

DCMI Get Sensor Reading command was still using the old IPMI API and
blocking dbus calls. This updates it to use the new API and yielding
dbus calls.

Tested: 'ipmitool dcmi sensors' works the same as before

Change-Id: I0aef54ec581dcc98d536e7dfa31c473f16e82754
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

show more ...

update DCMI Get Power Reading command

DCMI Get Power Reading command was still using the old IPMI API and
blocking dbus calls. This updates it to use the new API and yielding
dbus calls.

Tested: 'i

update DCMI Get Power Reading command

DCMI Get Power Reading command was still using the old IPMI API and
blocking dbus calls. This updates it to use the new API and yielding
dbus calls.

Tested: 'ipmitool dcmi power reading' works the same as before

Change-Id: Id8b732bd6ebf2a4d7087fa6fb47edcf35f20fee8
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

show more ...

update DCMI Read Temperatures command

DCMI Read Temperatures command was still using the old IPMI API and
blocking dbus calls. This updates it to use the new API and yielding
dbus calls.

Tested: 'i

update DCMI Read Temperatures command

DCMI Read Temperatures command was still using the old IPMI API and
blocking dbus calls. This updates it to use the new API and yielding
dbus calls.

Tested: 'ipmitool dcmi get_temp_reading' works the same as before

Change-Id: If5d9fb190173c3ba864030aec4067708fc70eb08
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

show more ...

Update DCMI Get Capabilities command

DCMI Get Capabilities command was still using the old IPMI API and
blocking dbus calls. This updates it to use the new API and yielding
dbus calls.

Tested: 'ipm

Update DCMI Get Capabilities command

DCMI Get Capabilities command was still using the old IPMI API and
blocking dbus calls. This updates it to use the new API and yielding
dbus calls.

Tested: 'ipmitool dcmi discover' works the same as before

Change-Id: I8360fc8f6a5ec69031d219f55a1b5b37593b185c
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

show more ...

update DCMI management ctrl ID str commands

DCMI management controller ID string commands were still using the old
IPMI API and blocking dbus calls. This updates them to use the new API
and yielding

update DCMI management ctrl ID str commands

DCMI management controller ID string commands were still using the old
IPMI API and blocking dbus calls. This updates them to use the new API
and yielding dbus calls.

Tested: 'ipmitool dcmi get_mc_id_string' and
'ipmitool dcmi set_mc_id_string' work the same as before

Change-Id: I6bd6284e8f346e4a80d744c6824c5f2f914cd7f3
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

show more ...

Update DCMI asset tag commands

DCMI asset tag commands were still using the old IPMI API and
blocking dbus calls. This updates them to use the new API and
yielding dbus calls.

Tested: 'ipmitool dcm

Update DCMI asset tag commands

DCMI asset tag commands were still using the old IPMI API and
blocking dbus calls. This updates them to use the new API and
yielding dbus calls.

Tested: 'ipmitool dcmi asset_tag' and ipmitool dcmi set_asset_tag'
work the same as before

Change-Id: I0f6486fc3d9494628db12ddfe0afbd6afd967a91
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

show more ...

Update DCMI power limit commands

DCMI power limit commands were still using the old IPMI API and
blocking dbus calls. This updates them to use the new API and yielding
dbus calls.

Tested: ipmitool

Update DCMI power limit commands

DCMI power limit commands were still using the old IPMI API and
blocking dbus calls. This updates them to use the new API and yielding
dbus calls.

Tested: ipmitool power get_limit works the same as before

Change-Id: Ib71afac7dd840b7a413813ee050c5fa238716af5
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

show more ...

make isDCMIPowerMgmtSupported cache response

isDCMIPowerMgmtSupported is called a lot if any of the DCMI commands
are used, so it makes sense to cache the value rather than constantly
re-parsing the

make isDCMIPowerMgmtSupported cache response

isDCMIPowerMgmtSupported is called a lot if any of the DCMI commands
are used, so it makes sense to cache the value rather than constantly
re-parsing the JSON file, especially since it won't change except for
on a fw update.

Tested: DCMI power management commands continue to work as before.

Change-Id: Id0deb40c4a5332d5f96d7dda6d958f20925c01a9
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

show more ...

change to use non-deprecated dcmi group value

All new code should be using the constants from the
new API, rather than the old code. This is a minor change
to remove usage of the DCMI group value fr

change to use non-deprecated dcmi group value

All new code should be using the constants from the
new API, rather than the old code. This is a minor change
to remove usage of the DCMI group value from all internal
phosphor-ipmi-host code.

Change-Id: Ib4b44bbb4a40945639eeb0f72e817f3dc716903b
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

show more ...

meson_options.txt: Support for reading options from meson.options

Support has been added for reading options from meson.options instead
of meson_options.txt[1]. These are equivalent, but not using t

meson_options.txt: Support for reading options from meson.options

Support has been added for reading options from meson.options instead
of meson_options.txt[1]. These are equivalent, but not using the .txt
extension for a build file has a few advantages, chief among them
many tools and text editors expect a file with the .txt extension to
be plain text files, not build scripts.

[1] https://mesonbuild.com/Release-notes-for-1-1-0.html#support-for-reading-options-from-mesonoptions

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I621a1d4139a00aa5044e586fbe1163b35563cad9

show more ...

Mark created SEL entries as 'IPMI generated'

SEL logger service can receive messages from many different
sources. To differentiate IPMI generated messages from all of
the others mark created SEL ent

Mark created SEL entries as 'IPMI generated'

SEL logger service can receive messages from many different
sources. To differentiate IPMI generated messages from all of
the others mark created SEL entries as 'IPMI generated'.

Change-Id: I15c1dcf47c5a5e59e62c2fb66d3b97573959bf26
Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>

show more ...

update Get System GUID to use yielding calls

The Get System GUID handler was using blocking calls
This updates it to use yielding calls instead.

Tested: run 'ipmitool raw 6 0x37' to verify that it

update Get System GUID to use yielding calls

The Get System GUID handler was using blocking calls
This updates it to use yielding calls instead.

Tested: run 'ipmitool raw 6 0x37' to verify that it returns the
value hosted by xyz.openbmc_project.Common.UUID under
/xyz/openbmc_project/inventory

Change-Id: Ifcd65c195d5ff684177b6d7f3f1eb5dbe61c24d2
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

show more ...