dbus-sdr: support Get Temperature Readings command

This commit support Get Temperature Readings command in the
dynamicsensor library.

The design follows teps:
- Get the list of sensors based on Ent

dbus-sdr: support Get Temperature Readings command

This commit support Get Temperature Readings command in the
dynamicsensor library.

The design follows teps:
- Get the list of sensors based on Entity Id
- Sort the list of sensors.
- Loop all of sensors in the list, if its Entity Instance is greater
than the Instance Start then read the temperature via object path.

Tested:
1. Request to read Temperature of sensors
"ipmitool dcmi get_temp_reading"
2. Display Entity Id, Entity Instance, Temperature of sensors

Change-Id: Iaa7d65a763dacb50c1488d2a161b180fed49899b
Signed-off-by: Thang Tran <thuutran@amperecomputing.com>

show more ...

dbus-sdr: check instance start value in getSensorInfo function

Issue: When users request to read DCMI sensor information via "ipmitool
raw 0x2c 0x07 0xdc 0x01 0x07 0x00 <Instance_start>", the return

dbus-sdr: check instance start value in getSensorInfo function

Issue: When users request to read DCMI sensor information via "ipmitool
raw 0x2c 0x07 0xdc 0x01 0x07 0x00 <Instance_start>", the return values
always are 8 first sensors even the "Instance_start" is not 0.

Root cause: In the getSensorInfo function, it does not check the
instance start parameter. It always returns 8 first sensors.

Solution: Update the getSensorInfo function as below:
- Get the list of Sensors based on the Entity ID.
- Sort the list of Sensors.
- Compare Sensor's Entity Instance with Instance start parameter

Tested:
1. Get the list of DCMI sensors information with Instance start
is not 0
"ipmitool raw 0x2c 0x07 0xdc 0x01 0x07 0x00 <Ins_Start>"
2. BMC returns sensor Record ID which have the Entity Instance
are greater than Instance start.

Change-Id: I10f7cf4e87cb5eb8fe1da81561263e1604418c45
Signed-off-by: Thang Tran <thuutran@amperecomputing.com>

show more ...

dbus-sdr: sel: Fix dst setting

Use the day time saving information on the system to calculate the time
instead of zero (no dst) as the default.

https://linux.die.net/man/3/mktime

Failure Example,

dbus-sdr: sel: Fix dst setting

Use the day time saving information on the system to calculate the time
instead of zero (no dst) as the default.

https://linux.die.net/man/3/mktime

Failure Example,
```
$ stat /var/log/ipmi_sel
File: /var/log/ipmi_sel
Size: 88 Blocks: 8 IO Block: 4096 regular file
Device: 1bh/27d Inode: 4125 Links: 1
Access: (0644/-rw-r--r--) Uid: ( 0/ root) Gid: ( 0/ root)
Access: 2023-09-25 14:37:03.631424968 -0700
Modify: 2023-09-25 14:37:02.291422780 -0700
Change: 2023-09-25 14:37:02.291422780 -0700

$ ipmitool sel
SEL Information
Version : 1.5 (v1.5, v2 compliant)
Entries : 0
Free Space : 65535 bytes or more
Percent Used : unknown
Last Add Time : 09/25/23 14:30:08 PDT
Last Del Time : Not Available
Overflow : false
Supported Cmds : 'Reserve'

$ ipmitool sel list
1 | 09/25/23 | 15:30:07 PDT | reserved #0xff | | Asserted
```

Tested:
Fixed the timezone issues
```
$ ipmitool sel list
1 | 09/25/23 | 14:30:07 PDT | reserved #0xff | | Asserted
```

Change-Id: I23bdb5039bed8e135f06d399a5e970bbc1e5ed58
Signed-off-by: Willy Tu <wltu@google.com>

show more ...

Watchdog: Add watchdog LogTimeout property setting function

Add function to set LogTimeout property to implement the function of
the watchdog not recording logs.

Tested:
No log bit is set to true :

Watchdog: Add watchdog LogTimeout property setting function

Add function to set LogTimeout property to implement the function of
the watchdog not recording logs.

Tested:
No log bit is set to true :
ipmitool raw 0x06 0x24 0x84 0x00 0x00 0x3e 0x64 0x00

No log bit is set to false :
ipmitool raw 0x06 0x24 0x04 0x00 0x00 0x3e 0x64 0x00

Reset watchdog timer :
ipmitool mc watchdog reset

If the LogTimeout property is true, the event will be logged
on watchdog expiration.
We can use 'ipmitool sel elist' to check the system event log.
1 | 01/26/23 | 00:21:21 PST | Watchdog2 host0 | Timer expired | Asserted

If the LogTimeout property is false, the event will not be
logged when the watchdog expires.

Related-Commit-Id: 66240
Related-Commit-Id: 67727

Change-Id: I9cf9a294be7f584760dc03efaab02384f17e4686
Signed-off-by: Tim Chao <Tim.Chao@quantatw.com>

show more ...

Update terminology used within repo

Update the terms to more inclusive language. This change if only for
variables used in the repo.

Change-Id: I5151c9c2efab707b5dbc707e55333a3cb8c4e32b
Signed-off-

Update terminology used within repo

Update the terms to more inclusive language. This change if only for
variables used in the repo.

Change-Id: I5151c9c2efab707b5dbc707e55333a3cb8c4e32b
Signed-off-by: Matt Simmering <matthew.simmering@intel.com>

show more ...

dbus-sdr: support reading OEM SEL logs

This commit supports reading OEM SEL record type in range 0xC0-0xDF and
0xE0-0xFF.

Tested:
Request to show SEL logs, OEM SEL log is shown.

Change-Id: I8e

dbus-sdr: support reading OEM SEL logs

This commit supports reading OEM SEL record type in range 0xC0-0xDF and
0xE0-0xFF.

Tested:
Request to show SEL logs, OEM SEL log is shown.

Change-Id: I8e2d2d84143c79cb7e3575c3f713d2b3ad2aaaf7
Signed-off-by: Thang Tran <thuutran@amperecomputing.com>

show more ...

Rewrite Read Event Buffer to use new API

Lots of hard-coded values in this one, but one value did get replaced
with a lookup. The output matches previous output with the one exception
that now the c

Rewrite Read Event Buffer to use new API

Lots of hard-coded values in this one, but one value did get replaced
with a lookup. The output matches previous output with the one exception
that now the current manufacturer is used instead of a hard-coded value.

Tested: run ipmitool raw 6 0x35 and check the output
Before:
ipmitool raw 6 0x35
55 55 c0 41 a7 00 00 00 00 00 3a ff 00 ff ff ff
After:
ipmitool raw 6 0x35
55 55 c0 57 01 00 00 00 00 00 3a ff 00 ff ff ff

Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>
Change-Id: I4910d8ee07db6f24d639f9322a0246e10a0260e3

show more ...

Fix the bugs found in static analysis

This commit fixes the following static analyzer reported issues:

Operands don't affect result
some conditions are not required to check as its always true

Fix the bugs found in static analysis

This commit fixes the following static analyzer reported issues:

Operands don't affect result
some conditions are not required to check as its always true
Unsigned compared against 0
Unchecked return value from library
Uninitialized scalar variable

Change-Id: I0b1fd426794bb88f6eafcc817cef5dd2f655e1ba
Signed-off-by: PavanKumarIntel <pavanx.kumar.martha@intel.com>

show more ...

user_channel: strlen isn't constexpr

Change-Id: Id08b03dc487a1c772fa39459cc4e6e3138675910
Signed-off-by: Peter Foley <pefoley@google.com>

unpack: Support std::span as package arguments

Change-Id: Iae594c0d1b10e96dd4fd1a83cdf60c0757f9f3bd
Signed-off-by: Willy Tu <wltu@google.com>

dbus-sdr: remove redundant Get/Set SEL time commands

In the dbus-sdr, the Set SEL time command is not implemented, it is an
dummy function. Beside that the Get SEL command does not refer to dbus
int

dbus-sdr: remove redundant Get/Set SEL time commands

In the dbus-sdr, the Set SEL time command is not implemented, it is an
dummy function. Beside that the Get SEL command does not refer to dbus
interface to get the SEL time, it is geting directly from hardware.

Both Set/Get SEL time commands are implemented in storagehandler.cpp
file, therefore, we should remove redundant commands in the dbus-sdr.

Tested:
1. Disable NTP
$timedatectl set-ntp false
2. Request to Set SEL time
$ipmitool sel time set "12/31/2020 12:00:00"
12/31/20 00:00:00 UTC
3. Request to Get SEL time
$ipmitool sel time get
12/31/20 00:00:03 UTC

Change-Id: I8545d4a604c2f01f5c771be99cff9a638d08d54d
Signed-off-by: Thang Tran <thuutran@amperecomputing.com>

show more ...

types: Support allocator rebinding

Avoid build failures with libc++ like:
include/c++/v1/vector:407:19: error: static assertion failed due to requirement 'is_same<ipmi::SecureAllocator<unsigned char

types: Support allocator rebinding

Avoid build failures with libc++ like:
include/c++/v1/vector:407:19: error: static assertion failed due to requirement 'is_same<ipmi::SecureAllocator<unsigned char>, std::allocator<unsigned char>>::value': [allocator.requirements] states that rebinding an allocator to the same type should result in the original allocator
407 | static_assert(is_same<allocator_type, __rebind_alloc<__alloc_traits, value_type> >::value,

Change-Id: I6f9637e2177669dce3509243135135a1b73fa9fe
Signed-off-by: Peter Foley <pefoley@google.com>

show more ...

subprojects: ignore redirected wrap files

We shouldn't have wrap-redirect files committed.

Change-Id: I6ae7c14ecc3edf3d9a11f6efd281c005afd7a05a
Signed-off-by: Peter Foley <pefoley@google.com>

transporthandler: Split constants into a standalone header.

In environments that disable exceptions, it's problematic to have
headers that depend on exceptions being enabled.
Split constant values o

transporthandler: Split constants into a standalone header.

In environments that disable exceptions, it's problematic to have
headers that depend on exceptions being enabled.
Split constant values out of transporthandler.hpp so that they can be
re-used.

Change-Id: If4ee8221f4350f1d63f87e3b7ced91472c52fad3
Signed-off-by: Peter Foley <pefoley@google.com>

show more ...

clang-format: copy latest and re-format

clang-format-17 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-17 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: Ic5fd073faa7391d3f0b37787d6a9c7688c9a3253
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

transporthandler: Fix path check

Right now, paths for channel names can sometimes conflict if we have
an interface whose name is a subset of another interface. This makes the
match much more explici

transporthandler: Fix path check

Right now, paths for channel names can sometimes conflict if we have
an interface whose name is a subset of another interface. This makes the
match much more explicit. It also happens to remove the string search
completely.

Change-Id: Ia3a91e4a04a28d0b76eade2c5e716017c5431e71
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

transporthandler: Use stdplus network functions

These are shared with phosphor-networkd.

Change-Id: I2dc796f195c733b5b5b4edcfd59186e3ef30b515
Signed-off-by: William A. Kennington III <wak@google.co

transporthandler: Use stdplus network functions

These are shared with phosphor-networkd.

Change-Id: I2dc796f195c733b5b5b4edcfd59186e3ef30b515
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

transporthandler: Let phosphor-networkd do field validation

We can leverage networkd error handling for validating our fields.

Change-Id: I880d6dd9a6418e55dfe821f84bfcb8cb4d2eb618
Signed-off-by: Wi

transporthandler: Let phosphor-networkd do field validation

We can leverage networkd error handling for validating our fields.

Change-Id: I880d6dd9a6418e55dfe821f84bfcb8cb4d2eb618
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

transporthandler: Generic set exception handling

This makes it easier to handle errors across multiple command types as
they all have common return codes for specific types of failures.

Change-Id:

transporthandler: Generic set exception handling

This makes it easier to handle errors across multiple command types as
they all have common return codes for specific types of failures.

Change-Id: I033a171b5fca78a62b52424db970ecfdf7a15e17
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

transporthandler: Refactor dhcp get / set

phosphor-networkd now exposes dhcp settings as individual properties, we
no longer need to parse an enum / repack an enum to interface with them.

Change-Id

transporthandler: Refactor dhcp get / set

phosphor-networkd now exposes dhcp settings as individual properties, we
no longer need to parse an enum / repack an enum to interface with them.

Change-Id: I2c6d366e936a2de172367cdd19bde06f8abf4dcb
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

apphandler: convert major verion if greater than or equal to 2000

For the platforms use year as major version, it would expect to have
major version between 0 - 99. If the major version is greater t

apphandler: convert major verion if greater than or equal to 2000

For the platforms use year as major version, it would expect to have
major version between 0 - 99. If the major version is greater than or
equal to 2000, it is treated as a year and converted to 0 - 99.

Change-Id: Iad13f8175499a86c279cd69fdc759d9425e89546
Signed-off-by: Potin Lai <potin.lai@quantatw.com>

show more ...

dcmi: fix Get Sensor Info command

Issue: if users request to Get Sensors Info via "ipmitool dcmi sensors"
command, the Record ID of sensors always are 0x0000.

Root Cause: In the loop of scanning th

dcmi: fix Get Sensor Info command

Issue: if users request to Get Sensors Info via "ipmitool dcmi sensors"
command, the Record ID of sensors always are 0x0000.

Root Cause: In the loop of scanning the configuration file to get the
record ID, it is using the "config" variable instead of the "reading"
variable. It makes the record ID always is 0x0000.

Solution: Replace the "config" variable with the "reading" variable.

Tested:
1. Request to Get Sensors Info.
$ipmitool dcmi sensors
2. The list of sensors and temperature are shown.

Change-Id: If2b03b6b8a077a4e9239403ec9ecd640f645cbc0
Signed-off-by: Thang Tran <thuutran@amperecomputing.com>

show more ...

Revert "Watchdog: Add Notlog setting function"

This reverts commit 5203602888ecd350bafc941b932ad3e01350be19.

The dbus interfaces and the implementation of this in phosphor-watchdog
was abandoned wi

Revert "Watchdog: Add Notlog setting function"

This reverts commit 5203602888ecd350bafc941b932ad3e01350be19.

The dbus interfaces and the implementation of this in phosphor-watchdog
was abandoned without being merged. We need to revert this in order
to get phosphor-host-ipmi SRCREV updates moving.

Change-Id: I26562c09b180b68baf9c04f6b4ac6ef57129a0ad
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

phosphor-sel-logger clears SEL

the SEL logger now clears the SEL and the option
'sel-logger-clears-sel' is removed.

This removes the ambiguity about who should clear it and provides
a single implem

phosphor-sel-logger clears SEL

the SEL logger now clears the SEL and the option
'sel-logger-clears-sel' is removed.

This removes the ambiguity about who should clear it and provides
a single implementation.

Tested: together with the other topic changes. SEL Add/Clear works.

Change-Id: I9d228ac418406272caf220170a824735108b5599
Signed-off-by: Alexander Hansen <alexander.hansen@9elements.com>

show more ...

ipmid: Update sdbuspp namespaces

Fixed all errors when we remove
`SDBUSPP_REMOVE_DEPRECATED_NAMESPACE` in sdbusplus.

Change-Id: I5607585b2709faa7aee347d26e458ef769ca1626
Signed-off-by: Willy Tu <wl

ipmid: Update sdbuspp namespaces

Fixed all errors when we remove
`SDBUSPP_REMOVE_DEPRECATED_NAMESPACE` in sdbusplus.

Change-Id: I5607585b2709faa7aee347d26e458ef769ca1626
Signed-off-by: Willy Tu <wltu@google.com>

show more ...