Fix MD040 warnings

The following warnings are generated by using markdownlint analysis:
```
MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"]
```
Refer

Fix MD040 warnings

The following warnings are generated by using markdownlint analysis:
```
MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"]
```
Refer to markdown-lint [1] to fix MD040
[1]: https://github.com/updownpress/markdown-lint/blob/master/rules/040-fenced-code-language.md

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: I3bcd15ed9ef26177daed8e5fdfe252e0d37f4ed0

show more ...

Fix MD041 warnings

The following warnings are generated by using markdownlint analysis:
```
README.md:1 MD041/first-line-heading/first-line-h1 First line in a file should be a top-level heading [Con

Fix MD041 warnings

The following warnings are generated by using markdownlint analysis:
```
README.md:1 MD041/first-line-heading/first-line-h1 First line in a file should be a top-level heading [Context: "### Compile ipmid with default..."]
scripts/entity-example.md:1 MD041/first-line-heading/first-line-h1 First line in a file should be a top-level heading [Context: "If your platform requires the ..."]
docs/ipmi-network-format.md:1 MD041/first-line-heading/first-line-h1 First line in a file should be a top-level heading [Context: "On platforms running AMI BMC f..."]
```
Refer to markdown-lint [1] to fix MD041
[1]: https://github.com/updownpress/markdown-lint/blob/master/rules/041-first-line-h1.md

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: I28d2121e54e078e701d35071cd4088fefcdd4a58

show more ...

prettier: re-format

Prettier is enabled in openbmc-build-scripts on Markdown, JSON, and YAML
files to have consistent formatting for these file types. Re-run the
formatter on the whole repository.

prettier: re-format

Prettier is enabled in openbmc-build-scripts on Markdown, JSON, and YAML
files to have consistent formatting for these file types. Re-run the
formatter on the whole repository.

Change-Id: I2e1710e269896e36a8bd864cfc81ff3b1c033222
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

black: re-format

black and isort are enabled in the openbmc-build-scripts on Python files
to have a consistent formatting. Re-run the formatter on the whole
repository.

Change-Id: I6c39862420de0e0

black: re-format

black and isort are enabled in the openbmc-build-scripts on Python files
to have a consistent formatting. Re-run the formatter on the whole
repository.

Change-Id: I6c39862420de0e038e69e2409f9f9e70cac4e6b9
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

python: fix flake8 warnings and format with black

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I1b29b18431abc3985c8a2ebe8c0632e39776f5ae

Add init_priority to generated code

Fix a issue(crash) on `FEATURE_SENSORS_CACHE` is enabled.
As below backtrace:
```
...
4 0x75ff9a34 in initSensorMatches () at ../../../../../../workspace/sources

Add init_priority to generated code

Fix a issue(crash) on `FEATURE_SENSORS_CACHE` is enabled.
As below backtrace:
```
...
4 0x75ff9a34 in initSensorMatches () at ../../../../../../workspace/sources/phosphor-ipmi-host/sensorhandler.cpp:153
5 0x75f887a8 in register_netfn_sen_functions () at ../../../../../../workspace/sources/phosphor-ipmi-host/sensorhandler.cpp:1561
...
```

This issue is caused by `ipmi::sensor::sensors` is not initialized when
register_netfn_sen_functions is called.
Add init_priority to generated code to fix this issue.

Tested: Build okay and no crash.

Signed-off-by: Jian Zhang <zhangjian.3032@bytedance.com>
Change-Id: Ic5cc96206f3df9fafa10bbfb88c0bb4459749575

show more ...

meson: refactor generators

Using 'run_command' is not the appropriate way to generate code
since it only runs when meson itself runs and doesn't expose to
meson the correct dependency information.

meson: refactor generators

Using 'run_command' is not the appropriate way to generate code
since it only runs when meson itself runs and doesn't expose to
meson the correct dependency information. 'custom_target' is
the more appropriate way to generate code, so switch to using it.

This was noticed because when trying to build as a subproject, the
depending repository failed with:
```
subprojects/phosphor-host-ipmid/meson.build:229:0: ERROR: Sandbox
violation: Tried to grab file sensor-gen.cpp outside current
(sub)project.
```

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I555c6e1a7bfaabae63d757042ddc1c5a548295aa

show more ...

build: Add meson build for phosphor-host-ipmi

Create meson and meson_options for the existing features.

Removed sample.h/cpp since that is not used at all.

Tested:
Ipmi command works fine the clea

build: Add meson build for phosphor-host-ipmi

Create meson and meson_options for the existing features.

Removed sample.h/cpp since that is not used at all.

Tested:
Ipmi command works fine the cleanup.
```
$ systemctl status phosphor-ipmi-host
● phosphor-ipmi-host.service - Phosphor Inband IPMI
Loaded: loaded (/lib/systemd/system/phosphor-ipmi-host.service; enabled; vendor preset: enabled)
Active: active (running) since Thu 1970-01-08 21:20:56 UTC; 21s ago
Main PID: 24987 (ipmid)
CGroup: /system.slice/phosphor-ipmi-host.service
└─24987 /tmp/ipmid

Jan 08 21:20:56 $HOST ipmid[24987]: Registering OEM:[0X002B79], Cmd:[0X30] for Ethstats Commands
Jan 08 21:20:56 $HOST ipmid[24987]: Registering OEM:[0X00C2CF], Cmd:[0X30] for Ethstats Commands
Jan 08 21:20:56 $HOST ipmid[24987]: Registering OEM:[0X002B79], Cmd:[0X32] for Sys Commands
Jan 08 21:20:56 $HOST ipmid[24987]: Registering OEM:[0X002B79], Cmd:[0X02] for I2C
Jan 08 21:20:56 $HOST ipmid[24987]: Registering OEM:[0X00C2CF], Cmd:[0X02] for I2C
Jan 08 21:20:56 $HOST ipmid[24987]: I2C_WHITELIST_CHECK is disabled, do not populate whitelist
Jan 08 21:20:56 $HOST ipmid[24987]: Registering OEM:[0X00C2CF], Cmd:[0X04] for Manual Zone Control
Jan 08 21:20:56 $HOST systemd[1]: Started Phosphor Inband IPMI.
Jan 08 21:20:56 $HOST ipmid[24987]: Loading whitelist filter
Jan 08 21:20:56 $HOST ipmid[24987]: Set restrictedMode = true
(reverse-i-search)`ipmi': systemctl status phosphor-^Cmi-host

$ ipmitool mc info
Device ID : 32
Device Revision : 1
Firmware Revision : 0.00
IPMI Version : 2.0
Manufacturer ID : 7244
Manufacturer Name : Quanta Computer Inc.
Product ID : 14426 (0x385a)
Product Name : Unknown (0x385A)
Device Available : yes
Provides Device SDRs : yes
Additional Device Support :
Sensor Device
SEL Device
FRU Inventory Device
Chassis Device
Aux Firmware Rev Info :
0x00
0x00
0x00
0x00
```

Change-Id: Ibaea9eea802b063a0207320654cbb817fde30c2a
Signed-off-by: Willy Tu <wltu@google.com>

show more ...

cleanup: Remove all warning errors for the Meson build support

Remove all the build warning to prepare for the meson build.
Meson build will be in
https://gerrit.openbmc-project.xyz/c/openbmc/phosph

cleanup: Remove all warning errors for the Meson build support

Remove all the build warning to prepare for the meson build.
Meson build will be in
https://gerrit.openbmc-project.xyz/c/openbmc/phosphor-host-ipmid/+/47748

Tested:
Ipmi command works fine the cleanup.
```
$ systemctl status phosphor-ipmi-host
● phosphor-ipmi-host.service - Phosphor Inband IPMI
Loaded: loaded (/lib/systemd/system/phosphor-ipmi-host.service; enabled; vendor preset: enabled)
Active: active (running) since Thu 1970-01-08 21:20:56 UTC; 21s ago
Main PID: 24987 (ipmid)
CGroup: /system.slice/phosphor-ipmi-host.service
└─24987 /tmp/ipmid

Jan 08 21:20:56 $HOST ipmid[24987]: Registering OEM:[0X002B79], Cmd:[0X30] for Ethstats Commands
Jan 08 21:20:56 $HOST ipmid[24987]: Registering OEM:[0X00C2CF], Cmd:[0X30] for Ethstats Commands
Jan 08 21:20:56 $HOST ipmid[24987]: Registering OEM:[0X002B79], Cmd:[0X32] for Sys Commands
Jan 08 21:20:56 $HOST ipmid[24987]: Registering OEM:[0X002B79], Cmd:[0X02] for I2C
Jan 08 21:20:56 $HOST ipmid[24987]: Registering OEM:[0X00C2CF], Cmd:[0X02] for I2C
Jan 08 21:20:56 $HOST ipmid[24987]: I2C_WHITELIST_CHECK is disabled, do not populate whitelist
Jan 08 21:20:56 $HOST ipmid[24987]: Registering OEM:[0X00C2CF], Cmd:[0X04] for Manual Zone Control
Jan 08 21:20:56 $HOST systemd[1]: Started Phosphor Inband IPMI.
Jan 08 21:20:56 $HOST ipmid[24987]: Loading whitelist filter
Jan 08 21:20:56 $HOST ipmid[24987]: Set restrictedMode = true
(reverse-i-search)`ipmi': systemctl status phosphor-^Cmi-host

$ ipmitool mc info
Device ID : 32
Device Revision : 1
Firmware Revision : 0.00
IPMI Version : 2.0
Manufacturer ID : 7244
Manufacturer Name : Quanta Computer Inc.
Product ID : 14426 (0x385a)
Product Name : Unknown (0x385A)
Device Available : yes
Provides Device SDRs : yes
Additional Device Support :
Sensor Device
SEL Device
FRU Inventory Device
Chassis Device
Aux Firmware Rev Info :
0x00
0x00
0x00
0x00
```

Change-Id: I372c9433a274bc633a24d213b7a1bc205531e33d
Signed-off-by: Willy Tu <wltu@google.com>

show more ...

Fix issues and support signed sensor values

Sensor will get "disable" when the command "ipmitool sdr elist" is
executed that if sensorReadingType is 0x6F.

sensor_units_1 is always set to 0 currentl

Fix issues and support signed sensor values

Sensor will get "disable" when the command "ipmitool sdr elist" is
executed that if sensorReadingType is 0x6F.

sensor_units_1 is always set to 0 currently. To support the display of
signed sensor values, we add the attribute "sensorUnits1" to the sensor
mapping yaml. This attribute can be used to determine whether the
sensor is signed.

It were making negative values 0 in get::readingData(). Fix the issue
by using a int32_t and add an overflow check.

Change-Id: I705defcf18805db9ada7d0de0738a59aedab61df
Signed-off-by: Tony Lee <tony.lee@quantatw.com>

show more ...

sensor yaml: allow custom sensor names

Currently, we can only name sensors based on data from the dbus object
implementing a sensor's interface. While this mostly works, there may
not be a sensible

sensor yaml: allow custom sensor names

Currently, we can only name sensors based on data from the dbus object
implementing a sensor's interface. While this mostly works, there may
not be a sensible name to extract in all cases.

This change introduces an optional sensorName property to the sensor
YAML description, which allows a custom name to be used.

Signed-off-by: Jeremy Kerr <jk@codeconstruct.com.au>
Change-Id: I3f3b8ef581c70fbde94db122d4f3c0ca181c6ff7

show more ...

scripts/writesensor: make sensor map definition less cryptic

Use .name = value initialisers when generating the IdInfoMap, so it's
more obvious which members are being initialised.

Signed-off-by: J

scripts/writesensor: make sensor map definition less cryptic

Use .name = value initialisers when generating the IdInfoMap, so it's
more obvious which members are being initialised.

Signed-off-by: Jeremy Kerr <jk@codeconstruct.com.au>
Change-Id: If6d33883e02790f59e26fb72a1b783e8256aaca9

show more ...

Switch to python3

Signed-off-by: Tom Joseph <tomjoseph@in.ibm.com>
Change-Id: I86ca25173c745442760eddd608ad48985cd46ee0

drop entity YAML in favor of json provided file

Step 5 of moving from entity map from YAML to JSON drops support for a
built-in YAML mapping of the entity containers.

Tested: Not tested. No platfo

drop entity YAML in favor of json provided file

Step 5 of moving from entity map from YAML to JSON drops support for a
built-in YAML mapping of the entity containers.

Tested: Not tested. No platform upstream updates this YAML file in
their builds.
Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: Ic2918f568f5a6f4a9f9135990889b3bb84a0c81d

show more ...

move sensors into ipmi::sensor namespace

The object was left in the global namespace, but the type was in the
ipmi::sensor namespace. Move the object into the namespace.

Signed-off-by: Patrick Ven

move sensors into ipmi::sensor namespace

The object was left in the global namespace, but the type was in the
ipmi::sensor namespace. Move the object into the namespace.

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I88e46da4abda220d3b6fcc2ea64b8ef0decb0dc3

show more ...

move entities into ipmi::sensor namespace

The object was left in the global namespace, but the type was in the
ipmi::sensor namespace. Move the object into the namespace.

Signed-off-by: Patrick Ve

move entities into ipmi::sensor namespace

The object was left in the global namespace, but the type was in the
ipmi::sensor namespace. Move the object into the namespace.

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: If3aa72ebbae980b0b837c45c8fcbc4b47b7fb742

show more ...

writeentity: add missing header utility

The code includes utility indirectly. Utility is required for make_pair().

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I3cdca868a69ca67363

writeentity: add missing header utility

The code includes utility indirectly. Utility is required for make_pair().

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I3cdca868a69ca67363f2e3692cbfd511dfde7b5f

show more ...

yaml: drop execute permissions from yaml files

Functionally this doesn't change anything but executable data files
would seem to be in conflict with typical idioms.

Change-Id: I5eddfd8a8be3d1b9eb53

yaml: drop execute permissions from yaml files

Functionally this doesn't change anything but executable data files
would seem to be in conflict with typical idioms.

Change-Id: I5eddfd8a8be3d1b9eb53062fb60e46b845008fd9
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

Fix dependencies on auto-generated code

The sensor/entity/fru/inventory auto-generated cpp code should
depend on the mako template, the generator python, and the yaml
that it is built with. This mod

Fix dependencies on auto-generated code

The sensor/entity/fru/inventory auto-generated cpp code should
depend on the mako template, the generator python, and the yaml
that it is built with. This modifies the autoconf to export the yaml
and the automake to set the dependencies.

Tested-by: modify one of the dependencies and watch it get rebuilt

Change-Id: Iaab9585c202baf4506e0b7e62aa42a3bf2828ae4
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

show more ...

sensordatahandler: Support empty inventory interfaces

This commit adds support for empty inventory interfaces when
asserting a sensor into the inventory. This is something already
supported in ipmi-

sensordatahandler: Support empty inventory interfaces

This commit adds support for empty inventory interfaces when
asserting a sensor into the inventory. This is something already
supported in ipmi-fru-parser, for example.

Currently, the notify::assertion function expects that each DBUS
interface also have a set of associated properties. One of the
use-cases this commit tries to solve is when a sensor being asserted
maps to an inventory item (accessed via
xyz.openbmc_project.Inventory.Manager DBUS service) that implements
a DBUS interface with no properties. For example, the GPU sensor
is mapped to a GPU inventory object that implements the DBUS
interface xyz.openbmc_project.Inventory.Item.Accelerator.
This commit enables phosphor-host-ipmid to correctly create/update
inventory objects even in cases where they implement DBUS interfaces
that contain no properties.

The sensor-example.yaml file has been updated to show an example
of a GPU sensor, the inventory object for which implements a
property-less DBUS interface.

Tested:

Tested on a witherspoon system that had some GPUs attached to it.
Pulled also https://gerrit.openbmc-project.xyz/c/openbmc/openbmc/+/21107
in order to generate the right sensor configs for testing.
Verified that the GPU invetory objects that are created when the host
asserts a GPU sensor now implement the empty interface
xyz.openbmc_project.Inventory.Item.Accelerator

Signed-off-by: Santosh Puranik <santosh.puranik@in.ibm.com>
Change-Id: I973580e285ae0fff1a513d3bbe8c03a89e0eeb83

show more ...

delete writechannel.mako.cpp

Delete obsolete scripts/writechannel.mako.cpp

Change-Id: I79dac382132bf89877f2718d1b6219a2503e415e
Signed-off-by: Patrick Venture <venture@google.com>

move types.hpp to ipmid/types.hpp for export

types.hpp is required by utility.hpp, which is exported, so it needs to
be exported as well. This moves it to the include/libipmid directory,
changes the

move types.hpp to ipmid/types.hpp for export

types.hpp is required by utility.hpp, which is exported, so it needs to
be exported as well. This moves it to the include/libipmid directory,
changes the Makefile to export it, and changes all the files that
include it so it can be found in the right place.

Change-Id: I30ec365446e4de466c266ec4faa327478460ec05
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

show more ...

Add support for Entity Association Record

Adding support for Entity Association Record (SDR type - 0x08h)
This patch includes:
1) Entity Association Record yaml file example
2) Entity Assocation Rec

Add support for Entity Association Record

Adding support for Entity Association Record (SDR type - 0x08h)
This patch includes:
1) Entity Association Record yaml file example
2) Entity Assocation Record related script and mako file changes
3) Adding Entity Association Record in get_sdr IPMI command response

From the host, tested that entity association records can be fetched

Change-Id: I9cf598e5d27d2e8c6751bbaae2176e7c976974b1
Tested: Yes
Signed-off-by: Jaghathiswari Rankappagounder Natarajan <jaghu@google.com>

show more ...

Removing net.hpp and net.cpp because functionality moved

The functionality provided by net.hpp and net.cpp has been moved into
the channel_mgmt class.

Change-Id: I4820609f87f27ebe81d9b36f7b8e95a526

Removing net.hpp and net.cpp because functionality moved

The functionality provided by net.hpp and net.cpp has been moved into
the channel_mgmt class.

Change-Id: I4820609f87f27ebe81d9b36f7b8e95a5262985ac
Signed-off-by: Johnathan Mantey <johnathanx.mantey@intel.com>

show more ...

Revert "eSEL: Remove unused code related to logging eSEL"

This reverts commit 54fad6de0541c2f98e9b511f1d30bbcbcd743db6.

This commit is reverted because the mapping of D-Bus object path to
sensor in

Revert "eSEL: Remove unused code related to logging eSEL"

This reverts commit 54fad6de0541c2f98e9b511f1d30bbcbcd743db6.

This commit is reverted because the mapping of D-Bus object path to
sensor information is still needed. The mapping is needed to serve
the SEL commands which translate D-Bus logging objects to SEL entries.

Change-Id: I2505299671db1f0bd7f116ef0e2ca4a0273eead8

show more ...