meson: Use boost as a dependency

Currently boost library is found via the 'cpp.find_library' call. With
this method local build of the project requires host to have the boost
libraries installed.
Si

meson: Use boost as a dependency

Currently boost library is found via the 'cpp.find_library' call. With
this method local build of the project requires host to have the boost
libraries installed.
Since the meson have a subproject system to download missing
dependencies, rewrite boost requirement to a 'dependency' object. This
way it would be possible to build the project locally on the system
without the boost library installed.

Tested:
Both local meson build and Yocto build are performed successfully.

Change-Id: I082aeb1d6c09627ea53f58cb6cd375f080401d57
Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>

show more ...

Remove libmapper dependency

After this commit is merged [1], phosphor-ipmi-host no longer depends
on libmapper. This commit removes the dependence on libmapper.

[1] https://gerrit.openbmc.org/c/ope

Remove libmapper dependency

After this commit is merged [1], phosphor-ipmi-host no longer depends
on libmapper. This commit removes the dependence on libmapper.

[1] https://gerrit.openbmc.org/c/openbmc/phosphor-host-ipmid/+/69082

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: Iacf20716b3dd02f0c3173eb6c1fcb39d416f72a6

show more ...

build: use allowed over enabled

Meson feature options are typically in a tri-state of enabled, disabled,
or auto. The enabled and disabled functions on an option (from
`get_option`) no longer retur

build: use allowed over enabled

Meson feature options are typically in a tri-state of enabled, disabled,
or auto. The enabled and disabled functions on an option (from
`get_option`) no longer return true for auto features. Instead, the
expectation is to use `allowed()` which is true for both enabled and auto.

Switch all uses of `enabled` to `allowed`.

Change-Id: I114b084eb227d4a767e404c14e4f3a613a5b83d6
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

meson: adjust nlohmann-json dependency

Simplify meson dependency logic and align wrap file name with other
repositories.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I516b4155786e

meson: adjust nlohmann-json dependency

Simplify meson dependency logic and align wrap file name with other
repositories.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I516b4155786e4ae2d72c99e3e253c63db3752449

show more ...

Rewrite Read Event Buffer to use new API

Lots of hard-coded values in this one, but one value did get replaced
with a lookup. The output matches previous output with the one exception
that now the c

Rewrite Read Event Buffer to use new API

Lots of hard-coded values in this one, but one value did get replaced
with a lookup. The output matches previous output with the one exception
that now the current manufacturer is used instead of a hard-coded value.

Tested: run ipmitool raw 6 0x35 and check the output
Before:
ipmitool raw 6 0x35
55 55 c0 41 a7 00 00 00 00 00 3a ff 00 ff ff ff
After:
ipmitool raw 6 0x35
55 55 c0 57 01 00 00 00 00 00 3a ff 00 ff ff ff

Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>
Change-Id: I4910d8ee07db6f24d639f9322a0246e10a0260e3

show more ...

transporthandler: Generic set exception handling

This makes it easier to handle errors across multiple command types as
they all have common return codes for specific types of failures.

Change-Id:

transporthandler: Generic set exception handling

This makes it easier to handle errors across multiple command types as
they all have common return codes for specific types of failures.

Change-Id: I033a171b5fca78a62b52424db970ecfdf7a15e17
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

phosphor-sel-logger clears SEL

the SEL logger now clears the SEL and the option
'sel-logger-clears-sel' is removed.

This removes the ambiguity about who should clear it and provides
a single implem

phosphor-sel-logger clears SEL

the SEL logger now clears the SEL and the option
'sel-logger-clears-sel' is removed.

This removes the ambiguity about who should clear it and provides
a single implementation.

Tested: together with the other topic changes. SEL Add/Clear works.

Change-Id: I9d228ac418406272caf220170a824735108b5599
Signed-off-by: Alexander Hansen <alexander.hansen@9elements.com>

show more ...

meson: add option for open-power functions

This repository has long had an open-power only function that ends
up compiled into all systems. We cannot use the phosphor-logging
generated errors, unle

meson: add option for open-power functions

This repository has long had an open-power only function that ends
up compiled into all systems. We cannot use the phosphor-logging
generated errors, unless we are able to disable this code on
non-open-power systems. Add necessary meson options.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Icd5b2f4cdec206597029930790ef2b10170d232a

show more ...

multiple ipmi shortname implementations

As ipmi subsystem requires short names, and there are multiple
ways to implement that, this patch provides compile-time configuration
options.

- shortname-r

multiple ipmi shortname implementations

As ipmi subsystem requires short names, and there are multiple
ways to implement that, this patch provides compile-time configuration
options.

- shortname-remove-suffix
- shortname-replace-words

Previously, PSU Sensor Names were stripped of some
suffixes, some of which uniquely identified the sensor.

e.g. "_Input_Voltage", "_Output_Voltage".
Without the suffix, the sensor cannot be uniquely identified.

Example: "PSU0_Input_Voltage", "PSU0_Output_Voltage"
both become "PSU0".

Tested:
- with both configurations turned off, name is only trucated
- with nothing configured, default config is applied and suffix is
removed (current behavior)
- word replacement enabled and suffix removal disabled: expected
behavior
- word replacement disabled and suffix removal enabled: expected
behavior

Change-Id: I01dd35f31e75df3c31733e9818884813a241440a
Signed-off-by: Alexander Hansen <alexander.hansen@9elements.com>

show more ...

Support to build storage commands in libipmi20

Currently, the storage commands only is built in the libdynamicsensor
library. To build those commands, we have to enable dynamic-sensor
option which m

Support to build storage commands in libipmi20

Currently, the storage commands only is built in the libdynamicsensor
library. To build those commands, we have to enable dynamic-sensor
option which makes sensor commands are built too.

To allow compiling storage commands w/o sensor commands, this commit
adds 'dynamic-storages-only' option to request to build storage commands
in libipmi20 library.

Tested:
1. Disable dynamic-sensor option and enable dynamic-storages-only
option.
2. Built the openBmc image and flash to the board.
3. Request to read/write FRU device via ipmitool.
All of request work well.
4. Request to read SEL list.
Display list of SEL logs.

Signed-off-by: Thang Tran <thuutran@amperecomputing.com>
Change-Id: I330919e7eebbb80bf568f36ead69ade670b2f8d1

show more ...

build: Remove forced lto

meson has an option for enabling LTO and we do so inside of releases. We
don't want to spend extra time with this for unit tests where we don't
care about binary size.

Chan

build: Remove forced lto

meson has an option for enabling LTO and we do so inside of releases. We
don't want to spend extra time with this for unit tests where we don't
care about binary size.

Change-Id: Id2642a72a671d4ea13cb6b0d5f383f2a509cfff3
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

build: upgrade to C++23

Meson 1.1.1 and GCC-13 both support C++23 and a sufficient portion of
the standard has been implemented. Upgrade the build to leverage it.

Change-Id: I672e2bc56f2ae99199802

build: upgrade to C++23

Meson 1.1.1 and GCC-13 both support C++23 and a sufficient portion of
the standard has been implemented. Upgrade the build to leverage it.

Change-Id: I672e2bc56f2ae991998021eef90c9f21eb4ea9ee
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

meson: Move IPMI_SMS_ATN_ACK_TIMEOUT_SECS out of softoff

The config `IPMI_SMS_ATN_ACK_TIMEOUT_SECS` is used by
`host-interface.cpp` and `host-cmd-manager.cpp`, which are not specific
to softoff, and

meson: Move IPMI_SMS_ATN_ACK_TIMEOUT_SECS out of softoff

The config `IPMI_SMS_ATN_ACK_TIMEOUT_SECS` is used by
`host-interface.cpp` and `host-cmd-manager.cpp`, which are not specific
to softoff, and it gets compile error when `softoff` is disabled.

Move the config out of `softoff` feature, so that it compiles OK with or
without `softoff` feature.

Tested: Verify the repo compile with `-Dsoftoff=disabled`.

Signed-off-by: Lei YU <yulei.sh@bytedance.com>
Change-Id: I03edc40684045a27255d5184ac6056f7181b0492

show more ...

move entity_map_json to libipmid

entity_map_json is used by dbus-sdr sensor handling so it needs to be in
a common location or loading order matters. This change moves the file
from the ipmi20 provi

move entity_map_json to libipmid

entity_map_json is used by dbus-sdr sensor handling so it needs to be in
a common location or loading order matters. This change moves the file
from the ipmi20 provider library to libipmi, a common library.

Tested: Found that even though the dbus-sdr provider loads before
ipmi20, it loads properly without missing symbols.

Change-Id: I9ab6833c78e6f3c89c02cf998ce0a36353059c3d
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

show more ...

Enable Yocto control of the USING_ENTITY_MANAGER_DECORATORS

The USING_ENTITY_MANAGER_DECORATORS compile switch is hard coded to
enabled in a header file. The changes here allow the feature to be
con

Enable Yocto control of the USING_ENTITY_MANAGER_DECORATORS

The USING_ENTITY_MANAGER_DECORATORS compile switch is hard coded to
enabled in a header file. The changes here allow the feature to be
controlled in recipes via PACKAGECONFIG entries in bbappend files.

Tested:
Applied https://gerrit.openbmc.org/c/openbmc/openbmc/+/63434
Modified internal bbappend file to PACKAGECONFIG:remove
entity-manager-decorators
Confirmed the code guarded by the ifdef no longer compiled
Removed change to bbappend file
Confirmed the code guarded by the ifdef was restored.

Change-Id: I4f3072451f893fcb5edaa478d0546253e7005b9f
Signed-off-by: Johnathan Mantey <johnathanx.mantey@intel.com>

show more ...

apphandler: add firmware version aux bytes parsing

Default regex string only tries to match Major and Minor version.

To match more firmware version info, platforms need to define it own
regex strin

apphandler: add firmware version aux bytes parsing

Default regex string only tries to match Major and Minor version.

To match more firmware version info, platforms need to define it own
regex string to match more strings, and assign correct mapping index in
matches array.

matches[0]: matched index for major ver
matches[1]: matched index for minor ver
matches[2]: matched index for aux[0] (set 0 to skip)
matches[3]: matched index for aux[1] (set 0 to skip)
matches[4]: matched index for aux[2] (set 0 to skip)
matches[5]: matched index for aux[3] (set 0 to skip)

Test Results:
```
regex = "([\d]+).([\d]+).([\d]+)-dev-([\d]+)-g([0-9a-fA-F]{2})([0-9a-fA-F]{2})([0-9a-fA-F]{2})([0-9a-fA-F]{2})"
matches = {1,2,5,6,7,8}
version = 2.14.0-dev-750-g37a7c5ad1-dirty
^ ^ ^ ^ ^ ^ ^ ^
| | | | | | | |
| | | | | | | |-- Aux byte 3 (0xAD), index 8
| | | | | | |---- Aux byte 2 (0xC5), index 7
| | | | | |------ Aux byte 1 (0xA7), index 6
| | | | |-------- Aux byte 0 (0x37), index 5
| | | |------------- Not used, index 4
| | |------------------- Not used, index 3
| |---------------------- Minor (14), index 2
|------------------------ Major (2), index 1
```

rev.major: 2
rev.minor: 14
rev.aux[0]: 55 (0x37)
rev.aux[1]: 167 (0xA7)
rev.aux[2]: 197 (0xC5)
rev.aux[3]: 173 (0xAD)

Change-Id: I01c4d6b7468cea04d5046bbc4a60c4db20a7f2a9
Signed-off-by: Potin Lai <potin.lai@quantatw.com>

show more ...

apphandler: use regex to parse firmware version

1. Use regular expression to parse firmware major & minor version.
2. Add meson option to modify regex string by platform layer.

Tested result:

- pa

apphandler: use regex to parse firmware version

1. Use regular expression to parse firmware major & minor version.
2. Add meson option to modify regex string by platform layer.

Tested result:

- parsing result of version 1: v0.6-19-gf363f61-dirty
rev.major = 0
rev.minor = 6

- parsing result of version 2: v1.99.10-113-g65edf7d-r3-0-g9e4f715
rev.major = 1
rev.minor = 99

- parsing result of version 3: 2.14.0-dev
rev.major = 2
rev.minor = 14

Change-Id: I1a5ebd592e3078d38182926a6a9ee98a129c3ee4
Signed-off-by: Potin Lai <potin.lai@quantatw.com>

show more ...

enable dbus-sdr in testing by default

Fix the build issues with dbus-sdr

Change-Id: If91de78de5f9ffeb8581b8ee5862363722103cac
Signed-off-by: Willy Tu <wltu@google.com>

Add option to disable getActiveSoftwareVersionInfo

Add metion option `get-dbus-active-software` to allow us to disable
calling getActiveSoftwareVersionInfo when we expect it to be failing and
depend

Add option to disable getActiveSoftwareVersionInfo

Add metion option `get-dbus-active-software` to allow us to disable
calling getActiveSoftwareVersionInfo when we expect it to be failing and
depend completely on dev_id.json for the version.

Tested:
Build with both options and works fine.

Change-Id: Icad3ad72521af35370e74cea36aa12085448dc53
Signed-off-by: Willy Tu <wltu@google.com>

show more ...

Remove ipmid-host library

This library causes some false positives with checksec, because it
doesn't really have any code in it, so there's no code to check for
stack canaries.

This commit removes

Remove ipmid-host library

This library causes some false positives with checksec, because it
doesn't really have any code in it, so there's no code to check for
stack canaries.

This commit removes the library. It doesn't seem to be used anywhere in
the project, and in practice, only links against sdbusplus, so it seems
like cruft.

Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: I15dd876b8dfd485d64572707071190fbea2357a0

show more ...

meson: refactor generators

Using 'run_command' is not the appropriate way to generate code
since it only runs when meson itself runs and doesn't expose to
meson the correct dependency information.

meson: refactor generators

Using 'run_command' is not the appropriate way to generate code
since it only runs when meson itself runs and doesn't expose to
meson the correct dependency information. 'custom_target' is
the more appropriate way to generate code, so switch to using it.

This was noticed because when trying to build as a subproject, the
depending repository failed with:
```
subprojects/phosphor-host-ipmid/meson.build:229:0: ERROR: Sandbox
violation: Tried to grab file sensor-gen.cpp outside current
(sub)project.
```

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I555c6e1a7bfaabae63d757042ddc1c5a548295aa

show more ...

Fix project name misspelling

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I11a2565cdf424fc98a193fe722643efdf8ae9424

meson: Fix channel command invaild

Fix channel command invaild, `channelcommands.cpp` file is missing in
meson.build.

Tested:

ipmitool channel info 1
Channel 0x1 info:
Channel Medium Type : 80

meson: Fix channel command invaild

Fix channel command invaild, `channelcommands.cpp` file is missing in
meson.build.

Tested:

ipmitool channel info 1
Channel 0x1 info:
Channel Medium Type : 802.3 LAN
Channel Protocol Type : IPMB-1.0
Session Support : multi-session
Active Session Count : 0
Protocol Vendor ID : 7154
Volatile(active) Settings
Alerting : enabled
Per-message Auth : enabled
User Level Auth : enabled
Access Mode : always available
Non-Volatile Settings
Alerting : enabled
Per-message Auth : enabled
User Level Auth : enabled
Access Mode : always available

Change-Id: I36436a78b4344087b4d079fa1775383005a0bd3d
Signed-off-by: Jian Zhang <zhangjian.3032@bytedance.com>

show more ...

remove std::experimental usage

C++17 moved this support out of std::experimental and into std
directly. Fix up the code and dependencies to reflect this.

Signed-off-by: Patrick Williams <patrick@s

remove std::experimental usage

C++17 moved this support out of std::experimental and into std
directly. Fix up the code and dependencies to reflect this.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I1cd852831fc2608bd3a36f047aa6ac14741da270

show more ...

meson: add nlohmann-json wrapper and deps

A number of locations within the repository do not appropriately
specify the dependency on nlohmann-json. Fix up the wrap file,
add appropriate dependency

meson: add nlohmann-json wrapper and deps

A number of locations within the repository do not appropriately
specify the dependency on nlohmann-json. Fix up the wrap file,
add appropriate dependency detection in the root meson, and add the
library as a dependency when needed. This gets closer to allowing
full subproject-based builds.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: If70888c6de5651ca355f84616e41408ddde9fc08

show more ...