clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda forma

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda formatting also changed, so we have made changes to the
organization default style format to better handle lambda formatting.

See I5e08687e696dd240402a2780158664b7113def0e for updated style.
See Iea0776aaa7edd483fa395e23de25ebf5a6288f71 for clang-18 enablement.

Change-Id: I01547e98d27910919e09ebf7907c86292a6c825d
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

convert ipmisensor.cpp to use lg2

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: I33c065cd9af4d9cb61787fc088d63752998534b6

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: I44441096113929ce96eb1439e2932e6ff3c87f27
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

cleanup: Remove all warning errors for the Meson build support

Remove all the build warning to prepare for the meson build.
Meson build will be in
https://gerrit.openbmc-project.xyz/c/openbmc/phosph

cleanup: Remove all warning errors for the Meson build support

Remove all the build warning to prepare for the meson build.
Meson build will be in
https://gerrit.openbmc-project.xyz/c/openbmc/phosphor-host-ipmid/+/47748

Tested:
Ipmi command works fine the cleanup.
```
$ systemctl status phosphor-ipmi-host
● phosphor-ipmi-host.service - Phosphor Inband IPMI
Loaded: loaded (/lib/systemd/system/phosphor-ipmi-host.service; enabled; vendor preset: enabled)
Active: active (running) since Thu 1970-01-08 21:20:56 UTC; 21s ago
Main PID: 24987 (ipmid)
CGroup: /system.slice/phosphor-ipmi-host.service
└─24987 /tmp/ipmid

Jan 08 21:20:56 $HOST ipmid[24987]: Registering OEM:[0X002B79], Cmd:[0X30] for Ethstats Commands
Jan 08 21:20:56 $HOST ipmid[24987]: Registering OEM:[0X00C2CF], Cmd:[0X30] for Ethstats Commands
Jan 08 21:20:56 $HOST ipmid[24987]: Registering OEM:[0X002B79], Cmd:[0X32] for Sys Commands
Jan 08 21:20:56 $HOST ipmid[24987]: Registering OEM:[0X002B79], Cmd:[0X02] for I2C
Jan 08 21:20:56 $HOST ipmid[24987]: Registering OEM:[0X00C2CF], Cmd:[0X02] for I2C
Jan 08 21:20:56 $HOST ipmid[24987]: I2C_WHITELIST_CHECK is disabled, do not populate whitelist
Jan 08 21:20:56 $HOST ipmid[24987]: Registering OEM:[0X00C2CF], Cmd:[0X04] for Manual Zone Control
Jan 08 21:20:56 $HOST systemd[1]: Started Phosphor Inband IPMI.
Jan 08 21:20:56 $HOST ipmid[24987]: Loading whitelist filter
Jan 08 21:20:56 $HOST ipmid[24987]: Set restrictedMode = true
(reverse-i-search)`ipmi': systemctl status phosphor-^Cmi-host

$ ipmitool mc info
Device ID : 32
Device Revision : 1
Firmware Revision : 0.00
IPMI Version : 2.0
Manufacturer ID : 7244
Manufacturer Name : Quanta Computer Inc.
Product ID : 14426 (0x385a)
Product Name : Unknown (0x385A)
Device Available : yes
Provides Device SDRs : yes
Additional Device Support :
Sensor Device
SEL Device
FRU Inventory Device
Chassis Device
Aux Firmware Rev Info :
0x00
0x00
0x00
0x00
```

Change-Id: I372c9433a274bc633a24d213b7a1bc205531e33d
Signed-off-by: Willy Tu <wltu@google.com>

show more ...

cleanup: scope reduction

[app/channel.cpp:102]: (style) The scope of the variable 'resp' can be reduced.
[ipmisensor.cpp:310]: (style) The scope of the variable 'i' can be reduced.

cleanup: scope reduction

[app/channel.cpp:102]: (style) The scope of the variable 'resp' can be reduced.
[ipmisensor.cpp:310]: (style) The scope of the variable 'i' can be reduced.
[ipmid.cpp:506]: (style) The scope of the variable 'num_handlers' can be reduced.
[read_fru_data.cpp:82]: (style) The scope of the variable 'fruId' can be reduced.
[sensorhandler.cpp:256]: (style) The scope of the variable 'p' can be reduced.
[storageaddsel.cpp:68]: (style) The scope of the variable 'p' can be reduced.

Also delete two extra vertical lines.

Change-Id: I8e72f8e1d94381f456674abf523d2f2fbdd8046d
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

cleanup: c-style casting

[ipmisensor.cpp:308]: (style) C-style pointer casting
[sensorhandler.cpp:302]: (style) C-style pointer casting
[sensorhandler.cpp:376]: (style) C-style po

cleanup: c-style casting

[ipmisensor.cpp:308]: (style) C-style pointer casting
[sensorhandler.cpp:302]: (style) C-style pointer casting
[sensorhandler.cpp:376]: (style) C-style pointer casting
[sensorhandler.cpp:404]: (style) C-style pointer casting
[sensorhandler.cpp:405]: (style) C-style pointer casting
[storageaddsel.cpp:157]: (style) C-style pointer casting
[storageaddsel.cpp:187]: (style) C-style pointer casting
Added missing const in reportSensorEventAssert and
reportSensorEventDeassert as the *pTable->func(...) take the const
pointer and the casting then was using the proper const casting.

Change-Id: I54a591b4e5e678b8ec3cae2633617a5f7aac7a66
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

add std namespace prefix to common methods

Standard clib methods should be explicitly grabbed from the standard
namespace.

Change-Id: I8bcfcb260a99180d535ec8102c1a24c318cbc209

add std namespace prefix to common methods

Standard clib methods should be explicitly grabbed from the standard
namespace.

Change-Id: I8bcfcb260a99180d535ec8102c1a24c318cbc209
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

replaced c headers with cpp where applicable

Change-Id: I23a70eb540ccde5d2aba467426769feffb07b516
Signed-off-by: Patrick Venture <venture@google.com>

rename headers to match style

Moving headers from ".h" to ".hpp"

Reworked the header inclusion a bit so that host-ipmid is treated as a
library, and local headers aren't.

rename headers to match style

Moving headers from ".h" to ".hpp"

Reworked the header inclusion a bit so that host-ipmid is treated as a
library, and local headers aren't.

renamed apphandler.h => apphandler.hpp
renamed chassishandler.h => chassishandler.hpp
renamed globalhandler.h => globalhandler.hpp
renamed sensorhandler.h => sensorhandler.hpp
renamed storageaddsel.h => storageaddsel.hpp
renamed storagehandler.h => storagehandler.hpp
renamed systemintfcmds.h => systemintfcmds.hpp

Change-Id: I9d4ce3dd57e2e996800f9020a10cc10cdf2c3914
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

add .clang-format

Change-Id: I7c2a527b4751a560703a61fcbe9638b150546af5
Signed-off-by: Patrick Venture <venture@google.com>

Remove trailing spaces

Change-Id: I3a58137b3300fcfe51a4182eb304a1b70885ad30
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

Grammar and spelling fixes

Spelling errors found using github.com/lucasdemarchi/codespell
A tool to fix common misspellings.
This tool is licensed under GNU General Public License, v

Grammar and spelling fixes

Spelling errors found using github.com/lucasdemarchi/codespell
A tool to fix common misspellings.
This tool is licensed under GNU General Public License, version 2.
Some additional grammar and capitalization errors were fixed as well.

Change-Id: I700db4e6d7ba52b02374c9c3e84be0af8bd91859
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Reducing IPMI logging footprint

-host-ipmid is very noisy in terms of journal logging. A small step
towards cleaning that up.
-Also converted printfs to phosphor-logging.

Pa

Reducing IPMI logging footprint

-host-ipmid is very noisy in terms of journal logging. A small step
towards cleaning that up.
-Also converted printfs to phosphor-logging.

Partially Resolves openbmc/openbmc#2507

Change-Id: I749c19c18d1cabf6f0216830c8cb0a08ee43d6de
Signed-off-by: Aditya Saripalli <aditya0124@gmail.com>
Signed-off-by: Nagaraju Goruganti <ngorugan@in.ibm.com>

show more ...

Add sensor entry for power supply redundancy enabled.

IPMI to dbus lookup contained only mapping for PS
redundancy disabled, adding the mapping for enabled.
Changing the PS redundanc

Add sensor entry for power supply redundancy enabled.

IPMI to dbus lookup contained only mapping for PS
redundancy disabled, adding the mapping for enabled.
Changing the PS redundancy sensor type from D8 to CA.

Resolves openbmc/openbmc#2810

Change-Id: I2399ce76a168f63f6a4528cff8aa397ef12d5e1e
Signed-off-by: Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com>

show more ...

ipmisensor.cpp: Fix msg from "Undetermine" to "Undetermined"

Change-Id: If647149928f9bafb0e0c2cfa33485b3f46328733
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

sensorhandler: Refactor find_sensor to eliminate redundant call

find_openbmc_path was being called within find_sensor as well as
following find_sensor

Change-Id: Ie94eab7afbe34f

sensorhandler: Refactor find_sensor to eliminate redundant call

find_openbmc_path was being called within find_sensor as well as
following find_sensor

Change-Id: Ie94eab7afbe34f214a07bda49bfbce729b20f237
Signed-off-by: Emily Shaffer <emilyshaffer@google.com>

show more ...

Set the TurboAllowed sensor value correctly.

Set the TurboAllowed to True for an assertion event and set it to
false for a deassertion event.

Resolves openbmc/openbmc#1530

Set the TurboAllowed sensor value correctly.

Set the TurboAllowed to True for an assertion event and set it to
false for a deassertion event.

Resolves openbmc/openbmc#1530

Change-Id: I3ee59e8770e75b02cdf83a956439f79779d2760c
Signed-off-by: Tom Joseph <tomjoseph@in.ibm.com>

show more ...

Add Sensor reading support for Power Cap.

Change-Id: I695c5a7e4da99b6ec1fe3045df91f483b6cad69c
Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>

Add Sensor Reading Support for Power Supply Derating

Change-Id: I0eb106c37c33db01937ec61dd5553b5799651633
Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>

Sensor Reading Support for Turbo Allowed

Change-Id: Ib2e89383fa1da4d3216ad5c50d257ec973547b71
Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>

IPMI Sensor Support for Power Supply Redundancy

Change-Id: Id475849a77fd18e8f6b05c73f55866aba604c9a7
Signed-off-by: Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com>

Refactor the code related to Sensor handling

The sensor related code is moved to sensorhandler.c. These changes
were part of the ipmi daemon code and would have to replicated in
RMCP

Refactor the code related to Sensor handling

The sensor related code is moved to sensorhandler.c. These changes
were part of the ipmi daemon code and would have to replicated in
RMCP daemon. The refactoring would get away with those changes.

Change-Id: Ib9e1a1929282221e6f259e4a54502eea82f42939
Signed-off-by: Tom <tomjoseph@in.ibm.com>

show more ...

ipmid: Change .H -> .hpp

Change-Id: Ia1ed05a533736105909717b86f16274b30d36401
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

Switch C++ source files to .cpp extension

Change-Id: I495186b4afd58ec1e5d9d5c6472394f96541d17d
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>