Adding a yielding option callDbusMethod

Currently there are a lot of yielding options that takes in utils.hpp
the ipmi::Context::ptr, but without callDbusMethod,
Now add this method to meet the need

Adding a yielding option callDbusMethod

Currently there are a lot of yielding options that takes in utils.hpp
the ipmi::Context::ptr, but without callDbusMethod,
Now add this method to meet the needs.

Tested:
The callDbusMethod method is called in a library, the compilation is
passed, and the functional test is successful.

Signed-off-by: Albert Zhang <zhanghaodi@inspur.com>
Change-Id: Id46f93708728b4449804ceedfa6d269071e52278

show more ...

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are for:
* bus_t
* exception_t
* manager_t
* match_t
* message_t
* object_t
* slot_t

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ibd2a0b512bfb7caf65bfab64b271d194da520aac

show more ...

avoid non-virtual-dtor warnings

```
../subprojects/phosphor-host-ipmid/include/ipmid/handler.hpp:157:7: error: base class ‘class ipmi::HandlerBase’ has accessible non-virtual destructor [-Werror=non

avoid non-virtual-dtor warnings

```
../subprojects/phosphor-host-ipmid/include/ipmid/handler.hpp:157:7: error: base class ‘class ipmi::HandlerBase’ has accessible non-virtual destructor [-Werror=non-virtual-dtor]
../subprojects/phosphor-host-ipmid/include/ipmid/filter.hpp:37:7: error: ‘class ipmi::FilterBase’ has virtual functions and accessible non-virtual destructor [-Werror=non-virtual-dtor]
```

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ib1f8befabc6ea4564524c474118b78f05403413d

show more ...

ipmid: message: fix pack/unpack compile error at aarch64 platform

After debugging with boost/multiprecision owner jzmaddock.
We have found the root cause why boost v1.79.0 got this compile error in

ipmid: message: fix pack/unpack compile error at aarch64 platform

After debugging with boost/multiprecision owner jzmaddock.
We have found the root cause why boost v1.79.0 got this compile error in ipmid.
More detail you can refer from https://github.com/boostorg/multiprecision/issues/472

Root cause:
Boost changed all bit counts from unsigned to std::size_t,
specifically for platforms like arm64 (and windows!) where unsigned is narrower than size_t
so that the maximum representable number isn't unnecessarily constrained.

This then changes the interface for cpp_int_backend to use size_t rather than unsigned for the bit counts.
On most platforms and most use cases, this makes no perceptible difference,
but unfortunately this appears to be one situation where it really does make a difference.

Apparently this is true even though:

template <unsigned N>
using fixed_uint_t =
boost::multiprecision::number<boost::multiprecision::cpp_int_backend<
N, N, boost::multiprecision::unsigned_magnitude,
boost::multiprecision::unchecked, void>>;

Is declared with an unsigned parameter, when partially specializing for fixed_uint_t
you need to use the actual type of the template parameter in the underlying template,
not the type used in the template alias!

Solution:
Change all usage of unsigned for bitcounts to a new typedef bitcount_t
which is size_t for Boost-1.79 and later, and unsigned for Boost-1.78 and earlier.

Verified:
No compile error at aarch64 platform and test ipmitool sdr command is pass.

Signed-off-by: jzmaddock <john@johnmaddock.co.uk>
Signed-off-by: Tim Lee <timlee660101@gmail.com>
Change-Id: Id7a7c86ef854f4b9c06fc4da054c8021f76812b8

show more ...

cleanup: Remove all warning errors for the Meson build support

Remove all the build warning to prepare for the meson build.
Meson build will be in
https://gerrit.openbmc-project.xyz/c/openbmc/phosph

cleanup: Remove all warning errors for the Meson build support

Remove all the build warning to prepare for the meson build.
Meson build will be in
https://gerrit.openbmc-project.xyz/c/openbmc/phosphor-host-ipmid/+/47748

Tested:
Ipmi command works fine the cleanup.
```
$ systemctl status phosphor-ipmi-host
● phosphor-ipmi-host.service - Phosphor Inband IPMI
Loaded: loaded (/lib/systemd/system/phosphor-ipmi-host.service; enabled; vendor preset: enabled)
Active: active (running) since Thu 1970-01-08 21:20:56 UTC; 21s ago
Main PID: 24987 (ipmid)
CGroup: /system.slice/phosphor-ipmi-host.service
└─24987 /tmp/ipmid

Jan 08 21:20:56 $HOST ipmid[24987]: Registering OEM:[0X002B79], Cmd:[0X30] for Ethstats Commands
Jan 08 21:20:56 $HOST ipmid[24987]: Registering OEM:[0X00C2CF], Cmd:[0X30] for Ethstats Commands
Jan 08 21:20:56 $HOST ipmid[24987]: Registering OEM:[0X002B79], Cmd:[0X32] for Sys Commands
Jan 08 21:20:56 $HOST ipmid[24987]: Registering OEM:[0X002B79], Cmd:[0X02] for I2C
Jan 08 21:20:56 $HOST ipmid[24987]: Registering OEM:[0X00C2CF], Cmd:[0X02] for I2C
Jan 08 21:20:56 $HOST ipmid[24987]: I2C_WHITELIST_CHECK is disabled, do not populate whitelist
Jan 08 21:20:56 $HOST ipmid[24987]: Registering OEM:[0X00C2CF], Cmd:[0X04] for Manual Zone Control
Jan 08 21:20:56 $HOST systemd[1]: Started Phosphor Inband IPMI.
Jan 08 21:20:56 $HOST ipmid[24987]: Loading whitelist filter
Jan 08 21:20:56 $HOST ipmid[24987]: Set restrictedMode = true
(reverse-i-search)`ipmi': systemctl status phosphor-^Cmi-host

$ ipmitool mc info
Device ID : 32
Device Revision : 1
Firmware Revision : 0.00
IPMI Version : 2.0
Manufacturer ID : 7244
Manufacturer Name : Quanta Computer Inc.
Product ID : 14426 (0x385a)
Product Name : Unknown (0x385A)
Device Available : yes
Provides Device SDRs : yes
Additional Device Support :
Sensor Device
SEL Device
FRU Inventory Device
Chassis Device
Aux Firmware Rev Info :
0x00
0x00
0x00
0x00
```

Change-Id: I372c9433a274bc633a24d213b7a1bc205531e33d
Signed-off-by: Willy Tu <wltu@google.com>

show more ...

Add data types to Value to extend setDbusProperty

Add new data types std::vector<uint8_t>, std::vector<uint16_t>,
std::vector<uint32_t> to support setDbusProperty to get/set the
corresponding type o

Add data types to Value to extend setDbusProperty

Add new data types std::vector<uint8_t>, std::vector<uint16_t>,
std::vector<uint32_t> to support setDbusProperty to get/set the
corresponding type of data.

Change-Id: I2a67f13273c8c317c2481184101b4b09392bf829
Signed-off-by: Jian Zhang <zhangjian.3032@bytedance.com>

show more ...

ipmid: message: pack: Fix cast issue

clang-tidy finds an issue related to below line:

uint64_t bits = t;

where if t is something like unit24_t, it gets compile error:

/usr/local/include/i

ipmid: message: pack: Fix cast issue

clang-tidy finds an issue related to below line:

uint64_t bits = t;

where if t is something like unit24_t, it gets compile error:

/usr/local/include/ipmid/message/pack.hpp:141:18: error: no viable conversion from 'const fixed_uint_t<24U>' (aka 'const number<boost::multiprecision::cpp_int_backend<24U, 24U, boost::multiprecision::unsigned_magnitude, boost::multiprecision::unchecked, void>>') to 'uint64_t' (aka 'unsigned long') [clang-diagnostic-error]

Fix it by using static_cast.

Signed-off-by: Lei YU <yulei.sh@bytedance.com>
Change-Id: I8cda6ec7dc48cab0da38cd1c587eb2da2121d287

show more ...

sensor-cache: Use async calls in get sensor reading

Use the async calls in ipmiSensorGetSensorReading() for cached sensors.

Note that the code was using sdbusplus::message as the parameter for the

sensor-cache: Use async calls in get sensor reading

Use the async calls in ipmiSensorGetSensorReading() for cached sensors.

Note that the code was using sdbusplus::message as the parameter for the
getFunc(), now it could be simplified to ipmi::PropertyMap and unify the
two cases: property update callback and getting property.

Tested: Verify the ipmi sensor list works fine.

Signed-off-by: Lei YU <yulei.sh@bytedance.com>
Change-Id: If7afed410f794a5317b8d4b4965cac291a735d12

show more ...

sensor-cache: Implement reading data

Implement reading data in property changed callback.
With sensor-cache, the sensor's property is returned by the
callback of propertiesChanged match, parse the p

sensor-cache: Implement reading data

Implement reading data in property changed callback.
With sensor-cache, the sensor's property is returned by the
callback of propertiesChanged match, parse the property from the message
and generate the sensor's response.

Tested: Verify the sensors using `readingData` have valid values in
QEMU, e.g.

Inlet_Temp | 20.000 | degrees C | ok | na | 0.000 | 5.000 | 38.000 | 43.000 | na

Signed-off-by: Lei YU <yulei.sh@bytedance.com>
Change-Id: I2c6328cb6001d0daf2045d17e73773dccf55d521

show more ...

sensor-cache: Use new get function

The get function for sensor-cache will use the sdbusplus message to get
the sensor data instead of making DBus calls, where the sdbusplus
message could be a signal

sensor-cache: Use new get function

The get function for sensor-cache will use the sdbusplus message to get
the sensor data instead of making DBus calls, where the sdbusplus
message could be a signal callback, or the getAllProperty's reply message.

So the get function's prototype is changed.

Tested: Verify the build is OK when enable or disable the sensor-cache
option.

Signed-off-by: Lei YU <yulei.sh@bytedance.com>
Change-Id: Ife2f55d87ce2b0941a4efdb599e46d80d827c2ff

show more ...

properly handle unexpected exceptions

Prior code followed a poorly explained example and then would
just re-throw the exception without actually catching it. The
new code (while specific to gcc and

properly handle unexpected exceptions

Prior code followed a poorly explained example and then would
just re-throw the exception without actually catching it. The
new code (while specific to gcc and clang) will log the unexpected
exception type so it will not be fatal.

Tested: throw an std::string in a handler and see that it is not fatal.
MESSAGE=Handler failed to catch exception
EXCEPTION=std::__cxx11::basic_string<char,
std::char_traits<char>, std::allocator<char> >

Change-Id: I4734aba8ea6fb02ad8ce54be55e860d2b4c6576c
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

show more ...

Add a SecureBuffer class

SecureBuffer is like SecureString, but a specialization of
std::vector<uint8_t> that cleans up after itself

Tested: Executed various ipmi commands to see that they still wo

Add a SecureBuffer class

SecureBuffer is like SecureString, but a specialization of
std::vector<uint8_t> that cleans up after itself

Tested: Executed various ipmi commands to see that they still work

Change-Id: Ifd255ef682d6e46d981de6a5a294d12f3666698b
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

show more ...

Fix issues and support signed sensor values

Sensor will get "disable" when the command "ipmitool sdr elist" is
executed that if sensorReadingType is 0x6F.

sensor_units_1 is always set to 0 currentl

Fix issues and support signed sensor values

Sensor will get "disable" when the command "ipmitool sdr elist" is
executed that if sensorReadingType is 0x6F.

sensor_units_1 is always set to 0 currently. To support the display of
signed sensor values, we add the attribute "sensorUnits1" to the sensor
mapping yaml. This attribute can be used to determine whether the
sensor is signed.

It were making negative values 0 in get::readingData(). Fix the issue
by using a int32_t and add an overflow check.

Change-Id: I705defcf18805db9ada7d0de0738a59aedab61df
Signed-off-by: Tony Lee <tony.lee@quantatw.com>

show more ...

Move SecureString class to ipmid/types.hpp

SecureString class doesn't have access in user_library to use in
other files

Tested:
Added class to ipmid/types.hpp from user_channel/user_mgmt.hpp
Build

Move SecureString class to ipmid/types.hpp

SecureString class doesn't have access in user_library to use in
other files

Tested:
Added class to ipmid/types.hpp from user_channel/user_mgmt.hpp
Build got successful.

Signed-off-by: Snehalatha Venkatesh <snehalathax.v@intel.com>
Change-Id: I5e0c4bb0744113e70540b272f16a5116421048fb

show more ...

Fixed timeout completion code

According to IPMI v2.0 timeout code is 0xc3.

Not tested
ccTimeout is used only in responseTimeout() and responseTimeout is never called.

Signed-off-by: Karol Niczyj <

Fixed timeout completion code

According to IPMI v2.0 timeout code is 0xc3.

Not tested
ccTimeout is used only in responseTimeout() and responseTimeout is never called.

Signed-off-by: Karol Niczyj <karol.niczyj@intel.com>
Change-Id: Iecf79724dac64d61dc08fce08daee578a540dbf9

show more ...

dbus-sdr: ipmiSetSensorReading handles discrete event for VR

Add the functionality for setting Voltage Regulator Mode as a writable
discrete sensor. Move sensor related helper functions into the nam

dbus-sdr: ipmiSetSensorReading handles discrete event for VR

Add the functionality for setting Voltage Regulator Mode as a writable
discrete sensor. Move sensor related helper functions into the namespace
of sensor.

The VR Controller is distinguished as having an interface of
xyz.openbmc_project.Control.VoltageRegulatorMode:
https://github.com/openbmc/phosphor-dbus-interfaces/blob/a7a6db3f770f5a1a5fd660ba3f6a611c435db616/xyz/openbmc_project/Control/VoltageRegulatorMode.interface.yaml

Tested = integrate-tested with VR daemon and ipmitool:

Example Tests,

// Setting to profileB (4)
$ ipmitool raw 0x4 0x30 0xb4 0 0 4 0 0 0 0 0 0 -v
Running Get PICMG Properties my_addr 0x20, transit 0, target 0
Error response 0xc1 from Get PICMG Properities
Running Get VSO Capabilities my_addr 0x20, transit 0, target 0
Invalid completion code received: Invalid command
Discovered IPMB address 0x0
RAW REQ (channel=0x0 netfn=0x4 lun=0x0 cmd=0x30 data_len=10)
RAW REQUEST (10 bytes)
b4 00 00 04 00 00 00 00 00 00
RAW RSP (0 bytes)

// Setting to profileA (2)
$ ipmitool raw 0x4 0x30 0xb4 0 0 2 0 0 0 0 0 0 -v
Running Get PICMG Properties my_addr 0x20, transit 0, target 0
Error response 0xc1 from Get PICMG Properities
Running Get VSO Capabilities my_addr 0x20, transit 0, target 0
Invalid completion code received: Invalid command
Discovered IPMB address 0x0
RAW REQ (channel=0x0 netfn=0x4 lun=0x0 cmd=0x30 data_len=10)
RAW REQUEST (10 bytes)
b4 00 00 02 00 00 00 00 00 00
RAW RSP (0 bytes)

$ journalctl -u vr_sensor_profiled.service --since "1 min ago" | tee
-- Logs begin at Thu 1970-01-01 00:00:25 UTC, end at Thu 1970-01-01 00:49:52 UTC. --
Jan 01 00:49:11 $HOST vr_sensor_profiled[4195]: Info: Transition VR Sensor 0 profile from profileA to profileB
Jan 01 00:49:52 $HOST vr_sensor_profiled[4195]: Info: Transition VR Sensor 0 profile from profileB to profileA

Signed-off-by: Hao Jiang <jianghao@google.com>
Change-Id: I9d6d2e8e5fa6b2be804a2657c6db079562247d90
Signed-off-by: Willy Tu <wltu@google.com>

show more ...

types: Force underlying int conversion for enums

Boost 1.76.0 changed the behavior of numeric to not accept implicitly
converted ints from enum class types. This breaks many of our casts and
would r

types: Force underlying int conversion for enums

Boost 1.76.0 changed the behavior of numeric to not accept implicitly
converted ints from enum class types. This breaks many of our casts and
would require 2 casts in most cases.

This adds a convenience function to do the underlying type conversions
needed to cast enums to ints and vice versa.

Change-Id: Id653d6a10ef5cab8267c174848940807d693dbf1
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

dbus-sdr: Initial Dynamic Sensor Stack

Migrate intel-ipmi-oem dynamic sensor stack into
phosphor-host-ipmid for more general use.

The files are copied from
https://gerrit.openbmc-project.xyz/c/open

dbus-sdr: Initial Dynamic Sensor Stack

Migrate intel-ipmi-oem dynamic sensor stack into
phosphor-host-ipmid for more general use.

The files are copied from
https://gerrit.openbmc-project.xyz/c/openbmc/intel-ipmi-oem/+/39743

https://gerrit.openbmc-project.xyz/plugins/gitiles/openbmc/intel-ipmi-oem/+/b910987a7d832e38e9342f0946aeb555a48f9cb0

Created `libdynamiccmds` to enable dynamic sensor stack.

Minor changes in the migration include:

1, Removing the use of `commandutils.hpp` in all files since it is only used
for
```
static constexpr bool debug = false;
```
It is added to `sdrutils.hpp` instead.

2, Update lastWriteAddr to size_t to match the vector.size() type
during comparison.

3, Renamed the sensorcommand unit test to sensorcommands_unitest.cpp

4, Removed unused variables.
- sensorcommands
```
constexpr uint8_t thresholdMask = 0xFF;
```
- sensorcommands_unitest
```
double yError = std::abs(y - yRoundtrip);
```
5, Removed Intel Specific Changes
- Redfish logs
- node manager/ME
- BIOS to SEL event
6, Removed externing a global variable for sensorTree.
- Replaced it with a method that returns a singleton
- auto& sensorTree = getSensorTree(); for access
7, Replaced intel_oem namespace with dynamic_sensors

8, Removed types.hpp and use `ipmid/types.hpp` directly
- Updated the types to match ipmid/types
- Added Association and std::vector<Association>> under Value.

9, Add cpp files for sdrutils and sensorutils.

10, link libipmid as it is required for getManagedObjects needed
by sensorcommands.cpp

Signed-off-by: Willy Tu <wltu@google.com>
Change-Id: If944620c895ecf4c9f4c3efe72479f4de276f4fb
Signed-off-by: Vijay Khemka <vijaykhemkalinux@gmail.com>

show more ...

ipmid/handler: Support exceptions with completion codes

Handlers don't always have a clear way to propagate error codes up to
the top level ipmi executor logic. This change defines an exception they

ipmid/handler: Support exceptions with completion codes

Handlers don't always have a clear way to propagate error codes up to
the top level ipmi executor logic. This change defines an exception they
can throw that will provide a message + code for the executor.

Change-Id: I5491111e4471910669ddba1c3f4469dc004232eb
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

Fix IPMI `Out of space` response error code.

As per IPMI spec `out of space` error code is 0xC4.

Tested:
IPMI responseOutOfSpace() returns correct string "Out of space".

Signed-off-by: Sharad Yada

Fix IPMI `Out of space` response error code.

As per IPMI spec `out of space` error code is 0xC4.

Tested:
IPMI responseOutOfSpace() returns correct string "Out of space".

Signed-off-by: Sharad Yadav <sharady@nvidia.com>
Change-Id: I134b2f0afbf23dcd083f6642d7e64f68546c4603

show more ...

phosphor-host-ipmid : yosemitev2: Add host Identification support

Added host Identification support in ipmid. This helps to
identify the particular hosts. The channel indexes for
hosts are getting f

phosphor-host-ipmid : yosemitev2: Add host Identification support

Added host Identification support in ipmid. This helps to
identify the particular hosts. The channel indexes for
hosts are getting from ipmb json config and passed from ipmb.

TESTED : Built Facebook YosemiteV2 & Tiogapass images and loaded on
the target hardware. We are able to see hostId's for all the hosts.

Note : This is the follow-up patch for multiple channels
support in ipmbbridge.
https://gerrit.openbmc-project.xyz/c/openbmc/ipmbbridge/+/34579

Signed-off-by: Kumar Thangavel <thangavel.k@hcl.com>
Change-Id: I01f1783f6c95780a62639d5ce9edc0b420d57be9

show more ...

sensor yaml: allow custom sensor names

Currently, we can only name sensors based on data from the dbus object
implementing a sensor's interface. While this mostly works, there may
not be a sensible

sensor yaml: allow custom sensor names

Currently, we can only name sensors based on data from the dbus object
implementing a sensor's interface. While this mostly works, there may
not be a sensible name to extract in all cases.

This change introduces an optional sensorName property to the sensor
YAML description, which allows a custom name to be used.

Signed-off-by: Jeremy Kerr <jk@codeconstruct.com.au>
Change-Id: I3f3b8ef581c70fbde94db122d4f3c0ca181c6ff7

show more ...

Fix includes

This patchset tries to fix some of the include problems in
phosphor-ipmi-host. First, it relies on io_service, which is
deprecated, and will not compile in boost 1.74. It also relies

Fix includes

This patchset tries to fix some of the include problems in
phosphor-ipmi-host. First, it relies on io_service, which is
deprecated, and will not compile in boost 1.74. It also relies on the
fact that sdbusplus #includes <asio.hpp> as a whole, this patchset makes
it add the correct includes, so it can compile on its own, and we can
improve compile times by removing asio.hpp from sdbusplus.

Signed-off-by: Ed Tanous <ed@tanous.net>
Change-Id: I0ab3b202b07a716368711dc6528d984c73bcb9d9

show more ...

Add LUN to the IPMI sensor context structure

Systems monitored by BMCs may have more than 255 sensors. This code
change provides the necessary piece to allow a BMC to support more
than 255 sensors.

Add LUN to the IPMI sensor context structure

Systems monitored by BMCs may have more than 255 sensors. This code
change provides the necessary piece to allow a BMC to support more
than 255 sensors. It does this by adding a variable to store a LUN
value. This allows LUN 0 to manage 255 sensors, and any overflow may
be assigned to LUN 1.

Tested:

Confirmed the following commands still work:
"ipmitool sdr elist"
"ipmitool sensor list"
"ipmitool raw 4 0x20 0"
"ipmitool raw -l 1 4 0x20 0"

Change-Id: I92d5205eac33829d8133f2e38ed96bfc5a9bc033
Signed-off-by: Johnathan Mantey <johnathanx.mantey@intel.com>

show more ...

include: ipmid/api.h add std::size_t

Add inclusion of cstddef and prefix size_t into standard namespace.
This is done to avoid build issues if a size_t isn't immediately
defined.

Signed-off-by: Pat

include: ipmid/api.h add std::size_t

Add inclusion of cstddef and prefix size_t into standard namespace.
This is done to avoid build issues if a size_t isn't immediately
defined.

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I486c2856023a6644c07b7062fa9c0264cc6b6e3e

show more ...