ipmid: Update sdbuspp namespaces

Fixed all errors when we remove
`SDBUSPP_REMOVE_DEPRECATED_NAMESPACE` in sdbusplus.

Change-Id: I5607585b2709faa7aee347d26e458ef769ca1626
Signed-off-by: Willy Tu <wl

ipmid: Update sdbuspp namespaces

Fixed all errors when we remove
`SDBUSPP_REMOVE_DEPRECATED_NAMESPACE` in sdbusplus.

Change-Id: I5607585b2709faa7aee347d26e458ef769ca1626
Signed-off-by: Willy Tu <wltu@google.com>

show more ...

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: I44441096113929ce96eb1439e2932e6ff3c87f27
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are for:
* bus_t
* exception_t
* manager_t
* match_t
* message_t
* object_t
* slot_t

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ibd2a0b512bfb7caf65bfab64b271d194da520aac

show more ...

add try-catch when call setAttention method

Currently, users can use btbridge/ssifbridge/kcsbridge to interact BMC
and HOST. But only btbridge define "org.openbmc.HostIpmi", therefore, if
the platfo

add try-catch when call setAttention method

Currently, users can use btbridge/ssifbridge/kcsbridge to interact BMC
and HOST. But only btbridge define "org.openbmc.HostIpmi", therefore, if
the platform does not use btbridge, host-ipmid will throw an exception
when try to check the status of HOST when call setAttention method.
This commit adds the try-catch to make platform still work moothly when
uses ssifbridge/kcsbridge.

Tested:
1. Use ssifbridge to interact BMC and HOST.
2. Check Host condition.
busctl introspect xyz.openbmc_project.Control.Host \
/xyz/openbmc_project/control/host0
3. Display information of "/xyz/openbmc_project/control/host0"

Signed-off-by: Thang Tran <thuutran@amperecomputing.com>
Change-Id: I63e584c1f89c6b31de4fa66beb3f0e0b6bdf5e0f

show more ...

mapper: remove mapper from host attention path

Error injection testing has shown a significant bottleneck in the host
attention path as the BMC is processing the error and also receiving

mapper: remove mapper from host attention path

Error injection testing has shown a significant bottleneck in the host
attention path as the BMC is processing the error and also receiving
commands from an external device requesting writes to the flash.

During this scenario, there are a lot of BMC processes stopping and
starting (as the host is being stopped and error data is collected).
This results in a lot of work for the mapper application. It must delete
its data structure for removed services and introspect all new services.

This heavy workload by mapper not only affects the overall utilization
of the BMC processor, but it also affect any other applications making
D-Bus calls into mapper.

Given the critical nature of this host ipmid code, which is being used
as a part of the protocol with the debug collecting external device,
it's important that mapper not be a bottle neck in this flow. This
commit removes the mapper call from this critical path and just hard
codes the needed service name.

In general, BMC code is moving away from using mapper as a service
lookup application if there is minimal chance of a service being
implemented by multiple applications. In this case, the
org.openbmc.HostIpmi service has had a single implementation since
the beginning of the project.

Tested:
Verified that with this change the error inject was successfully
processed and expected error was logged.

Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: I4db3b309db0169cbb98a9c0fd7527379a9071287

show more ...

mapper: remove un-needed string defines

The mapper function was moved to a utility function so these are no
longer needed

Signed-off-by: Andrew Geissler <geissonator@yahoo.com>

mapper: remove un-needed string defines

The mapper function was moved to a utility function so these are no
longer needed

Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: I5014ee635f0c130c51643e74f8140b4a0b95f8fc

show more ...

move variant to std namespace

sdbusplus::message::variant_ns has been std for a while now. This moves
ipmid away from sdbusplus::message::variant_ns to directly use
std::variant.

move variant to std namespace

sdbusplus::message::variant_ns has been std for a while now. This moves
ipmid away from sdbusplus::message::variant_ns to directly use
std::variant.

Tested-by: built, compiles, and runs the same as before.

Change-Id: I8caa945f31c926c2721319f001b9d7f83fd3f1b7
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

show more ...

Move util.cpp/util.hpp to libipmid

These are functions that are used widely by ipmid providers, so it makes
sense to put them in libipmi.so (the library that all providers must
link

Move util.cpp/util.hpp to libipmid

These are functions that are used widely by ipmid providers, so it makes
sense to put them in libipmi.so (the library that all providers must
link against).

Tested-by: use nm to inspect the binaries to see that the symbols are in
the expected library.

arm-openbmc-linux-gnueabi-nm libipmid.so.0.0.0 \
| grep getDbusObject
0001063c T _ZN4ipmi13getDbusObjectERN9sdbusplus....

Change-Id: I1221f807f2711c5301c5574623564ea1ae48a437
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

show more ...

ipmid: host-cmd-manager to use default event source for timers

The sdbusplus/timer.hpp class can be passed an event, but by default, it
just uses the default system event queue. This upd

ipmid: host-cmd-manager to use default event source for timers

The sdbusplus/timer.hpp class can be passed an event, but by default, it
just uses the default system event queue. This updates the
host-cmd-manager Manager class to use the defaults.

Tested-by: Send the heartbeat command with the host powered off and
watch for a timeout message:

dbus-send --print-reply --system \
--dest=xyz.openbmc_project.Ipmi.Host \
/xyz/openbmc_project/control/host0 \
xyz.openbmc_project.Control.Host.Execute \
string:"xyz.openbmc_project.Control.Host.Command.Heartbeat"

Watch the log (journalctl -f):

Nov 27 00:34:52 wolfpass ipmid[1255]: Pushing cmd on to queue
Nov 27 00:34:52 wolfpass ipmid[1255]: Pushing cmd on to queue
Nov 27 00:34:52 wolfpass ipmid[1255]: Asserting SMS Attention
Nov 27 00:34:52 wolfpass ipmid[1255]: SMS Attention asserted
Nov 27 00:35:23 wolfpass ipmid[1255]: Host control timeout hit!

Change-Id: I904d34b67050723a9c7e405bda4e02f1a9cb4dbd
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

show more ...

Convert variant usage to std interface

This is just a refactoring to use the c++17 std::variant interfaces
instead of the mapbox::variant specific ones. We should be able to use
mapb

Convert variant usage to std interface

This is just a refactoring to use the c++17 std::variant interfaces
instead of the mapbox::variant specific ones. We should be able to use
mapbox::variant and std::variant interchangeably now.

Tested:
Built against sdbusplus with mapbox::variant and sbusplus using
std::variant. Both variant compile and test out.

Change-Id: I6fbaad3d12dd34968db6a10f3d74a65e07d0f0cc
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

Use the common timer class

The common timer class from sdbusplus offers all the timer goodness that
we currently use. The unit test is also no longer needed (and has been
added to sd

Use the common timer class

The common timer class from sdbusplus offers all the timer goodness that
we currently use. The unit test is also no longer needed (and has been
added to sdbusplus's version of the timer.hpp implementation).

Change-Id: I278817489433a29ca739f70fdacd8bb897797d66
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

show more ...

rename headers to match style

Moving headers from ".h" to ".hpp"

Reworked the header inclusion a bit so that host-ipmid is treated as a
library, and local headers aren't.

rename headers to match style

Moving headers from ".h" to ".hpp"

Reworked the header inclusion a bit so that host-ipmid is treated as a
library, and local headers aren't.

renamed apphandler.h => apphandler.hpp
renamed chassishandler.h => chassishandler.hpp
renamed globalhandler.h => globalhandler.hpp
renamed sensorhandler.h => sensorhandler.hpp
renamed storageaddsel.h => storageaddsel.hpp
renamed storagehandler.h => storagehandler.hpp
renamed systemintfcmds.h => systemintfcmds.hpp

Change-Id: I9d4ce3dd57e2e996800f9020a10cc10cdf2c3914
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

add .clang-format

Change-Id: I7c2a527b4751a560703a61fcbe9638b150546af5
Signed-off-by: Patrick Venture <venture@google.com>

Clear host command queue on a power on

When the RequestedHostTransition property changes to On, clear
any pending commands in the command queue. This is done to avoid
race condition

Clear host command queue on a power on

When the RequestedHostTransition property changes to On, clear
any pending commands in the command queue. This is done to avoid
race conditions around state transitions as well as other
scenarios like the following:

1) Host is already off
2) RequestedHostTransition is set to Off
3) RequestedHostTransition is set to On
4) Host powers on
5) Host immediately powers off because of the pending command
sent in 2).

Resolves openbmc/openbmc#3207

Tested: Verified the scenario above no longer occurs.

Change-Id: I26c8195c305c75b01333d1b10ff4bf16d76b91a6
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

show more ...

Reducing IPMI logging footprint

-host-ipmid is very noisy in terms of journal logging. A small step
towards cleaning that up.
-Also converted printfs to phosphor-logging.

Pa

Reducing IPMI logging footprint

-host-ipmid is very noisy in terms of journal logging. A small step
towards cleaning that up.
-Also converted printfs to phosphor-logging.

Partially Resolves openbmc/openbmc#2507

Change-Id: I749c19c18d1cabf6f0216830c8cb0a08ee43d6de
Signed-off-by: Aditya Saripalli <aditya0124@gmail.com>
Signed-off-by: Nagaraju Goruganti <ngorugan@in.ibm.com>

show more ...

Make host command manager accessible by OpenPower OEM

Since OpenPower Host IPMI OEM also needs to use the Host
Command manager, need to place the files in appropriate
directories and

Make host command manager accessible by OpenPower OEM

Since OpenPower Host IPMI OEM also needs to use the Host
Command manager, need to place the files in appropriate
directories and make needed changes.

Change-Id: I7536a0ff1e53a844ec05f73c4e0605cbf4341465
Signed-off-by: Vishwanatha Subbanna <vishwa@linux.vnet.ibm.com>

show more ...

Use Host Command Manager in host interface implementation

Change-Id: Icefce510a3a0022bf0288fa99518459b732a2e04
Signed-off-by: Vishwanatha Subbanna <vishwa@linux.vnet.ibm.com>

Define the Manager for handling host bound commands

Since some of the host bound commands are valid only for
OpenPower systems, a manager is needed, which can handle
commands from Op

Define the Manager for handling host bound commands

Since some of the host bound commands are valid only for
OpenPower systems, a manager is needed, which can handle
commands from OpenBmc common code and also OpenPower
implementations.

Change-Id: Icf6566e701921ecea4c8cff1c16e498385303396
Signed-off-by: Vishwanatha Subbanna <vishwa@linux.vnet.ibm.com>

show more ...