Watchdog: Add watchdog LogTimeout property setting function

Add function to set LogTimeout property to implement the function of
the watchdog not recording logs.

Tested:
No log bit is set to true :

Watchdog: Add watchdog LogTimeout property setting function

Add function to set LogTimeout property to implement the function of
the watchdog not recording logs.

Tested:
No log bit is set to true :
ipmitool raw 0x06 0x24 0x84 0x00 0x00 0x3e 0x64 0x00

No log bit is set to false :
ipmitool raw 0x06 0x24 0x04 0x00 0x00 0x3e 0x64 0x00

Reset watchdog timer :
ipmitool mc watchdog reset

If the LogTimeout property is true, the event will be logged
on watchdog expiration.
We can use 'ipmitool sel elist' to check the system event log.
1 | 01/26/23 | 00:21:21 PST | Watchdog2 host0 | Timer expired | Asserted

If the LogTimeout property is false, the event will not be
logged when the watchdog expires.

Related-Commit-Id: 66240
Related-Commit-Id: 67727

Change-Id: I9cf9a294be7f584760dc03efaab02384f17e4686
Signed-off-by: Tim Chao <Tim.Chao@quantatw.com>

show more ...

Revert "Watchdog: Add Notlog setting function"

This reverts commit 5203602888ecd350bafc941b932ad3e01350be19.

The dbus interfaces and the implementation of this in phosphor-watchdog
was abandoned wi

Revert "Watchdog: Add Notlog setting function"

This reverts commit 5203602888ecd350bafc941b932ad3e01350be19.

The dbus interfaces and the implementation of this in phosphor-watchdog
was abandoned without being merged. We need to revert this in order
to get phosphor-host-ipmi SRCREV updates moving.

Change-Id: I26562c09b180b68baf9c04f6b4ac6ef57129a0ad
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

ipmid: Update sdbuspp namespaces

Fixed all errors when we remove
`SDBUSPP_REMOVE_DEPRECATED_NAMESPACE` in sdbusplus.

Change-Id: I5607585b2709faa7aee347d26e458ef769ca1626
Signed-off-by: Willy Tu <wl

ipmid: Update sdbuspp namespaces

Fixed all errors when we remove
`SDBUSPP_REMOVE_DEPRECATED_NAMESPACE` in sdbusplus.

Change-Id: I5607585b2709faa7aee347d26e458ef769ca1626
Signed-off-by: Willy Tu <wltu@google.com>

show more ...

Watchdog: Add Notlog setting function

Add function to set Notlog property to implement the function of
the watchdog not recording logs.

Related commit:
https://gerrit.openbmc.org/c/openbmc/phosphor

Watchdog: Add Notlog setting function

Add function to set Notlog property to implement the function of
the watchdog not recording logs.

Related commit:
https://gerrit.openbmc.org/c/openbmc/phosphor-dbus-interfaces/+/66240
https://gerrit.openbmc.org/c/openbmc/phosphor-watchdog/+/66242

Change-Id: Ia90c345a72f8f877aa8f8216337a1267f09b839a
Signed-off-by: Tim Chao <Tim.Chao@quantatw.com>

show more ...

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are for:
* bus_t
* exception_t
* manager_t
* match_t
* message_t
* object_t
* slot_t

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ibd2a0b512bfb7caf65bfab64b271d194da520aac

show more ...

app/watchdog: Always use resetTimeRemaining

The SetWatchdog function currently sets the intervals and then the time
remaining on the watchdog. It uses the user provided interval for both

app/watchdog: Always use resetTimeRemaining

The SetWatchdog function currently sets the intervals and then the time
remaining on the watchdog. It uses the user provided interval for both
values. Recently, the watchdog was extended to allow for the interval to
be capped above a certain value to prevent the user from setting
watchdogs that are known to be too short. In order to keep the
timeRemaining in sync with the value in the watchdog, just use the
resetTimeRemaining() function which reads the current interval to set
the timeRemaining.

Change-Id: I3f15030a85c625fcb1ed8040add03496618a5ece
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

Watchdog: move get and set watchdog to new api.

Rewrite "get and set watchdog" command to use the newly
introduced ipmi api.

Tested:
Verified using ipmitool "get and set wat

Watchdog: move get and set watchdog to new api.

Rewrite "get and set watchdog" command to use the newly
introduced ipmi api.

Tested:
Verified using ipmitool "get and set watchdog",
timer behavior is same before and after the changes.

Testing Procedure:
default watchdog timer is 11.2 seconds.

ipmitool raw 0x06 0x25 ---> Get
Output: 00 00 00 00 70 17 70 17

Note: Here 70 count(hex value)->112 count(decimal value)->112*100=11200ms
[100ms per count]->11.2sec (watchdog timer)

watchdog timer set to 20 seconds.

ipmitool raw 0x06 0x24 0x44 0x01 0x00 0x10 0xc8 0x00 ----> Set
output:

ipmitool raw 0x06 0x25 ---> Get
output: 04 01 00 00 c8 00 c8 00

Note: Here 20sec->20000ms->200count->c8 (hex value)

Signed-off-by: Deepak Kumar Sahu <deepakx.sahu@intel.com>
Change-Id: Id8c096bc1635d1900ee842a9726c49fb690fa8bc

show more ...

Move util.cpp/util.hpp to libipmid

These are functions that are used widely by ipmid providers, so it makes
sense to put them in libipmi.so (the library that all providers must
link

Move util.cpp/util.hpp to libipmid

These are functions that are used widely by ipmid providers, so it makes
sense to put them in libipmi.so (the library that all providers must
link against).

Tested-by: use nm to inspect the binaries to see that the symbols are in
the expected library.

arm-openbmc-linux-gnueabi-nm libipmid.so.0.0.0 \
| grep getDbusObject
0001063c T _ZN4ipmi13getDbusObjectERN9sdbusplus....

Change-Id: I1221f807f2711c5301c5574623564ea1ae48a437
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

show more ...

Add timer use field support in watchdog command

Tested:
ipmitool raw 0x06 0x24 1 0 0 0 0 0
ipmitool mc watchdog get

Change-Id: Iaffd6622821d33183a52f54a4e2e52a36aa17dde

Add timer use field support in watchdog command

Tested:
ipmitool raw 0x06 0x24 1 0 0 0 0 0
ipmitool mc watchdog get

Change-Id: Iaffd6622821d33183a52f54a4e2e52a36aa17dde
Signed-off-by: Yong Li <yong.b.li@linux.intel.com>

show more ...

add .clang-format

Change-Id: I7c2a527b4751a560703a61fcbe9638b150546af5
Signed-off-by: Patrick Venture <venture@google.com>

watchdog: Get only the initialized property during reset

Since we switched to resetting the watchdog with a built-in method, we
are only using a single property from the watchdog. Instea

watchdog: Get only the initialized property during reset

Since we switched to resetting the watchdog with a built-in method, we
are only using a single property from the watchdog. Instead of fetching
all the properties and reading just the initialized one, only request
the initialized property from the watchdog.

Change-Id: I5e29b5100629e1ce23f352b0b749a434cd1ab793
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

watchdog: Use ResetTimeRemaining for wd_reset

Using this helper method reduces the number of dbus calls made during
each watchdog reset.

Change-Id: I373db3babe03e05fca33eb4dbbbc

watchdog: Use ResetTimeRemaining for wd_reset

Using this helper method reduces the number of dbus calls made during
each watchdog reset.

Change-Id: I373db3babe03e05fca33eb4dbbbc7c07f95a39ea
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

watchdog: Cache service name

We have occasionally noticed that the watchdog will be enabled and then
immediately trip upon booting of the BMC. This happens if the host is
still runni

watchdog: Cache service name

We have occasionally noticed that the watchdog will be enabled and then
immediately trip upon booting of the BMC. This happens if the host is
still running when the BMC is coming up. Digging into the issue we notice
that the phosphor-mapper can be under very heavy load responding to all
of the initial mapping requests from BMC daemons starting. This causes a
delay in the phosphor-watchdog service name lookup during an attempt to
reset the watchdog countdown. The lookup delay is so long that the
watchdog ends up tripping before the reset is actually issued, causing
the BMC to reset the host. Since we know that the watchdog will not be
armed until the service resolves for the first time, we can reduce the
dependence and pressure on the service mapper by caching the service
name. Since it is the case that we want to keep issuing resets to the
same daemon that was initially configured, we should have no worries
about invalidating the cached service name. The name will be invalidated
any time we encounter a dbus level error issuing a watchdog commmand.

Change-Id: I303a39be997c2e57050b71efc8ef2e2cb27f8cf7
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

watchdog: Implement watchdog action setting

We now respect the action set during the SetTimeout command. This maps
to one of the actions defined by the dbus Watchdog interface

C

watchdog: Implement watchdog action setting

We now respect the action set during the SetTimeout command. This maps
to one of the actions defined by the dbus Watchdog interface

Change-Id: I4d13d2539a2d955a4340bf5f915ca6f3b694550a
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

watchdog: Implement initialized using the new dbus interface

This makes it possible for the phosphor-host-ipmi or any other watchdog
managing daemon to report to the caller that the watc

watchdog: Implement initialized using the new dbus interface

This makes it possible for the phosphor-host-ipmi or any other watchdog
managing daemon to report to the caller that the watchdog was not configured
if the phosphor-watchdog daemon restarts for any reason.

Change-Id: Iae3a8554c2f5d1cb89368f3ce14b3d44922599c0
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

watchdog: Rewrite using sdbusplus

Change-Id: I730317954819859d23fdaca7336f19f5c5b0c107
Signed-off-by: William A. Kennington III <wak@google.com>