Remove unused variables

Using clang-tidy, it was detected that some variables are no longer
in use. This commit remove unused variables.

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id

Remove unused variables

Using clang-tidy, it was detected that some variables are no longer
in use. This commit remove unused variables.

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: I382e6ce07e66dc5ad082be9b36d217a037e609b5

show more ...

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda forma

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda formatting also changed, so we have made changes to the
organization default style format to better handle lambda formatting.

See I5e08687e696dd240402a2780158664b7113def0e for updated style.
See Iea0776aaa7edd483fa395e23de25ebf5a6288f71 for clang-18 enablement.

Change-Id: I01547e98d27910919e09ebf7907c86292a6c825d
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

app: remove unused commands

Since the implementations of commands ipmi_app_channel_info,
ipmi_get_channel_access, and ipmi_set_channel_access have been
removed in a previous patch [1], this commit r

app: remove unused commands

Since the implementations of commands ipmi_app_channel_info,
ipmi_get_channel_access, and ipmi_set_channel_access have been
removed in a previous patch [1], this commit removes the
declarations in hpp.

[1]: https://github.com/openbmc/phosphor-host-ipmid/commit/d2a57decf383eb3faf3587739ad0b3181b7bb2d6

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: Ice8b824abba4126d373cdfcf63364b6257d045ac

show more ...

app: switch to lg2

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: Id55c91667a7bd0184ec4d55d6e1c15844d9ffb50

Watchdog: Add watchdog LogTimeout property setting function

Add function to set LogTimeout property to implement the function of
the watchdog not recording logs.

Tested:
No log bit is set to true :

Watchdog: Add watchdog LogTimeout property setting function

Add function to set LogTimeout property to implement the function of
the watchdog not recording logs.

Tested:
No log bit is set to true :
ipmitool raw 0x06 0x24 0x84 0x00 0x00 0x3e 0x64 0x00

No log bit is set to false :
ipmitool raw 0x06 0x24 0x04 0x00 0x00 0x3e 0x64 0x00

Reset watchdog timer :
ipmitool mc watchdog reset

If the LogTimeout property is true, the event will be logged
on watchdog expiration.
We can use 'ipmitool sel elist' to check the system event log.
1 | 01/26/23 | 00:21:21 PST | Watchdog2 host0 | Timer expired | Asserted

If the LogTimeout property is false, the event will not be
logged when the watchdog expires.

Related-Commit-Id: 66240
Related-Commit-Id: 67727

Change-Id: I9cf9a294be7f584760dc03efaab02384f17e4686
Signed-off-by: Tim Chao <Tim.Chao@quantatw.com>

show more ...

Revert "Watchdog: Add Notlog setting function"

This reverts commit 5203602888ecd350bafc941b932ad3e01350be19.

The dbus interfaces and the implementation of this in phosphor-watchdog
was abandoned wi

Revert "Watchdog: Add Notlog setting function"

This reverts commit 5203602888ecd350bafc941b932ad3e01350be19.

The dbus interfaces and the implementation of this in phosphor-watchdog
was abandoned without being merged. We need to revert this in order
to get phosphor-host-ipmi SRCREV updates moving.

Change-Id: I26562c09b180b68baf9c04f6b4ac6ef57129a0ad
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

ipmid: Update sdbuspp namespaces

Fixed all errors when we remove
`SDBUSPP_REMOVE_DEPRECATED_NAMESPACE` in sdbusplus.

Change-Id: I5607585b2709faa7aee347d26e458ef769ca1626
Signed-off-by: Willy Tu <wl

ipmid: Update sdbuspp namespaces

Fixed all errors when we remove
`SDBUSPP_REMOVE_DEPRECATED_NAMESPACE` in sdbusplus.

Change-Id: I5607585b2709faa7aee347d26e458ef769ca1626
Signed-off-by: Willy Tu <wltu@google.com>

show more ...

Watchdog: Add Notlog setting function

Add function to set Notlog property to implement the function of
the watchdog not recording logs.

Related commit:
https://gerrit.openbmc.org/c/openbmc/phosphor

Watchdog: Add Notlog setting function

Add function to set Notlog property to implement the function of
the watchdog not recording logs.

Related commit:
https://gerrit.openbmc.org/c/openbmc/phosphor-dbus-interfaces/+/66240
https://gerrit.openbmc.org/c/openbmc/phosphor-watchdog/+/66242

Change-Id: Ia90c345a72f8f877aa8f8216337a1267f09b839a
Signed-off-by: Tim Chao <Tim.Chao@quantatw.com>

show more ...

Remove is_method_error method

Remove the usage of is_method_error()[1], and add try-catch to handle
D-Bus exceptions around mapper call.

[1]https://github.com/openbmc/sdbusplus/commit/079fb85a398d9

Remove is_method_error method

Remove the usage of is_method_error()[1], and add try-catch to handle
D-Bus exceptions around mapper call.

[1]https://github.com/openbmc/sdbusplus/commit/079fb85a398d90800935e3985bb1266a7530a26e#diff-945669e8bd9cab4ecc83a574a732921281b2c79eb8bba65efff11736ad18f92bR237-R240

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I85192219c1c34cf5fd6c6aca06a8b207d7e06697

show more ...

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: I44441096113929ce96eb1439e2932e6ff3c87f27
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are for:
* bus_t
* exception_t
* manager_t
* match_t
* message_t
* object_t
* slot_t

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ibd2a0b512bfb7caf65bfab64b271d194da520aac

show more ...

build: Add meson build for phosphor-host-ipmi

Create meson and meson_options for the existing features.

Removed sample.h/cpp since that is not used at all.

Tested:
Ipmi command works fine the clea

build: Add meson build for phosphor-host-ipmi

Create meson and meson_options for the existing features.

Removed sample.h/cpp since that is not used at all.

Tested:
Ipmi command works fine the cleanup.
```
$ systemctl status phosphor-ipmi-host
● phosphor-ipmi-host.service - Phosphor Inband IPMI
Loaded: loaded (/lib/systemd/system/phosphor-ipmi-host.service; enabled; vendor preset: enabled)
Active: active (running) since Thu 1970-01-08 21:20:56 UTC; 21s ago
Main PID: 24987 (ipmid)
CGroup: /system.slice/phosphor-ipmi-host.service
└─24987 /tmp/ipmid

Jan 08 21:20:56 $HOST ipmid[24987]: Registering OEM:[0X002B79], Cmd:[0X30] for Ethstats Commands
Jan 08 21:20:56 $HOST ipmid[24987]: Registering OEM:[0X00C2CF], Cmd:[0X30] for Ethstats Commands
Jan 08 21:20:56 $HOST ipmid[24987]: Registering OEM:[0X002B79], Cmd:[0X32] for Sys Commands
Jan 08 21:20:56 $HOST ipmid[24987]: Registering OEM:[0X002B79], Cmd:[0X02] for I2C
Jan 08 21:20:56 $HOST ipmid[24987]: Registering OEM:[0X00C2CF], Cmd:[0X02] for I2C
Jan 08 21:20:56 $HOST ipmid[24987]: I2C_WHITELIST_CHECK is disabled, do not populate whitelist
Jan 08 21:20:56 $HOST ipmid[24987]: Registering OEM:[0X00C2CF], Cmd:[0X04] for Manual Zone Control
Jan 08 21:20:56 $HOST systemd[1]: Started Phosphor Inband IPMI.
Jan 08 21:20:56 $HOST ipmid[24987]: Loading whitelist filter
Jan 08 21:20:56 $HOST ipmid[24987]: Set restrictedMode = true
(reverse-i-search)`ipmi': systemctl status phosphor-^Cmi-host

$ ipmitool mc info
Device ID : 32
Device Revision : 1
Firmware Revision : 0.00
IPMI Version : 2.0
Manufacturer ID : 7244
Manufacturer Name : Quanta Computer Inc.
Product ID : 14426 (0x385a)
Product Name : Unknown (0x385A)
Device Available : yes
Provides Device SDRs : yes
Additional Device Support :
Sensor Device
SEL Device
FRU Inventory Device
Chassis Device
Aux Firmware Rev Info :
0x00
0x00
0x00
0x00
```

Change-Id: Ibaea9eea802b063a0207320654cbb817fde30c2a
Signed-off-by: Willy Tu <wltu@google.com>

show more ...

remove unused enable/disableNetworkIPMI functions

enableNetworkIPMI and disableNetworkIPMI were legacy functions from
before implementing separate netipmid instances for each network
interface.

Cha

remove unused enable/disableNetworkIPMI functions

enableNetworkIPMI and disableNetworkIPMI were legacy functions from
before implementing separate netipmid instances for each network
interface.

Change-Id: Ife54412e9dcb86f96309db2cda071de70405b29d
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

show more ...

types: Force underlying int conversion for enums

Boost 1.76.0 changed the behavior of numeric to not accept implicitly
converted ints from enum class types. This breaks many of our casts and
would r

types: Force underlying int conversion for enums

Boost 1.76.0 changed the behavior of numeric to not accept implicitly
converted ints from enum class types. This breaks many of our casts and
would require 2 casts in most cases.

This adds a convenience function to do the underlying type conversions
needed to cast enums to ints and vice versa.

Change-Id: Id653d6a10ef5cab8267c174848940807d693dbf1
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

Don't report serviceable action if the watchdog service is not present

There were a few cases where a service action was reported because the
watchdog service was not present. It was because of a ra

Don't report serviceable action if the watchdog service is not present

There were a few cases where a service action was reported because the
watchdog service was not present. It was because of a race condition where
the power down operation is trigerred and the watchdog service is shutdown
but if was followed by a watchdog reset. Since the watchdog service is absent
it resulted in an error log which calls for serviceable action. The IPMI error
response code will report the failure to the host platform software.

Change-Id: Iaf0a860b53fbd85dc451fc4d4a337406ba74e0d6
Signed-off-by: Tom Joseph <tomjoseph@in.ibm.com>

show more ...

app/watchdog: Always use resetTimeRemaining

The SetWatchdog function currently sets the intervals and then the time
remaining on the watchdog. It uses the user provided interval for both
values. Rec

app/watchdog: Always use resetTimeRemaining

The SetWatchdog function currently sets the intervals and then the time
remaining on the watchdog. It uses the user provided interval for both
values. Recently, the watchdog was extended to allow for the interval to
be capped above a certain value to prevent the user from setting
watchdogs that are known to be too short. In order to keep the
timeRemaining in sync with the value in the watchdog, just use the
resetTimeRemaining() function which reads the current interval to set
the timeRemaining.

Change-Id: I3f15030a85c625fcb1ed8040add03496618a5ece
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

Expiration flags fix for watchdog get/set commands

The expiration flags should be retain their state
across system resets and power cycles.

Tested:
Set “BIOS FRB2” and start
ipmitool raw 0x06 0x24

Expiration flags fix for watchdog get/set commands

The expiration flags should be retain their state
across system resets and power cycles.

Tested:
Set “BIOS FRB2” and start
ipmitool raw 0x06 0x24 0x01 0x00 0x00 0x00 0x30 0x00
ipmitool mc watchdog reset

after stopped:
Timer Expiration Flags should be : (0x02)
* BIOS FRB2

Then Set “BIOS/POST” and start,
ipmitool raw 0x06 0x24 0x02 0x00 0x00 0x00 0x30 0x00
ipmitool mc watchdog reset

after stopped:
Timer Expiration Flags should be : (0x06)
* BIOS FRB2
* BIOS/POST

“impitool mc watchdog get” displays the correct Timer Expiration Flags
when the timer is running;

Signed-off-by: Yong Li <yong.b.li@linux.intel.com>
Change-Id: Ic0c27c6c1e8bed2db8ce30fc0eec2a6538bb1992

show more ...

channel:Fix get channel ciphersuite - payloadtypes

Issue: Get channel CipherSuite command passed with invalid payload type

Fix: Added the check now to allow only valid payload types

Tested:
Comman

channel:Fix get channel ciphersuite - payloadtypes

Issue: Get channel CipherSuite command passed with invalid payload type

Fix: Added the check now to allow only valid payload types

Tested:
Command: ipmitool raw 0x06 0x54 0x01 0xff 0x80
Response: Unable to send RAW command (channel=0x0 netfn=0x6 lun=0x0 cmd=0x54
rsp=0x80): Unknown (0x80)

Command: ipmitool raw 0x06 0x54 0x01 0x12 0x80
Response: 01 c0 03 01 41 81 c0 11 03 44 81

Command: ipmitool raw 0x06 0x54 0x01 0x09 0x80
Response: Unable to send RAW command (channel=0x0 netfn=0x6 lun=0x0 cmd=0x54
rsp=0x80): Unknown (0x80)

Command: ipmitool raw 0x06 0x54 0x01 0x02 0x00
Response: Unable to send RAW command (channel=0x0 netfn=0x6 lun=0x0 cmd=0x54
rsp=0x80): Unknown (0x80)
Command: ipmitool raw 0x06 0x54 0x01 0x12 0x00
Response: 01 01 03 41 44 81

Signed-off-by: jayaprakash Mutyala <mutyalax.jayaprakash@intel.com>
Change-Id: I552250736d7e898191ddbb45fd1bff42681b9c63

show more ...

Data checking fix for watchdog set/get commands

data length check for timeout action and byte 1 reserved field check
are missing, causing not to throw the error;
Log flags is on bit 7, also needs to

Data checking fix for watchdog set/get commands

data length check for timeout action and byte 1 reserved field check
are missing, causing not to throw the error;
Log flags is on bit 7, also needs to right-shift this flag;
This commit fixes these issues;

Tested:
Set different timer use/actions:
ipmitool raw 0x06 0x24 0x85 0x0 0x0 0x0 0x64 0x00
ipmitool raw 0x06 0x24 0x84 0x1 0x0 0x0 0x64 0x00

Check the settings are correct:
ipmitool raw 0x06 0x25

Signed-off-by: Yong Li <yong.b.li@linux.intel.com>
Change-Id: Ia4226bb4597d2c670f93522aa763e43d15eb6cf1

show more ...

transporthandler: Rewrite + New Handler

This rewrites the old transport handler to use the new ipmi handler
registration functions. It attempts to clean up the old code, by
refactoring any business

transporthandler: Rewrite + New Handler

This rewrites the old transport handler to use the new ipmi handler
registration functions. It attempts to clean up the old code, by
refactoring any business logic out of the code that parses the IPMI
messages. This makes the code paths easier to understand and allows for
better code re-use.

This also gets rid of the concept of the settings change timer. Clients
expect to see their settings take effect as soon as they are set,
regardless of the "Set In Progress" flag. This means we no longer need a
cache for our network settings that are about to be set by the daemon,
and a client can hold the BMC in "Set In Progress" while it verifies
settings like other BMC implementations.

Change-Id: I5406a674f087600afdfc2c0b3adeacde10986abc
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

Fix: execute get channel cipher suite in lan chan

Get channel cipher suites command was executed for non lan channels.
Fixing the same by adding active lan channel support check.

Tested:
ipmitool r

Fix: execute get channel cipher suite in lan chan

Get channel cipher suites command was executed for non lan channels.
Fixing the same by adding active lan channel support check.

Tested:
ipmitool raw 0x06 0x54 0x01 0x00 0x80
01 c0 03 01 41 81 c0 11 03 44 81
//cmd executed for lan chan 1

ipmitool raw 0x06 0x54 0x00 0x00 0x80
Unable to send RAW command (channel=0x0 netfn=0x6 lun=0x0
cmd=0x54 rsp=0xcc): Invalid data field in request
//cc resulted for non lan chan 0

Signed-off-by: Ayushi Smriti <smriti.ayushi@linux.intel.com>
Change-Id: Ic3c2dfa3f4537be789e2afc912fa8f4c2a49bda4

show more ...

Fix: refactor get channel cipher suite command

Get channel cipher suites command updated as per new ipmi structure.

Tested:
ipmitool raw 0x06 0x54 0x01 0x00 0x80
01 c0 03 01 41 81 c0 11 03 44 81

Fix: refactor get channel cipher suite command

Get channel cipher suites command updated as per new ipmi structure.

Tested:
ipmitool raw 0x06 0x54 0x01 0x00 0x80
01 c0 03 01 41 81 c0 11 03 44 81 //response

Also verified by issuing cmd:
ipmitool channel getciphers ipmi 0x01
which listed supported CIA algorithms as response

Signed-off-by: Ayushi Smriti <smriti.ayushi@linux.intel.com>
Change-Id: Ibc942f5b197c72071cd35a138fbe244db7519824

show more ...

Static code analysis scan issue fix

Fix the issues found during code static scan

Tested:
test in board, function works fine.
1. busctl set-property for watchdog, it works fine.
2. It works by runni

Static code analysis scan issue fix

Fix the issues found during code static scan

Tested:
test in board, function works fine.
1. busctl set-property for watchdog, it works fine.
2. It works by running "ipmitool chassis power soft".
3. run "ipmitool raw 0x6 0x46 1", get expected user information.

Change-Id: I7a2cc3c934db6a7531f8a8ea05956cb6d6337633
Signed-off-by: Chen,Yugang <yugang.chen@linux.intel.com>

show more ...

Watchdog: move get and set watchdog to new api.

Rewrite "get and set watchdog" command to use the newly
introduced ipmi api.

Tested:
Verified using ipmitool "get and set watchdog",
timer behavior i

Watchdog: move get and set watchdog to new api.

Rewrite "get and set watchdog" command to use the newly
introduced ipmi api.

Tested:
Verified using ipmitool "get and set watchdog",
timer behavior is same before and after the changes.

Testing Procedure:
default watchdog timer is 11.2 seconds.

ipmitool raw 0x06 0x25 ---> Get
Output: 00 00 00 00 70 17 70 17

Note: Here 70 count(hex value)->112 count(decimal value)->112*100=11200ms
[100ms per count]->11.2sec (watchdog timer)

watchdog timer set to 20 seconds.

ipmitool raw 0x06 0x24 0x44 0x01 0x00 0x10 0xc8 0x00 ----> Set
output:

ipmitool raw 0x06 0x25 ---> Get
output: 04 01 00 00 c8 00 c8 00

Note: Here 20sec->20000ms->200count->c8 (hex value)

Signed-off-by: Deepak Kumar Sahu <deepakx.sahu@intel.com>
Change-Id: Id8c096bc1635d1900ee842a9726c49fb690fa8bc

show more ...

Return error if the input data is larger than expected

If the input data length exceeds the expected, return len_invalid too

Tested:
ipmitool raw 0x06 0x24 0x01 0x13 0x0 0x2 0xa 0x00 0xff

Will ret

Return error if the input data is larger than expected

If the input data length exceeds the expected, return len_invalid too

Tested:
ipmitool raw 0x06 0x24 0x01 0x13 0x0 0x2 0xa 0x00 0xff

Will return error

Signed-off-by: Yu Ren <yux.ren@intel.com>
Change-Id: I12168f4aed51c499fd06067ca4475917b68e819e

show more ...