metric-config: remove thresholds on total-memory

The total memory metric cannot change and it isn't really possible to
have a threshold on it. Remove the bogus threshold.

Signed-off-by: Patrick Wi

metric-config: remove thresholds on total-memory

The total memory metric cannot change and it isn't really possible to
have a threshold on it. Remove the bogus threshold.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I99659919afc55b636dc2a22dca33e0caae634847

show more ...

metric-config: remove thresholds on userspace and kernel CPU

We do not need a default threshold on the userspace and kernel CPU
metrics because we already have a threshold on the overall CPU usage.

metric-config: remove thresholds on userspace and kernel CPU

We do not need a default threshold on the userspace and kernel CPU
metrics because we already have a threshold on the overall CPU usage.
Sustained CPU usage is likely what someone wants to identify, no matter
which side of the accounting it is attributed to. Delete the extra
thresholds.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I56352169b3fc50f11410f054053c39c40a79b82e

show more ...

fix the byte multiplier for /proc/meminfo values

Fix the byte multiplier for values being read from /proc/meminfo to use
1024 for kibibytes rather than 1000 for kilobytes as it represents
values in

fix the byte multiplier for /proc/meminfo values

Fix the byte multiplier for values being read from /proc/meminfo to use
1024 for kibibytes rather than 1000 for kilobytes as it represents
values in kibibytes.

Change-Id: Ib7c34ab9e944171918b626bca5efd2518202ed04
Signed-off-by: Jagpal Singh Gill <paligill@gmail.com>

show more ...

remove default bmc_health_config.json

Remove default bmc_health_config.json as default config is in code now
in health_metric_config.cpp.

Change-Id: Ie3dd21a77f84a5417e1cfef7ddde1a1eaf0fad3c
Signed

remove default bmc_health_config.json

Remove default bmc_health_config.json as default config is in code now
in health_metric_config.cpp.

Change-Id: Ie3dd21a77f84a5417e1cfef7ddde1a1eaf0fad3c
Signed-off-by: Jagpal Singh Gill <paligill@gmail.com>

show more ...

metric_config: add lower bound support

Add the lower bound support to the metric config and fix the parsing
logic to update threshold configs accordingly. Update the collection
test for lower bound.

metric_config: add lower bound support

Add the lower bound support to the metric config and fix the parsing
logic to update threshold configs accordingly. Update the collection
test for lower bound.

Change-Id: I6fd3bd8d85974f95ba877eb8d19a77c8acffef7c
Signed-off-by: Jagpal Singh Gill <paligill@gmail.com>

show more ...

health_metric: add threshold lower bound support

Add the lower bound logic to the threshold monitoring.

Change-Id: I445d58a798cdbc04c8d818b9156a8431daed6aa7
Signed-off-by: Jagpal Singh Gill <paligi

health_metric: add threshold lower bound support

Add the lower bound logic to the threshold monitoring.

Change-Id: I445d58a798cdbc04c8d818b9156a8431daed6aa7
Signed-off-by: Jagpal Singh Gill <paligill@gmail.com>

show more ...

mapper: use async client for GetSubTreePaths

Use the generated client bindings instead of hard-coding strings for
function names and parameters.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

mapper: use async client for GetSubTreePaths

Use the generated client bindings instead of hard-coding strings for
function names and parameters.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ica2c6f29961a81a484548a8f74634067c53cec3d

show more ...

use async context more in health monitor

Push the async context into the HealthMonitor class implementation.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I465c9c839016416e683415dd

use async context more in health monitor

Push the async context into the HealthMonitor class implementation.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I465c9c839016416e683415dd235e69817b7e1ba6

show more ...

Add Jagpal as a reviewer

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I19fe75212c1e217b3108204cb7160a63f3e61660

expose storage health metric value in bytes

Fix logic to expose storage health metric in bytes rather than KiB.

Change-Id: Ie8b5c1953076a4d1c7795836e64d871c80a59043
Signed-off-by: Jagpal Singh Gill

expose storage health metric value in bytes

Fix logic to expose storage health metric in bytes rather than KiB.

Change-Id: Ie8b5c1953076a4d1c7795836e64d871c80a59043
Signed-off-by: Jagpal Singh Gill <paligill@gmail.com>

show more ...

enable health_monitor new implementation

Add health_monitor interface and implementation. Enable the
health_monitor from existing healthMonitor flow.
This change is in relation to following design a

enable health_monitor new implementation

Add health_monitor interface and implementation. Enable the
health_monitor from existing healthMonitor flow.
This change is in relation to following design and D-Bus interface
update -
https://gerrit.openbmc.org/c/openbmc/docs/+/64917
https://gerrit.openbmc.org/c/openbmc/phosphor-dbus-interfaces/+/64914

Tested:
```
busctl tree xyz.openbmc_project.HealthMon
`- /xyz
`- /xyz/openbmc_project
`- /xyz/openbmc_project/metric
`- /xyz/openbmc_project/metric/bmc
|- /xyz/openbmc_project/metric/bmc/cpu
| |- /xyz/openbmc_project/metric/bmc/cpu/kernel
| |- /xyz/openbmc_project/metric/bmc/cpu/total
| `- /xyz/openbmc_project/metric/bmc/cpu/user
|- /xyz/openbmc_project/metric/bmc/memory
| |- /xyz/openbmc_project/metric/bmc/memory/available
| |- /xyz/openbmc_project/metric/bmc/memory/buffered_and_cached
| |- /xyz/openbmc_project/metric/bmc/memory/free
| |- /xyz/openbmc_project/metric/bmc/memory/shared
| `- /xyz/openbmc_project/metric/bmc/memory/total
`- /xyz/openbmc_project/metric/bmc/storage
|- /xyz/openbmc_project/metric/bmc/storage/rw
`- /xyz/openbmc_project/metric/bmc/storage/tmp

curl -k https://localhost:8443/redfish/v1/Managers/bmc/ManagerDiagnosticData
--user "root:0penBmc"
{
"@odata.id": "/redfish/v1/Managers/bmc/ManagerDiagnosticData",
"@odata.type": "#ManagerDiagnosticData.v1_2_0.ManagerDiagnosticData",
"FreeStorageSpaceKiB": 3,
"Id": "ManagerDiagnosticData",
"MemoryStatistics": {
"AvailableBytes": 354029533,
"BuffersAndCacheBytes": 79077333,
"FreeBytes": 291730033,
"SharedBytes": 11876000,
"TotalBytes": 425516000
},
"Name": "Manager Diagnostic Data",
"ProcessorStatistics": {
"KernelPercent": 16.1534,
"UserPercent": 10.6638
},
"ServiceRootUptimeSeconds": 834.753
}

```

Change-Id: I1e9fac226b438f0556cb20321f1f2b6d51af7dbc
Signed-off-by: Jagpal Singh Gill <paligill@gmail.com>

show more ...

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are for:
* bus_t
* exception_t
* manager_t
* match_t
* message_t
* object_t
* slot_t

Change-Id: I7948c1c8108da238952abaa3e7d400fdca80c7e5
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

add health_metric_collection implementation

Add the interface and implementation for health_metric_collection which
encapsulates various health_metrics.
This change is in relation to following desig

add health_metric_collection implementation

Add the interface and implementation for health_metric_collection which
encapsulates various health_metrics.
This change is in relation to following design and D-Bus interface
update -
https://gerrit.openbmc.org/c/openbmc/docs/+/64917
https://gerrit.openbmc.org/c/openbmc/phosphor-dbus-interfaces/+/64914

Add test_health_metric_collection gtest for unit testing.

Change-Id: Ia0b9fbc6bec4850735c7eb74dcd5c40fc47c568c
Signed-off-by: Jagpal Singh Gill <paligill@gmail.com>

show more ...

health_metric_config: add more memory metrics

Add shared and bufferAndCached memory metric to health config.

Change-Id: I02a8f3e88e601b25fe93ba18676b73c4ddddc7a8
Signed-off-by: Jagpal Singh Gill <p

health_metric_config: add more memory metrics

Add shared and bufferAndCached memory metric to health config.

Change-Id: I02a8f3e88e601b25fe93ba18676b73c4ddddc7a8
Signed-off-by: Jagpal Singh Gill <paligill@gmail.com>

show more ...

health_metric_config: update the metric name

Update the metric name while parsing the health config.

Change-Id: Idb2691543aee73a17d3f27e03dcf93405ddce204
Signed-off-by: Jagpal Singh Gill <paligill@

health_metric_config: update the metric name

Update the metric name while parsing the health config.

Change-Id: Idb2691543aee73a17d3f27e03dcf93405ddce204
Signed-off-by: Jagpal Singh Gill <paligill@gmail.com>

show more ...

health_metric: add tmp storage support

Add the tmp storage support in health config parser and health metric.

Change-Id: Ibb265c28b22d786031ed152d2cc52f40814be984
Signed-off-by: Jagpal Singh Gill <

health_metric: add tmp storage support

Add the tmp storage support in health config parser and health metric.

Change-Id: Ibb265c28b22d786031ed152d2cc52f40814be984
Signed-off-by: Jagpal Singh Gill <paligill@gmail.com>

show more ...

health_metric_config: add storage tmp

Add the Storage_TMP to metric json config.

Change-Id: Ie32a71c936b974ebaaeb625f7018d4b875f831a2
Signed-off-by: Jagpal Singh Gill <paligill@gmail.com>

health_metric: avoid signal generation for init properties

Avoid signal generation for properties initialization for health
metrics.

Change-Id: If1d7f89a01f40022e6ed7073548291cf5f965b84
Signed-off-

health_metric: avoid signal generation for init properties

Avoid signal generation for properties initialization for health
metrics.

Change-Id: If1d7f89a01f40022e6ed7073548291cf5f965b84
Signed-off-by: Jagpal Singh Gill <paligill@gmail.com>

show more ...

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are for:
* bus_t
* exception_t
* manager_t
* match_t
* message_t
* object_t
* slot_t

Change-Id: Ie0805a98908ddca5c97471588adc160d9f5633c6
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

add health_metric implementation

Add the interface and implementation for the health_metric to be used
in the rewrite for phosphor-health-monitor.
This change is in relation to following design and

add health_metric implementation

Add the interface and implementation for the health_metric to be used
in the rewrite for phosphor-health-monitor.
This change is in relation to following design and D-Bus interface
update -
https://gerrit.openbmc.org/c/openbmc/docs/+/64917
https://gerrit.openbmc.org/c/openbmc/phosphor-dbus-interfaces/+/64914

gtest added for UT.

Change-Id: Iffcc52f9dff712890377b1222fd7e7d5d6661eaf
Signed-off-by: Jagpal Singh Gill <paligill@gmail.com>

show more ...

add health_metric_config implementation

Add the health_metric_config interface and implementation for
phosphor-health-monitor. This interface will be used in the
re-write of phosphor-health-monitor.

add health_metric_config implementation

Add the health_metric_config interface and implementation for
phosphor-health-monitor. This interface will be used in the
re-write of phosphor-health-monitor.
This change is in relation to following design and D-Bus interface
update-
https://gerrit.openbmc.org/c/openbmc/docs/+/64917
https://gerrit.openbmc.org/c/openbmc/phosphor-dbus-interfaces/+/64914

gtest added for UT.

Change-Id: Ic40faafbb57597023cc70036428d46ee69a895a2
Signed-off-by: Jagpal Singh Gill <paligill@gmail.com>

show more ...

Finish lg2 conversion

Use lg2 instead of cout/cerr.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ib9c47bd26a73c7d411161816ef1a106b76561ec9

meson: adjust nlohmann-json dependency

Simplify the nlohmann-json dependency in meson and use the wrap file
location aligned with other repos.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Ch

meson: adjust nlohmann-json dependency

Simplify the nlohmann-json dependency in meson and use the wrap file
location aligned with other repos.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I3c157966fafb5d9090c3c67d916b06932d3ef3df

show more ...

clang-format: copy latest and re-format

clang-format-17 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-17 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: Ia89f3b88381720be41bbb4ae626758fb0d0b9b4e
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

build: upgrade to C++23

Meson 1.1.1 and GCC-13 both support C++23 and a sufficient portion of
the standard has been implemented. Upgrade the build to leverage it.

Change-Id: I128440980a0e76a3dbb8a

build: upgrade to C++23

Meson 1.1.1 and GCC-13 both support C++23 and a sufficient portion of
the standard has been implemented. Upgrade the build to leverage it.

Change-Id: I128440980a0e76a3dbb8ab8e201790138c085542
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...