clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda forma

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda formatting also changed, so we have made changes to the
organization default style format to better handle lambda formatting.

See I5e08687e696dd240402a2780158664b7113def0e for updated style.
See Iea0776aaa7edd483fa395e23de25ebf5a6288f71 for clang-18 enablement.

Change-Id: If87740ef153661e338448c9de753cbd61fd164eb
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

OWNERS: remove Vijay

It has been since 2021 that Vijay has made any comments on a
phosphor-health-monitor code review and since 2020 since there
were any contributions. Jagpal has rewritten large p

OWNERS: remove Vijay

It has been since 2021 that Vijay has made any comments on a
phosphor-health-monitor code review and since 2020 since there
were any contributions. Jagpal has rewritten large portions of
the repository and was added as a maintainer. Remove Vijay.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I30acfb0f325ee5a28583b60ff626fa650bf07bd7

show more ...

request MAINTAINER access for repo

Add myself to the OWNERS list to request MAINTAINERS access for the
repo.

Change-Id: Ibf42281ed6d25a31ea107b11664ffc4e34277365
Signed-off-by: Jagpal Singh Gill <p

request MAINTAINER access for repo

Add myself to the OWNERS list to request MAINTAINERS access for the
repo.

Change-Id: Ibf42281ed6d25a31ea107b11664ffc4e34277365
Signed-off-by: Jagpal Singh Gill <paligill@gmail.com>

show more ...

Fix spelling mistakes using codespell

This commit corrects various spelling mistakes throughout the
repository. The corrections were made automatically using `codespell`[1]
tool.

[1]: https://githu

Fix spelling mistakes using codespell

This commit corrects various spelling mistakes throughout the
repository. The corrections were made automatically using `codespell`[1]
tool.

[1]: https://github.com/codespell-project/codespell

Change-Id: Ib3d3a9eae5d449323c49dec3794a74c8a6333997
Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>

show more ...

meson: Provide missing meson dependency for tests

Currently local meson build fails with error:
"""
../health_metric_config.cpp:5:10: fatal error: nlohmann/json.hpp:
No such file or directory
5

meson: Provide missing meson dependency for tests

Currently local meson build fails with error:
"""
../health_metric_config.cpp:5:10: fatal error: nlohmann/json.hpp:
No such file or directory
5 | #include <nlohmann/json.hpp>
"""
Add missing nlohmann_json dependency to fix the issue.

Tested:
Local build via "meson setup build && cd build && meson compile" now
finishes without errors.

Change-Id: I1f42d6a9c1ddf838a90f7d8b9d880cc4faf7150c
Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>

show more ...

remove "Not enough samples" log to journal

Noticed on a few systems that this is filling up the journal. Not sure
why the "debug" logs are even making it to the journal via lg2 but this
one needs to

remove "Not enough samples" log to journal

Noticed on a few systems that this is filling up the journal. Not sure
why the "debug" logs are even making it to the journal via lg2 but this
one needs to go if debug is going always be going to the journal by
default.

Change-Id: I6667552186c38bd38a2105c7cbd8aeb0aa56f3e6
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>

show more ...

bmc_health_config_json.md: add hysteresis info

Add the hysteresis info to the bmc_health_config_json.md.

Change-Id: I11721f5f8d014d9cffe4ffc0ed1100bafbb2b6a3
Signed-off-by: Jagpal Singh Gill <palig

bmc_health_config_json.md: add hysteresis info

Add the hysteresis info to the bmc_health_config_json.md.

Change-Id: I11721f5f8d014d9cffe4ffc0ed1100bafbb2b6a3
Signed-off-by: Jagpal Singh Gill <paligill@gmail.com>

show more ...

remove default values from in code json config

Remove the properties with default values from in code config.

Change-Id: I86f06ea60c0cdfef11594bc3825bc34f73ee2d02
Signed-off-by: Jagpal Singh Gill <

remove default values from in code json config

Remove the properties with default values from in code config.

Change-Id: I86f06ea60c0cdfef11594bc3825bc34f73ee2d02
Signed-off-by: Jagpal Singh Gill <paligill@gmail.com>

show more ...

change the window size default to 120

Change the window size default to 120 rather than 1.

Change-Id: Iffe843acd3966ac7a723a0969c791282e0f8c31c
Signed-off-by: Jagpal Singh Gill <paligill@gmail.com>

add json config and implementation for hysteresis

Add the json config for health metric hysteresis and implementation
logic for it. Update the health metric config test to validate the
hysteresis va

add json config and implementation for hysteresis

Add the json config for health metric hysteresis and implementation
logic for it. Update the health metric config test to validate the
hysteresis value.

Change-Id: I60c0daa601abee9ac1916581d23257cc04128dd0
Signed-off-by: Jagpal Singh Gill <paligill@gmail.com>

show more ...

add the meson option for monitor collection freq

Add the meson option for health monitor collection frequency with a
default value of 1s.

Change-Id: I47a87c5b85eebc676239d1d3dcf90037f0bc56b1
Signed

add the meson option for monitor collection freq

Add the meson option for health monitor collection frequency with a
default value of 1s.

Change-Id: I47a87c5b85eebc676239d1d3dcf90037f0bc56b1
Signed-off-by: Jagpal Singh Gill <paligill@gmail.com>

show more ...

drop the collection frequency from health metric

Drop the collection frequency from health metric config and its
corresponding code as collection frequency has been moved to
monitor specific propert

drop the collection frequency from health metric

Drop the collection frequency from health metric config and its
corresponding code as collection frequency has been moved to
monitor specific property rather than metric.

Change-Id: If8345581552b99397487cf5d67865f44e1b2fc2e
Signed-off-by: Jagpal Singh Gill <paligill@gmail.com>

show more ...

meson.build: remove unused config data options

Remove the unused config data options from meson.build

Change-Id: I31165ab25b797c1cf5234100e9a6e871d1545fd9
Signed-off-by: Jagpal Singh Gill <paligill

meson.build: remove unused config data options

Remove the unused config data options from meson.build

Change-Id: I31165ab25b797c1cf5234100e9a6e871d1545fd9
Signed-off-by: Jagpal Singh Gill <paligill@gmail.com>

show more ...

health metric: check hysteresis for value notify

Add hysteresis for metric value and check it before notifying the metric
value update.

Change-Id: I8dace4b9436dd9b16f1a075505079d5001928f52
Signed-o

health metric: check hysteresis for value notify

Add hysteresis for metric value and check it before notifying the metric
value update.

Change-Id: I8dace4b9436dd9b16f1a075505079d5001928f52
Signed-off-by: Jagpal Singh Gill <paligill@gmail.com>

show more ...

health metric: use instantaneous value

For health metric value update use the instantaneous value rather than
average value as initial average value calculation takes around 2 mins
because of window

health metric: use instantaneous value

For health metric value update use the instantaneous value rather than
average value as initial average value calculation takes around 2 mins
because of window size requirement.

Change-Id: I5e53536b79374a75b1ddfa18ab7a6f782c5ae361
Signed-off-by: Jagpal Singh Gill <paligill@gmail.com>

show more ...

health_metric: simplify type aliases

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I116b46a0633daae6c0b44e0419434f01a58aad58

add bmc health metric json markdown file

Add the markdown file for BMC health metric json which helps understand
its format and use.

Change-Id: I184889640ff64beba2426a2e33184b213235fe1e
Signed-off-

add bmc health metric json markdown file

Add the markdown file for BMC health metric json which helps understand
its format and use.

Change-Id: I184889640ff64beba2426a2e33184b213235fe1e
Signed-off-by: Jagpal Singh Gill <paligill@gmail.com>

show more ...

storage metric: add generic implementation

Add the generic implementation for the storage metric, so there is no
need to add a new enum value and new code, every time a new storage
type needs to be

storage metric: add generic implementation

Add the generic implementation for the storage metric, so there is no
need to add a new enum value and new code, every time a new storage
type needs to be added.

Change-Id: Idcd99455ca559eb6274a71613684a99b4b63a6f0
Signed-off-by: Jagpal Singh Gill <paligill@gmail.com>

show more ...

health metric config: add missing threshold level

Add the missing threshold levels to health metric config.

Change-Id: Ie988e1f1ac53a6a562e38cf6c61c1669b9269d7d
Signed-off-by: Jagpal Singh Gill <pa

health metric config: add missing threshold level

Add the missing threshold levels to health metric config.

Change-Id: Ie988e1f1ac53a6a562e38cf6c61c1669b9269d7d
Signed-off-by: Jagpal Singh Gill <paligill@gmail.com>

show more ...

improve enum logging

Ensure we're using an enumeration string everywhere we log one to
improve readability of the log statements.

This depends on I6850b0bb142f0ef5219a5fc07c2cb4e2c90d5779 from
phos

improve enum logging

Ensure we're using an enumeration string everywhere we log one to
improve readability of the log statements.

This depends on I6850b0bb142f0ef5219a5fc07c2cb4e2c90d5779 from
phosphor-logging for `to_string` conversion support.

Tested:

Running directly on development system shows:
```
<7> TYPE=CPU, NAME=CPU SUBTYPE=CPU PATH=, FREQ=1, WSIZE=120
<7> THRESHOLD TYPE=xyz.openbmc_project.Common.Threshold.Type.Warning THRESHOLD BOUND=xyz.openbmc_project.Common.Threshold.Bound.Upper VALUE=80.000000 LOG=False TARGET=
```

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I5ea7a050e94833af272e79e6add716d1d3e66571

show more ...

health_monitor: change the ctx run time frequency

Change the time frequency at which health monitor runs to 1 second.

Change-Id: I73330c05fbe55e9254823a0a20d3f6ef7cca8b38
Signed-off-by: Jagpal Sing

health_monitor: change the ctx run time frequency

Change the time frequency at which health monitor runs to 1 second.

Change-Id: I73330c05fbe55e9254823a0a20d3f6ef7cca8b38
Signed-off-by: Jagpal Singh Gill <paligill@gmail.com>

show more ...

threshold: use absolute value for D-Bus

Use the absolute value for threshold rather than percentage value.
This involves passing the total value from the metric collection so it
can be used in perce

threshold: use absolute value for D-Bus

Use the absolute value for threshold rather than percentage value.
This involves passing the total value from the metric collection so it
can be used in percentage calculation within health metric logic.

Change-Id: I46240aee54117c70637f9fbf882018f0eac520b2
Signed-off-by: Jagpal Singh Gill <paligill@gmail.com>

show more ...

Decrease logging severity for common message

The health monitor always logs this for each metric on start-up until
enough samples have been collected. Decrease it to debug log level.

Signed-off-by

Decrease logging severity for common message

The health monitor always logs this for each metric on start-up until
enough samples have been collected. Decrease it to debug log level.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I4b321b02c88c9e4b8d0b557e711a1c4fa41b1e44

show more ...

metric-config: remove the buffer/cache-memory threshold

The kernel will naturally attempt to use almost all free memory up with
buffers and caches. We should not have a threshold on this behavior
b

metric-config: remove the buffer/cache-memory threshold

The kernel will naturally attempt to use almost all free memory up with
buffers and caches. We should not have a threshold on this behavior
by default.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ic40a260667e89d62820e99753efda025ba5bde47

show more ...

metric-config: remove the free-memory threshold

By default we have a metric on the available memory. Free memory should
be a subset of available memory. You can have some memory held by
kernel cac

metric-config: remove the free-memory threshold

By default we have a metric on the available memory. Free memory should
be a subset of available memory. You can have some memory held by
kernel caches that can be evicted as needed, which show up in available
and not free. Having a threshold on free memory is probably not what
anyone wants by default, so remove it from the default config.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I16d15266b6e10e6c7a788095b4b29d5e603e102c

show more ...