Add systemd units for new phosphor-multi-gpio-monitor

Also added sample phosphor-multi-gpio-monitor.json for
configuration of list of GPIO to be monitored. Platform
specific file can be added throug

Add systemd units for new phosphor-multi-gpio-monitor

Also added sample phosphor-multi-gpio-monitor.json for
configuration of list of GPIO to be monitored. Platform
specific file can be added through bbappend file.

Signed-off-by: Vijay Khemka <vijaykhemka@fb.com>
Change-Id: I3a2fac155be4583aeee52f018da6be0b506633fd

show more ...

GPIO Monitor with multiple lines and libgpiod

Added a new GPIO monitor (phosphor-multi-gpio-monitor) which monitors
multiple gpio lines based on their line name or offset. GPIO details
need to be de

GPIO Monitor with multiple lines and libgpiod

Added a new GPIO monitor (phosphor-multi-gpio-monitor) which monitors
multiple gpio lines based on their line name or offset. GPIO details
need to be defined in a JSON file and needs to be passed to this daemon.

This uses libgpiod for accessing gpio lines and also uses CLI11 for
parsing input parameter.

Signed-off-by: Vijay Khemka <vijaykhemka@fb.com>
Change-Id: I843e6df8c1159888f2ca628d1f69c1d2294d29d6

show more ...

systemd: remove double braces

Previously these unit files were processed by pythons format() method,
so the double braces would be reduced to a single brace.

The unit files are no longer processed

systemd: remove double braces

Previously these unit files were processed by pythons format() method,
so the double braces would be reduced to a single brace.

The unit files are no longer processed so the double braces are not
removed and break starting of the unit.

Tested:
From systemctl status phosphor-gpio-presence@0.service:

`-398 /usr/bin/phosphor-gpio-presence --path=/dev/input/by-path/platform-gpio-keys-event --inventory=/system/chassis/motherboard/powersupply0 --key=104 --name=powersupply0 --drivers=/sys/bus/i2c/drivers/ibm-cffps,3-0069 --extra-ifaces=xyz.openbmc_project.Inventory.Item.PowerSupply

Nov 01 19:28:33 witherspoon-Y230UF71K03T systemd[1]: Started Phosphor GPIO 0 Presence.
Nov 01 19:28:34 witherspoon-Y230UF71K03T phosphor-gpio-presence[398]: Updating inventory present property

Change-Id: Iacb29c8524152f87c676fd70227b076a6c84b877
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>

show more ...

presence: fix systemd unit syntax error

26373ab Add systemd units for monitor and presence

added system units for the monitor and presence applications, but that
patch does not remove the special {

presence: fix systemd unit syntax error

26373ab Add systemd units for monitor and presence

added system units for the monitor and presence applications, but that
patch does not remove the special {envfiledir} replacement token that
exists in the original unit file. Replace with the actual path.

Change-Id: Ib51f30edb45d6186ea3890783f0f3430d3c184ea
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

Add systemd units for monitor and presence

Change-Id: I77593fe6b7927511042aeebff17519719c0742e3
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

build: drop autotools

With previously added support for building with meson/ninja autotools
support is no longer required.

Change-Id: I7bc2588ac71a7c37d1c542927dca8f8ae50c8c83
Signed-off-by: Brad B

build: drop autotools

With previously added support for building with meson/ninja autotools
support is no longer required.

Change-Id: I7bc2588ac71a7c37d1c542927dca8f8ae50c8c83
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

build: add support for building with meson

Follow the OpenBMC herd and support a more modern, more comprehensible,
more performant build framework.

To build using meson:
meson build
ninja -C

build: add support for building with meson

Follow the OpenBMC herd and support a more modern, more comprehensible,
more performant build framework.

To build using meson:
meson build
ninja -C build
ninja -C build install

Added -Dtests to match de-facto OpenBMC meson usage conventions.

Dropped support for --enable-oe-sdk rpath munging. This was a
workaround for broken oe sdks that don't figure out the correct rpath
when running make check or ninja test.

Ran existing unit tests (which passed) using ninja test.

Change-Id: I198700d866e1b23ba0a22b156335bbb973b98f43
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

gpio-util: fix some warnings

Fix a couple of warnings:

-Werror=unused-parameter

so we can use meson's warning_level=3 and -Werror without build
failures.

Change-Id: I667598763790d5ab0090820de329b

gpio-util: fix some warnings

Fix a couple of warnings:

-Werror=unused-parameter

so we can use meson's warning_level=3 and -Werror without build
failures.

Change-Id: I667598763790d5ab0090820de329b241639ae97c
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

build: fix some warnings

Fix a couple of warnings:

-Werror=unused-parameter

so we can use meson's warning_level=3 and -Werror without build
failures.

Change-Id: I14487a56727469f6bda1cabccce8241ac

build: fix some warnings

Fix a couple of warnings:

-Werror=unused-parameter

so we can use meson's warning_level=3 and -Werror without build
failures.

Change-Id: I14487a56727469f6bda1cabccce8241ac1acb149
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

monitor.cpp: don't include config.h

config.h doesn't contain anything useful. Don't include it.

Change-Id: Id3c77cd549a61a4dee295b1c2d5e33fc6d5d82fa
Signed-off-by: Brad Bishop <bradleyb@fuzziesqui

monitor.cpp: don't include config.h

config.h doesn't contain anything useful. Don't include it.

Change-Id: Id3c77cd549a61a4dee295b1c2d5e33fc6d5d82fa
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

gpio-presence: Support for multiple iface assocs

This will allow additional interfaces to be specified
to associate with inventory items to allow for further
customization of inventory items.

Speci

gpio-presence: Support for multiple iface assocs

This will allow additional interfaces to be specified
to associate with inventory items to allow for further
customization of inventory items.

Specifying property values for an interface added this way
is currently not supported.

Tested: Verified any given interface(s) is associated properly

Signed-off-by: Anthony Wilson <wilsonan@us.ibm.com>
Change-Id: I99e655b35120c82454a8851201218ec548ad9fe3

show more ...

build: install into bin instead of sbin

Installs into bin instead of sbin per guidelines.

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I1b764bb63d7a79b69a94f63e2c449b5e1ca5ffb8

build: pkg anti-pattern: use defaults

Use the defaults in the pkg check where the default error message is
sufficient to identify which package is missing.

Change-Id: If3a19a3857645dc36d48b3d849d1d

build: pkg anti-pattern: use defaults

Use the defaults in the pkg check where the default error message is
sufficient to identify which package is missing.

Change-Id: If3a19a3857645dc36d48b3d849d1d6a222a8cfbb
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

gpio: Fix missing cassert

This file is relying on assert() being transitively provided by
sdbusplus. Fix the includes.

Change-Id: Ia081478eb55a90bf5af541a4b16124dcfb224a13
Signed-off-by: William A.

gpio: Fix missing cassert

This file is relying on assert() being transitively provided by
sdbusplus. Fix the includes.

Change-Id: Ia081478eb55a90bf5af541a4b16124dcfb224a13
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

Add clang-format to repo

Add clang-format to repo.

Change-Id: I3f8704d80dd0bdde0706ab189c68cffe6d347995
Signed-off-by: Patrick Venture <venture@google.com>

cleanup: use const reference passing string

[presence/main.cpp:21]: (performance) Function parameter 'driverString' should
be passed by const reference.

Change-Id: I024e1622b03a3f2ac3487051bdd8f7e3

cleanup: use const reference passing string

[presence/main.cpp:21]: (performance) Function parameter 'driverString' should
be passed by const reference.

Change-Id: I024e1622b03a3f2ac3487051bdd8f7e3b403639d
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

phosphor-gpio-monitor: use c++17

Update configure.ac to choose the c++17 standard

Change-Id: Ie68586622ec8802ce1421dbbcfe8ec6a6f695df0
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

Spelling fixes

Spelling errors found using github.com/lucasdemarchi/codespell
A tool to fix common misspellings.
This tool is licensed under GNU General Public License, version 2.

Change-Id: Ic3964

Spelling fixes

Spelling errors found using github.com/lucasdemarchi/codespell
A tool to fix common misspellings.
This tool is licensed under GNU General Public License, version 2.

Change-Id: Ic396413f5bc7d9fc45e1042870634ea13185ae03
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Use s.c_str() in log messages

Partly Resolves openbmc/openbmc 2905

Tested: static_assert only

Change-Id: I16db5b66bf5a26558a2ed0c1617ef5466dadefea
Signed-off-by: Joseph Reynolds <jrey@us.ibm.com>

Add MAINTAINERS file

Change-Id: I15c1f6c0991927e51fa7c78bcb851ade8a8a3049
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

Make --continue as no_argument

This is an improvement for the previous commit, that make --continue
option as no_argument.

Tested: phosphor-gpio-monitor is able to run with or without --continue

Make --continue as no_argument

This is an improvement for the previous commit, that make --continue
option as no_argument.

Tested: phosphor-gpio-monitor is able to run with or without --continue
argument, and it it continues to run after key press with this
argument.

Change-Id: I6f9dc5423e19eace366e382a2408dd143a124915
Signed-off-by: Lei YU <mine260309@gmail.com>

show more ...

Add --continue argument

The monitor will exit when key is pressed.
Add --continue argument and if it is set to "true", the monitor will
continue after key is pressed.

This is useful in cases to mon

Add --continue argument

The monitor will exit when key is pressed.
Add --continue argument and if it is set to "true", the monitor will
continue after key is pressed.

This is useful in cases to monitor a button presses.
E.g. It can be used to monitor ID button and start a system unit
everytime when the button is pressed.

This argument is optional so it does not break the current code.

Tested: With "--continue=true", the monitor does not exit when the key
is pressed.
Without the argument of if it is set to other strings, the
monitor exits after the key is pressed.

Change-Id: I4f2ca16d7b26e10397181c83c2c5947ed5ce091f
Signed-off-by: Lei YU <mine260309@gmail.com>

show more ...

Spelling fixes

Spelling errors found using github.com/lucasdemarchi/codespell
A tool to fix common misspellings.
This tool is licensed under GNU General Public License, version 2.

Change-Id: I72697

Spelling fixes

Spelling errors found using github.com/lucasdemarchi/codespell
A tool to fix common misspellings.
This tool is licensed under GNU General Public License, version 2.

Change-Id: I726975922b185adefa65010ff60c391f143570ba
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Spelling fixes

Spelling errors found using github.com/lucasdemarchi/codespell
A tool to fix common misspellings.
This tool is licensed under GNU General Public License, version 2.

Change-Id: I7d8be

Spelling fixes

Spelling errors found using github.com/lucasdemarchi/codespell
A tool to fix common misspellings.
This tool is licensed under GNU General Public License, version 2.

Change-Id: I7d8bec30c823f0d73bbab748069edc6b1eb92ecc
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

gpio-presence: Pass drivers in to application

With the optional --drivers argument, pass in the
path/device pairs to bind/unbind. That string will be parsed,
and then passed into the Presence class

gpio-presence: Pass drivers in to application

With the optional --drivers argument, pass in the
path/device pairs to bind/unbind. That string will be parsed,
and then passed into the Presence class.

Change-Id: I1ac0e005de673a679dcb45e93bcac35fddf24d01
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

show more ...