Continue on missing GPIOs in the monitor/presence

In some cases, if a GPIO is not found, the function returns -1 to exit
the process. To improve this, change the return value from -1 to
continue so

Continue on missing GPIOs in the monitor/presence

In some cases, if a GPIO is not found, the function returns -1 to exit
the process. To improve this, change the return value from -1 to
continue so each object can be handled separately. This ensures
the JSON file fully parses even if some GPIOs are missing.

Change-Id: I83763d56963e3d2ec9981a95a1a0da17d0882910
Signed-off-by: Yang Chen <yang.chen@quantatw.com>

show more ...

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda forma

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda formatting also changed, so we have made changes to the
organization default style format to better handle lambda formatting.

See I5e08687e696dd240402a2780158664b7113def0e for updated style.
See Iea0776aaa7edd483fa395e23de25ebf5a6288f71 for clang-18 enablement.

Change-Id: Ia9dd4aed00238b28839b86dfe4ca93155a521766
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

README.md: Fix MD024 warnings

The following warnings are generated by using markdownlint analysis:
```
README.md:91 MD024/no-duplicate-heading Multiple headings with the same content [Context: "## C

README.md: Fix MD024 warnings

The following warnings are generated by using markdownlint analysis:
```
README.md:91 MD024/no-duplicate-heading Multiple headings with the same content [Context: "## Configuration"]
README.md:109 MD024/no-duplicate-heading Multiple headings with the same content [Context: "## Sample config file"]
```
Refer to markdown-lint [1] to fix MD024
[1]: https://github.com/updownpress/markdown-lint/blob/master/rules/024-no-duplicate-header.md

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: I37415b6d3212a0ac9419919095296e9ff2e21fad

show more ...

meson: Provide missing boost dependency and its wrap file

Currently local meson build fails with the error:
"""
fatal error: boost/asio/io_context.hpp: No such file or directory
"""
This is happenin

meson: Provide missing boost dependency and its wrap file

Currently local meson build fails with the error:
"""
fatal error: boost/asio/io_context.hpp: No such file or directory
"""
This is happening because boost is not listed as a dependency for the
targets that use it.
Add boost dependency for all the necessary targets and provide a wrap
file for boost for the local meson build.

Tested:
"meson setup build && cd build && meson compile" finishes successfully.

Change-Id: I3f418091d8a2da9377684e16ce3e2f88db4c6eb8
Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>

show more ...

meson: Provide "gmock" for local build

Currently local meson build fails with the error:
"""
test/meson.build:1:8: ERROR: Dependency "gmock" not found, tried
pkgconfig and system
"""
Provide "gmock/

meson: Provide "gmock" for local build

Currently local meson build fails with the error:
"""
test/meson.build:1:8: ERROR: Dependency "gmock" not found, tried
pkgconfig and system
"""
Provide "gmock/gtest" for local build to fix the issue.

Tested:
"meson setup build" no longer fails with the "gmock not found" error.

Change-Id: Ia5987e9355e76ce69fa5258d19f097be10a9d5f9
Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>

show more ...

meson: adjust nlohmann-json dependency

- Add the 'include_type' field to avoid clang-tidy warnings.
- Rename wrap file to align with meson wrapdb choice.

Signed-off-by: Patrick Williams <patrick@st

meson: adjust nlohmann-json dependency

- Add the 'include_type' field to avoid clang-tidy warnings.
- Rename wrap file to align with meson wrapdb choice.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I11866aa34c7b8defb0463c2d7bb9ec3fdb67c92d

show more ...

build: simplify nlohmann-json subproject and update

The bitbake package for nlohmann-json installs a nlohmann_json.pc
file and the subproject has a meson variable. We can simplify the
dependency in

build: simplify nlohmann-json subproject and update

The bitbake package for nlohmann-json installs a nlohmann_json.pc
file and the subproject has a meson variable. We can simplify the
dependency in the meson file significantly by using the correct
dependency name and adding a minor tweak to the wrapfile.

Also update the revision to HEAD rather than pinning.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Iddbbf8117d7d8e7a0cc6a4f9ad5c6e9bff984834

show more ...

clang-format: copy latest and re-format

clang-format-17 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-17 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: I4c5b9d2879d3f682f7ed9922a58712ef958f0547
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

Add phosphor-multi-gpio-presence

The new service works like phosphor-gpio-presence, but uses libgpiod
and can monitor an arbitrary amount of GPIOs.

The driver loading feature hasn't been ported to

Add phosphor-multi-gpio-presence

The new service works like phosphor-gpio-presence, but uses libgpiod
and can monitor an arbitrary amount of GPIOs.

The driver loading feature hasn't been ported to the new service.

Change-Id: I412345f804208e48eec40ec020b3a0d8f668a34b
Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>

show more ...

meson_options.txt: Support for reading options from meson.options

Support has been added for reading options from meson.options instead
of meson_options.txt[1]. These are equivalent, but not using t

meson_options.txt: Support for reading options from meson.options

Support has been added for reading options from meson.options instead
of meson_options.txt[1]. These are equivalent, but not using the .txt
extension for a build file has a few advantages, chief among them
many tools and text editors expect a file with the .txt extension to
be plain text files, not build scripts.

[1] https://mesonbuild.com/Release-notes-for-1-1-0.html#support-for-reading-options-from-mesonoptions

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: Ic9e17bdb9faf8c36b0451a9f19deba1d3f38cb9b

show more ...

phosphor-gpio-presence: Add expected method for CLI11

The Phosph-gpio-presence@.service template has a --drivers and
--extra-ifaces which can be empty in some configurations[1].
systemd will end up

phosphor-gpio-presence: Add expected method for CLI11

The Phosph-gpio-presence@.service template has a --drivers and
--extra-ifaces which can be empty in some configurations[1].
systemd will end up launching the process with an extra empty
argument. CLI11 will fail unless we give an explicit
"--drivers=<value> or --extra-ifaces=<value>".
Add the expected method to --drivers and --extra-ifaces to limit the
number of incoming parameters for parameters.

Observed in hardware testing:
```
--drivers: 1 required TEXT missing
Run with --help for more information.
```

[1] https://github.com/openbmc/openbmc/blob/master/meta-facebook/meta-bletchley/recipes-phosphor/gpio/phosphor-gpio-monitor/obmc/gpio/presence-sled1.conf

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: Iab8da95d88843652e657933656d9121b43311655

show more ...

phosphor-gpio-monitor: ignore extra args

The phosphor-gpio-monitor@.service template has an EXTRA_ARGS which
in some configs can be empty. systemd will end up launching the
process with an extra, e

phosphor-gpio-monitor: ignore extra args

The phosphor-gpio-monitor@.service template has an EXTRA_ARGS which
in some configs can be empty. systemd will end up launching the
process with an extra, empty argument. CLI11 fails on this unless
we give an explicit `allow_extra` call.

Observed in hardware testing:
```
Aug 09 19:28:46 witherspoon-Y230UF71K03T phosphor-gpio-monitor[632]: The following argument was not expected:
Aug 09 19:28:46 witherspoon-Y230UF71K03T phosphor-gpio-monitor[632]: Run with --help for more information.
```

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I42ae7e0e67f424bd1ae894a2a6a84b99ee32b723

show more ...

phosphor-gpio-monitor: fix continue flag

"--continue" is intended to be a flag and not a boolean option[1].

Change the CLI11 call so that we do not need a boolean value for it.

[1]: https://github

phosphor-gpio-monitor: fix continue flag

"--continue" is intended to be a flag and not a boolean option[1].

Change the CLI11 call so that we do not need a boolean value for it.

[1]: https://github.com/openbmc/openbmc/blob/master//meta-ibm/meta-romulus/recipes-phosphor/gpio/id-button/obmc/gpio/id_button#L5

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I6f870a0b416465e042ed6bf34d62db9be042c394

show more ...

build: add cli11 dependency as necessary

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I5431ae89a8b14e0ddad6e23895efaa044d67df46

meson: Enable tests by default

The test subdirectory should no longer be compiled when `tests`
disabled, So tests should be explicitly enabled by default.
Also `tests` has been disabled in meta-phos

meson: Enable tests by default

The test subdirectory should no longer be compiled when `tests`
disabled, So tests should be explicitly enabled by default.
Also `tests` has been disabled in meta-phosphor[1].

[1] https://gerrit.openbmc.org/c/openbmc/openbmc/+/43812

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I80352925719d3be137f99457ff38a948413f9c17

show more ...

meson: Replace configure_file with fs.copyfile

configure_file is deprecated since 0.64.0, and replace it with
fs.copyfile.

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I632344af1add12

meson: Replace configure_file with fs.copyfile

configure_file is deprecated since 0.64.0, and replace it with
fs.copyfile.

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I632344af1add1253214f22b08d42165e14eabfbd

show more ...

Fix some warnings by cppcheck

Warnign message:
evdev.hpp:23:9: warning: Assignment of function parameter has no
effect outside the function. Did you forget dereferencing it?
[uselessAssignmentPtrArg

Fix some warnings by cppcheck

Warnign message:
evdev.hpp:23:9: warning: Assignment of function parameter has no
effect outside the function. Did you forget dereferencing it?
[uselessAssignmentPtrArg]
event = sd_event_unref(event);
^
evdev.hpp:33:9: warning: Assignment of function parameter has no
effect outside the function. Did you forget dereferencing it?
[uselessAssignmentPtrArg]
eventSource = sd_event_source_unref(eventSource);
^
file.hpp:28:5: style: Class 'FileDescriptor' has a constructor with 1
argument that is not explicit. [noExplicitConstructor]
FileDescriptor(int fd) : fd(fd)
^

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I66cc8a3faebb39dabcaac71b6930c22acc351447

show more ...

Remove gpio-util

The gpio-util directory is not widely used in the community, and its
only known usage[1] has been removed, and so we agreed with the
maintainer to delete this directory.

[1] https:

Remove gpio-util

The gpio-util directory is not widely used in the community, and its
only known usage[1] has been removed, and so we agreed with the
maintainer to delete this directory.

[1] https://gerrit.openbmc.org/c/openbmc/openbmc/+/65642

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I61294b6a456e95532414687427b0c1cf36d58b4a

show more ...

presence: Replace Argument class with CLI11

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: Idd6e49c7206ce0b71990cc4999659bd51768f691

phosphor-gpio-monitor: Replace Argument class with CLI11

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: Id750beb9f8b8f8ec0c611c58b9a0ef86d92750f4

Update the clang-format file with latest

The latest clang format adds the IndentExternBlock property[1]

[1] https://github.com/openbmc/docs/blob/master/style/cpp/.clang-format

Signed-off-by: Georg

Update the clang-format file with latest

The latest clang format adds the IndentExternBlock property[1]

[1] https://github.com/openbmc/docs/blob/master/style/cpp/.clang-format

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I69d1a17de61c052193891cc9c009c54e68605022

show more ...

logging: switch to lg2

After switching to C++20, it is recommended to use `phosphor::lg2`
to format log, and the correct `CODE_LINE` and `CODE_FUNC` values
can be used in log tracking.

Signed-off-b

logging: switch to lg2

After switching to C++20, it is recommended to use `phosphor::lg2`
to format log, and the correct `CODE_LINE` and `CODE_FUNC` values
can be used in log tracking.

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I4fe8f4dec90e5062096168e05947b6d9bc355bb2

show more ...

Remove is_method_error method

Remove the usage of is_method_error()[1], and add try-catch to handle
D-Bus exceptions around mapper call.

[1]https://github.com/openbmc/sdbusplus/commit/079fb85a398d9

Remove is_method_error method

Remove the usage of is_method_error()[1], and add try-catch to handle
D-Bus exceptions around mapper call.

[1]https://github.com/openbmc/sdbusplus/commit/079fb85a398d90800935e3985bb1266a7530a26e#diff-945669e8bd9cab4ecc83a574a732921281b2c79eb8bba65efff11736ad18f92bR237-R240

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I8bbd5396e69dfa343936a9275c8d6ff2cf76c8a9

show more ...

gpio-util: Remove Makefile.am

The Makefile.am file is no longer used in meson.

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I12734a42f938cbe7561d0d2dcc0343422113777b

build: upgrade to C++23

Meson 1.1.1 and GCC-13 both support C++23 and a sufficient portion of
the standard has been implemented. Upgrade the build to leverage it.

Change-Id: I04ae932ba0948b66f31cc

build: upgrade to C++23

Meson 1.1.1 and GCC-13 both support C++23 and a sufficient portion of
the standard has been implemented. Upgrade the build to leverage it.

Change-Id: I04ae932ba0948b66f31cca7e4b203ee021d32223
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...