clang-format: re-format for clang-19

clang-format-19 isn't compatible with the clang-format-18 output, so we
need to reformat the code with the latest version. A few parameters
in clang-tidy have b

clang-format: re-format for clang-19

clang-format-19 isn't compatible with the clang-format-18 output, so we
need to reformat the code with the latest version. A few parameters
in clang-tidy have been deprecated, so adjust the style file
accordingly.

See Ie2f6eb3b043f2d655c9df806815afd7971fd0947 for updated style.
See I88192b41ab7a95599a90915013579608af7bc56f for clang-19 enablement.

Change-Id: I143ed8acc77de34cab0d51ae908999ed0aec4ee6
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

clang-tidy: Replace NULL with nullptr

Replaced all instances of NULL with nullptr to improve type safety
and clarity, as nullptr is the modern C++ standard for null pointers.

Tested: Build verified

clang-tidy: Replace NULL with nullptr

Replaced all instances of NULL with nullptr to improve type safety
and clarity, as nullptr is the modern C++ standard for null pointers.

Tested: Build verified

Change-Id: Iade4e4f1f25092f880fe06d61703db505b6e03d1
Signed-off-by: Jayanth Othayoth <ojayanth@gmail.com>

show more ...

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda forma

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda formatting also changed, so we have made changes to the
organization default style format to better handle lambda formatting.

See I5e08687e696dd240402a2780158664b7113def0e for updated style.
See Iea0776aaa7edd483fa395e23de25ebf5a6288f71 for clang-18 enablement.

Change-Id: Ia9dd4aed00238b28839b86dfe4ca93155a521766
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

phosphor-gpio-presence: Add expected method for CLI11

The Phosph-gpio-presence@.service template has a --drivers and
--extra-ifaces which can be empty in some configurations[1].
systemd will end up

phosphor-gpio-presence: Add expected method for CLI11

The Phosph-gpio-presence@.service template has a --drivers and
--extra-ifaces which can be empty in some configurations[1].
systemd will end up launching the process with an extra empty
argument. CLI11 will fail unless we give an explicit
"--drivers=<value> or --extra-ifaces=<value>".
Add the expected method to --drivers and --extra-ifaces to limit the
number of incoming parameters for parameters.

Observed in hardware testing:
```
--drivers: 1 required TEXT missing
Run with --help for more information.
```

[1] https://github.com/openbmc/openbmc/blob/master/meta-facebook/meta-bletchley/recipes-phosphor/gpio/phosphor-gpio-monitor/obmc/gpio/presence-sled1.conf

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: Iab8da95d88843652e657933656d9121b43311655

show more ...

build: add cli11 dependency as necessary

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I5431ae89a8b14e0ddad6e23895efaa044d67df46

presence: Replace Argument class with CLI11

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: Idd6e49c7206ce0b71990cc4999659bd51768f691

logging: switch to lg2

After switching to C++20, it is recommended to use `phosphor::lg2`
to format log, and the correct `CODE_LINE` and `CODE_FUNC` values
can be used in log tracking.

Signed-off-b

logging: switch to lg2

After switching to C++20, it is recommended to use `phosphor::lg2`
to format log, and the correct `CODE_LINE` and `CODE_FUNC` values
can be used in log tracking.

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I4fe8f4dec90e5062096168e05947b6d9bc355bb2

show more ...

Remove is_method_error method

Remove the usage of is_method_error()[1], and add try-catch to handle
D-Bus exceptions around mapper call.

[1]https://github.com/openbmc/sdbusplus/commit/079fb85a398d9

Remove is_method_error method

Remove the usage of is_method_error()[1], and add try-catch to handle
D-Bus exceptions around mapper call.

[1]https://github.com/openbmc/sdbusplus/commit/079fb85a398d90800935e3985bb1266a7530a26e#diff-945669e8bd9cab4ecc83a574a732921281b2c79eb8bba65efff11736ad18f92bR237-R240

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I8bbd5396e69dfa343936a9275c8d6ff2cf76c8a9

show more ...

presence: optimize emplace_back

The emplace_back call is created using temporary strings obtained from a
substr call which are not used past that point. Use std::move to avoid
string copy during th

presence: optimize emplace_back

The emplace_back call is created using temporary strings obtained from a
substr call which are not used past that point. Use std::move to avoid
string copy during the emplacement.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I5b0c7eebfd7281a2be379192ccdb0b2e5e4d5828

show more ...

meson: remove cppfs dependency and experimental::filesystem

The dependency on the c++fs library is something very old from the C++14
era and is no longer necessary with a modern compiler. Remove th

meson: remove cppfs dependency and experimental::filesystem

The dependency on the c++fs library is something very old from the C++14
era and is no longer necessary with a modern compiler. Remove the
explicit dependency from the meson setup.

Remove all use of `std::experimental::filesystem` and replace with the
real `std::filesystem`.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I62214337ec1b72f7c999de605b9ebe409d22ce79

show more ...

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: I3942bdbbb0fc2d46d755a74f481bb44fa63dc486
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are for:
* bus_t
* exception_t
* manager_t
* match_t
* message_t
* object_t
* slot_t

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Id8497e7fed0c6a278e29528d07486f5159687696

show more ...

catch exceptions as const

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ib9f55b5a26f9a48838759cfaef73c44181242ac6

presence: Get DRIVER_BIND_DELAY_MS value from env

Add a delay variable to the Presence class, defaulted to 0. Attempt to
set this value from the DRIVER_BIND_DELAY_MS environment variable. This
delay

presence: Get DRIVER_BIND_DELAY_MS value from env

Add a delay variable to the Presence class, defaulted to 0. Attempt to
set this value from the DRIVER_BIND_DELAY_MS environment variable. This
delay is then used between seeing the power supply present and binding
the device driver.

Signed-off-by: Brandon Wyman <bjwyman@gmail.com>
Change-Id: I62757d0585c2e34879f6b93b353bcef650aba52c

show more ...

sdbusplus: replace message::variant with std::variant

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I8c5f1951104be5a847cb054670f9b5018925c72c

build: drop autotools

With previously added support for building with meson/ninja autotools
support is no longer required.

Change-Id: I7bc2588ac71a7c37d1c542927dca8f8ae50c8c83
Signed-off-by: Brad B

build: drop autotools

With previously added support for building with meson/ninja autotools
support is no longer required.

Change-Id: I7bc2588ac71a7c37d1c542927dca8f8ae50c8c83
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

build: add support for building with meson

Follow the OpenBMC herd and support a more modern, more comprehensible,
more performant build framework.

To build using meson:
meson build
ninja -C

build: add support for building with meson

Follow the OpenBMC herd and support a more modern, more comprehensible,
more performant build framework.

To build using meson:
meson build
ninja -C build
ninja -C build install

Added -Dtests to match de-facto OpenBMC meson usage conventions.

Dropped support for --enable-oe-sdk rpath munging. This was a
workaround for broken oe sdks that don't figure out the correct rpath
when running make check or ninja test.

Ran existing unit tests (which passed) using ninja test.

Change-Id: I198700d866e1b23ba0a22b156335bbb973b98f43
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

build: fix some warnings

Fix a couple of warnings:

-Werror=unused-parameter

so we can use meson's warning_level=3 and -Werror without build
failures.

Change-Id: I14487a56727469f6bda1cabccce8241ac

build: fix some warnings

Fix a couple of warnings:

-Werror=unused-parameter

so we can use meson's warning_level=3 and -Werror without build
failures.

Change-Id: I14487a56727469f6bda1cabccce8241ac1acb149
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

gpio-presence: Support for multiple iface assocs

This will allow additional interfaces to be specified
to associate with inventory items to allow for further
customization of inventory items.

Speci

gpio-presence: Support for multiple iface assocs

This will allow additional interfaces to be specified
to associate with inventory items to allow for further
customization of inventory items.

Specifying property values for an interface added this way
is currently not supported.

Tested: Verified any given interface(s) is associated properly

Signed-off-by: Anthony Wilson <wilsonan@us.ibm.com>
Change-Id: I99e655b35120c82454a8851201218ec548ad9fe3

show more ...

build: install into bin instead of sbin

Installs into bin instead of sbin per guidelines.

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I1b764bb63d7a79b69a94f63e2c449b5e1ca5ffb8

Add clang-format to repo

Add clang-format to repo.

Change-Id: I3f8704d80dd0bdde0706ab189c68cffe6d347995
Signed-off-by: Patrick Venture <venture@google.com>

cleanup: use const reference passing string

[presence/main.cpp:21]: (performance) Function parameter 'driverString' should
be passed by const reference.

Change-Id: I024e1622b03a3f2ac3487051bdd8f7e3

cleanup: use const reference passing string

[presence/main.cpp:21]: (performance) Function parameter 'driverString' should
be passed by const reference.

Change-Id: I024e1622b03a3f2ac3487051bdd8f7e3b403639d
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

Use s.c_str() in log messages

Partly Resolves openbmc/openbmc 2905

Tested: static_assert only

Change-Id: I16db5b66bf5a26558a2ed0c1617ef5466dadefea
Signed-off-by: Joseph Reynolds <jrey@us.ibm.com>

gpio-presence: Pass drivers in to application

With the optional --drivers argument, pass in the
path/device pairs to bind/unbind. That string will be parsed,
and then passed into the Presence class

gpio-presence: Pass drivers in to application

With the optional --drivers argument, pass in the
path/device pairs to bind/unbind. That string will be parsed,
and then passed into the Presence class.

Change-Id: I1ac0e005de673a679dcb45e93bcac35fddf24d01
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

show more ...

gpio-presence: Add function to bind/unbind drivers

The cards that this app is doing presence detection for
may have devices with drivers that need to be bound and
unbound when the card is added and

gpio-presence: Add function to bind/unbind drivers

The cards that this app is doing presence detection for
may have devices with drivers that need to be bound and
unbound when the card is added and removed, respectively.

The drivers to do this to will be passed into the app
on startup (in a future commit). Then when presence detect
changes the proper binds/unbinds will be done.

This commit adds the code in the Presence class to do so.

Change-Id: I32827e45b88ddb7586aba6b819cc591b49aa9c51
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

show more ...