Fix indentation from review comment

https://gerrit.openbmc-project.xyz/#/c/7574/7/control/fan.cpp@89

Change-Id: I572093d1bbe636f5fb4f021b3b8478de19acc673
Signed-off-by: Matthew Barth <msbarth@us.ib

Fix indentation from review comment

https://gerrit.openbmc-project.xyz/#/c/7574/7/control/fan.cpp@89

Change-Id: I572093d1bbe636f5fb4f021b3b8478de19acc673
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

Use in place init of event data

Change-Id: Ia56acbeaa89423060e65e50eff8accffec5a4631
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

Remove empty service name

Before refreshing the service names and states for a group, the empty
service name should be removed if it exists. An empty service name may
exist where upon startup, a par

Remove empty service name

Before refreshing the service names and states for a group, the empty
service name should be removed if it exists. An empty service name may
exist where upon startup, a particular service was not found for a
member or members of a group.

Change-Id: I15d224231bb9db0823866393ec1776f793a3c126
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

Refresh service states for a group

Prior to an action resulting from missing service owners, all of the
services for a group should be refreshed to ensure they are in the most
up-to-date state. Ensu

Refresh service states for a group

Prior to an action resulting from missing service owners, all of the
services for a group should be refreshed to ensure they are in the most
up-to-date state. Ensuring the service states are current allows the
action to be correctly taken since owners of services could change at
anytime.

Change-Id: I59c59c6fcf456fa9c0a733d6406c90ea11f6e2b2
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

Init zone target speed to current target speed

Whenever fan control (control mode) is started, the target speed for
each zone should be initialized to the currently set target speed.

In the case wh

Init zone target speed to current target speed

Whenever fan control (control mode) is started, the target speed for
each zone should be initialized to the currently set target speed.

In the case where a watchdog has triggered the fans to full speed
and the target speed does not reflect this, the proper set of set speed
events should be configured. In this case, an event could be defined to
use the current tach feedback to adjust the target speed prior to
account for the real state of the fan speeds.

Change-Id: I538644ffc83a6e01469174304d393c889038d066
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

Set fan speed on missing owner action

Sets the zone's fan speeds to a given speed when any service owner
associated with an event group is missing. Once all the services are
functional and providing

Set fan speed on missing owner action

Sets the zone's fan speeds to a given speed when any service owner
associated with an event group is missing. Once all the services are
functional and providing the event data again, active fan speed changes
are allowed.

Change-Id: I318f6114c8d0392432c421f803db07a4683d1097
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

Set floor to default on missing owner action

An action to set the fan floor speed to the defined default fan floor
speed when any services associated to a given group of sensors have
terminated. Onc

Set floor to default on missing owner action

An action to set the fan floor speed to the defined default fan floor
speed when any services associated to a given group of sensors have
terminated. Once those services are functional and providing the
sensors, the fan floor is allowed to be set normally again.

i.e.) For fan floor speeds based on an ambient sensor, if the service
providing the ambient temperature value from the sensor terminates, the
default floor for the zone is used as the fan floor speed.

Change-Id: I2d58cc9b31051e6b8e5e798c0a736f58f5efe5b1
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

Allow timers & embedded actions within an action

Add support for timer parameters to action functions along with
recursively build action functions that are a parameter to an event
action.

Change-I

Allow timers & embedded actions within an action

Add support for timer parameters to action functions along with
recursively build action functions that are a parameter to an event
action.

Change-Id: Ic126c8dfc85d5ede5f53034262f8910913e4cdd4
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

Modify generating event actions

Move to constructing the entire event action parameter string within the
python code in prep for additional special parameters.

Change-Id: I517ad859813e348cd6781cc9b

Modify generating event actions

Move to constructing the entire event action parameter string within the
python code in prep for additional special parameters.

Change-Id: I517ad859813e348cd6781cc9be11ab92fa6cac09
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

Action that creates/starts a timer

Another action is provided to the timer and is performed when the timer
expires.

Change-Id: Ie6a06b0d56272a158d74bf03287183f07f00aed8
Signed-off-by: Matthew Barth

Action that creates/starts a timer

Another action is provided to the timer and is performed when the timer
expires.

Change-Id: Ie6a06b0d56272a158d74bf03287183f07f00aed8
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

Add timer event management

Events defined to have timers require the ability to find a timer, add a
timer to the event, and removing a timer event entirely. These event
timers are intended to allow

Add timer event management

Events defined to have timers require the ability to find a timer, add a
timer to the event, and removing a timer event entirely. These event
timers are intended to allow actions based on the event to be delayed or
recurring based on the timer defined.

Change-Id: Ieaf26f031c5e5aac9472e92354bfb76392642cb4
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

Add timer type for set speed event timers

This is the first step towards allowing timer driven and/or wrapped
actions where the timer interval and type will be defined by the user.

Change-Id: If008

Add timer type for set speed event timers

This is the first step towards allowing timer driven and/or wrapped
actions where the timer interval and type will be defined by the user.

Change-Id: If008fda5a2b73117e869f93223e0bfe61290f858
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

Fill in NameOwnerChanged signal support

A NameOwnerChanged signal message provides three strings containing the
service name that has changed along with its old service owner name and
new service ow

Fill in NameOwnerChanged signal support

A NameOwnerChanged signal message provides three strings containing the
service name that has changed along with its old service owner name and
new service owner name. These names are then passed along to the handler
to find/update the group associated with the changed owner name.

Change-Id: I7d67883b010fec5b282bd00a4dcc29629486af00
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

Generate selected handlers

The available event handlers are listed within the events yaml and would
be selected per event.

Change-Id: Ia393009b3a10b6f47f5de9a0e6d44f804576f05a
Signed-off-by: Matthe

Generate selected handlers

The available event handlers are listed within the events yaml and would
be selected per event.

Change-Id: Ia393009b3a10b6f47f5de9a0e6d44f804576f05a
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

Set/update a service name owner for a group

Adds a service name associated with a group when the group or given
service name is not found within the map of services otherwise updates
the service nam

Set/update a service name owner for a group

Adds a service name associated with a group when the group or given
service name is not found within the map of services otherwise updates
the service name owner associated with the group.

Change-Id: I602ddaa7e06e354e01ea70d6c5c0a45e74a14e99
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

Stub NameOwnerChanged signal support

NameOwnerChanged signals will be used within fan control to configure
set speed events for when services providing parameters to the fan
control application have

Stub NameOwnerChanged signal support

NameOwnerChanged signals will be used within fan control to configure
set speed events for when services providing parameters to the fan
control application have unexpectedly terminated.

Change-Id: I04f3c7ca2842732e33dc94b0280ad4483f7f1286
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

Update event initialization

Using a null dbus message to the event signal will perform the necessary
steps to initialize the event parameters using the given signal
handler's function directly.

i.e

Update event initialization

Using a null dbus message to the event signal will perform the necessary
steps to initialize the event parameters using the given signal
handler's function directly.

i.e.) In the case for subscribing to PropertiesChanged signals,
initially the given property must be read. When the PropertiesChanged
signal struct is given a null message, it finds the property, reads the
value, and then can perform the given signal handler function directly.
This produces the same functional path as receiving a PropertiesChanged
signal containing the property value within the message.

Change-Id: I35575cfff66eb0305156be786cb1f5536d42bb1c
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

Fix up InternalFailure to include metadata

Scope is to add missing logs for InternalFailure errors

Change-Id: I12c958127c1303fba0057914682e651457a0e547
Signed-off-by: Marri Devender Rao <devenrao@i

Fix up InternalFailure to include metadata

Scope is to add missing logs for InternalFailure errors

Change-Id: I12c958127c1303fba0057914682e651457a0e547
Signed-off-by: Marri Devender Rao <devenrao@in.ibm.com>

show more ...

Generate selected match strings and signals

The available matches and their associated signals are now listed
within the events yaml and can be added to the list of matches to
register for per event

Generate selected match strings and signals

The available matches and their associated signals are now listed
within the events yaml and can be added to the list of matches to
register for per event.

Change-Id: I65f657038afe7c68a421adb4820ea09e275be06d
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

DOC ONLY: Add preconditions section description

Change-Id: I260319dbfc4cb87bfed8fd724ffc4978f34e7325
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

Spelling fixes

Spelling errors found using github.com/lucasdemarchi/codespell
A tool to fix common misspellings.
This tool is licensed under GNU General Public License, version 2.

Change-Id: Iefb2a

Spelling fixes

Spelling errors found using github.com/lucasdemarchi/codespell
A tool to fix common misspellings.
This tool is licensed under GNU General Public License, version 2.

Change-Id: Iefb2ad70d313a4800cd413c7c2e5e2154bec49fb
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

monitor: Start checking tach trust

The Fan class now uses the trust::Manager class
to ask if a sensor value is trusted before analyzing
its value against the upper and lower limits.

Change-Id: I81

monitor: Start checking tach trust

The Fan class now uses the trust::Manager class
to ask if a sensor value is trusted before analyzing
its value against the upper and lower limits.

Change-Id: I81dd468877873ba84753d76395b4a59129824c0b
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

show more ...

monitor: Update YAML parser to handle trust groups

It creates a list of group creator lambdas based on
the information in the monitor YAML file.

These lambdas are called by the manager class to cre

monitor: Update YAML parser to handle trust groups

It creates a list of group creator lambdas based on
the information in the monitor YAML file.

These lambdas are called by the manager class to create
the trust group instances.

A real life example is:

const std::vector<CreateGroupFunction> trustGroups
{
{
[]()
{
std::vector<std::string> names{
"fan0_1",
"fan1_1",
"fan2_1",
"fan3_1",
};
return std::make_unique<NonzeroSpeed>(names);
}
},
};

Change-Id: Ia883df35efb86242aae2f8ed7d1714e94e65a6e6
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

show more ...

monitor: Update example YAML

Update the YAML documentation with sensor
trust information.

Change-Id: Ia5407b079b5dcfbd4063cec8dbba032fefa11b6b
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

monitor: Add trust manager class

This class contains the trust groups, and is the interface
for asking if a sensor value can be trusted or not.

It will also start and stop timers on all sensors in

monitor: Add trust manager class

This class contains the trust groups, and is the interface
for asking if a sensor value can be trusted or not.

It will also start and stop timers on all sensors in the same
group as the timer in question whose trust value just changed.

This class will be used by the Fan class in the speed change
callback function to check if a sensor is trusted before
analyzing its value.

Change-Id: I134be095b6b5222f7bc0e457078cf01f75a36219
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

show more ...