control:ibm,Bonnell: Add hot PCIe card

Add the 'GTO' PCIe card to the list of hot PCIe cards, and add floor
values for its floor index.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I

control:ibm,Bonnell: Add hot PCIe card

Add the 'GTO' PCIe card to the list of hot PCIe cards, and add floor
values for its floor index.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: Ie2863a08cdf9c85ca5e6c25d56d4cc367da60218

show more ...

sensor-monitor: support skip power checking

The threshold event is binding with power state currently.
Due to some sensors access will not depend on the power state.
Provide a new option to let user

sensor-monitor: support skip power checking

The threshold event is binding with power state currently.
Due to some sensors access will not depend on the power state.
Provide a new option to let user to disable it.

Change-Id: Ib232b889cde70082e3bd630ffbe6939eede474f8
Signed-off-by: Jerry C Chen <jerry.c.chen.wiwynn@gmail.com>

show more ...

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda forma

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda formatting also changed, so we have made changes to the
organization default style format to better handle lambda formatting.

See I5e08687e696dd240402a2780158664b7113def0e for updated style.
See Iea0776aaa7edd483fa395e23de25ebf5a6288f71 for clang-18 enablement.

Change-Id: Ica590f8613f1fb89ab1ca676ac51c1cc7e38d67f
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

docs/control/README.md: Fix MD051 warnings

The following warnings are generated by using markdownlint analysis:
```
docs/control/README.md:7:3 MD051/link-fragments Link fragments should be valid [Co

docs/control/README.md: Fix MD051 warnings

The following warnings are generated by using markdownlint analysis:
```
docs/control/README.md:7:3 MD051/link-fragments Link fragments should be valid [Context: "[Example](#example)"]
```

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: I3a1e38966509b1490640018415b40df2f2233c7e

show more ...

docs/control/README.md: Fix MD034 warnings

The following warnings are generated by using markdownlint analysis:
```
docs/control/README.md:243:1 MD034/no-bare-urls Bare URL used [Context: "https://g

docs/control/README.md: Fix MD034 warnings

The following warnings are generated by using markdownlint analysis:
```
docs/control/README.md:243:1 MD034/no-bare-urls Bare URL used [Context: "https://github.com/openbmc/pho..."]
```
Refer to markdown-lint [1] to fix MD034
[1]: https://github.com/updownpress/markdown-lint/blob/master/rules/034-no-bare-urls.md

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: I48595b22044c4fc22741d302862bc6c7260d1cc7

show more ...

docs/control/fanctl/README.md: Fix MD026 warnings

The following warnings are generated by using markdownlint analysis:
```
docs/control/fanctl/README.md:60:12 MD026/no-trailing-punctuation Trailing

docs/control/fanctl/README.md: Fix MD026 warnings

The following warnings are generated by using markdownlint analysis:
```
docs/control/fanctl/README.md:60:12 MD026/no-trailing-punctuation Trailing punctuation in heading [Punctuation: ':']
```
Refer to markdown-lint [1] to fix MD026
[1]: https://github.com/updownpress/markdown-lint/blob/master/rules/026-no-trailing-punctuation.md

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: Icf87d4d60f406b0b936bddd98b7dbe91099ef58e

show more ...

docs/control/events.md: Fix MD029 warnings

The following warnings are generated by using markdownlint analysis:
```
docs/control/events.md:301:1 MD029/ol-prefix Ordered list item prefix [Expected: 1

docs/control/events.md: Fix MD029 warnings

The following warnings are generated by using markdownlint analysis:
```
docs/control/events.md:301:1 MD029/ol-prefix Ordered list item prefix [Expected: 1; Actual: 2; Style: 1/1/1]
docs/control/events.md:329:1 MD029/ol-prefix Ordered list item prefix [Expected: 1; Actual: 2; Style: 1/1/1]
docs/control/events.md:366:1 MD029/ol-prefix Ordered list item prefix [Expected: 1; Actual: 2; Style: 1/1/1]
docs/control/events.md:393:1 MD029/ol-prefix Ordered list item prefix [Expected: 1; Actual: 2; Style: 1/1/1]
```
Refer to markdown-lint [1] to fix MD029
[1]: https://github.com/updownpress/markdown-lint/blob/master/rules/029-ol-prefix.md

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: I6e81aee613c92e368905811ba51ef5be0696c0a1

show more ...

README.md: Fix MD037 warnings

The following warnings are generated by using markdownlint analysis:
```
docs/monitor/sensors.md:11:23 MD037/no-space-in-emphasis Spaces inside emphasis markers [Contex

README.md: Fix MD037 warnings

The following warnings are generated by using markdownlint analysis:
```
docs/monitor/sensors.md:11:23 MD037/no-space-in-emphasis Spaces inside emphasis markers [Context: "_ ("]
docs/monitor/sensors.md:11:66 MD037/no-space-in-emphasis Spaces inside emphasis markers [Context: ") _"]
docs/monitor/sensors.md:13:23 MD037/no-space-in-emphasis Spaces inside emphasis markers [Context: "_ ("]
docs/monitor/sensors.md:13:66 MD037/no-space-in-emphasis Spaces inside emphasis markers [Context: ") _"]
```
Refer to markdown-lint [1] to fix MD037
[1]: https://github.com/updownpress/markdown-lint/blob/master/rules/037-no-space-in-emphasis.md

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: Ifff2a9c647b284b49423ed3d04c79af8d5576b16

show more ...

Fix MD040 warnings

The following warnings are generated by using markdownlint analysis:
```
MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"]
```
Refer

Fix MD040 warnings

The following warnings are generated by using markdownlint analysis:
```
MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"]
```
Refer to markdown-lint [1] to fix MD040
[1]: https://github.com/updownpress/markdown-lint/blob/master/rules/040-fenced-code-language.md

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: Ie866ac8c3d8e33d2c8811f7c6a5965d6dad1f88a

show more ...

Fix MD033 warnings

The following warnings are generated by using markdownlint analysis:
```
MD033/no-inline-html Inline HTML [Element: code]
MD033/no-inline-html Inline HTML [Element: pre]
MD033/no-

Fix MD033 warnings

The following warnings are generated by using markdownlint analysis:
```
MD033/no-inline-html Inline HTML [Element: code]
MD033/no-inline-html Inline HTML [Element: pre]
MD033/no-inline-html Inline HTML [Element: b]
MD033/no-inline-html Inline HTML [Element: i]
```
Refer to markdown-lint [1] to fix MD033
[1]: https://github.com/updownpress/markdown-lint/blob/master/rules/033-no-inline-html.md

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: I7dfb63e9f3a663cfea60b5d0a0a4ae8540ddd1d6

show more ...

docs/presence/rpolicy.md: Fix MD033 warnings

The following warnings are generated by using markdownlint analysis:
```
docs/presence/rpolicy.md:37:6 MD033/no-inline-html Inline HTML [Element: code]
d

docs/presence/rpolicy.md: Fix MD033 warnings

The following warnings are generated by using markdownlint analysis:
```
docs/presence/rpolicy.md:37:6 MD033/no-inline-html Inline HTML [Element: code]
docs/presence/rpolicy.md:37:1 MD033/no-inline-html Inline HTML [Element: pre]
docs/presence/rpolicy.md:50:5 MD033/no-inline-html Inline HTML [Element: b]
docs/presence/rpolicy.md:50:8 MD033/no-inline-html Inline HTML [Element: i]
```
Refer to markdown-lint [1] to fix MD033
[1]: https://github.com/updownpress/markdown-lint/blob/master/rules/033-no-inline-html.md

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: I31748039b2f6a5bae46245a416dbde2eed4f3699

show more ...

docs/presence/rpolicy.md: Fix MD040 warnings

The following warnings are generated by using markdownlint analysis:
```
MD040/fenced-code-language Fenced code blocks should have a language specified [

docs/presence/rpolicy.md: Fix MD040 warnings

The following warnings are generated by using markdownlint analysis:
```
MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"]
```
Refer to markdown-lint [1] to fix MD040
[1]: https://github.com/updownpress/markdown-lint/blob/master/rules/040-fenced-code-language.md

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: Ic2ddba30a55a328af2528afc56a2147c7ceb6f59

show more ...

docs/presence/README.md: Fix MD040 warnings

The following warnings are generated by using markdownlint analysis:
```
MD040/fenced-code-language Fenced code blocks should have a language specified [C

docs/presence/README.md: Fix MD040 warnings

The following warnings are generated by using markdownlint analysis:
```
MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"]
```
Refer to markdown-lint [1] to fix MD040
[1]: https://github.com/updownpress/markdown-lint/blob/master/rules/040-fenced-code-language.md

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: Icb601fbd199f536600d35322b7aca19371be00a4

show more ...

README.md: Fix MD040 warnings

The following warnings are generated by using markdownlint analysis:
```
MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"]

README.md: Fix MD040 warnings

The following warnings are generated by using markdownlint analysis:
```
MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"]
```
Refer to markdown-lint [1] to fix MD040
[1]: https://github.com/updownpress/markdown-lint/blob/master/rules/040-fenced-code-language.md

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: I0bdf6a9c97282f1fbb528b84691d23fb67ed2bf3

show more ...

README.md: Update access permissions

The default access permission for the README.md file should be 664.

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: Ibf94e02728703b19c71cbb882ce24

README.md: Update access permissions

The default access permission for the README.md file should be 664.

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: Ibf94e02728703b19c71cbb882ce24b87edb88820

show more ...

sensor-mon: Add Threshold value for Threshold event

Add the threshold value for threshold event to let user knowing the
status of sensor through threshold event log.
Divide the ErrorName into ErrorS

sensor-mon: Add Threshold value for Threshold event

Add the threshold value for threshold event to let user knowing the
status of sensor through threshold event log.
Divide the ErrorName into ErrorStatus and ErrorName which ErrorName is
used for getting threshold property and ErrorStatus represents this
threshold event is cleared or triggered in the event log.

Change-Id: I1979544d89cd87a307c58909a566c05707a3c1f2
Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@wiwynn.com>

show more ...

control: json: Correct hysteresis definitions

The action target_from_group_max has been implementing the reversed
definitions of positive hysteresis and negative hysteresis. The positive
hysteresis

control: json: Correct hysteresis definitions

The action target_from_group_max has been implementing the reversed
definitions of positive hysteresis and negative hysteresis. The positive
hysteresis should be for the value increasing case and vice versa. This
commit corrects that in source code and events.md.

Signed-off-by: Chau Ly <chaul@amperecomputing.com>
Change-Id: I1b84884d16d5f20d0fdcd9033188ffd31e91f907

show more ...

control: manager: Services with no managed objs

When a D-Bus object used in events is under a service that has the
"org.freedesktop.DBus.ObjectManager", the control::json::Manager will
try to get al

control: manager: Services with no managed objs

When a D-Bus object used in events is under a service that has the
"org.freedesktop.DBus.ObjectManager", the control::json::Manager will
try to get all the managed objects under the service and add to cache.
However, in case when the results from the GetManagedObjects are empty,
it omits the attempt to directly read the object from D-Bus using the
configured information.

This patch handles this situation and allows services that have the
ObjectManager interface but empty managed objects can be read.

Example: Objects under xyz.openbmc_project.State.Host service.

root@mtmitchell-dcscm:~# busctl call xyz.openbmc_project.State.Host \
/xyz/openbmc_project/state/host0 org.freedesktop.DBus.ObjectManager \
GetManagedObjects

a{oa{sa{sv}}} 0

Signed-off-by: Chau Ly <chaul@amperecomputing.com>
Change-Id: I5eca78fdfbc8a26fb7effb861440dc3cf28959d0

show more ...

control:Bonnell: Increase deviation value

Increase Bonnell's lower deviation setting from 18% to 22%. This is
necessary because the lower end for the outlet rotors was raised by an
earlier commit t

control:Bonnell: Increase deviation value

Increase Bonnell's lower deviation setting from 18% to 22%. This is
necessary because the lower end for the outlet rotors was raised by an
earlier commit that modified the factor and offset values so that a
different fan type can be supported.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: Ie68e6f2a60109b566328ab2bac1cdeb029f255b2

show more ...

control:Bonnell: Increase ambient values by 4.5

Increase any values referencing the ambient temperature by 4.5 degrees
to account for the fact that the actual temperature is 4.5 degrees
higher than

control:Bonnell: Increase ambient values by 4.5

Increase any values referencing the ambient temperature by 4.5 degrees
to account for the fact that the actual temperature is 4.5 degrees
higher than what the sensor shows.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I2441c68676a716f7d5324b81bb48102187ab600f

show more ...

control:Bonnell: Remove hot PCIe cards

It turns out that Bonnell doesn't have any 'hot' pcie cards, so the
floor can just be based on ambient and altitude.

This commit removes the cards from pcie_c

control:Bonnell: Remove hot PCIe cards

It turns out that Bonnell doesn't have any 'hot' pcie cards, so the
floor can just be based on ambient and altitude.

This commit removes the cards from pcie_cards.json and removes any PCIe
floor index values from the mapped_floor action in events.json. It
still leaves the infrastructure to keep things more common with the
other IBM systems, and to make it easier to add in a card if/when a hot
one comes into plan.

There is also a code update needed to allow an empty pcie_cards.json
file.

Tested:
Floors are set appropriately based on the altitude and ambient.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I10e6904602c7abf61121f7c610059f164405b758

show more ...

meson: Fix local cereal build

Currently local build is failing with a message:
"""
cereal| Exception: Failed to configure the CMake subproject: Could NOT
find Boost (missing: Boost_INCLUDE_DIR seria

meson: Fix local cereal build

Currently local build is failing with a message:
"""
cereal| Exception: Failed to configure the CMake subproject: Could NOT
find Boost (missing: Boost_INCLUDE_DIR serialization)
Subproject subprojects/cereal is buildable: NO (disabling)
"""
Since cereal requires boost only for the sandbox build and this
functionality is not needed, add option to skip building performance
sandbox comparison to solve the issue.

Tested:
"meson setup build" no longer fails with the cereal error.

Change-Id: I4c3ba38acbe64ae90de1c4879368fae2a6565709
Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>

show more ...

monitor:cnfgs:Bonnell: Update tach 1 equation

The Bonnell system will support fans from two different vendors where
the equation: "tach1_rpm = (target_rpm * factor) + offset" is slightly
different

monitor:cnfgs:Bonnell: Update tach 1 equation

The Bonnell system will support fans from two different vendors where
the equation: "tach1_rpm = (target_rpm * factor) + offset" is slightly
different between the two.

Change the factor and offset values to one that will work for both.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: Iffb3f597f4d30b3c3b76edf8950702c0517a59f2

show more ...

control:Bonnell: Config updates

The following updates were made to the Bonnell fan control config:
- Change max RPMs to 17000 from 18000
- The fans could never actually hit 18000
- Add the real PC

control:Bonnell: Config updates

The following updates were made to the Bonnell fan control config:
- Change max RPMs to 17000 from 18000
- The fans could never actually hit 18000
- Add the real PCIe card list
- Update the floor table and the associated parameters
- Some unused floor indices are left in the table to make
it easier for future expansion.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: Ia7f4627f9458322e250452e67f330ede063c7efe

show more ...

hwmon_ffdc: fix compile fail with newer glibc

An upcoming Yocto update reveiled a compile failure due to ignoring the
return value from `pclose` when used as a unique_ptr deleter. Switch
to a lambd

hwmon_ffdc: fix compile fail with newer glibc

An upcoming Yocto update reveiled a compile failure due to ignoring the
return value from `pclose` when used as a unique_ptr deleter. Switch
to a lambda indirection where the return is explicitly ignored.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ifa5d3f346f75d37075df78acf916dde8fc1ead69

show more ...