e5049b25 | 04-Feb-2025 |
Matt Spinler <spinler@us.ibm.com> |
Fix custom_target breakage
The recent meson format commit reordered arguments of some custom_target calls, where the code expected the first input to be the script being run. Hardcode that argument
Fix custom_target breakage
The recent meson format commit reordered arguments of some custom_target calls, where the code expected the first input to be the script being run. Hardcode that argument instead.
Signed-off-by: Matt Spinler <spinler@us.ibm.com> Change-Id: I2d895da8ad2ddb0aba3a545129ff698438f8eaa7
show more ...
|
4fa67aa1 | 03-Feb-2025 |
Patrick Williams <patrick@stwcx.xyz> |
clang-format: update latest spec and reformat
Copy the latest format file from the docs repository and apply.
Change-Id: If152304b21dd2daaa2f79255a4f98218615efb05 Signed-off-by: Patrick Williams <p
clang-format: update latest spec and reformat
Copy the latest format file from the docs repository and apply.
Change-Id: If152304b21dd2daaa2f79255a4f98218615efb05 Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
show more ...
|
f5f87cae | 01-Feb-2025 |
Patrick Williams <patrick@stwcx.xyz> |
meson: reformat with meson formatter
Apply the `meson format` results.
Change-Id: I0992e665c16f369772eb0cb5ac65553654fd464a Signed-off-by: Patrick Williams <patrick@stwcx.xyz> |
7d07cb1e | 21-Jan-2025 |
Matt Spinler <spinler@us.ibm.com> |
fanctl: Add option to display sensors
Add a new 'sensors' option to fanctl to display sensor values for debug, which the code gets straight from D-Bus.
The help: $ fanctl sensors -h ``` Retrieve se
fanctl: Add option to display sensors
Add a new 'sensors' option to fanctl to display sensor values for debug, which the code gets straight from D-Bus.
The help: $ fanctl sensors -h ``` Retrieve sensor values Usage: fanctl sensors [OPTIONS]
Options: -h,--help Retrieve sensor values -t,--type TEXT Only show sensors of this type (i.e. 'temperature'). Optional -n,--name TEXT Only show sensors with this string in the name. Optional -v,--verbose Verbose: Use sensor object path for the name ```
Example output:
$ fanctl sensors Altitude: 110.901 Ambient_0_Temp: 22.562 Ambient_1_Temp: 22.604 Ambient_2_Temp: 22.4047 Ambient_Virtual_Temp: 22.562 Battery_Voltage: 3.144 NVMe_1_Temp: 31 NVMe_2_Temp: 31 NVMe_JBOF_Card_C10_Local_Temp: 33.938 NVMe_JBOF_Card_C10_Temp: 44 ...
Display the object path for the sensor name: ``` $ fanctl sensors -v /xyz/openbmc_project/sensors/altitude/Altitude: 110.901 /xyz/openbmc_project/sensors/current/ps0_output_current: 20.375 /xyz/openbmc_project/sensors/current/ps1_output_current: 18.218 /xyz/openbmc_project/sensors/current/vcs_p0_dcm0_rail_iout: 1.75 /xyz/openbmc_project/sensors/current/vcs_p0_dcm0_rail_iout_peak: 6.5 /xyz/openbmc_project/sensors/current/vcs_p0_dcm0_rail_iout_valley: 0 /xyz/openbmc_project/sensors/current/vcs_p0_dcm1_rail_iout: 0.75 /xyz/openbmc_project/sensors/current/vcs_p0_dcm1_rail_iout_peak: 3 /xyz/openbmc_project/sensors/current/vcs_p0_dcm1_rail_iout_valley: 0 /xyz/openbmc_project/sensors/current/vcs_p1_dcm0_rail_iout: 2.75 ... ```
Display only voltage sensors: ``` $ fanctl sensors -t voltage Battery_Voltage: 3.144 ps0_input_voltage: 207 ps0_input_voltage_rating: 220 ps0_output_voltage: 12.296 ... ```
Display only sensors that contain the substring 'core': $ fanctl sensors -n core ``` proc0_core0_0_temp: 44 proc0_core0_1_temp: 44 proc0_core10_0_temp: 45 proc0_core10_1_temp: 45 ... ```
Signed-off-by: Matt Spinler <spinler@us.ibm.com> Change-Id: Ib93f00c457a6972e9eba1f74adca904baa2bf28c
show more ...
|
3e485596 | 15-Jan-2025 |
Matt Spinler <spinler@us.ibm.com> |
control:ibm,Rainier: Add hot PCIe card
Add the 'Moso' card to all Rainier models.
Signed-off-by: Matt Spinler <spinler@us.ibm.com> Change-Id: I2ad38ea9926f76fe9324052ef68045bd086dcb63 |
79f2e819 | 09-Jan-2025 |
Matt Spinler <spinler@us.ibm.com> |
control:configs:Everest: Add a new floor index
Add a new floor index of 4, and change the Cedar Lake and Haleakala cards to use it.
Signed-off-by: Matt Spinler <spinler@us.ibm.com> Change-Id: Icd8f
control:configs:Everest: Add a new floor index
Add a new floor index of 4, and change the Cedar Lake and Haleakala cards to use it.
Signed-off-by: Matt Spinler <spinler@us.ibm.com> Change-Id: Icd8fd365f756e3d36199237dec2d478aa8091f0e
show more ...
|
6c9644da | 07-Jan-2025 |
Matt Spinler <spinler@us.ibm.com> |
monitor:configs: BlueRidge 2U new fan support
The BlueRidge 2U is similar to the Rainier 2U but uses different fans. These fans require different factor/offset values.
Copy over the Rainier config.
monitor:configs: BlueRidge 2U new fan support
The BlueRidge 2U is similar to the Rainier 2U but uses different fans. These fans require different factor/offset values.
Copy over the Rainier config.json and update these values.
Signed-off-by: Matt Spinler <spinler@us.ibm.com> Change-Id: Icad2178559d6fa0cc67105d7112041c4b7c0fec2
show more ...
|
f6767f4e | 07-Jan-2025 |
Matt Spinler <spinler@us.ibm.com> |
control:configs: BlueRidge 2U fan support
The BlueRidge 2U is similar to the Rainier 2U but uses different fans. The only difference from Rainier so far is the fan ceiling is changing from 18000 to
control:configs: BlueRidge 2U fan support
The BlueRidge 2U is similar to the Rainier 2U but uses different fans. The only difference from Rainier so far is the fan ceiling is changing from 18000 to 17000.
Copy over the Rainier files that reference this and change the values. The groups.json and pcie_cards.json used will still be obtained from the Rainier directory.
Signed-off-by: Matt Spinler <spinler@us.ibm.com> Change-Id: Ib935e0d168d6b6cad2f26b5d455aec957af204e5
show more ...
|
9087cafb | 16-Dec-2024 |
Matt Spinler <spinler@us.ibm.com> |
cooling-type: Remove vim modeline lines
There's no need for editor settings in source files.
Signed-off-by: Matt Spinler <spinler@us.ibm.com> Change-Id: Ic9fd851d9940b632f18213a1d9066a44ad8bf08b |
9da54c0b | 18-Dec-2024 |
Patrick Williams <patrick@stwcx.xyz> |
clang-format: re-format for clang-19
clang-format-19 isn't compatible with the clang-format-18 output, so we need to reformat the code with the latest version. A few parameters in clang-tidy have b
clang-format: re-format for clang-19
clang-format-19 isn't compatible with the clang-format-18 output, so we need to reformat the code with the latest version. A few parameters in clang-tidy have been deprecated, so adjust the style file accordingly.
See Ie2f6eb3b043f2d655c9df806815afd7971fd0947 for updated style. See I88192b41ab7a95599a90915013579608af7bc56f for clang-19 enablement.
Change-Id: Iacf6a2a529546f93915ac1309ee3b682cadc29ae Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
show more ...
|
3d0c3696 | 12-Dec-2024 |
Matt Spinler <spinler@us.ibm.com> |
control: Load only 1 pcie_cards.json
The pcie_cards.json file contains PCIe cards that need special fan floor values. The previous code would attempt to load multiple files, based on the thinking t
control: Load only 1 pcie_cards.json
The pcie_cards.json file contains PCIe cards that need special fan floor values. The previous code would attempt to load multiple files, based on the thinking that there might be a common file that is shared between systems and then other system specific files with just the cards that are different.
In practice this feature was never used, and made systems harder to patch in /etc/ since even after a file was found in /etc the file would also be loaded out of /usr, overwriting the values.
Tested: A file was put in each non default location of:
``` /etc/phosphor-fan-presence/control/ /etc/phosphor-fan-presence/control/com.ibm.Hardware.Chassis.Model.Rainier4U/
/usr/share/phosphor-fan-presence/control/ /usr/share/phosphor-fan-presence/control/com.ibm.Hardware.Chassis.Model.Rainier/ ```
With the existing file in flash at: /usr/share/ ... /com.ibm.Hardware.Chassis.Model.Rainier4U/
And in each case the correct file was chosen. Verified using the traces shown on startup like:
``` Loading configuration from /etc/phosphor-fan-presence/control/pcie_cards.json ```
Signed-off-by: Matt Spinler <spinler@us.ibm.com> Change-Id: I14b849a2bff65402508ef92e293f3237729721e5
show more ...
|
10d4542d | 12-Dec-2024 |
Matt Spinler <spinler@us.ibm.com> |
Fix markdown format problem
The example wasn't proper JSON. Make it proper with good formatting.
Signed-off-by: Matt Spinler <spinler@us.ibm.com> Change-Id: Idbbd7d13357430351162a3e0b0a0ea26c86ff712 |
8dab554b | 11-Oct-2024 |
Matt Spinler <spinler@us.ibm.com> |
control:ibm,Bonnell: Add hot PCIe card
Add the 'GTO' PCIe card to the list of hot PCIe cards, and add floor values for its floor index.
Signed-off-by: Matt Spinler <spinler@us.ibm.com> Change-Id: I
control:ibm,Bonnell: Add hot PCIe card
Add the 'GTO' PCIe card to the list of hot PCIe cards, and add floor values for its floor index.
Signed-off-by: Matt Spinler <spinler@us.ibm.com> Change-Id: Ie2863a08cdf9c85ca5e6c25d56d4cc367da60218
show more ...
|
35fb3a05 | 30-Aug-2024 |
Jerry C Chen <jerry.c.chen.wiwynn@gmail.com> |
sensor-monitor: support skip power checking
The threshold event is binding with power state currently. Due to some sensors access will not depend on the power state. Provide a new option to let user
sensor-monitor: support skip power checking
The threshold event is binding with power state currently. Due to some sensors access will not depend on the power state. Provide a new option to let user to disable it.
Change-Id: Ib232b889cde70082e3bd630ffbe6939eede474f8 Signed-off-by: Jerry C Chen <jerry.c.chen.wiwynn@gmail.com>
show more ...
|
dfddd648 | 16-Aug-2024 |
Patrick Williams <patrick@stwcx.xyz> |
clang-format: re-format for clang-18
clang-format-18 isn't compatible with the clang-format-17 output, so we need to reformat the code with the latest version. The way clang-18 handles lambda forma
clang-format: re-format for clang-18
clang-format-18 isn't compatible with the clang-format-17 output, so we need to reformat the code with the latest version. The way clang-18 handles lambda formatting also changed, so we have made changes to the organization default style format to better handle lambda formatting.
See I5e08687e696dd240402a2780158664b7113def0e for updated style. See Iea0776aaa7edd483fa395e23de25ebf5a6288f71 for clang-18 enablement.
Change-Id: Ica590f8613f1fb89ab1ca676ac51c1cc7e38d67f Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
show more ...
|
d24eeba0 | 05-Aug-2024 |
George Liu <liuxiwei@ieisystem.com> |
docs/control/README.md: Fix MD051 warnings
The following warnings are generated by using markdownlint analysis: ``` docs/control/README.md:7:3 MD051/link-fragments Link fragments should be valid [Co
docs/control/README.md: Fix MD051 warnings
The following warnings are generated by using markdownlint analysis: ``` docs/control/README.md:7:3 MD051/link-fragments Link fragments should be valid [Context: "[Example](#example)"] ```
Signed-off-by: George Liu <liuxiwei@ieisystem.com> Change-Id: I3a1e38966509b1490640018415b40df2f2233c7e
show more ...
|
ab818284 | 05-Aug-2024 |
George Liu <liuxiwei@ieisystem.com> |
docs/control/README.md: Fix MD034 warnings
The following warnings are generated by using markdownlint analysis: ``` docs/control/README.md:243:1 MD034/no-bare-urls Bare URL used [Context: "https://g
docs/control/README.md: Fix MD034 warnings
The following warnings are generated by using markdownlint analysis: ``` docs/control/README.md:243:1 MD034/no-bare-urls Bare URL used [Context: "https://github.com/openbmc/pho..."] ``` Refer to markdown-lint [1] to fix MD034 [1]: https://github.com/updownpress/markdown-lint/blob/master/rules/034-no-bare-urls.md
Signed-off-by: George Liu <liuxiwei@ieisystem.com> Change-Id: I48595b22044c4fc22741d302862bc6c7260d1cc7
show more ...
|
6631eee0 | 05-Aug-2024 |
George Liu <liuxiwei@ieisystem.com> |
docs/control/fanctl/README.md: Fix MD026 warnings
The following warnings are generated by using markdownlint analysis: ``` docs/control/fanctl/README.md:60:12 MD026/no-trailing-punctuation Trailing
docs/control/fanctl/README.md: Fix MD026 warnings
The following warnings are generated by using markdownlint analysis: ``` docs/control/fanctl/README.md:60:12 MD026/no-trailing-punctuation Trailing punctuation in heading [Punctuation: ':'] ``` Refer to markdown-lint [1] to fix MD026 [1]: https://github.com/updownpress/markdown-lint/blob/master/rules/026-no-trailing-punctuation.md
Signed-off-by: George Liu <liuxiwei@ieisystem.com> Change-Id: Icf87d4d60f406b0b936bddd98b7dbe91099ef58e
show more ...
|
cf04f3f2 | 05-Aug-2024 |
George Liu <liuxiwei@ieisystem.com> |
docs/control/events.md: Fix MD029 warnings
The following warnings are generated by using markdownlint analysis: ``` docs/control/events.md:301:1 MD029/ol-prefix Ordered list item prefix [Expected: 1
docs/control/events.md: Fix MD029 warnings
The following warnings are generated by using markdownlint analysis: ``` docs/control/events.md:301:1 MD029/ol-prefix Ordered list item prefix [Expected: 1; Actual: 2; Style: 1/1/1] docs/control/events.md:329:1 MD029/ol-prefix Ordered list item prefix [Expected: 1; Actual: 2; Style: 1/1/1] docs/control/events.md:366:1 MD029/ol-prefix Ordered list item prefix [Expected: 1; Actual: 2; Style: 1/1/1] docs/control/events.md:393:1 MD029/ol-prefix Ordered list item prefix [Expected: 1; Actual: 2; Style: 1/1/1] ``` Refer to markdown-lint [1] to fix MD029 [1]: https://github.com/updownpress/markdown-lint/blob/master/rules/029-ol-prefix.md
Signed-off-by: George Liu <liuxiwei@ieisystem.com> Change-Id: I6e81aee613c92e368905811ba51ef5be0696c0a1
show more ...
|
d7cd9f1e | 05-Aug-2024 |
George Liu <liuxiwei@ieisystem.com> |
README.md: Fix MD037 warnings
The following warnings are generated by using markdownlint analysis: ``` docs/monitor/sensors.md:11:23 MD037/no-space-in-emphasis Spaces inside emphasis markers [Contex
README.md: Fix MD037 warnings
The following warnings are generated by using markdownlint analysis: ``` docs/monitor/sensors.md:11:23 MD037/no-space-in-emphasis Spaces inside emphasis markers [Context: "_ ("] docs/monitor/sensors.md:11:66 MD037/no-space-in-emphasis Spaces inside emphasis markers [Context: ") _"] docs/monitor/sensors.md:13:23 MD037/no-space-in-emphasis Spaces inside emphasis markers [Context: "_ ("] docs/monitor/sensors.md:13:66 MD037/no-space-in-emphasis Spaces inside emphasis markers [Context: ") _"] ``` Refer to markdown-lint [1] to fix MD037 [1]: https://github.com/updownpress/markdown-lint/blob/master/rules/037-no-space-in-emphasis.md
Signed-off-by: George Liu <liuxiwei@ieisystem.com> Change-Id: Ifff2a9c647b284b49423ed3d04c79af8d5576b16
show more ...
|
64fb88c1 | 05-Aug-2024 |
George Liu <liuxiwei@ieisystem.com> |
Fix MD040 warnings
The following warnings are generated by using markdownlint analysis: ``` MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"] ``` Refer
Fix MD040 warnings
The following warnings are generated by using markdownlint analysis: ``` MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"] ``` Refer to markdown-lint [1] to fix MD040 [1]: https://github.com/updownpress/markdown-lint/blob/master/rules/040-fenced-code-language.md
Signed-off-by: George Liu <liuxiwei@ieisystem.com> Change-Id: Ie866ac8c3d8e33d2c8811f7c6a5965d6dad1f88a
show more ...
|
6d3e18c0 | 05-Aug-2024 |
George Liu <liuxiwei@ieisystem.com> |
Fix MD033 warnings
The following warnings are generated by using markdownlint analysis: ``` MD033/no-inline-html Inline HTML [Element: code] MD033/no-inline-html Inline HTML [Element: pre] MD033/no-
Fix MD033 warnings
The following warnings are generated by using markdownlint analysis: ``` MD033/no-inline-html Inline HTML [Element: code] MD033/no-inline-html Inline HTML [Element: pre] MD033/no-inline-html Inline HTML [Element: b] MD033/no-inline-html Inline HTML [Element: i] ``` Refer to markdown-lint [1] to fix MD033 [1]: https://github.com/updownpress/markdown-lint/blob/master/rules/033-no-inline-html.md
Signed-off-by: George Liu <liuxiwei@ieisystem.com> Change-Id: I7dfb63e9f3a663cfea60b5d0a0a4ae8540ddd1d6
show more ...
|
3dfaa524 | 05-Aug-2024 |
George Liu <liuxiwei@ieisystem.com> |
docs/presence/rpolicy.md: Fix MD033 warnings
The following warnings are generated by using markdownlint analysis: ``` docs/presence/rpolicy.md:37:6 MD033/no-inline-html Inline HTML [Element: code] d
docs/presence/rpolicy.md: Fix MD033 warnings
The following warnings are generated by using markdownlint analysis: ``` docs/presence/rpolicy.md:37:6 MD033/no-inline-html Inline HTML [Element: code] docs/presence/rpolicy.md:37:1 MD033/no-inline-html Inline HTML [Element: pre] docs/presence/rpolicy.md:50:5 MD033/no-inline-html Inline HTML [Element: b] docs/presence/rpolicy.md:50:8 MD033/no-inline-html Inline HTML [Element: i] ``` Refer to markdown-lint [1] to fix MD033 [1]: https://github.com/updownpress/markdown-lint/blob/master/rules/033-no-inline-html.md
Signed-off-by: George Liu <liuxiwei@ieisystem.com> Change-Id: I31748039b2f6a5bae46245a416dbde2eed4f3699
show more ...
|
14c82483 | 05-Aug-2024 |
George Liu <liuxiwei@ieisystem.com> |
docs/presence/rpolicy.md: Fix MD040 warnings
The following warnings are generated by using markdownlint analysis: ``` MD040/fenced-code-language Fenced code blocks should have a language specified [
docs/presence/rpolicy.md: Fix MD040 warnings
The following warnings are generated by using markdownlint analysis: ``` MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"] ``` Refer to markdown-lint [1] to fix MD040 [1]: https://github.com/updownpress/markdown-lint/blob/master/rules/040-fenced-code-language.md
Signed-off-by: George Liu <liuxiwei@ieisystem.com> Change-Id: Ic2ddba30a55a328af2528afc56a2147c7ceb6f59
show more ...
|
97bdb287 | 05-Aug-2024 |
George Liu <liuxiwei@ieisystem.com> |
docs/presence/README.md: Fix MD040 warnings
The following warnings are generated by using markdownlint analysis: ``` MD040/fenced-code-language Fenced code blocks should have a language specified [C
docs/presence/README.md: Fix MD040 warnings
The following warnings are generated by using markdownlint analysis: ``` MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"] ``` Refer to markdown-lint [1] to fix MD040 [1]: https://github.com/updownpress/markdown-lint/blob/master/rules/040-fenced-code-language.md
Signed-off-by: George Liu <liuxiwei@ieisystem.com> Change-Id: Icb601fbd199f536600d35322b7aca19371be00a4
show more ...
|