monitor: Change Fan/Sensor def tuples to structs

The tuples were big and hard to read/use. Change them to structs so the
members are always named.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>

monitor: Change Fan/Sensor def tuples to structs

The tuples were big and hard to read/use. Change them to structs so the
members are always named.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I79826563faf44636b251e614f45ff86f1e02c607

show more ...

monitor:yaml: Fix generated code

An if statement in the mako template went around two FanDefinition
members instead of one, leaving off the last value when a condition
name was in the input yaml.

S

monitor:yaml: Fix generated code

An if statement in the mako template went around two FanDefinition
members instead of one, leaving off the last value when a condition
name was in the input yaml.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: Ifa485174e7195b3738528236cc6c3344917ea37d

show more ...

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: I152f141a5e8343b92b5ce81d3ca16eec77b5606b
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

control:configs:rainier-2u: Add new hot card

Add the Lassen InfiniBand adapter to the hot cards list for the Rainier
2U.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I88f84068f2e22e7

control:configs:rainier-2u: Add new hot card

Add the Lassen InfiniBand adapter to the hot cards list for the Rainier
2U.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I88f84068f2e22e743fdd764b17914383ea3371a0

show more ...

meson: update required version

In meson 0.58 the `get_variable` was enhanced to no longer require the
`pkgconfig` keyword argument, but instead it uses a positional argument
which applies to all sea

meson: update required version

In meson 0.58 the `get_variable` was enhanced to no longer require the
`pkgconfig` keyword argument, but instead it uses a positional argument
which applies to all search-types. This repository is already using
a variant which is only supported on meson 0.58 (or later) so ensure
the 0.58 version is required.

Change-Id: I782f745d4a0676fa35f80712cf5bc08b79f7cbdf
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

control:configs:rainier-*4u: Add new hot card

Add the Dragonhead PCIe card to the hot cards list pcie_cards.json for
the Rainier 4U and 1S4U.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change

control:configs:rainier-*4u: Add new hot card

Add the Dragonhead PCIe card to the hot cards list pcie_cards.json for
the Rainier 4U and 1S4U.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: Idd355a350f39e0c8739fd3c68f16840f7da70cec

show more ...

control: Expose fanctl dump option in YAML mode

While the fan control code that uses the YAML configuration doesn't have
any dump capabilities, there are testcases in the
openbmc-test-automation rep

control: Expose fanctl dump option in YAML mode

While the fan control code that uses the YAML configuration doesn't have
any dump capabilities, there are testcases in the
openbmc-test-automation repo that call fanctl dump that don't know if
it's available or not.

This commit just exposes the 'dump' option even in YAML mode so that the
testcase doesn't need to care about fan control's internal
configuration. There was already code that would write the following to
/tmp/fan_control_dump.json in YAML mode:

"msg": "Unable to create dump on non-JSON config based system"

I also changed the help text to a more generic statement about dumping
data debug as opposed to saying it just dumps the flight recorder, since
it does a lot more.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I119b733628402d0719fd42b90254d7072245d080

show more ...

monitor: ibm,bonnell: Add remaining rotors to config

Add the second rotor of each fan to the Bonnell fan monitor config.
It's the same fan as used in the Rainier 2U so it has the same
characteristic

monitor: ibm,bonnell: Add remaining rotors to config

Add the second rotor of each fan to the Bonnell fan monitor config.
It's the same fan as used in the Rainier 2U so it has the same
characteristics.

Also add the EPOW configuration, which is the same as the Rainier 2U's
to start out with.

Change-Id: I3246638f46999732b50e4cc2e3dd81bd10555916
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

show more ...

treewide: remove dependencies on mapper.target

The mapper is dbus activated now, so these explicit dependency
declarations are unnecessary and redundant.

Change-Id: I7edbd283e021bdfb13b13daae7e792e

treewide: remove dependencies on mapper.target

The mapper is dbus activated now, so these explicit dependency
declarations are unnecessary and redundant.

Change-Id: I7edbd283e021bdfb13b13daae7e792ec65a4f26a
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

monitor:configs:Rainier 4U: increase deviation

Increase the deviation setting from 15 to 18 on the two IBM Rainier 4U
models to match that of the other IBM systems. There have been false
fails with

monitor:configs:Rainier 4U: increase deviation

Increase the deviation setting from 15 to 18 on the two IBM Rainier 4U
models to match that of the other IBM systems. There have been false
fails with the value at 15.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I515738163960da7f1497c74575ede8e4954d4c86

show more ...

control: Removed unused variable

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I65053bf7a2802eb3c1e5755c975b808978e75056

Add explicit keyword to 1 arg constructors

The cppcheck tool complains about it otherwise.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: Id977a6c349b0b49354b52ac994ea7742e0a39307

monitor: Use host state to decide power state

phosphos-fan-monitor service is using pgood to decide the power state.
When power state is off, phosphor-fan-monitor should not check
functionality of f

monitor: Use host state to decide power state

phosphos-fan-monitor service is using pgood to decide the power state.
When power state is off, phosphor-fan-monitor should not check
functionality of fans. However, with Ampere's Softoff (e.g via power
cycle), it takes long for pgood to change state after the command to
power cycle host is taken, so phosphor-fan-monitor fails to detect the
power state is off, and continues to check functionality. This results
in fans being marked non-functional when host is off during power cycle.
This patch offers a package configuration option for choosing to use
CurrentHostState instead of pgood to decide the power state. When the
CurrentHostState is TransitioningToOff, which is set right after the
power cycle command, the power state will be considered as off.

Signed-off-by: Chau Ly <chaul@amperecomputing.com>
Change-Id: I6f459384b1d536f61c5df787d696412acc04ba02

show more ...

monitor: Add delay for host control

Some OpenBMC platforms use dbus-sensor and entity-manager to create
the fan sensors. In those systems, phosphor-fan-monitor starts before
the fan sensors are crea

monitor: Add delay for host control

Some OpenBMC platforms use dbus-sensor and entity-manager to create
the fan sensors. In those systems, phosphor-fan-monitor starts before
the fan sensors are created during BMC boot up. phosphor-fan-monitor
is designed to shutdown the host when there is no fan tach sensors which
is not desirable in this case. This patch supports a package
configuration option delay-host-control to add a desired delay before
phosphor-fan-monitor turns off host. This can be configured to match
with each system timing.

Signed-off-by: Chau Ly <chaul@amperecomputing.com>
Change-Id: I63cd85eb5e6cb04069ce7b4c21c2f4621d243502

show more ...

monitor: Change 'input' to 'actual' in trace

Change the 'input' label in a trace to 'actual' to make it more obvious
that it means the fan's actual speed.

Signed-off-by: Matt Spinler <spinler@us.ib

monitor: Change 'input' to 'actual' in trace

Change the 'input' label in a trace to 'actual' to make it more obvious
that it means the fan's actual speed.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I76686bf8b68ad7b8fb5ad994a78a50eb1a60900c

show more ...

control:configs: rainier-1s4u floor updates

If the model value of the first processor is 5CF9, use a different
mapped_floor table with higher floors.

Signed-off-by: Matt Spinler <spinler@us.ibm.com

control:configs: rainier-1s4u floor updates

If the model value of the first processor is 5CF9, use a different
mapped_floor table with higher floors.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I2ebea798e3c5e5bf60aa82d12b4139239f383a72

show more ...

control: Trace around enabling events

Add flight recorder entries before and after fan control events are
enabled on startup. This can be used for debug to tell how long the
enables take.

e.g.
```

control: Trace around enabling events

Add flight recorder entries before and after fan control events are
enabled on startup. This can be used for debug to tell how long the
enables take.

e.g.
```
"Jan 10 16:03:11.329067: main: Enabling events",
"Jan 10 16:03:11.385515: zone-floor0: mapped_floor-70(Fan floors) is setting floor hold to 7300",
"Jan 10 16:03:11.385534: zone-floor0: Setting new floor to 7300",
"Jan 10 16:03:13.951341: main: Done enabling events",
```

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I5753617a38972b28ab12b314576c8774ee73c37e

show more ...

control:configs: Add altitude group to Rainier 4Us

The altitude is used by actions in the Rainier 4U and 1S4U, but was
missing from the groups.json files. This caused the altitude offsets
used by th

control:configs: Add altitude group to Rainier 4Us

The altitude is used by actions in the Rainier 4U and 1S4U, but was
missing from the groups.json files. This caused the altitude offsets
used by the mapped floor action to always be zero.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I46748a9dfe5f054964c11ae28009c0c73b23b1fc

show more ...

control: mapped_floor: Add conditions

Add the concept of a condition to the mapped_floor action such that it
will only run if the condition is met. If the condition isn't met, the
run() function wi

control: mapped_floor: Add conditions

Add the concept of a condition to the mapped_floor action such that it
will only run if the condition is met. If the condition isn't met, the
run() function will just exit immediately.

A condition is created by placing the following in the JSON:

* condition_group
- The name of the group that has the property the condition
will use. For now, it must be a single member group.
* condition_value
- The value the property has to be to meet the condition.
* condition_op
- Either 'equal' or 'not_equal', where the property has to
either be equal to or not equal to the condition value.

For example, the following says the single member of the 'cpu 0' group
must have its Model property be equal to "1234" for the action to run:

{
"groups": [{
"name": "cpu 0",
"interface": "xyz.openbmc_project.Inventory.Decorator.Asset",
"property": { "name": "Model" }
}
...
],
...
"name": "mapped_floor",
"key_group": "ambient temp",
"condition_group": "cpu 0",
"condition_value": "1234",
"condition_op": "equal",
...
}

If a condition is present but isn't met, the action will remove its
floor hold if it has one to support the case of the condition property
changing values.

Change-Id: I3ede20efd334e2c5292a441c089534420959c7bc
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

show more ...

control: Add Zone::hasFloorHold() function

Add this to the Zone class so actions can check if they currently have a
floor hold.

Change-Id: I84d0cec7bc3d45feab0ae2c4b08acf6832337f8f
Signed-off-by: M

control: Add Zone::hasFloorHold() function

Add this to the Zone class so actions can check if they currently have a
floor hold.

Change-Id: I84d0cec7bc3d45feab0ae2c4b08acf6832337f8f
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

show more ...

control: Catch GetManagedObjects exceptions

The get_managed_objects action makes a GetManagedObjects D-Bus call to
put D-bus properties from a service into the cache.

Handle exceptions thrown by it

control: Catch GetManagedObjects exceptions

The get_managed_objects action makes a GetManagedObjects D-Bus call to
put D-bus properties from a service into the cache.

Handle exceptions thrown by it in case it was called from a
name_owner_changed trigger when the service went off of D-Bus, which
would cause it to fail.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I18ebcea327578073780b4658c8a1d897cbfa20e5

show more ...

prettier: re-format

Prettier is enabled in openbmc-build-scripts on Markdown, JSON, and YAML
files to have consistent formatting for these file types. Re-run the
formatter on the whole repository.

prettier: re-format

Prettier is enabled in openbmc-build-scripts on Markdown, JSON, and YAML
files to have consistent formatting for these file types. Re-run the
formatter on the whole repository.

Change-Id: Ia2f5cffe35ac3175d6663d9b4e173d16e985bf4c
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

prettier: re-format

Prettier is enabled in openbmc-build-scripts on Markdown, JSON, and YAML
files to have consistent formatting for these file types. Re-run the
formatter on the whole repository.

prettier: re-format

Prettier is enabled in openbmc-build-scripts on Markdown, JSON, and YAML
files to have consistent formatting for these file types. Re-run the
formatter on the whole repository.

Change-Id: I961ec77b2617da3e097e64e0d8e8980bb7e5b426
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

black: re-format

black and isort are enabled in the openbmc-build-scripts on Python files
to have a consistent formatting. Re-run the formatter on the whole
repository.

Change-Id: Ic2869f39aef47b8

black: re-format

black and isort are enabled in the openbmc-build-scripts on Python files
to have a consistent formatting. Re-run the formatter on the whole
repository.

Change-Id: Ic2869f39aef47b874c1bfb2caead790fc628d737
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

python: fix flake8 warnings and format with black

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: If25d550660b82ea8c5f2c9b9140f3e7c5f77e906