14cc043f | 16-Jan-2019 |
Matthew Barth <msbarth@us.ibm.com> |
Fan control dbus busname and object path
Add fan control's default dbus busname and object path to use or what's provided thru configure. The fan control manager requests the busname after all the z
Fan control dbus busname and object path
Add fan control's default dbus busname and object path to use or what's provided thru configure. The fan control manager requests the busname after all the zones are created.
Tested: Found the requested busname for a zone in the busctl list
Change-Id: I8ee1e9e4094dcec958e8ae81ad4299357b8f792d Signed-off-by: Matthew Barth <msbarth@us.ibm.com>
show more ...
|
dea024f0 | 29-Oct-2018 |
William A. Kennington III <wak@google.com> |
libfan: Remove
Since the removal of the custom timer implementation our libfan has nothing but a single header file. Since we have no object code left we do not need a library to contain this code s
libfan: Remove
Since the removal of the custom timer implementation our libfan has nothing but a single header file. Since we have no object code left we do not need a library to contain this code since the header is directly included where needed.
Tested: Built and run through unit tests.
Change-Id: I139b83ab979ead88cfd4c180ba8847a29c6407e2 Signed-off-by: William A. Kennington III <wak@google.com>
show more ...
|
8fd879fb | 30-Oct-2018 |
William A. Kennington III <wak@google.com> |
Remove timer in favor of sdeventplus/utility/timer
This removes the custom timer implementation and moves to the sdeventplus utility. Functionally this should make no change
Tested: Built and r
Remove timer in favor of sdeventplus/utility/timer
This removes the custom timer implementation and moves to the sdeventplus utility. Functionally this should make no change
Tested: Built and run through the unit test suite.
Change-Id: Ib7ee90d489d5db72496aaaca91c3cf5490ad47d6 Signed-off-by: William A. Kennington III <wak@google.com>
show more ...
|
a1aef7a1 | 16-Jan-2019 |
Matthew Barth <msbarth@us.ibm.com> |
Parser updates to support alternate events action
With the use alternate events action, the ability to generate an event type is required within the parser. This action requires two separate lists o
Parser updates to support alternate events action
With the use alternate events action, the ability to generate an event type is required within the parser. This action requires two separate lists of events to be generated and to generate the event code, it was necessary to add what code is generated for each section that comprises an event to the parser directly.
Tested: Updated events yaml with an event to use the alternate events action Verified the generated code builds and runs on wspoon
Change-Id: I2078610222b0ae0f7fdbcf348e5c9ff02c4108b6 Signed-off-by: Matthew Barth <msbarth@us.ibm.com>
show more ...
|
c410ddab | 11-Jan-2019 |
Matthew Barth <msbarth@us.ibm.com> |
Add alternate events action
The alternate events action uses a group of properties to determine whether a default set of events should be used or an alternate set of events should be used. When any
Add alternate events action
The alternate events action uses a group of properties to determine whether a default set of events should be used or an alternate set of events should be used. When any of the members of the group do not match the given property state, the default set of events are used. Once all members of the group match the given state, the alternate set of events are used. Each time the events used are to change, the current set of events are removed prior to loading the replacement set of events.
Tested: Used the 'WaterCooled' property to trigger using the default or alternate floor speed events. Verified fan control memory usage doesnt grow by doing multiple event switching.
Change-Id: Ib8a4b835bf370894c572ccfa8fdc5a4479ef570f Signed-off-by: Matthew Barth <msbarth@us.ibm.com>
show more ...
|
f0b020fb | 21-Nov-2018 |
Brad Bishop <bradleyb@fuzziesquirrel.com> |
control: manager: Avoid the need for fconcepts
Use of auto in a function parameter list is supported in c++17 but gcc8 requires enabling concepts TS support. We don't require a template anyway - ju
control: manager: Avoid the need for fconcepts
Use of auto in a function parameter list is supported in c++17 but gcc8 requires enabling concepts TS support. We don't require a template anyway - just be explicit here and avoid the need for -fconcepts until such a time that other concepts TS features are required.
Change-Id: Iec6205a2e4da41aeb5840dd9942778ba0f373842 Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
show more ...
|
4978e06c | 27-Nov-2018 |
William A. Kennington III <wak@google.com> |
std::variant: Apply missing fixup
This code is not compiled during the unit test run. The issue was noticed trying to integrate into a real openbmc build.
Change-Id: I30b7afaf722b1a14e5ac3d5e93e13b
std::variant: Apply missing fixup
This code is not compiled during the unit test run. The issue was noticed trying to integrate into a real openbmc build.
Change-Id: I30b7afaf722b1a14e5ac3d5e93e13b59db48be7a Signed-off-by: William A. Kennington III <wak@google.com>
show more ...
|
2c8e1988 | 12-Nov-2018 |
William A. Kennington III <wak@google.com> |
control/zone: Fix missing cassert include
This was relying on sdbusplus to provide a transitive include for <cassert>. Since we are directly using the assert() call we should include <cassert> ourse
control/zone: Fix missing cassert include
This was relying on sdbusplus to provide a transitive include for <cassert>. Since we are directly using the assert() call we should include <cassert> ourselves.
Change-Id: I095af26c7a589ab337facc6ac2d0c4983a0f0c2c Signed-off-by: William A. Kennington III <wak@google.com>
show more ...
|
e8b340bd | 09-Nov-2018 |
Matthew Barth <msbarth@us.ibm.com> |
control: Add interface when not in service cache
When a service is cached, each interface it hosts is added to a list. In the case where an object path given to fan control is never found, a service
control: Add interface when not in service cache
When a service is cached, each interface it hosts is added to a list. In the case where an object path given to fan control is never found, a service lookup is performed on this path causing its given interface to be added. This fixes that interface from continuously being added in the case that the object path is attempted to be accessed continuously from dbus.
Resolves openbmc/phosphor-fan-presence#12
Tested: Added & removed events containing object paths that dont exist, interface list remains the same size.
Change-Id: Id034e7829566979c196cb9901cbea287ddab78d4 Signed-off-by: Matthew Barth <msbarth@us.ibm.com>
show more ...
|
52fbe0d9 | 06-Nov-2018 |
William A. Kennington III <wak@google.com> |
Fix std::variant usage
We need to use the std::get() interface instead of the mapbox .get() member interface for variant compatibility.
Change-Id: I6c7843ea0cb765332457273867b5df6b78ca72a2 Signed-o
Fix std::variant usage
We need to use the std::get() interface instead of the mapbox .get() member interface for variant compatibility.
Change-Id: I6c7843ea0cb765332457273867b5df6b78ca72a2 Signed-off-by: William A. Kennington III <wak@google.com>
show more ...
|
8ce4b5f5 | 06-Nov-2018 |
Matthew Barth <msbarth@us.ibm.com> |
Rebase correction (timerPos -> timerConfPos)
Change-Id: I5ab5adcc22f044b3cf0955082061c67f2a281307 Signed-off-by: Matthew Barth <msbarth@us.ibm.com> |
0420a932 | 30-Oct-2018 |
William A. Kennington III <wak@google.com> |
control/zone: Use const references when iterating
We don't want to copy the object out of the container we are iterating over.
Tested: Built and run through unit tests.
Change-Id: I68b041f98e1
control/zone: Use const references when iterating
We don't want to copy the object out of the container we are iterating over.
Tested: Built and run through unit tests.
Change-Id: I68b041f98e1c6a6a9dbc59448b629e1d22ba62c9 Signed-off-by: William A. Kennington III <wak@google.com>
show more ...
|
33bfe761 | 05-Nov-2018 |
Matthew Barth <msbarth@us.ibm.com> |
Remove all signals when an event is removed
Each event could have multiple signals associated and when the event is removed, all of those signals should also be removed. This ensures no dangling sig
Remove all signals when an event is removed
Each event could have multiple signals associated and when the event is removed, all of those signals should also be removed. This ensures no dangling signals remain after an event is removed from be processed by fan control
Tested: The total number of signals subscribed are reduced by the same number of signals of a removed event
Change-Id: I651f70dbe6aed9c7eef06aff4eac9eae7ad89d77 Signed-off-by: Matthew Barth <msbarth@us.ibm.com>
show more ...
|
22c36ab6 | 30-Oct-2018 |
William A. Kennington III <wak@google.com> |
Prefer bind over method call in lambda
This reduces a layer of indirection since the function can be called directly instead of indirectly accessing it with the lambda. It also makes the instantiati
Prefer bind over method call in lambda
This reduces a layer of indirection since the function can be called directly instead of indirectly accessing it with the lambda. It also makes the instantiation more flexible since it can match callbacks with extra arguments.
Tested: Built and run through unit tests.
Change-Id: I5317203fa70c027c5e774ed6192952058e35bd81 Signed-off-by: William A. Kennington III <wak@google.com>
show more ...
|
c0c5f07f | 30-Oct-2018 |
William A. Kennington III <wak@google.com> |
control/zone: Reference instead of copying timer data
Tested: Built and ran through unit tests.
Change-Id: I9a98d9a3eaee47885b18b642ffd01a38a864dd02 Signed-off-by: William A. Kennington III <wa
control/zone: Reference instead of copying timer data
Tested: Built and ran through unit tests.
Change-Id: I9a98d9a3eaee47885b18b642ffd01a38a864dd02 Signed-off-by: William A. Kennington III <wak@google.com>
show more ...
|
94fe1a0c | 30-Oct-2018 |
William A. Kennington III <wak@google.com> |
control/zone: Refactor addTimer
Anything adding a timer uses roughly the same process of building the event data and timer from the event group, actions, and timer config. We can adjust the method t
control/zone: Refactor addTimer
Anything adding a timer uses roughly the same process of building the event data and timer from the event group, actions, and timer config. We can adjust the method to do this for all callers.
Tested: Builds and passes unit tests.
Change-Id: I4013ff2f7bff65095a6e1db7075bc013da374f51 Signed-off-by: William A. Kennington III <wak@google.com>
show more ...
|
122b843f | 30-Oct-2018 |
William A. Kennington III <wak@google.com> |
control: Rename Timer -> TimerConf
It is confusing to read some of the type definitions that deal with timers when Timer could mean a timer instantiation or a set of timer configuration parameters.
control: Rename Timer -> TimerConf
It is confusing to read some of the type definitions that deal with timers when Timer could mean a timer instantiation or a set of timer configuration parameters. This change disambiguates the two types.
Tested: Built and run through unit tests.
Change-Id: I9dd6b47886747d56a86b6a50eb9a74a331d0a1fe Signed-off-by: William A. Kennington III <wak@google.com>
show more ...
|
0ce353ec | 30-Oct-2018 |
William A. Kennington III <wak@google.com> |
control: Alias TimerType locally
This is needed for a future commit that removes the local phosphor::util::Timer implementation.
Tested: Built and run through unit tests.
Change-Id: I8ea3399fe
control: Alias TimerType locally
This is needed for a future commit that removes the local phosphor::util::Timer implementation.
Tested: Built and run through unit tests.
Change-Id: I8ea3399fec8761055d4a0d94fb9ea91fd34040ea Signed-off-by: William A. Kennington III <wak@google.com>
show more ...
|
1cfc2f11 | 19-Oct-2018 |
William A. Kennington III <wak@google.com> |
Switch sd_event loops to sdeventplus
This change is mostly focused around plumbing the sdeventplus::Event object everywhere and using the member functions provided for the event. No migration to the
Switch sd_event loops to sdeventplus
This change is mostly focused around plumbing the sdeventplus::Event object everywhere and using the member functions provided for the event. No migration to the timer utility is performed yet.
Change-Id: I912ab82bc081239d3b7c3cf7c5caca6742ef9c87 Signed-off-by: William A. Kennington III <wak@google.com>
show more ...
|
5882e0c0 | 24-Oct-2018 |
Patrick Venture <venture@google.com> |
gitignore: add libtool
Add libtool artifact to gitignore.
Change-Id: Ie283f97cc0d714be89ebed420f439322cda653b1 Signed-off-by: Patrick Venture <venture@google.com> |
3e781064 | 19-Oct-2018 |
William A. Kennington III <wak@google.com> |
Fix exit status codes
Using an exit status of -1 everywhere leads to the status being converted to 255 when output to a calling application. While this does signify an error it has a reserved meanin
Fix exit status codes
Using an exit status of -1 everywhere leads to the status being converted to 255 when output to a calling application. While this does signify an error it has a reserved meaning for exit status out of range. Lets use a valid general exit status of 1 instead.
Change-Id: I326701c78985e34c430c258fe31d9e910da10405 Signed-off-by: William A. Kennington III <wak@google.com>
show more ...
|
b884821d | 19-Oct-2018 |
William A. Kennington III <wak@google.com> |
Makefile: Fix library compile flags
We are missing flags for compiling against dependencies used in libfan.
Change-Id: I62addac0d153be194171acee77ec7a32a503b85c Signed-off-by: William A. Kennington
Makefile: Fix library compile flags
We are missing flags for compiling against dependencies used in libfan.
Change-Id: I62addac0d153be194171acee77ec7a32a503b85c Signed-off-by: William A. Kennington III <wak@google.com>
show more ...
|
48df959b | 04-Oct-2018 |
Vernon Mauery <vernon.mauery@linux.intel.com> |
phosphor-fan-presence: use c++17
Update configure.ac to choose the c++17 standard
Change-Id: I9c7bba8ae28101e95eb969dd1d1ae01f37cd3e48 Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com> |
bd2e80a6 | 18-Sep-2018 |
Lei YU <mine260309@gmail.com> |
Fix libfan_la_CXXFLAGS
The libfan_la_CXXFLAGS was incorrectly defined as empty by a typo, fix it. Then specify gcc-ar gcc-ranlib for link time optimization, otherwise the static library will get lin
Fix libfan_la_CXXFLAGS
The libfan_la_CXXFLAGS was incorrectly defined as empty by a typo, fix it. Then specify gcc-ar gcc-ranlib for link time optimization, otherwise the static library will get link error.
Tested: Verify the build is OK in CI, local build, and SDK build. Resolves openbmc/phosphor-fan-presence#11
Change-Id: I17c83b9927a796f8928a71688c1640d1a602a108 Signed-off-by: Lei YU <mine260309@gmail.com>
show more ...
|
ecd4bc7b | 27-Aug-2018 |
Andrew Geissler <geissonator@yahoo.com> |
Add -flto to CXXFLAGS
Per openbmc/openbmc#3364, adding -flto to CXX flags in order to reduce overall library and binary sizes.
Ref: https://gcc.gnu.org/wiki/LinkTimeOptimization
Change-Id: I3ee31a
Add -flto to CXXFLAGS
Per openbmc/openbmc#3364, adding -flto to CXX flags in order to reduce overall library and binary sizes.
Ref: https://gcc.gnu.org/wiki/LinkTimeOptimization
Change-Id: I3ee31a15fc0ded4308aa9d00a11b41bc62eb9799 Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
show more ...
|