| 83467409 | 31-Oct-2023 |
Matt Spinler <spinler@us.ibm.com> |
monitor:ibm,bonnell: Increase service mode delay
Change Bonnell's fan monitor service mode delay to 5 minutes. This is
the delay that 2 rotors can be missing/faulted before a shutdown is
requested.
monitor:ibm,bonnell: Increase service mode delay
Change Bonnell's fan monitor service mode delay to 5 minutes. This is
the delay that 2 rotors can be missing/faulted before a shutdown is
requested.
Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I89042efdca4d5dab7e8c58eff19d5604922e7b02
show more ...
|
| 1b3bcc32 | 31-Oct-2023 |
Matt Spinler <spinler@us.ibm.com> |
control:cnfgs:ibm,bonnell: Enable fan control
Check in the JSON files to enable fan control on IBM's Bonnell system.
It is a 1 socket 4 DIMM 2 fan system. It uses the same fan model as the
Rainier
control:cnfgs:ibm,bonnell: Enable fan control
Check in the JSON files to enable fan control on IBM's Bonnell system.
It is a 1 socket 4 DIMM 2 fan system. It uses the same fan model as the
Rainier 2U, and uses mostly the same settings as the Rainier 2U with the
exception of having some lower floors, though only when there are no hot
PCIe cards present.
The floor values when there are hot PCIe card present may change in the
future.
Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I30b42fa4f2c2715ba26bbfef4a3d28dc77373390
show more ...
|
| 5e15c3ba | 20-Oct-2023 |
Patrick Williams <patrick@stwcx.xyz> |
clang-format: copy latest and re-format
clang-format-17 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest
clang-format: copy latest and re-format
clang-format-17 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.
Change-Id: I3e9e6350864ac267819a4b8d670bef7d3746976e
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
show more ...
|
| 785f6d68 | 16-Oct-2023 |
Matt Spinler <spinler@us.ibm.com> |
control:configs:rainier-*4u: Add new hot card
Add the Shale PCIe card to the hot cards list pcie_cards.json for
the Rainier 4U and 1S4U.
Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id:
control:configs:rainier-*4u: Add new hot card
Add the Shale PCIe card to the hot cards list pcie_cards.json for
the Rainier 4U and 1S4U.
Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I84ad11d790f48584fe6fffd850a474532e5214fe
show more ...
|
| 0cff4ea6 | 12-Sep-2023 |
Chau Ly <chaul@amperecomputing.com> |
Small change to power state initial sequence
When HostPowerState is constructed with a callback, if it reads true
from HostState (different from the init value of _powerState), the
callback will be
Small change to power state initial sequence
When HostPowerState is constructed with a callback, if it reads true
from HostState (different from the init value of _powerState), the
callback will be called. This is not a power state change at all, so we
shouldn't call the callback.
Tested with monitor-use-host-state enabled for phosphor-fan-monitor
service.
When HostState is On, restart phosphor-fan-monitor service.
Result: the service won't throw or turn host off.
Signed-off-by: Chau Ly <chaul@amperecomputing.com>
Change-Id: Ie616a9631a129401a3cdc000612a8e694d02ef7a
show more ...
|
| 2e22b235 | 24-Aug-2023 |
Matt Spinler <spinler@us.ibm.com> |
Remove remaining fmt::format use
The only remaining use of the fmt::format library was for something
std::format can't yet handle, printing ranges. This was only used
twice, in the same file, so ju
Remove remaining fmt::format use
The only remaining use of the fmt::format library was for something
std::format can't yet handle, printing ranges. This was only used
twice, in the same file, so just manually build up the vectors in
question into a string and use std::format. This was already being done
in other places anyway.
Now the fmt::format subproject and dependencies can be completely
removed.
An added benefit is that those two fmt::format calls were failing to
build on my system when I was trying to build using subprojects, and
without them everything works.
Tested:
Can still see the traces, though I only have a 1 element vector to test
with:
Adding fan target lock of 11300 on fans [fan0] zone 0",
Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I90055e9d1c8d0b79b151e1cfd0af2052005cef3c
show more ...
|
| 023d2c70 | 24-Aug-2023 |
Matt Spinler <spinler@us.ibm.com> |
Make gmock dep initially not required
Add a 'required: false' when building the gmock dependency so it doesn't
have to be present initially, as the code right below will already fetch
it if not pres
Make gmock dep initially not required
Add a 'required: false' when building the gmock dependency so it doesn't
have to be present initially, as the code right below will already fetch
it if not present. Otherwise, the build will fail before it has a
chance to build the subproject if it needs it.
Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I20c58f3b5b6978fa6deb69cdf799e34bb4054ce4
show more ...
|
| fbf4703f | 17-Jul-2023 |
Patrick Williams <patrick@stwcx.xyz> |
use std::format instead of fmt::format
The std::format is sufficient for the uses in this repository except
for in one file (override_fan_target.cpp, since P2286 isn't supported
by GCC yet). Switch
use std::format instead of fmt::format
The std::format is sufficient for the uses in this repository except
for in one file (override_fan_target.cpp, since P2286 isn't supported
by GCC yet). Switch to std::format whenever possible.
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ib2576fb530a4d7ce238e1b0bd95b40b476ec2107
show more ...
|
| 45b3537a | 15-Aug-2023 |
George Liu <liuxiwei@inspur.com> |
meson_options.txt: Support for reading options from meson.options
Support has been added for reading options from meson.options instead
of meson_options.txt[1]. These are equivalent, but not using t
meson_options.txt: Support for reading options from meson.options
Support has been added for reading options from meson.options instead
of meson_options.txt[1]. These are equivalent, but not using the .txt
extension for a build file has a few advantages, chief among them
many tools and text editors expect a file with the .txt extension to
be plain text files, not build scripts.
[1] https://mesonbuild.com/Release-notes-for-1-1-0.html#support-for-reading-options-from-mesonoptions
Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I1ba676af3dead18aa55db47823605918c46fd1cd
show more ...
|
| 8426b2d5 | 15-Aug-2023 |
George Liu <liuxiwei@inspur.com> |
evmon: Replace Argument class with CLI11
Phosphor-fan already depends on cli11, delete Argument class and use
cli11 instead.
Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: Ia69628eb61d6
evmon: Replace Argument class with CLI11
Phosphor-fan already depends on cli11, delete Argument class and use
cli11 instead.
Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: Ia69628eb61d628ae878e5332ea14255c76ebe11b
show more ...
|
| 854abad4 | 15-Aug-2023 |
George Liu <liuxiwei@inspur.com> |
control: Replace Argument class with CLI11
Phosphor-fan already depends on cli11, delete Argument class and use
cli11 instead.
Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I4f4283f2d1
control: Replace Argument class with CLI11
Phosphor-fan already depends on cli11, delete Argument class and use
cli11 instead.
Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I4f4283f2d1c9a096a921814156ba81fea72eab34
show more ...
|
| acc66d02 | 15-Aug-2023 |
George Liu <liuxiwei@inspur.com> |
cooling-type: Replace Argument class with CLI11
Phosphor-fan already depends on cli11, delete Argument class and use
cli11 instead.
Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I327a5
cooling-type: Replace Argument class with CLI11
Phosphor-fan already depends on cli11, delete Argument class and use
cli11 instead.
Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I327a522ecf232c00661088f2c527e626c24610bc
show more ...
|
| cb6129e0 | 14-Aug-2023 |
George Liu <liuxiwei@inspur.com> |
monitor: Replace Argument class with CLI11
Phosphor-fan already depends on cli11, delete Argument class and use
cli11 instead.
Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I017ff2012f
monitor: Replace Argument class with CLI11
Phosphor-fan already depends on cli11, delete Argument class and use
cli11 instead.
Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I017ff2012f73d0025ea04f6fe1d5d86710e04645
show more ...
|
| fc4be0d6 | 17-Jul-2023 |
Patrick Williams <patrick@stwcx.xyz> |
control: add missing phosphor-logging dependency
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Iefa68e90bf03255119f7dd38dd4de96ac6589fd1 |
| 15499905 | 19-Jul-2023 |
Patrick Williams <patrick@stwcx.xyz> |
build: evdev: update wrap to newest URL
The freedesktop project moved all of their repositories out of github
and into their own gitlab instance. Unfortunately they deleted all of
the old repositor
build: evdev: update wrap to newest URL
The freedesktop project moved all of their repositories out of github
and into their own gitlab instance. Unfortunately they deleted all of
the old repositories and no longer even mirror to github, so the URL
that was previously here is broken. Update to the origin gitlab URL.
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I328faa9ab787156f9efb149a103358dfc2c21c0e
show more ...
|
| 16e512d4 | 17-Jul-2023 |
Patrick Williams <patrick@stwcx.xyz> |
build: fix nlohmann-json dependency
Previously the json dependency was only added when `json-control` or
`json-config` options were enabled, but there is now base code that
utilizes nlohmann-json di
build: fix nlohmann-json dependency
Previously the json dependency was only added when `json-control` or
`json-config` options were enabled, but there is now base code that
utilizes nlohmann-json directly (such as logger.hpp). Add the
dependency at the top level.
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ia92e54f9bd4812af0977bcfa5479f093f7bdbc67
show more ...
|
| 1a56c2bc | 17-Jul-2023 |
Patrick Williams <patrick@stwcx.xyz> |
build: add cereal dependencies
Numerous places are missing dependencies for Cereal, which makes the
repository impossible to build with meson subprojects. Add them and
the appropriate wrap file.
S
build: add cereal dependencies
Numerous places are missing dependencies for Cereal, which makes the
repository impossible to build with meson subprojects. Add them and
the appropriate wrap file.
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: If20779983b9b062d7050dc323ccbae678ce58220
show more ...
|
| 2fbbae69 | 12-Jul-2023 |
Patrick Williams <patrick@stwcx.xyz> |
build: upgrade to C++23
Meson 1.1.1 and GCC-13 both support C++23 and a sufficient portion of
the standard has been implemented. Upgrade the build to leverage it.
Change-Id: I97076369348784595b127
build: upgrade to C++23
Meson 1.1.1 and GCC-13 both support C++23 and a sufficient portion of
the standard has been implemented. Upgrade the build to leverage it.
Change-Id: I97076369348784595b127357b01c0a28ee4c23df
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
show more ...
|
| 12cb6906 | 12-May-2023 |
Matt Spinler <spinler@us.ibm.com> |
control:fanctl: Option to do dump before query
Add a -d option to the 'fanctl query_dump' command that will generate
the dump and do the query in one step. Previously the dump had to be
generated f
control:fanctl: Option to do dump before query
Add a -d option to the 'fanctl query_dump' command that will generate
the dump and do the query in one step. Previously the dump had to be
generated first with the 'fanctl dump' command.
Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: Ibe0b60ca75f2390fea03ea450bfd4da6a57f57b6
show more ...
|
| f2040133 | 10-May-2023 |
Matt Spinler <spinler@us.ibm.com> |
control: Trace which fan gets target locked
The override_fan_target action is used to lock a fan to a target in
certain cases. It was already tracing when this was occurring, but it
didn't say whic
control: Trace which fan gets target locked
The override_fan_target action is used to lock a fan to a target in
certain cases. It was already tracing when this was occurring, but it
didn't say which fan it was happening to. Add that information.
Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I074ddcbab32ff5606b7a1c7b3ceb03076a49ce30
show more ...
|
| bfe42adf | 10-May-2023 |
Matt Spinler <spinler@us.ibm.com> |
monitor:configs: Add ibm,bonnell upper deviation
Add an upper deviation of 40% to the Bonnell fan monitor config.
This helps in the case when a single rotor is stopped which causes the
remaining ro
monitor:configs: Add ibm,bonnell upper deviation
Add an upper deviation of 40% to the Bonnell fan monitor config.
This helps in the case when a single rotor is stopped which causes the
remaining rotor to spin faster than usual.
Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I07dcc0b551385a5024057f965d580f649dbeafce
show more ...
|
| f724c16b | 10-May-2023 |
Matt Spinler <spinler@us.ibm.com> |
monitor: Support a separate upper deviation
Add an optional 'upper_deviation' field to the fan monitor config and if
supplied it will be used for the allowed deviation when the fan value is
over the
monitor: Support a separate upper deviation
Add an optional 'upper_deviation' field to the fan monitor config and if
supplied it will be used for the allowed deviation when the fan value is
over the target. If not supplied it will work as today and the single
deviation value will be used for both the upper and lower bounds.
Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I085dc1996832e79b94bd1df3a05681d107f466eb
show more ...
|
| 18fb12b8 | 09-May-2023 |
Matt Spinler <spinler@us.ibm.com> |
monitor: Change Fan/Sensor def tuples to structs
The tuples were big and hard to read/use. Change them to structs so the
members are always named.
Signed-off-by: Matt Spinler <spinler@us.ibm.com>
monitor: Change Fan/Sensor def tuples to structs
The tuples were big and hard to read/use. Change them to structs so the
members are always named.
Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I79826563faf44636b251e614f45ff86f1e02c607
show more ...
|
| 086e8168 | 09-May-2023 |
Matt Spinler <spinler@us.ibm.com> |
monitor:yaml: Fix generated code
An if statement in the mako template went around two FanDefinition
members instead of one, leaving off the last value when a condition
name was in the input yaml.
S
monitor:yaml: Fix generated code
An if statement in the mako template went around two FanDefinition
members instead of one, leaving off the last value when a condition
name was in the input yaml.
Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: Ifa485174e7195b3738528236cc6c3344917ea37d
show more ...
|
| 61b73296 | 10-May-2023 |
Patrick Williams <patrick@stwcx.xyz> |
clang-format: copy latest and re-format
clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest
clang-format: copy latest and re-format
clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.
Change-Id: I152f141a5e8343b92b5ce81d3ca16eec77b5606b
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
show more ...
|