control:p10bmc:rainier-4u/1s4u - Comment repurpose of memory temps

To have different t-control points for the 2U and 4U sized dimms, the
external memory buffer/dram temp sensor type will be repurpos

control:p10bmc:rainier-4u/1s4u - Comment repurpose of memory temps

To have different t-control points for the 2U and 4U sized dimms, the
external memory buffer/dram temp sensor type will be repurposed to
report the dram temperatures of 4U DDIMMs. Additionally, the external
memory buffer temp sensor type will be repurposed to report the pmic
temperatures of 4U DDIMMs.

Change-Id: I5b05085acb51cfdf8d1809cc11e3b4498844de0b
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

control: action to override a single fan in a zone - Lock fan in Zone

The override Action can only reference fans by name. Thus, Zone is
modified to apply a target lock to a specific fan given by na

control: action to override a single fan in a zone - Lock fan in Zone

The override Action can only reference fans by name. Thus, Zone is
modified to apply a target lock to a specific fan given by name.
Additionally, the unlock method must pass the target value to allow
support for concurrent locks.

Signed-off-by: Mike Capps <mikepcapps@gmail.com>
Change-Id: Ic2ea81f318fb2c866198a4b24e38cc679147afc5

show more ...

control: action to override a single fan in a zone - ability to lock Fan

This change modifies Fan to accept one or more override targets which
prevent Fan from accepting regular target updates until

control: action to override a single fan in a zone - ability to lock Fan

This change modifies Fan to accept one or more override targets which
prevent Fan from accepting regular target updates until all locks have
been cleared using unlockTarget().

Multiple locks are supported, however only the higest locked target will
ever be active. For instance, if targets are locked at 9000 and 10000
(in either order), the 10000 lock will be active until it is cleared, at
which point the 2nd lowest lock (9000) will become active. When it is
cleared, Fan will become unlocked and resume its target from temperature
control. If the first locked target happens to be lower than its current
target, the lock will take precedence even though it's lower.

Signed-off-by: Mike Capps <mikepcapps@gmail.com>
Change-Id: Iba73aa06eed25452117eb138768ed300bc45b0d9

show more ...

control: Rework/optimize preloading timer groups

Employ the use of the service name defined on the group instead of
retrieving the service for each group member if its given in the group's
configura

control: Rework/optimize preloading timer groups

Employ the use of the service name defined on the group instead of
retrieving the service for each group member if its given in the group's
configuration. In addition, switch to getting the service, when not
configured on the group, from the service tree cache.

Change-Id: Ice7b19c90c8fc03cb7201ebdb884c23366c1f23e
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

control - Ensure `nameHasOwner` set on all group members

It was found that `nameHasOwner` method calls upon fan control starting
was not setting all group members' service owned states. This was due

control - Ensure `nameHasOwner` set on all group members

It was found that `nameHasOwner` method calls upon fan control starting
was not setting all group members' service owned states. This was due to
skipping group members if they were hosted by the same service, which
actually caused a problem later when the action would be run looking at
the service state for all groups members. With this fix all group
members get an initial service owned state thru `nameHasOwner`.

Change-Id: Icd8e16e0a2235522aa531a629a82aa2af47c5199
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

control: Record configuration load/reload paths

Add `main` recorder entries to the flight recorder when the
configurations are loaded or reloaded thru SIGHUP.

Change-Id: Ib720f6342a8579e2fc0df30e89

control: Record configuration load/reload paths

Add `main` recorder entries to the flight recorder when the
configurations are loaded or reloaded thru SIGHUP.

Change-Id: Ib720f6342a8579e2fc0df30e8975dd140dba28e2
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

control:fanctl - Update `get` output formatting

Fix up fan feedback alignment for fans with more than one rotor.

Change-Id: Icf574647a7ebbebf5c684aadd106e8e40f320b24
Signed-off-by: Matthew Barth <m

control:fanctl - Update `get` output formatting

Fix up fan feedback alignment for fans with more than one rotor.

Change-Id: Icf574647a7ebbebf5c684aadd106e8e40f320b24
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

control:fanctl - Update `status` output formatting

On systems where fan inventory and sensors do not match, the output per
fan on the `status` command was mis-aligned. This inserts "Unknown" for
fan

control:fanctl - Update `status` output formatting

On systems where fan inventory and sensors do not match, the output per
fan on the `status` command was mis-aligned. This inserts "Unknown" for
fan inventory items that do not exist for a fan sensor.

Change-Id: Id73ae90c8a36c375cd88ac3d097721815d8ef2bf
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

control - Remove `nameOwnerChanged` signal flight recorder

Remove due to the possibility of being called more than once if more
than one event uses the same group trigger as it could be confusing th

control - Remove `nameOwnerChanged` signal flight recorder

Remove due to the possibility of being called more than once if more
than one event uses the same group trigger as it could be confusing that
more than one signal was received when it was not. This is due to the
`sd_bus_message_rewind` in Manager::handleSignal().

Change-Id: I6e6739658c67fe745e525b3da9bffd0213119c8c
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

monitor: ibm3223 partial revert, restore service file dependency

monitor depends on inventory before it can start

Signed-off-by: Mike Capps <mikepcapps@gmail.com>
Change-Id: Ib4f2885f04a5d178a66077

monitor: ibm3223 partial revert, restore service file dependency

monitor depends on inventory before it can start

Signed-off-by: Mike Capps <mikepcapps@gmail.com>
Change-Id: Ib4f2885f04a5d178a6607780774662560a3da041

show more ...

Monitor: disable inventory svc dependency in systemd

Startup Monitor without the systemd dependency on inventory.

Signed-off-by: Mike Capps <mikepcapps@gmail.com>
Change-Id: I9700b061d7d6b42ace2985

Monitor: disable inventory svc dependency in systemd

Startup Monitor without the systemd dependency on inventory.

Signed-off-by: Mike Capps <mikepcapps@gmail.com>
Change-Id: I9700b061d7d6b42ace2985936a98df18e790c395

show more ...

Monitor : avoid mapper lookups in Tach Sensor

There is a race condition that can fail in certain situations where
mapper has not completed introspection, causing a lookup failure and
D-Bus exception

Monitor : avoid mapper lookups in Tach Sensor

There is a race condition that can fail in certain situations where
mapper has not completed introspection, causing a lookup failure and
D-Bus exception. This change uses a hard-coded service name, thus
avoiding the lookup and allowing tach sensors to write status directly
to inventory.

Signed-off-by: Mike Capps <mikepcapps@gmail.com>
Change-Id: If6ad105055762c6240b36d904d169094088b7c81

show more ...

control: `nameOwnerChanged` signals update all caches

When a `nameOwnerChanged` signal is received, update all entries within
the service tree cache for the given service's owner state change. Also,

control: `nameOwnerChanged` signals update all caches

When a `nameOwnerChanged` signal is received, update all entries within
the service tree cache for the given service's owner state change. Also,
use the service tree cache to cross reference removal of the associated
interfaces from objects within the objects cache.

Change-Id: Idab52a7533d626f1f7ef03397f904a74cb6457a3
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

monitor: ibm3223 partial revert, restore service file dependency

Signed-off-by: Mike Capps <mikepcapps@gmail.com>
Change-Id: I834b99e0033dd75e0189f2b9ef4884646e4a764b

Fix fmt violation

The newest version of fmt enables more safety flags to ensure that no
implicit casts are done by default. The line changed was trying to
implicitly cast an enum. This commit make

Fix fmt violation

The newest version of fmt enables more safety flags to ensure that no
implicit casts are done by default. The line changed was trying to
implicitly cast an enum. This commit makes this explicit with a
static_cast.

Tested: Code compiles against the latest subtree update.

Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: I1eda57cf1bd2cbf3551f6c2d59660119ef713dbe

show more ...

Control: fanctl should validate dumpfile output

fanctl is emitting "done" messages prematurely before all file contents
have been written. This change erases any existing json outputs and
proactivel

Control: fanctl should validate dumpfile output

fanctl is emitting "done" messages prematurely before all file contents
have been written. This change erases any existing json outputs and
proactively validates the output before reporting success.

Signed-off-by: Mike Capps <mikepcapps@gmail.com>
Change-Id: I364024675a468bc0dfb1035e3158e85c206b79d2

show more ...

Monitor: disable inventory svc dependency in systemd

Now that Monitor can startup properly without depending on inventory,
this commit removes the systemd dependency, allowing the system to
startup

Monitor: disable inventory svc dependency in systemd

Now that Monitor can startup properly without depending on inventory,
this commit removes the systemd dependency, allowing the system to
startup more quickly.

Signed-off-by: Mike Capps <mikepcapps@gmail.com>
Change-Id: If36aee2265c9909a18ce27c8fbf56d04095dcc14

show more ...

Monitor : handle inventory service offline

Using nameHasOwner and nameOwnerChanged D-Bus signals, a callback is
activated when inventory is started.

There are two primary modes for operation: Compa

Monitor : handle inventory service offline

Using nameHasOwner and nameOwnerChanged D-Bus signals, a callback is
activated when inventory is started.

There are two primary modes for operation: Compatible Interfaces, the
inventory-detection callback will fail, however start() will be called a
second time after EntityManager starts and forces a reload of the proper
config for the machine type. Separately, if no EntityManager exists,
then the callback for Inventory-detection will succeed and use the
default configuration file.

To test: stop fan monitor and inventory services. start monitor, wait
10s, start Inventory, after about 15s you should see the online
detection.

Signed-off-by: Mike Capps <mikepcapps@gmail.com>
Change-Id: I289493a0aabb849abee8ce8de047513e94ee2219

show more ...

control:p10bmc:ibm,rainier-4u/1s4u - Add power mode group

Change-Id: I35cb6aa5506157c7c10ff6cf882a93b4fb8ef536
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

control:p10bmc:ibm,rainier-4u/1s4u - pcie slots & cards groups

Add the pcie slots and cards groups for upcoming support of determining
the fan floor.

Change-Id: I1bb49b219aefc68c274d35699a6cbfe6401

control:p10bmc:ibm,rainier-4u/1s4u - pcie slots & cards groups

Add the pcie slots and cards groups for upcoming support of determining
the fan floor.

Change-Id: I1bb49b219aefc68c274d35699a6cbfe6401cee8f
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

control:p10bmc: Provide OCC service name to OCC object group

Providing the OCC service name for the OCC object group allows the
"service(s) missing" event to set the owner state to false during the

control:p10bmc: Provide OCC service name to OCC object group

Providing the OCC service name for the OCC object group allows the
"service(s) missing" event to set the owner state to false during the
`init` trigger and successfully subscribe to the nameOwnerChanged
signal. This is necessary since the OCC service has changed to starting
after fan control has already loaded its configuration.

Change-Id: I5b7f51674a94a68bf9979aa8548e0a4a32edfc49
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

control: Support group service names in name owner triggers

If a group provides a service name, which is required to be the service
name for all group members and their interfaces, use that service

control: Support group service names in name owner triggers

If a group provides a service name, which is required to be the service
name for all group members and their interfaces, use that service name
when subscribing to nameOwnerChanged signals or calling the nameHasOwner
method. This can be used so that the service name does not have to be
looked up for each group member(and interface) or where the service for
a group(and interface) may not be on dbus when subscribing.

Change-Id: Ic52aef519eef61103478742c7a32e1f268809d38
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

control:p10bmc: Standardize PCIe cable card group name

Use the same group name of "pcie cable card temps" for the PCIe cable
card temperature sensors across all p10bmc systems. This will help
minimi

control:p10bmc: Standardize PCIe cable card group name

Use the same group name of "pcie cable card temps" for the PCIe cable
card temperature sensors across all p10bmc systems. This will help
minimize any copy/paste errors that could happen when adding events that
may use this group across all the different system event.json files.

Change-Id: If93b52ccb91b57a87b0765d3a6159f2c05d1721d
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

control:p10bmc: Add more critical services to monitor

Include the services that host the nvme, planar, flett, bear lake,
ambient, and altitude sensors. Note that currently the planar, flett,
pcie ca

control:p10bmc: Add more critical services to monitor

Include the services that host the nvme, planar, flett, bear lake,
ambient, and altitude sensors. Note that currently the planar, flett,
pcie cable card, ambient, and altitude sensors are provided by the same
service and were purposely all added here for completeness. This will
have no affect on the handling of that single service that hosts all of
these sensors.

The flett, pcie cable card, and nvme groups require the service name be
provided since the lookup for that group's members' service name will
fail until power is on.

Change-Id: Ib8baa266ee2d5aefe3c5a3eb4151ba2301189a25
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

control:p10bmc: Raise floor for nonfunctional ambient or altitude

Rainier4U does not utilize the altitude sensor currently.

Include ambient and altitude sensors in raising the floor when they are
m

control:p10bmc: Raise floor for nonfunctional ambient or altitude

Rainier4U does not utilize the altitude sensor currently.

Include ambient and altitude sensors in raising the floor when they are
marked nonfunctional. If either of these do not require the fan floor to
be raised to this target, they can be removed from this event and set to
a different floor if necessary.

Change-Id: Ieddd616b54e392746bdff195ef4d45af6f6fe7b0
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...