p10bmc: Allow generic NVMe drive name (#11)

Not all drives are Samsung PM1735s, and for lab systems we can't learn
the drive model in order to state accurately what has been plugged.
Instead, defer

p10bmc: Allow generic NVMe drive name (#11)

Not all drives are Samsung PM1735s, and for lab systems we can't learn
the drive model in order to state accurately what has been plugged.
Instead, defer to what we do know, which is that it's an NVMe drive.

This is a transition change. It needs to be followed by integration of
an entity-manager change to switch the drive names, then finally by a
change to drop the old drive names from the fan configuration.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: I334cf2b518257ed445f4df9bfbed6968d33f1341

show more ...

meson support: remove code warnings 2

This commit contains code changes necessary to support the increased
warning level from Meson builds. Most changes are for unused variables.
to keep the review

meson support: remove code warnings 2

This commit contains code changes necessary to support the increased
warning level from Meson builds. Most changes are for unused variables.
to keep the review size manageable, this commit contains only control
changes (plus one in sensor-monitor).

Change-Id: Ie20f1d9028add4b605e4cc9fb230940710365706
Signed-off-by: Mike Capps <mikepcapps@gmail.com>

show more ...

meson support: remove code warnings 1

This commit contains code changes necessary to support the increased
warning level from Meson builds. Most changes are for unused variables.

To keep the review

meson support: remove code warnings 1

This commit contains code changes necessary to support the increased
warning level from Meson builds. Most changes are for unused variables.

To keep the review size manageable, this commit contains only monitor
and presence changes (and top-level json_config.hpp).

Signed-off-by: Mike Capps <mikepcapps@gmail.com>
Change-Id: I7280b512c54e8d5aeba3300764a239f3dcbab14d

show more ...

control:rainier-4u: Remove power mode floors

The power mode entries in the mapped_floor action were just place
holders that used the same values as the default_floor field until
better values were n

control:rainier-4u: Remove power mode floors

The power mode entries in the mapped_floor action were just place
holders that used the same values as the default_floor field until
better values were needed. It turns out the floors won't need to be
based on power mode so remove these entries.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I3e25065bf6ccc56c99931ee431ce97abf9e29560

show more ...

presence: Only allow loading once

If entity manager were to get restarted, the JsonConfig::start()
function would be called again which would attempt to load a config on
top of an existing one.

Fix

presence: Only allow loading once

If entity manager were to get restarted, the JsonConfig::start()
function would be called again which would attempt to load a config on
top of an existing one.

Fix that by only allowing the config to load once. If someone wanted
the config to load again, they could either send the HUP signal or just
restart the service.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I1526db17500ffe88408c8bc1f0abba9c4952107b

show more ...

monitor: fix undefined behavior

A recent static analysis check revealed a use-after-free condition in
json_parser.cpp. This fixes the undefined behavior.

Signed-off-by: Mike Capps <mikepcapps@gmail

monitor: fix undefined behavior

A recent static analysis check revealed a use-after-free condition in
json_parser.cpp. This fixes the undefined behavior.

Signed-off-by: Mike Capps <mikepcapps@gmail.com>
Change-Id: I62b82b4982386d14e6ee7225b3ab6f3628e2a416

show more ...

control:p10bmc:rainier-1s4u: 4000 -> 3700 floor

Lower the floor from 4000 to 3700 in the lowest ambient table. This is
for acoustic reasons.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change

control:p10bmc:rainier-1s4u: 4000 -> 3700 floor

Lower the floor from 4000 to 3700 in the lowest ambient table. This is
for acoustic reasons.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I082c7e75a65662f0cf1b328d5da9d0006c2da57e

show more ...

Revert "control:configs:ibm,everest: Change 11300 -> 11000"

This reverts commit cd6c66882613ed248e048a338d775653da881f34.

Turns out the fans need to be allowed to go to 11300 to help with high
alti

Revert "control:configs:ibm,everest: Change 11300 -> 11000"

This reverts commit cd6c66882613ed248e048a338d775653da881f34.

Turns out the fans need to be allowed to go to 11300 to help with high
altitude systems.

Change-Id: I29ed5dc2b9d31de893acd18051e7b28addc17fee

show more ...

control:configs:ibm,everest: Change 11300 -> 11000

Change all occurrences of the 11300 fan ceiling value to 11000.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I0ed283ae0fdf3f1029099

control:configs:ibm,everest: Change 11300 -> 11000

Change all occurrences of the 11300 fan ceiling value to 11000.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I0ed283ae0fdf3f10290990c94b3c6086a2a5e407

show more ...

monitor:configs:ibm,everest: increase fault delay

Change the time it takes for a out of range fan to be set to
nonfunctional to 45s from 30.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-

monitor:configs:ibm,everest: increase fault delay

Change the time it takes for a out of range fan to be set to
nonfunctional to 45s from 30.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I5c4f85e919256e48d2071d51133a39cc74a431f0

show more ...

control:docs: Add a section on debug

Describe how fanctl dump and fanctl query_dump can be used to help with
debug.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: Iac9b50685c03b5f030af

control:docs: Add a section on debug

Describe how fanctl dump and fanctl query_dump can be used to help with
debug.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: Iac9b50685c03b5f030af1f965ca776e1d16f3f81

show more ...

control:docs:events: Document modifiers

Modifiers can be used by certain actions to modify the result in a
configurable manner.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I587034ae

control:docs:events: Document modifiers

Modifiers can be used by certain actions to modify the result in a
configurable manner.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I587034ae3c6be8c5ce6c47aba35d9d1e199f0665

show more ...

control:docs:events: Add two more actions

Describe the call_actions_based_on_timer and get_managed_objects
actions.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: Ie159a9bc14084b9439d8

control:docs:events: Add two more actions

Describe the call_actions_based_on_timer and get_managed_objects
actions.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: Ie159a9bc14084b9439d8f00b54679591f6c0cd81

show more ...

control:docs:events: Add more actions

Describe the pcie_card_floors, set_request_target_base_with_max, and
set_parameter_from_group_max actions.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Cha

control:docs:events: Add more actions

Describe the pcie_card_floors, set_request_target_base_with_max, and
set_parameter_from_group_max actions.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I18f58846da516ac3ea962e5a0e5e3aa168f46d59

show more ...

control:docs:events: Add more actions

Describe the mapped_floor, set_target_on_missing_owner, and
override_fan_target actions.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: Ifb7fb14fb

control:docs:events: Add more actions

Describe the mapped_floor, set_target_on_missing_owner, and
override_fan_target actions.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: Ifb7fb14fbecd2538118282848da29377fe288e2f

show more ...

control:docs:events: Add three more actions

Describe the count_state_floor, count_state_before_target, and
default_floor_on_missing_owner actions.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
C

control:docs:events: Add three more actions

Describe the count_state_floor, count_state_before_target, and
default_floor_on_missing_owner actions.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I77be2a743391b9cbd3033970bca8449da84a395f

show more ...

control:docs:events: Start adding actions

Describe the net_target_increase and net_target_decrease actions.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I7de18b4cad79767079daef3e8a48

control:docs:events: Start adding actions

Describe the net_target_increase and net_target_decrease actions.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I7de18b4cad79767079daef3e8a48e355999a9d4e

show more ...

control:docs:events: Describe triggers

Describe the trigger entries in events.json.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I7158b72f0ebb00714fb8bf28bcda46ff2ffd2e80

control:docs:events: Describe groups

Describe the groups entries in events.json.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I6ab62748f47a3b73106639c404841cecf892a957

control:docs: Create events.md

This describes the events.json file. Only an introduction and example
is added with this commit. Further details will be added in future
commits.

Signed-off-by: Mat

control:docs: Create events.md

This describes the events.json file. Only an introduction and example
is added with this commit. Further details will be added in future
commits.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: If50579d6b26afb979933d4f085cdb21ab14235b2

show more ...

control:docs: create zones.md

This describes the zones.json file.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: Id559f4989637d23b842d0a2485785128dedb1107

control:docs: Create groups.md

This describes the groups.json file.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I8cba2159dbd56b0e631dc378ccfc38a6cf9b9a6c

control:docs: Create fans.md

This describes the fans.json file.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: Idd206d02d869d5eb35e4ad6b89191bef7452310c

control:docs: Fill in readme sections

Fill in missing sections. Future commits will have the details of the
component JSON files.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I8c021

control:docs: Fill in readme sections

Fill in missing sections. Future commits will have the details of the
component JSON files.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I8c021dd66c4c534b0f782302fe412b0435ac08c3

show more ...

monitor: add journal entries to fan PELs

Adds a new JSON section to the PEL that contains the last 25 systemd
journal entries indicating which system services have
started/stopped/etc.

Signed-off-

monitor: add journal entries to fan PELs

Adds a new JSON section to the PEL that contains the last 25 systemd
journal entries indicating which system services have
started/stopped/etc.

Signed-off-by: Mike Capps <mikepcapps@gmail.com>
Change-Id: I9f8a7ab8bb7c213cde30496327d83e9f3fab7c94

show more ...