sensor-monitor: support skip power checking

The threshold event is binding with power state currently.
Due to some sensors access will not depend on the power state.
Provide a new option to let user

sensor-monitor: support skip power checking

The threshold event is binding with power state currently.
Due to some sensors access will not depend on the power state.
Provide a new option to let user to disable it.

Change-Id: Ib232b889cde70082e3bd630ffbe6939eede474f8
Signed-off-by: Jerry C Chen <jerry.c.chen.wiwynn@gmail.com>

show more ...

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda forma

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda formatting also changed, so we have made changes to the
organization default style format to better handle lambda formatting.

See I5e08687e696dd240402a2780158664b7113def0e for updated style.
See Iea0776aaa7edd483fa395e23de25ebf5a6288f71 for clang-18 enablement.

Change-Id: Ica590f8613f1fb89ab1ca676ac51c1cc7e38d67f
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

sensor-mon: Add Threshold value for Threshold event

Add the threshold value for threshold event to let user knowing the
status of sensor through threshold event log.
Divide the ErrorName into ErrorS

sensor-mon: Add Threshold value for Threshold event

Add the threshold value for threshold event to let user knowing the
status of sensor through threshold event log.
Divide the ErrorName into ErrorStatus and ErrorName which ErrorName is
used for getting threshold property and ErrorStatus represents this
threshold event is cleared or triggered in the event log.

Change-Id: I1979544d89cd87a307c58909a566c05707a3c1f2
Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@wiwynn.com>

show more ...

clang-format: copy latest and re-format

clang-format-17 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-17 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: I3e9e6350864ac267819a4b8d670bef7d3746976e
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

use std::format instead of fmt::format

The std::format is sufficient for the uses in this repository except
for in one file (override_fan_target.cpp, since P2286 isn't supported
by GCC yet). Switch

use std::format instead of fmt::format

The std::format is sufficient for the uses in this repository except
for in one file (override_fan_target.cpp, since P2286 isn't supported
by GCC yet). Switch to std::format whenever possible.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ib2576fb530a4d7ce238e1b0bd95b40b476ec2107

show more ...

build: add cereal dependencies

Numerous places are missing dependencies for Cereal, which makes the
repository impossible to build with meson subprojects. Add them and
the appropriate wrap file.

S

build: add cereal dependencies

Numerous places are missing dependencies for Cereal, which makes the
repository impossible to build with meson subprojects. Add them and
the appropriate wrap file.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: If20779983b9b062d7050dc323ccbae678ce58220

show more ...

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: I152f141a5e8343b92b5ce81d3ca16eec77b5606b
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

treewide: remove dependencies on mapper.target

The mapper is dbus activated now, so these explicit dependency
declarations are unnecessary and redundant.

Change-Id: I7edbd283e021bdfb13b13daae7e792e

treewide: remove dependencies on mapper.target

The mapper is dbus activated now, so these explicit dependency
declarations are unnecessary and redundant.

Change-Id: I7edbd283e021bdfb13b13daae7e792ec65a4f26a
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

sensor-mon: Check service on D-Bus at power on

If sensor-monitor has detected a threshold alarm when power is off, it
would log an error for that when the power turns on.

Add a check that the alarm

sensor-mon: Check service on D-Bus at power on

If sensor-monitor has detected a threshold alarm when power is off, it
would log an error for that when the power turns on.

Add a check that the alarm interface is still on D-Bus before logging
the error, in case the sensor-daemon stopped running.

Alternatively, the code could listen for a NameOwnerChanged signal to
see if the daemon stopped, but then it would have to keep a map of
sensor names to service names and always keep it up to date. The chosen
method seems more straightforward and less error prone.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: Idd6201e5b974a6e0d8f9960b39176374a2a01af8

show more ...

sensor-mon: Watch for InterfacesAdded

Start handling the InterfacesAdded signal for the threshold interfaces.
This is so that if a sensor has a threshold alarm set, but then restarts
and then doesn'

sensor-mon: Watch for InterfacesAdded

Start handling the InterfacesAdded signal for the threshold interfaces.
This is so that if a sensor has a threshold alarm set, but then restarts
and then doesn't have it set, sensor-monitor will get the update to the
new good value.

Previously, sensor-monitor would still log a threshold alarm on every
power on after a sensor daemon restarted and then showed no alarm.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I691c8949165bc29ac2eab4190e5dc9a9283bd2e6

show more ...

meson support: remove autoconf

This commit removes the deprecated autoconf makefiles, artifacts, and
service files which have autoconf-style naming (*.in).

Signed-off-by: Mike Capps <mikepcapps@gma

meson support: remove autoconf

This commit removes the deprecated autoconf makefiles, artifacts, and
service files which have autoconf-style naming (*.in).

Signed-off-by: Mike Capps <mikepcapps@gmail.com>
Change-Id: I9c0e6162798c235f899aeb5cd9ecea1a0eee29a5

show more ...

meson support: create meson.build files

This commit contains the meson.build files necessary to build the
project and unit tests. The normal procedure is to run the command
'meson build' followed by

meson support: create meson.build files

This commit contains the meson.build files necessary to build the
project and unit tests. The normal procedure is to run the command
'meson build' followed by ninja -C build. Additionally, service files
are copied to remove autoconf-style naming convention (they cannot be
removed before autoconf files are removed).

Signed-off-by: Mike Capps <mikepcapps@gmail.com>
Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I6cf8f5c1c923a198ad2fb4638843645479fd0498

show more ...

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are for:
* bus_t
* exception_t
* manager_t
* match_t
* message_t
* object_t
* slot_t

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I9029cc722e7712633c15436bd3868d8c3209f567

show more ...

sensor-monitor: fix logging statement

Previous implementation used Logger class which caused build failures.
This fix uses only minimal logging necessary.

Signed-off-by: Mike Capps <mikepcapps@gmai

sensor-monitor: fix logging statement

Previous implementation used Logger class which caused build failures.
This fix uses only minimal logging necessary.

Signed-off-by: Mike Capps <mikepcapps@gmail.com>
Change-Id: Icfa605e6cf62c559e5baeac0e0a3e75edf2ef712

show more ...

monitor,sensor-monitor: catch exceptions when creating BMC dumps

catch and log exceptions thrown when creating BMC dumps

Signed-off-by: Mike Capps <mikepcapps@gmail.com>
Change-Id: I986ca3e51302016

monitor,sensor-monitor: catch exceptions when creating BMC dumps

catch and log exceptions thrown when creating BMC dumps

Signed-off-by: Mike Capps <mikepcapps@gmail.com>
Change-Id: I986ca3e51302016886ca8ae571054a5b4260a093

show more ...

meson support: remove code warnings 2

This commit contains code changes necessary to support the increased
warning level from Meson builds. Most changes are for unused variables.
to keep the review

meson support: remove code warnings 2

This commit contains code changes necessary to support the increased
warning level from Meson builds. Most changes are for unused variables.
to keep the review size manageable, this commit contains only control
changes (plus one in sensor-monitor).

Change-Id: Ie20f1d9028add4b605e4cc9fb230940710365706
Signed-off-by: Mike Capps <mikepcapps@gmail.com>

show more ...

meson support: remove code warnings 1

This commit contains code changes necessary to support the increased
warning level from Meson builds. Most changes are for unused variables.

To keep the review

meson support: remove code warnings 1

This commit contains code changes necessary to support the increased
warning level from Meson builds. Most changes are for unused variables.

To keep the review size manageable, this commit contains only monitor
and presence changes (and top-level json_config.hpp).

Signed-off-by: Mike Capps <mikepcapps@gmail.com>
Change-Id: I7280b512c54e8d5aeba3300764a239f3dcbab14d

show more ...

sensor-monitor: Missing includes

The sensor-monitor app doesn't compile by default so some missing
includes were missed. Add them.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I2d71

sensor-monitor: Missing includes

The sensor-monitor app doesn't compile by default so some missing
includes were missed. Add them.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I2d7160df6b3168d1e567b5fe16ffb29627e3c928

show more ...

Fix loading json file causing coredump

If the json file is damaged, when the process is running and
deserializing, a coredump will occur and a ereal::RapidJSONException
will be thrown.

Signed-off-b

Fix loading json file causing coredump

If the json file is damaged, when the process is running and
deserializing, a coredump will occur and a ereal::RapidJSONException
will be thrown.

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I601865e796d50241262edf0fdb09935e4e1b93e2

show more ...

monitor: Capture BMC dumps on fan/ambient shutdowns

When fan-monitor or sensor-monitor generates an EPOW, this change
creates a BMC dump after the system is powered off and all error logs
are create

monitor: Capture BMC dumps on fan/ambient shutdowns

When fan-monitor or sensor-monitor generates an EPOW, this change
creates a BMC dump after the system is powered off and all error logs
are created.

Change-Id: Iacdd2d2b388e79988e2536d52497f0e697e1d444
Signed-off-by: Mike Capps <mikepcapps@gmail.com>

show more ...

sensor-mon: Add missing arg in fmt::format call

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I6b1a08033b45724e04dfd620ffe4a2a5b51b6312

monitor: remove POWER_THERMAL_CRITICAL_FAULT PEL message

This message has been deprecated due to the removal of the PowerFault
bit.

Signed-off-by: Mike Capps <mikepcapps@gmail.com>
Change-Id: I730d

monitor: remove POWER_THERMAL_CRITICAL_FAULT PEL message

This message has been deprecated due to the removal of the PowerFault
bit.

Signed-off-by: Mike Capps <mikepcapps@gmail.com>
Change-Id: I730dca008d15f5b985a3c2006e164edba53330c6

show more ...

Add power_state implementation

Added power_state implementation for multi host platform
specific shutdown interfaces like hard shutdown or soft
shutdown interfaces.

Getting the current host state o

Add power_state implementation

Added power_state implementation for multi host platform
specific shutdown interfaces like hard shutdown or soft
shutdown interfaces.

Getting the current host state of all the hosts and set
power_state values based on the hosts current host state.

TESTED : Verified the Shutdown alarms trigged and platform
specific actions done in Facebook YosemiteV2 platform.

Signed-off-by: Kumar Thangavel <thangavel.k@hcl.com>
Change-Id: I5e38bb9f28b7840c9de10082905b31deb8ffc4ff

show more ...

sensor-monitor: Correct shutdown propertiesChanged matches

The wrong shutdown type was associated to the defined propertiesChanged
matches. It appears this had no affect on receiving these signals a

sensor-monitor: Correct shutdown propertiesChanged matches

The wrong shutdown type was associated to the defined propertiesChanged
matches. It appears this had no affect on receiving these signals as
long as both hard & soft threshold interfaces were implemented on a
system since after receiving the signal, the data in the signal is used
to determine which threshold changed.

Change-Id: I64b44ca474fe2a5049774b0018787c6016c35691
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

sensor-monitor: Fix missing function prototype

Add the missing ThresholdAlarmLogger::interfacesRemoved function
prototype. This passed CI because the --enable-sensor-monitor flag
must not be turned

sensor-monitor: Fix missing function prototype

Add the missing ThresholdAlarmLogger::interfacesRemoved function
prototype. This passed CI because the --enable-sensor-monitor flag
must not be turned on.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I5ad5617bd56ae6649d6adde31faa02f9326d0483

show more ...