History log of /openbmc/phosphor-fan-presence/presence/tach.hpp (Results 1 – 5 of 5)
Revision Date Author Comments
# cb356d48 22-Jul-2022 Patrick Williams <patrick@stwcx.xyz>

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are for:
* bus_t
* exception_t
* manager_t
* match_t
* message_t
* object_t
* slot_t

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I9029cc722e7712633c15436bd3868d8c3209f567

show more ...


# c65d91d6 21-Apr-2021 Matt Spinler <spinler@us.ibm.com>

presence: Sensor conflict checking for AnyOf

There can be more than one way to detect the presence of a fan, such as
by a GPIO and by a nonzero tach reading. The AnyOf redundancy policy

presence: Sensor conflict checking for AnyOf

There can be more than one way to detect the presence of a fan, such as
by a GPIO and by a nonzero tach reading. The AnyOf redundancy policy
only requires one of these to indicate present when determining the
overall fan presence state.

This commit adds the functionality to check for the case when one of the
method reports not present while another reports present. In this case,
the one reporting not present will be considered the wrong one, and
depending on the detection type either an information event log or just
a journal trace will be created.

Only one log per method per power cycle will occur. Since one of the
methods probably looks for nonzero tach readings, there is a 5 second
delay after a power on is detected before a conflict check is done.

If the GPIO method is where the problem is detected, an event log is
created. If it's instead the tach sensor method, then a trace will just
be put in the journal because there is already code watching for and
creating event logs for stopped tachs - the fan monitor code.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I72a764ecff4076d6dc40335b92d177b6b3cfa2d9

show more ...


# ad2cd247 13-Aug-2020 Matthew Barth <msbarth@us.ibm.com>

presence: Tach input to double

It was found that after the Value property on the Sensor.Value interface
was changed to be of double type, the tach input failed to get converted
corre

presence: Tach input to double

It was found that after the Value property on the Sensor.Value interface
was changed to be of double type, the tach input failed to get converted
correctly from double to int64 type when the property changed. Need to
set the tach input to be of double type explicitly.

Tested:
Tach input values correctly read from dbus signal

Change-Id: Ia12697e12b4003c62868f1fb97576df03c46c53f
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...


# 2d2caa34 26-May-2020 Matthew Barth <msbarth@us.ibm.com>

presence: Clang format updates

Used `format-code.sh` build script to make changes to conform to clang
format.

Tested: Compiled

Change-Id: I2fc795938e85a752ee56b54212d38

presence: Clang format updates

Used `format-code.sh` build script to make changes to conform to clang
format.

Tested: Compiled

Change-Id: I2fc795938e85a752ee56b54212d389c2ff296828
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...


# dd62e36e 14-Jun-2017 Brad Bishop <bradleyb@fuzziesquirrel.com>

presence: Add new tach sensor implementation

Add a new fan speed (tach) presence implementation for the new
PresenceSensor interface.

This fan tach sensor behaves mostly like th

presence: Add new tach sensor implementation

Add a new fan speed (tach) presence implementation for the new
PresenceSensor interface.

This fan tach sensor behaves mostly like the existing one, with
the addition of support for multiple tach sensors for the
single PresenceSensor instance, and implementation of the
PresenceSensor start and stop interfaces.

Change-Id: I535a3e2c78ef0f06f10b6f4cda9a7e2d0e9c11db
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...