clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda forma

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda formatting also changed, so we have made changes to the
organization default style format to better handle lambda formatting.

See I5e08687e696dd240402a2780158664b7113def0e for updated style.
See Iea0776aaa7edd483fa395e23de25ebf5a6288f71 for clang-18 enablement.

Change-Id: Ica590f8613f1fb89ab1ca676ac51c1cc7e38d67f
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

use std::format instead of fmt::format

The std::format is sufficient for the uses in this repository except
for in one file (override_fan_target.cpp, since P2286 isn't supported
by GCC yet). Switch

use std::format instead of fmt::format

The std::format is sufficient for the uses in this repository except
for in one file (override_fan_target.cpp, since P2286 isn't supported
by GCC yet). Switch to std::format whenever possible.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ib2576fb530a4d7ce238e1b0bd95b40b476ec2107

show more ...

cooling-type: Replace Argument class with CLI11

Phosphor-fan already depends on cli11, delete Argument class and use
cli11 instead.

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I327a5

cooling-type: Replace Argument class with CLI11

Phosphor-fan already depends on cli11, delete Argument class and use
cli11 instead.

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I327a522ecf232c00661088f2c527e626c24610bc

show more ...

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: I152f141a5e8343b92b5ce81d3ca16eec77b5606b
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

meson support: remove autoconf

This commit removes the deprecated autoconf makefiles, artifacts, and
service files which have autoconf-style naming (*.in).

Signed-off-by: Mike Capps <mikepcapps@gma

meson support: remove autoconf

This commit removes the deprecated autoconf makefiles, artifacts, and
service files which have autoconf-style naming (*.in).

Signed-off-by: Mike Capps <mikepcapps@gmail.com>
Change-Id: I9c0e6162798c235f899aeb5cd9ecea1a0eee29a5

show more ...

meson support: create meson.build files

This commit contains the meson.build files necessary to build the
project and unit tests. The normal procedure is to run the command
'meson build' followed by

meson support: create meson.build files

This commit contains the meson.build files necessary to build the
project and unit tests. The normal procedure is to run the command
'meson build' followed by ninja -C build. Additionally, service files
are copied to remove autoconf-style naming convention (they cannot be
removed before autoconf files are removed).

Signed-off-by: Mike Capps <mikepcapps@gmail.com>
Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I6cf8f5c1c923a198ad2fb4638843645479fd0498

show more ...

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are for:
* bus_t
* exception_t
* manager_t
* match_t
* message_t
* object_t
* slot_t

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I9029cc722e7712633c15436bd3868d8c3209f567

show more ...

catch exceptions as const

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Id1b5054d3147c39d98309bc11ed7016d6909e2a6

Enhance fan tracing support - add device access info

Move file names for file errors to the journal message. Enhance
usablility.

Logging messages for file errors contain the file names and other
in

Enhance fan tracing support - add device access info

Move file names for file errors to the journal message. Enhance
usablility.

Logging messages for file errors contain the file names and other
information inside structured entries rather than directly in the log
message. This makes viewing errors more difficult than need be. Before
this change, the journal report needed to be run with '-o verbose' to
see the file names.

Tested:
- For cooling-type/cooling_type.cpp
Approx line 39:
A dry-dock test of this message was performed by commenting out the
return for the successful case just above and adding a successful
return just below the journal message.
Then the next test can output this log message:
Failed to get libevdev from file descriptor 4, return code 0

Approx line 71:
Do this to get error below:
"phosphor-cooling-type --air
--dev=/dev/input/by-path/platform-gpio-keys-polled-event
--path=/system/chassis/motherboard/ --event=21"
Message:
"Device does not support event type keycode 21"

- For cooling-type/main.cpp
Approx line 73:
Do this to provoke error below:
"phosphor-cooling-type --air
--dev=/dev/input/by-path/platform-gpio-keys-polled-event
--path=/system/chassis/motherboard/ --event=6"
Message:
"Uncaught DBus method failure exception Busname:
xyz.openbmc_project.Inventory.Manager Path:
/xyz/openbmc_project/inventory Interface
xyz.openbmc_project.Inventory.Manager Method: Notify"

- For presence/fallback.cpp
Approx line 56:
Run fan presence application using a 'fallback' rpolicy
for a fan and set that fan's gpio presence line to false within
simulation.

Journal Message:
Using backup presence sensor for fan /system/chassis/motherboard/fan0

For presence/fallback.cpp
Approx line 82:
Set a fan's gpio presence line to false within simulation and then run
the fan presence application using a 'fallback' rpolicy for that fan.

Journal Message:
Using backup presence sensor for fan /system/chassis/motherboard/fan0

- For presence/tach.cpp
Approx line 76:
Remove a fan sensor from the fan controller hwmon config that is
configured within the fan presence application. Then unbind and
rebind the fan controller device driver and start the fan presence
application.

Journal Message:
Unable to read fan tach sensor /xyz/openbmc_project/sensors/fan_tach/fan3_0

- For utility.hpp:
Approx line 65:
Do this to get error below:
"phosphor-cooling-type --air
--dev=/dev/input/by-path/platform-gpio-keys-polled-
--path=/system/chassis/motherboard/ --event=21"
Message:
"Failed to open file device path
/dev/input/by-path/platform-gpio-keys-polled-"

Signed-off-by: Jay Meyer <jaymeyer@us.ibm.com>
Change-Id: I592481d92b18b85e5ea5b7040389467530b581e1

show more ...

Fix some gcc warnings and style suggestions

Building against gcc-10 produced warnings and style suggestions.
Fixed all the warnings, but only select style suggestions due to
readability and others a

Fix some gcc warnings and style suggestions

Building against gcc-10 produced warnings and style suggestions.
Fixed all the warnings, but only select style suggestions due to
readability and others appeared to be compiler confusion.

Tested: Compiled
No functional impacts appear to have been made with these changes

Change-Id: I1adcce355b831ae8b178bfba9b89cc18fe4f3cf7
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

cooling-type: Clang format updates

Used `format-code.sh` build script to make changes to conform to clang
format.

Tested: Compiled

Change-Id: I2294141845790cbb79e599741802bfede574a0b9
Signed-off-b

cooling-type: Clang format updates

Used `format-code.sh` build script to make changes to conform to clang
format.

Tested: Compiled

Change-Id: I2294141845790cbb79e599741802bfede574a0b9
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

sdbusplus: replace message::variant with std::variant

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I7b2bc0a8b34e4d276c0e8ea2243459aab4e1c177

cooling_type: remove unnecssary static_cast

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I5d50d5bc503966910de3c33ed76edc11e3b6e248

build: install into bin instead of sbin

Installs into bin instead of sbin per guidelines.

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I452171c4661228d903fe0570342be630cb0dbbd9

libfan: Remove

Since the removal of the custom timer implementation our libfan has
nothing but a single header file. Since we have no object code left we
do not need a library to contain this code s

libfan: Remove

Since the removal of the custom timer implementation our libfan has
nothing but a single header file. Since we have no object code left we
do not need a library to contain this code since the header is directly
included where needed.

Tested:
Built and run through unit tests.

Change-Id: I139b83ab979ead88cfd4c180ba8847a29c6407e2
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

Fix exit status codes

Using an exit status of -1 everywhere leads to the status being
converted to 255 when output to a calling application. While this does
signify an error it has a reserved meanin

Fix exit status codes

Using an exit status of -1 everywhere leads to the status being
converted to 255 when output to a calling application. While this does
signify an error it has a reserved meaning for exit status out of range.
Lets use a valid general exit status of 1 instead.

Change-Id: I326701c78985e34c430c258fe31d9e910da10405
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

Add -flto to CXXFLAGS

Per openbmc/openbmc#3364, adding -flto to CXX flags
in order to reduce overall library and binary sizes.

Ref: https://gcc.gnu.org/wiki/LinkTimeOptimization

Change-Id: I3ee31a

Add -flto to CXXFLAGS

Per openbmc/openbmc#3364, adding -flto to CXX flags
in order to reduce overall library and binary sizes.

Ref: https://gcc.gnu.org/wiki/LinkTimeOptimization

Change-Id: I3ee31a15fc0ded4308aa9d00a11b41bc62eb9799
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>

show more ...

cooling-type: Use lookupAndCallMethod

Have phosphor-cooling-type fail with a DBusMethodError exception when a
failure occurs on updating inventory.

Resolves: openbmc/openbmc#2628

Tested:
Cooli

cooling-type: Use lookupAndCallMethod

Have phosphor-cooling-type fail with a DBusMethodError exception when a
failure occurs on updating inventory.

Resolves: openbmc/openbmc#2628

Tested:
Cooling type properties still set correctly

Change-Id: Ia7e3379fc7d75c70e9c71d4f940f9da84b9f5774
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

Spelling fixes

Spelling errors found using github.com/lucasdemarchi/codespell
A tool to fix common misspellings.
This tool is licensed under GNU General Public License, version 2.

Change-Id: Iefb2a

Spelling fixes

Spelling errors found using github.com/lucasdemarchi/codespell
A tool to fix common misspellings.
This tool is licensed under GNU General Public License, version 2.

Change-Id: Iefb2ad70d313a4800cd413c7c2e5e2154bec49fb
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Switch which GPIO value sets air or water cooled

During the coding and testing of this application there was some
miscommunication on the jumper position for a Witherspoon system. The
system was jum

Switch which GPIO value sets air or water cooled

During the coding and testing of this application there was some
miscommunication on the jumper position for a Witherspoon system. The
system was jumpered for Air when intended to be jumpered for the Water
cooled position. Further examination of the documentation and the jumper
settings on systems found that the logic was reversed. This change
should correct the problem and report the correct cooling properties.

Resolves openbmc/openbmc#2041

Change-Id: I7e25bd72342fde40df1fec8f6a1a444eac401f09
Signed-off-by: Brandon Wyman <bjwyman@gmail.com>

show more ...

phosphor-fan-presence elog error exception.

Implemented elog exception for phosphor fan presence,
replacing runtime_errors.

Change-Id: I70465060838b2cbaeadccf84ed5924e222ac59e3
Signed-off-by: Dines

phosphor-fan-presence elog error exception.

Implemented elog exception for phosphor fan presence,
replacing runtime_errors.

Change-Id: I70465060838b2cbaeadccf84ed5924e222ac59e3
Signed-off-by: Dinesh Chinari <chinari@us.ibm.com>

show more ...

Have cooling-type use the common argument.hpp

The cooling-type application should use the common
header file for the ArgumentParser class now that one
is available.

Also fixed where a static Argume

Have cooling-type use the common argument.hpp

The cooling-type application should use the common
header file for the ArgumentParser class now that one
is available.

Also fixed where a static ArgumentParser constant was
being initialized.

Change-Id: I1fb0dfe3bd0c6e0200ad7c718ef2a3def5476f3f
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

show more ...

Implement changes to read GPIO device for cooling type.

Change-Id: If40a54510fb05d67ee0bfdf24026c1d7470897ca
Signed-off-by: Brandon Wyman <bjwyman@gmail.com>

Fix bitbake build break due to <utility.hpp>

Should have used #include "utility.hpp" to include that header file in
the phosphor-fan-presence repo.

Change-Id: I01ac9a0cd4b3942f4b052ae3f52abd828cf8d

Fix bitbake build break due to <utility.hpp>

Should have used #include "utility.hpp" to include that header file in
the phosphor-fan-presence repo.

Change-Id: I01ac9a0cd4b3942f4b052ae3f52abd828cf8dc20
Signed-off-by: Brandon Wyman <bjwyman@gmail.com>

show more ...

Implement updating the inventory properties

Implement code needed to update the chassis AirCooled and
WaterCooled properties.

Change-Id: I9a67d1129e99f841200241e2daae08fb6119d9d3
Signed-off-by: Bra

Implement updating the inventory properties

Implement code needed to update the chassis AirCooled and
WaterCooled properties.

Change-Id: I9a67d1129e99f841200241e2daae08fb6119d9d3
Signed-off-by: Brandon Wyman <bjwyman@gmail.com>

show more ...