control: Support target_path option in configuration file

The target path containing the interface
xyz.openbmc_project.control.FanPwm or
xyz.openbmc_project.control.FanSpeed can be different between

control: Support target_path option in configuration file

The target path containing the interface
xyz.openbmc_project.control.FanPwm or
xyz.openbmc_project.control.FanSpeed can be different between
phosphor-hwmon and dbus-sensor.

In phosphor-hwmon, it is "/xyz/openbmc_project/sensors/fan_tach/".
In dbus-sensor, it is "/xyz/openbmc_project/control/fanpwm/"

This commit supports making this path configurable via "target_path".
By default, it is "/xyz/openbmc_project/sensors/fan_tach/".

Signed-off-by: Chau Ly <chaul@amperecomputing.com>
Change-Id: Id799986ff69455b7c7054070ed2ab3b2e2500a6c

show more ...

Conditionally add/remove events action

A new action to add or remove events based on the state of all members
of a group. When all members of a group match the state given, the
events will be enable

Conditionally add/remove events action

A new action to add or remove events based on the state of all members
of a group. When all members of a group match the state given, the
events will be enabled. At any time a member's property state no longer
matches, all the events will be removed.

For example, to enable an event that changes the fan floor table using
different values based on the selected state of the current thermal
mode.

- name: set_speed_boundaries_based_on_ambient
groups:
- name: zone0_control_mode
interface: xyz.openbmc_project.Control.ThermalMode
property:
name: Current
type: std::string
triggers:
- name: init
method: getProperties
handler: setProperty
- name: signal
signal: propertiesChanged
handler: setProperty
actions:
- name: use_events_on_state
property:
value: DEFAULT
type: std::string
events:
- name: default_fan_speed_boundaries
groups:
- name: zone0_ambient
interface: xyz.openbmc_project.Sensor.Value
property:
name: Value
type: int64_t
triggers:
- name: init
method: getProperties
handler: setProperty
- name: signal
signal: propertiesChanged
handler: setProperty
actions:
- name: set_floor_from_average_sensor_value
map:
value:
- 27000: 3500
- 32000: 4600
- 37000: 5200
- 40000: 5800
type: std::map<int64_t, uint64_t>
- name: use_events_on_state
property:
value: CUSTOM
type: std::string
events:
- name: custom_fan_speed_boundaries
groups:
- name: zone0_ambient
interface: xyz.openbmc_project.Sensor.Value
property:
name: Value
type: int64_t
triggers:
- name: init
method: getProperties
handler: setProperty
- name: signal
signal: propertiesChanged
handler: setProperty
actions:
- name: set_floor_from_average_sensor_value
map:
value:
- 27000: 4600
- 32000: 5000
- 37000: 5400
- 40000: 5800
type: std::map<int64_t, uint64_t>

Tested:
Different fan floor events loaded based on thermal mode state

Change-Id: I85a4718e928996d2063e51eb31bfbb45e0e40c0b
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

Update default floor action

Add action to be able to update the default fan floor thru a configured
event.

Tested:
Default floor is updated based on state of group property value

Change-Id: I8

Update default floor action

Add action to be able to update the default fan floor thru a configured
event.

Tested:
Default floor is updated based on state of group property value

Change-Id: I83a4ae313636abbe1e5c8b6ddfc2d5f9d281f844
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

doc only: Update events example yaml

Update the events example yaml to correctly reflect the redesign that
was done under openbmc/openbmc#2911 for enhancing performance and
flexibility of the config

doc only: Update events example yaml

Update the events example yaml to correctly reflect the redesign that
was done under openbmc/openbmc#2911 for enhancing performance and
flexibility of the configuration for fan control.

Change-Id: Ie5270afb601c7b63f1b8c12e7f63372451723817
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

Add target interface for fan control

Current fan control assumes the use of the FanSpeed interface for fan
targets.
For fans controlled by pwm, FanPwm interface is added.

This commit adds "target_i

Add target interface for fan control

Current fan control assumes the use of the FanSpeed interface for fan
targets.
For fans controlled by pwm, FanPwm interface is added.

This commit adds "target_interface" config parameter, so that user can
specify the interface for the fan targets.

E.g.

- inventory: /system/chassis/motherboard/fan0
cooling_zone: 0
cooling_profile: air
sensors:
- fan0
target_interface: xyz.openbmc_project.Control.FanPwm

The config is optional and defaults to FanSpeed, so the current code
will not be affected.

Tested: Use this config on Romulus, ensures the fan control sets
target on FanPwm interface and works fine.

Change-Id: I73adccaa770d657b5d7aaeb307917f89588524de
Signed-off-by: Lei YU <mine260309@gmail.com>

show more ...

Generate selected match strings and signals

The available matches and their associated signals are now listed
within the events yaml and can be added to the list of matches to
register for per event

Generate selected match strings and signals

The available matches and their associated signals are now listed
within the events yaml and can be added to the list of matches to
register for per event.

Change-Id: I65f657038afe7c68a421adb4820ea09e275be06d
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

DOC ONLY: Add preconditions section description

Change-Id: I260319dbfc4cb87bfed8fd724ffc4978f34e7325
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

DOC ONLY: Example events yaml format update

Made updates to the example events.yaml to reflect the new format and
use.

Change-Id: I13b323487565f0c1c29eb97d9ddcf8da3295b21c
Signed-off-by: Matthew Ba

DOC ONLY: Example events yaml format update

Made updates to the example events.yaml to reflect the new format and
use.

Change-Id: I13b323487565f0c1c29eb97d9ddcf8da3295b21c
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

Update parser to support optional preconditions

Set speed events are now allowed to have preconditions defined within
the event where those preconditions must be met before the set speed
event is en

Update parser to support optional preconditions

Set speed events are now allowed to have preconditions defined within
the event where those preconditions must be met before the set speed
event is enabled and active. The supported precondition added is against
a list of groups and their properties matching a given value.

The parser generates a precondition with the same layout as a set speed
event where the event is nested as the last parameter to the
precondition function. Having the set speed event as the last input
parameter to precondition functions is required.

Resolves openbmc/openbmc#1835

Change-Id: I7a247e7eb2d6b31ba9a60da1bc321a35edda9b24
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

Fan control: Example yaml updates(doc only)

Change-Id: I30fdecd3af3dcdc7f954bdb9d535c6bc92edd67a
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

Example zone conditions yaml

An example yaml file for zone conditions to be used to
create the correct fan zones.

Change-Id: I6ca339a3a9f37bc70424cde57f2229a5dcb70cbb
Signed-off-by: Gunnar Mills <g

Example zone conditions yaml

An example yaml file for zone conditions to be used to
create the correct fan zones.

Change-Id: I6ca339a3a9f37bc70424cde57f2229a5dcb70cbb
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Remove TBD on zone conditions in zones.yaml

Change-Id: I8eb215aaf90ef9553a52e8eaa54d3fd1a1a00ca5
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

Example set speed event yaml

An example yaml file to define set speed events based on groups of dbus
object properties and a set of actions that can be performed based on
those property values

Chan

Example set speed event yaml

An example yaml file to define set speed events based on groups of dbus
object properties and a set of actions that can be performed based on
those property values

Change-Id: I2f713920f9ce25859855cfec783df0adb505f31d
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

Change example/zones.yaml to full_speed

initial_speed should be full_speed in example/zones.yaml

Change-Id: I64b4803a26006cf78f6d29859bb8dd43a5cf63b3
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

Add modes to phosphor-fan-control

phosphor-fan-control can behave differently based
on its command line arguments

--init: Set fans to full speed, delay for a
configurable amount of time t

Add modes to phosphor-fan-control

phosphor-fan-control can behave differently based
on its command line arguments

--init: Set fans to full speed, delay for a
configurable amount of time to allow fans to ramp up,
start the fan control ready target, and then exit.

--control: Start the control algorithm. Never exits.
Will be started as part of the fan control ready target.

Change-Id: I453daf8cc05a5c85a19c098e1cca64cac2ad9520
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

show more ...

Fan control: Enable data generation

Start running the python script that generates the
fan zone data structures during the build.

If the paths to the 2 yaml files aren't provided during
configure,

Fan control: Enable data generation

Start running the python script that generates the
fan zone data structures during the build.

If the paths to the 2 yaml files aren't provided during
configure, then the yaml in the example directory will
be used instead.

Change-Id: I9f67c1b94b5302c30ac87b0f80746854c42776b2
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

show more ...