clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda forma

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda formatting also changed, so we have made changes to the
organization default style format to better handle lambda formatting.

See I5e08687e696dd240402a2780158664b7113def0e for updated style.
See Iea0776aaa7edd483fa395e23de25ebf5a6288f71 for clang-18 enablement.

Change-Id: I748aeef75e2078199193cd98013dd2fe7f6b5db8
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

host-transport-extensions: Replace deprecated libpldm header path

There are more OEMs than IBM contributing to libpldm, so the OEM headers
were restructured. Replace the deprecated IBM OEM header pa

host-transport-extensions: Replace deprecated libpldm header path

There are more OEMs than IBM contributing to libpldm, so the OEM headers
were restructured. Replace the deprecated IBM OEM header path with the
namespaced path.

The patch was generated by with the coccinelle[1] script from [2]:

```
$ spatch \
--sp-file .../libpldm/origin/evolutions/current/oem-ibm-header-compat.cocci \
--in-place \
$(git ls-files | grep -E '\.[ch](pp)?')
```

[1]: https://coccinelle.gitlabpages.inria.fr/website/
[2]: https://gerrit.openbmc.org/c/openbmc/libpldm/+/72202

Change-Id: I60f2fb09f1f680e21522f2d3f9d9fa8ecc115bfe
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

pldm_oem_cmds: fix compile fail

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I5730c247fe7d83d2dcef29eb3429971f1d847b87

lg2: use direct enum conversion

lg2 now allows logging an enum directly without extra casting. Remove
the `underlying_cast` to simplify the code.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz

lg2: use direct enum conversion

lg2 now allows logging an enum directly without extra casting. Remove
the `underlying_cast` to simplify the code.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I3415be5f7e9be2302c870b5499f96cda3545d0fa

show more ...

build: use allowed over enabled

Meson feature options are typically in a tri-state of enabled, disabled,
or auto. The enabled and disabled functions on an option (from
`get_option`) no longer retur

build: use allowed over enabled

Meson feature options are typically in a tri-state of enabled, disabled,
or auto. The enabled and disabled functions on an option (from
`get_option`) no longer return true for auto features. Instead, the
expectation is to use `allowed()` which is true for both enabled and auto.

Switch all uses of `enabled` to `allowed`.

Change-Id: I8671a81c57e5032c776691d30a941c19b1d53e9d
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

Minor cleanup: Remove unused header file and namespace

This commit performs minor by removing an unnecessary
header file: phosphor-logging/log.hpp
and namespace: using namespace phosphor::logging

T

Minor cleanup: Remove unused header file and namespace

This commit performs minor by removing an unnecessary
header file: phosphor-logging/log.hpp
and namespace: using namespace phosphor::logging

These cleanup changes have no impact on the functionality.
They enhance code cleanliness, reduce potential confusion,
and promote better code maintenance and readability.

Test:
Created a full build to make sure no errors

Change-Id: I68f2d81c538d3f632e6edd24702efc6ae7b07086
Signed-off-by: Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com>

show more ...

Implementing Phosphor-Logging/LG2 logging

This commit introduces changes in the phosphor-debug-collector
repository to implement structured logging using the LG2
framework. The existing log calls in

Implementing Phosphor-Logging/LG2 logging

This commit introduces changes in the phosphor-debug-collector
repository to implement structured logging using the LG2
framework. The existing log calls in the repository,
have been replaced with LG2 logging, facilitates better
log tracking and troubleshooting by offering improved
detail in JSON object values.

Test:
- Created BMC dump
- Created system dump

Here is a example
{
"_EXE" : "/tmp/phosphor-dump-manager",
"_MACHINE_ID" : "f9ca96d99c7b4ba688556f632ffeff5d",
"_CAP_EFFECTIVE" : "1ffffffffff",
"LOG2_FMTMSG" : "Invalid Dump file name, FILENAME: {FILENAME}",
"__CURSOR" : "s=721ae7a5b6ed43ec904f2bb03e3c0403;i=2a8d0;\
b=b372b9a5989e46bb8e62b33310e181ea;m=2c05fda2b;t=5fdf0684c1e70;x=1592f60584d6486c",
"CODE_FUNC" : "void phosphor::dump::bmc::Manager::\
createEntry(const std::filesystem::__cxx11::path&)",
"_SYSTEMD_SLICE" : "system-dropbear.slice",
"CODE_LINE" : "174",
"__REALTIME_TIMESTAMP" : "1686583867350640",
"PRIORITY" : "3",
"_SYSTEMD_UNIT" : "dropbear@1-9.3.29.238:22-9.3.84.138:45432.service",
"_PID" : "16209",
"_BOOT_ID" : "b372b9a5989e46bb8e62b33310e181ea",
"_SOURCE_REALTIME_TIMESTAMP" : "1686583867350580",
"_TRANSPORT" : "journal",
"_HOSTNAME" : "openbmc",
"SYSLOG_IDENTIFIER" : "phosphor-dump-manager",
"MESSAGE" : "Invalid Dump file name, \
FILENAME: BMCDUMP.XXXXXXX.0000006.20230612153010",
"CODE_FILE" : \
"/usr/src/debug/phosphor-debug-collector/1.0+gitAUTOINC+a17f1c92ce-r1\
/dump_manager_bmc.cpp",
"_UID" : "0",
"_CMDLINE" : "/tmp/phosphor-dump-manager",
"_RUNTIME_SCOPE" : "system",
"FILENAME" : "BMCDUMP.XXXXXXXX.0000006.20230612153010",
"_SYSTEMD_INVOCATION_ID" : "64a11629aade4c96ab62154cbc4be8b7",
"__MONOTONIC_TIMESTAMP" : "11817441835",
"_SYSTEMD_CGROUP" : "/system.slice/system-dropbear.slice/\
dropbear@1-9.3.29.238:22-9.3.84.138:45432.service",
"_COMM" : "phosphor-dump-m",
"_GID" : "0"
}

Change-Id: I3a52b812b059b64d945493de2e2cc68a43f6d72a
Signed-off-by: Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com>

show more ...

gcc13 : fix argument format issues

gcc13 based build failed with below errors.
error: static assertion failed: Cannot format an argument.
To make type T formattable provide a formatter<T> speciali

gcc13 : fix argument format issues

gcc13 based build failed with below errors.
error: static assertion failed: Cannot format an argument.
To make type T formattable provide a formatter<T> specialization:
https://fmt.dev/latest/api.html#udt

Problem reported during enum type input is similar to
https://github.com/fmtlib/fmt/issues/391
Fix is to static_cast the "enum" type to "underlying_type" in
fmt::format function.

Problem related file descriptor input is to static_cast enum
to "underlying_type".

Change-Id: I587e4abfb4e188d40a0e4bfbdd57e6da6a77616d
Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>

show more ...

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: If4790d4928efc3e6690ca090aa79f0c7737c3683
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

OpenPOWER: Add additional traces when requesting instance id

The dump manager requests an instance id from PLDM to communicate
with the host. Since the number of instances is limited
PLDM needs to k

OpenPOWER: Add additional traces when requesting instance id

The dump manager requests an instance id from PLDM to communicate
with the host. Since the number of instances is limited
PLDM needs to keep track of the requests, adding
additional traces while requesting the instance id.
Added exception handling for bus errors while
getting instance id from PLDM.

Testing:
Execute offload and delete to see whether traces are coming.

Signed-off-by: Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com>
Change-Id: Id15a99d349851ca00baf7fc8d59a83d7d266fa44

show more ...

OpenPOWER: Use non blocking call for host dump offload request

Currently dump manager is using pldm_send_recv which is
a blocking call and if the host is not responding
dump manager will hang to avo

OpenPOWER: Use non blocking call for host dump offload request

Currently dump manager is using pldm_send_recv which is
a blocking call and if the host is not responding
dump manager will hang to avoid this using pldm_send
which is a non-blocking call.

Tests:

Send message while host is down and dump manager is
not hung.

Signed-off-by: Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com>
Change-Id: Ie90e217325da4c8778c7527afcd453a8fdce02c8

show more ...

OpenPOWER: Do not wait for response deleting host dump

The resource dump delete is long running operation with
dbus call to PLDM for instance id, making it inside a
dbus call will end up timeouts wh

OpenPOWER: Do not wait for response deleting host dump

The resource dump delete is long running operation with
dbus call to PLDM for instance id, making it inside a
dbus call will end up timeouts when PLDM tries to
access dump manager. To avoid dead-locks dump manager
will not be waiting for response after a delete
operation

Testing:
Create system dump and delete the dump
Create 10 resource dumps and delete one by one

Signed-off-by: Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com>
Change-Id: I9c98c40672274a33097d9c4129ea52b5984c4246

show more ...

Add fmtlib for phosphor-debug-collector

Call fmtlib to get additional information from journal.

Tested: built phosphor-debug-collector successfully
and Unit Test passes.

Signed-off-by: Geo

Add fmtlib for phosphor-debug-collector

Call fmtlib to get additional information from journal.

Tested: built phosphor-debug-collector successfully
and Unit Test passes.

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: Ibe65637a0b29b76269fb4bc3f498438901c9306a

show more ...

Update clang-format

Update to the latest OpenBMC clang-format.

Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
Change-Id: I54010d3c756af4c85786285644038d449730612b

Error while invalidating the resource dump over PLDM.

Problem:
The wrong identifier type was passed to the host dump
transport for deleting the dump, so an exception
is thrown.
Fix was needed in two

Error while invalidating the resource dump over PLDM.

Problem:
The wrong identifier type was passed to the host dump
transport for deleting the dump, so an exception
is thrown.
Fix was needed in two places
1) Dump identifier number was old in resource dump manager
2) PLDM_FILE_TYPE_RESOURCE_DUMP_PARAMS was given as dump
identifier instead of PLDM_FILE_TYPE_RESOURCE_DUMP.
Test:
- Created a new dump
- Invalidated the dump
Result: Dump is deleted from the host.

Signed-off-by: Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com>
Change-Id: If68f415439d8322f47fa6a6bc7a9b230e9f67fb1

show more ...

Add support for resource dump delete.

Add support for deleting resource dumps in host memory.
Change requestDelete to accept dump type.
Update system dump delete to pass dump type.

Signed-off-by: D

Add support for resource dump delete.

Add support for deleting resource dumps in host memory.
Change requestDelete to accept dump type.
Update system dump delete to pass dump type.

Signed-off-by: Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com>
Change-Id: I8dcf85a2b38da15ff8451003c11232e340c4ca89

show more ...

host-transport: pldm: default: Added missing header

Added missing header file inclusion to fix compilation error when
using "host-transport" option alone to get default pldm behaviour
to do required

host-transport: pldm: default: Added missing header

Added missing header file inclusion to fix compilation error when
using "host-transport" option alone to get default pldm behaviour
to do required host dump action.

Error 1: 'uint32_t' was not declared in this scope
Fixed by using `#include <stdint.h>`

Error 2: 'runtime_error' is not a member of 'std'
Fixed by using `#include <stdexcept>`

TestedBy:
- meson builddir -Dhost-transport=pldm
ninja -C builddir

Signed-off-by: Ramesh Iyyar <rameshi1@in.ibm.com>
Change-Id: I136defcf5f45a6f15be41e11e792091e103ce2c3

show more ...

host: Added support to delete system dump

To delete host system dump using pldm oem command "FileAck" with
dump file type and dump id which is present as source dump id (which
is got from pldm after

host: Added support to delete system dump

To delete host system dump using pldm oem command "FileAck" with
dump file type and dump id which is present as source dump id (which
is got from pldm after created the host system dump) in system dump entry
dbus object and also, to use pldm oem command added support to indicate
delete host system dump support is not available for other host transport
consumer and for other oem vendors who are using pldm as host transport
to get host dump.

Also, changed existing commited error i.e internal failure into not allowed
for host system dump offload to avoid bmc dump creation in dump path.

Signed-off-by: Ramesh Iyyar <rameshi1@in.ibm.com>
Change-Id: Ib6be5b521fb3c5aa2926497bae0b03c1d9737161

show more ...

ibm-host-system-dump-offload: Used CustomFd

Used "CustomFd" class instead closeFD() to avoid call in requried place
for close fd.

Signed-off-by: Ramesh Iyyar <rameshi1@in.ibm.com>
Change-Id: Id2107

ibm-host-system-dump-offload: Used CustomFd

Used "CustomFd" class instead closeFD() to avoid call in requried place
for close fd.

Signed-off-by: Ramesh Iyyar <rameshi1@in.ibm.com>
Change-Id: Id210713e4ae67495ee504fab47067c8a5643c930

show more ...

offload: Moved existing pldm offload as oem/ibm command

Currently used host mctp end point id is ibm specific and also
the used effecter id (0x05) is for phyp and "SetNumericEffecterValue"
pldm comm

offload: Moved existing pldm offload as oem/ibm command

Currently used host mctp end point id is ibm specific and also
the used effecter id (0x05) is for phyp and "SetNumericEffecterValue"
pldm command is common so, changing existing pldm offload implementation
into oem based and added default pldm offload interface as well.

Signed-off-by: Ramesh Iyyar <rameshi1@in.ibm.com>
Change-Id: I8a401e03d29f9245dd54577b8b7b1d87d4a13d18

show more ...

host-dump: Renamed host-dump-offload-transport build option

Currently dump manager using "host-dump-offload-transport" to mention
the transport protocol name to offload host dumps but, same transpor

host-dump: Renamed host-dump-offload-transport build option

Currently dump manager using "host-dump-offload-transport" to mention
the transport protocol name to offload host dumps but, same transport
can use to other actions i.e create and delete. So, Changing build option
name into "host-transport" to make generic.

Also, transport code sources files are organized based on "offload" name
so, changed same as "host-transport".

Signed-off-by: Ramesh Iyyar <rameshi1@in.ibm.com>
Change-Id: I9e229218ea8c606e7092daf4d24fd6d16eb425c8

show more ...