Break apart trigger interface

Having this large type creates confusion for translation. Splitting
this parameter into two fields allows us to remove the variant property
altogether, and allows spli

Break apart trigger interface

Having this large type creates confusion for translation. Splitting
this parameter into two fields allows us to remove the variant property
altogether, and allows splitting the rules for each type into their own
description.

The only users of this are bmcweb and telemetry, both of which have
patches up to effect this change under the same topic. Testing in those
patches.

Change-Id: I51a1dd3fe0619aa7a75f92764875552feda01a92
Signed-off-by: Ed Tanous <ed@tanous.net>

show more ...

Telemetry: Update Report interface

Updating Report interface to the state that is currently implemented in
service code:

- added `SetReadingProperties` method, which allows safe modification of
`Re

Telemetry: Update Report interface

Updating Report interface to the state that is currently implemented in
service code:

- added `SetReadingProperties` method, which allows safe modification of
`ReportingType` and `Interval` properties
- made `ReportingType` and `Interval` properties read-only

Change-Id: I9a9539a3f9a95b6a1eb19134a264f9438605a66d
Signed-off-by: Michal Orzel <michalx.orzel@intel.com>

show more ...

telemetry: Unify reading parameter property names

Changes name of "MetricParams" argument of ReportManager.AddReport
method to "ReadingParameters", which is its equivalent from Report
interface. Thi

telemetry: Unify reading parameter property names

Changes name of "MetricParams" argument of ReportManager.AddReport
method to "ReadingParameters", which is its equivalent from Report
interface. This helps avoid possible confusion, whether those parameters
should refer to the same thing or not.

Change-Id: I18e504462fb379e5267cee2c4102cf61e2b157a8
Signed-off-by: Michal Orzel <michalx.orzel@intel.com>

show more ...

updated telemetry service API

Reverted addReport function to take multiple parameters instead of list
of variants. Removed errors property from Report.

Change-Id: Idd9ac31958142b7ce120fad676877b722

updated telemetry service API

Reverted addReport function to take multiple parameters instead of list
of variants. Removed errors property from Report.

Change-Id: Idd9ac31958142b7ce120fad676877b7226a32be7
Signed-off-by: Krzysztof Grobelny <krzysztof.grobelny@intel.com>

show more ...

reformat with latest settings

Reformat with the latest settings from openbmc-build-scripts (and
copy latest config files where appropriate). Fix a few minor
markdownlint issues.

Signed-off-by: Pat

reformat with latest settings

Reformat with the latest settings from openbmc-build-scripts (and
copy latest config files where appropriate). Fix a few minor
markdownlint issues.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I55205817c29dc3f182a165ddf9cd5d4e07b90063

show more ...

Update Telemetry service interfaces

This change updates description of interfaces utilized by Telemetry
service, so that its contents mirror the desired implementation.

Change-Id: I7207c4889912e848

Update Telemetry service interfaces

This change updates description of interfaces utilized by Telemetry
service, so that its contents mirror the desired implementation.

Change-Id: I7207c4889912e848a058279b9d89f643a7e0b6b8
Signed-off-by: Michal Orzel <michalx.orzel@intel.com>

show more ...

yaml: format with prettier

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I193f690f3612fe72ec69030f81f4d5096a761601

Update Telemetry Report and ReportManager

For Report interface:
- Added 'Enabled' property. It may be set by user to enable or disable
readings updates, or can be set by service when certain condi

Update Telemetry Report and ReportManager

For Report interface:
- Added 'Enabled' property. It may be set by user to enable or disable
readings updates, or can be set by service when certain conditions are
met.
- Added 'CollectionTimescope' enum, used by ReadingParameters property
and used by AddReport method in ReportManager.
- Updated 'ReportUpdates' enum with 1 new value:
-- NewReport. A new report is created, whose name is the current
metric report name concatenated with the timestamp.
- Updated description of 'Overwrite' ReportUpdate value, to clarify its
interaction (or lack of it) with AppendLimit.
- Updated 'AppendLimit' description to match redfish description.
- Updated 'ReadingParameters' to include multiple sensors, collection
timescope and collection duration.
- Fixed typos in some descriptions.

For ReportManger interface:
- Updated 'appendLimit' description in AddReport method to match redfish
description.
- Updated 'metricParams' in AddReport method to include multiple sensor
paths, collection timescope and collection duration.

Signed-off-by: Szymon Dompke <szymon.dompke@intel.com>
Change-Id: Icfd8c4f37863ce0663535e9ec492f465709425cc

show more ...

Update Telemetry Trigger and TriggerManager

For Trigger interface:
- Removed LogToJournal, LogToRedfish and UpdateReport properties.
- Added TriggerActions property which is an array of TriggerActio

Update Telemetry Trigger and TriggerManager

For Trigger interface:
- Removed LogToJournal, LogToRedfish and UpdateReport properties.
- Added TriggerActions property which is an array of TriggerAction enum.
- Defined TriggerAction enum: LogToLogService, RedfishEvent,
UpdateReport. Those values correspond to removed properties.
- Modified Thresholds property to reflect current telemetry
implementation.

For TriggerManager interface:
- Removed 'discrete' param from AddTrigger method. This can be deduced
by service.
- Removed 'logToJournal', 'logToRedfish' and 'updateReport' params from
AddTrigger method.
- Added 'triggerActions' param to AddTrigger method, which contains
values corresponding to removed params.
- Modified 'thresholds' param in AddTrigger method to reflect current
telemetry implementation.

By replacing bool properties/params with single array, trigger interface
will be easier to implement in Redfish.

Signed-off-by: Szymon Dompke <szymon.dompke@intel.com>
Change-Id: I995ba8272c633054106c76fefaa38df87384f64d

show more ...

treewide: Create yaml directory

This allows the propagated yamldir paramter to work correctly in
subproject style builds. We don't want other files in the project
conflicting with tools that scan th

treewide: Create yaml directory

This allows the propagated yamldir paramter to work correctly in
subproject style builds. We don't want other files in the project
conflicting with tools that scan the yamldir.

Change-Id: Ie2759c7f3baf399392cdda0e507055ceb262d2e1
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...