Fix spelling mistakes using codespell

This commit corrects various spelling mistakes throughout the
repository. The corrections were made automatically using `codespell`[1]
tool.

[1]: https://githu

Fix spelling mistakes using codespell

This commit corrects various spelling mistakes throughout the
repository. The corrections were made automatically using `codespell`[1]
tool.

[1]: https://github.com/codespell-project/codespell

Change-Id: I965f52f9eae78bcad39a8d711f99bef7be4cbde0
Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>

show more ...

postcode: add dbus paths

The default path for the post code objects is, from
phosphor-post-code-manager:

```
meson.build
16:conf_data.set_quoted('DBUS_OBJECT_NAME', '/xyz/openbmc_project/State/Boot

postcode: add dbus paths

The default path for the post code objects is, from
phosphor-post-code-manager:

```
meson.build
16:conf_data.set_quoted('DBUS_OBJECT_NAME', '/xyz/openbmc_project/State/Boot/PostCode')

src/main.cpp
60: std::string dbusObjName = DBUS_OBJECT_NAME + std::to_string(node);
```

Add these constants to the interface YAML file so they can be used by
dbus clients.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: If255733aaf12cf7283e191c31fe13ba3025736d8

show more ...

State.Host: use set for AllowedHostTransitions

The intended use of this is as a set of allowed elements. Express
intent with `set` instead of `array`, even though these end up on dbus
in the same d

State.Host: use set for AllowedHostTransitions

The intended use of this is as a set of allowed elements. Express
intent with `set` instead of `array`, even though these end up on dbus
in the same data type.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I0c2f55daa704f578ed1bb45a93ad81b4c57b90fc

show more ...

host-state: define new allowed host transition prop

IBM has a system where the host firmware does not want to allow
a ForcedWarmReboot due to potential error paths with the chassis power
remaining o

host-state: define new allowed host transition prop

IBM has a system where the host firmware does not want to allow
a ForcedWarmReboot due to potential error paths with the chassis power
remaining on and their software being forcefully rebooted.

Define a new property which allows the BMC software to optionally define
which Transition actions they support.

bmcweb currently hard codes the AllowableValues in
redfish/v1/Systems/system/ResetActionInfo. That code will be changed
to first look for this new property on D-Bus. If it's not found or
empty, stick with the hard coded defaults. If it is found and it's
non-empty then use it to fill in the AllowableValues.

Change-Id: I65d29c2bbc54a64084aea21023fd7d33cd129dce
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>

show more ...

State: add default paths for BMC,Host,Chassis

Add namespace and path constants matching those in the README for
programmatic use.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ice4

State: add default paths for BMC,Host,Chassis

Add namespace and path constants matching those in the README for
programmatic use.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ice4e14716b2de6477f3dd7c15e53cc7bdb68270f

show more ...

Watchdog: Add LogTimeout property in watchdog

Add the LogTimeout property in watchdog yaml.
This property is used for configuring whether an event
will be logged on watchdog expiration.

Tested:
No

Watchdog: Add LogTimeout property in watchdog

Add the LogTimeout property in watchdog yaml.
This property is used for configuring whether an event
will be logged on watchdog expiration.

Tested:
No log bit is set to true :
ipmitool raw 0x06 0x24 0x84 0x00 0x00 0x3e 0x64 0x00

No log bit is set to false :
ipmitool raw 0x06 0x24 0x04 0x00 0x00 0x3e 0x64 0x00

Reset watchdog timer :
ipmitool mc watchdog reset

If the LogTimeout property is true, the event will be logged
on watchdog expiration.
We can use 'ipmitool sel elist' to check the system event log.
1 | 01/26/23 | 00:21:21 PST | Watchdog2 host0 | Timer expired | Asserted

If the LogTimeout property is false, the event will not be
logged when the watchdog expires.

Related-Commit-Id: 67727
Related-Commit-Id: 67728

Change-Id: I278b8bb3eec1951ba505ab53527826aef075a05f
Signed-off-by: Tim Chao <Tim.Chao@quantatw.com>

show more ...

bmc-ready: include new error codes in interfaces

This will generate the appropriate bindings and ensure the error is
passed back to the caller allowing them to properly handle this type of
error.

C

bmc-ready: include new error codes in interfaces

This will generate the appropriate bindings and ensure the error is
passed back to the caller allowing them to properly handle this type of
error.

Change-Id: I63301d0371d27835417fcba503c32f854f1919bd
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>

show more ...

bmc-ready: new error def for when bmc not ready

phosphor-state-manager is introducing a new optional feature that users
can enable which will not allow chassis or host power on operations if
the BMC

bmc-ready: new error def for when bmc not ready

phosphor-state-manager is introducing a new optional feature that users
can enable which will not allow chassis or host power on operations if
the BMC is not at its "Ready" state.

This commit defines some new error codes so callers will have the
appropriate return information when this situation arises.

Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: Ibbe71356b54675601b54179633e76310fdabccec

show more ...

bootprogress: add OEM value for ProgressStages enumerations

This commit adds the OEM enumerations for the ProgressStages to
indicate the last stage is OEM as defined in the DSP0268_2021.2
Redfish Sc

bootprogress: add OEM value for ProgressStages enumerations

This commit adds the OEM enumerations for the ProgressStages to
indicate the last stage is OEM as defined in the DSP0268_2021.2
Redfish Schema Supplement.pdf specification and DEN0069D_SBMR_2.0.pdf
document section F.2.2.

Signed-off-by: Hieu Huynh <hieuh@os.amperecomputing.com>
Change-Id: I5a2b5943df54d5208fb847c7b9e89c09af3b73cd

show more ...

reformat with latest settings

Reformat with the latest settings from openbmc-build-scripts (and
copy latest config files where appropriate). Fix a few minor
markdownlint issues.

Signed-off-by: Pat

reformat with latest settings

Reformat with the latest settings from openbmc-build-scripts (and
copy latest config files where appropriate). Fix a few minor
markdownlint issues.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I55205817c29dc3f182a165ddf9cd5d4e07b90063

show more ...

Add PowerCycleError parameter in Chassis Error yaml

A new system is being designed which will utilize phosphor-state-manager
and it requires the chassis system power cycle feature.
When chassis powe

Add PowerCycleError parameter in Chassis Error yaml

A new system is being designed which will utilize phosphor-state-manager
and it requires the chassis system power cycle feature.
When chassis power cycle target failed to complete,
it need a parameter to represent chassis system power error status.

Test plan:
Build success and check the chassis system power parameter in configuration.

Change-Id: I0de438b63f6221ec4fbffcdc070a65a48a2dafde
Signed-off-by: Bonnie Lo <Bonnie_Lo@wiwynn.com>

show more ...

Correct links in the state management documentation

Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>
Change-Id: I55fb0dc9bcbcc7326e39ac83169ebeba2cbc6693

prettier: reformat YAML

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ib7050ca82a9826efbd5ef356f546f3c33d7a2186

State: New PowerSystemInputs interface

Add a new PowerSystemInputs interface to describe the state of the power
supplied to the chassis via the power supply unit(s), in order to have
state manager h

State: New PowerSystemInputs interface

Add a new PowerSystemInputs interface to describe the state of the power
supplied to the chassis via the power supply unit(s), in order to have
state manager handle Brownout conditions as described in design doc:
https://gerrit.openbmc-project.xyz/c/openbmc/docs/+/48015

This interface would be implemented by the phosphor-power repo and the
Status property set to Fault when a Brownout condition is detected.

Change-Id: I7aeea45f7285835fdb97a34706b3eef610d7532d
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

show more ...

doc: format with markdownlint

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Id1efc27791e219e5fbfe08023143be2f59037307

yaml: format with prettier

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I193f690f3612fe72ec69030f81f4d5096a761601

bmc-reboot: add pinhole reset reason

Some systems have a physical mechanism on them to force a reboot of the
BMC. One common mechanism for this is a pinhole. The user utilizes a
round, thin piece of

bmc-reboot: add pinhole reset reason

Some systems have a physical mechanism on them to force a reboot of the
BMC. One common mechanism for this is a pinhole. The user utilizes a
round, thin piece of metal (commonly a paper clip) to trigger this
reset.

The use of the pinhole reset is usually utilized to force a reboot of
an unresponsive BMC. BMC firmware, when it comes back from the reboot,
may want to do some special handling for this scenario.

Some systems, like the IBM p10bmc machines, have some logic in the
hardware to set a GPIO so that BMC firmware will have a mechanism to
know if the reboot cause was the result of a pinhole reset. IBM systems
would like to add some software logic around this. For example, if a
pinhole reset was done, the firmware will not run its auto power on
functions. If a user has force reset a system, they do not want firmware
trying to auto power on the machine.

The design on this can be found here:
https://gerrit.openbmc-project.xyz/c/openbmc/docs/+/47816

Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: Id8f0e5b8da708ec82d13a89013e19692ef5959b8

show more ...

power-recovery: introduce CurrentPowerStatus to chassis

The power coming into a chassis can have its own status. For example, if
power has been lost (blackout) but the system has an uninterruptible

power-recovery: introduce CurrentPowerStatus to chassis

The power coming into a chassis can have its own status. For example, if
power has been lost (blackout) but the system has an uninterruptible
power supply(UPS) connected, then chassis power could still be on but
its important to provide the fact that the system is running off of a
UPS to other BMC software.

For example, IBM has a policy that it will allow a system to remain on
if it is already on when a blackout or brownout occurs (and running on
a UPS), but it will not allow a user to power a system on if in one of
these conditions. IBM will also not allow a system to power on until
a UPS is fully charged.

The design for this can be found over in the following series:
https://gerrit.openbmc-project.xyz/c/openbmc/docs/+/48210

Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: I4300167f3baa66bc9229651178d161fc12c92e1b

show more ...

host-state: introduce new host crash restart reason

In situations where the host firmware crashes, and BMC firmware detects
it, the BMC will attempt to recover by initiating a reboot of the host
fir

host-state: introduce new host crash restart reason

In situations where the host firmware crashes, and BMC firmware detects
it, the BMC will attempt to recover by initiating a reboot of the host
firmware a certain amount of times.

On IBM systems, the host needs to know when a crash is the reason for a
boot. This property will be utilized by the host communication firmware
to tell them.

Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: Ibf18c1ac084ec8fb0b0ab3985623ed41f01f65ad

show more ...

host-state: introduce new scheduled power on reason

The xyz.openbmc_project.State.ScheduledHostTransition interface is
utilized to schedule a host transition at some point in the future. Add
this as

host-state: introduce new scheduled power on reason

The xyz.openbmc_project.State.ScheduledHostTransition interface is
utilized to schedule a host transition at some point in the future. Add
this as a potential reason for the host RestartCause property.

On IBM systems, the host needs to know when a scheduled transition is
the reason for a boot. This property will be utilized by the host
communication firmware to tell them.

Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: I438982223482f9819abaee25bbf5b85ae27392bc

show more ...

bmc-quiesced: introduce bmc service failure state

Introduce a new Quiesced state for the BMC. This state will be entered
when the new obmc-bmc-service-failure.target is started. This target
will be

bmc-quiesced: introduce bmc service failure state

Introduce a new Quiesced state for the BMC. This state will be entered
when the new obmc-bmc-service-failure.target is started. This target
will be started when a systemd service within the BMC goes into a fail
state and has its OnFailure set to start this target.

The design doc for this new function is at:
https://gerrit.openbmc-project.xyz/c/openbmc/docs/+/46690

Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: I847aeaf2267709c080cf2fd49aac15506c23e2bb

show more ...

Put PowerState On/Off enums in quotes

Without this, the python code generator converts them to booleans and
emits True and False as the enum values in the generated code.

Signed-off-by: Matt Spinle

Put PowerState On/Off enums in quotes

Without this, the python code generator converts them to booleans and
emits True and False as the enum values in the generated code.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I4d8804e6c83055c55ebbbe032d65c6609518c711

show more ...

Add PowerState Interface

There are many cases where a BMC would have to show the power state
of a FRU, This commit adds a generic interface for capturing the
power state of an object.

This would he

Add PowerState Interface

There are many cases where a BMC would have to show the power state
of a FRU, This commit adds a generic interface for capturing the
power state of an object.

This would help map the actual power state of the FRU to redfish.
Below is the spec link :
http://redfish.dmtf.org/schemas/v1/Resource.json#/definitions/PowerState

Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>
Change-Id: Iea8455ef9b03de7923104c1e29d28a201756fc7a

show more ...

watchdog: Add Watchdog Timeout signal

The `Timeout` signal is used to indicate a watchdog timeout event. It is
being used in `phosphor-watchdog` for timeout events. It has a `Action`
property to ind

watchdog: Add Watchdog Timeout signal

The `Timeout` signal is used to indicate a watchdog timeout event. It is
being used in `phosphor-watchdog` for timeout events. It has a `Action`
property to indicate the timeout event that it took. It could be
different from the expiredAction due to fallback watchdog.

The new signal is picked up in `phosphor-sel-logger` handle Watchdog SEL
logs.

Change-Id: I0e20af1d23f7a8dbc9a7580797923373b04f2905
Signed-off-by: Willy Tu <wltu@google.com>

show more ...

Add LastRebootCause property for BMC Reboot Cause feature

Scenario:
Customer want to know the last reboot cause of BMC through OpenBMC WebUI.
Thus, we need to add LastRebootCause property in BMC.int

Add LastRebootCause property for BMC Reboot Cause feature

Scenario:
Customer want to know the last reboot cause of BMC through OpenBMC WebUI.
Thus, we need to add LastRebootCause property in BMC.interface.yaml.
Meanwhile, we also modify phosphor-state-manager and phosphor-webui
to support show BMC Reboot Cause information in Reboot BMC page.

Tested:
busctl get-property xyz.openbmc_project.State.BMC /xyz/openbmc_project/state/bmc0 xyz.openbmc_project.State.BMC LastRebootCause

When unplug/plug in BMC power cable then return as below: (POR i.e. Power-On-Reset)
s "xyz.openbmc_project.State.BMC.BMCResetCause.POR"

When executing reboot command then return as below:
s "xyz.openbmc_project.State.BMC.BMCResetCause.Watchdog"

Signed-off-by: Tim Lee <timlee660101@gmail.com>
Change-Id: Iac99adc1e12ab42076f0d33aa87a179f63b9c1ce

show more ...