move non-threshold events into sensor namespace

Move the non-threshold events into the sensor namespace so they don't
include threshold in their interface name. These events are generic
sensor event

move non-threshold events into sensor namespace

Move the non-threshold events into the sensor namespace so they don't
include threshold in their interface name. These events are generic
sensor events and have no relation to threshold monitoring. I verified
in the openBMC code and there has been no user of these events for now,
hence they are safe to move.

Change-Id: I5aa6a5bdda04f520f842107c2e7a3537e04f821a
Signed-off-by: Jagpal Singh Gill <paligill@gmail.com>

show more ...

sensor events: add internal threshold level events

In certain scenarios, the threshold monitoring is done internally by the
hardware and no thresholds values are available for the software to
consum

sensor events: add internal threshold level events

In certain scenarios, the threshold monitoring is done internally by the
hardware and no thresholds values are available for the software to
consume. In such scenarios, add internal level based events as per
Redfish SensorEvent schema [1].

[1] https://github.com/DMTF/Redfish-Publications/blob/main/registries/SensorEvent.1.0.1.json#L306

Change-Id: I61c9375b6fd0347084f08e770b86c349a1eecabb
Signed-off-by: Jagpal Singh Gill <paligill@gmail.com>

show more ...

add valve namespace to sensor value

The valve open status is being represented as a sensor value in
percentage units. Recently, Redfish introduced "valve" as a ReadingType
under the sensors schema [

add valve namespace to sensor value

The valve open status is being represented as a sensor value in
percentage units. Recently, Redfish introduced "valve" as a ReadingType
under the sensors schema [1]. This update aligns with that change by
adding support for monitoring the open/close status of water valves.

[1] https://github.com/openbmc/bmcweb/blob/master/redfish-core/schema/dmtf/json-schema/Sensor.v1_11_0.json#L201

Change-Id: I59fd4bd1d510b89ec5edd923b9fe71f99c3985c1
Signed-off-by: Jagpal Singh Gill <paligill@gmail.com>

show more ...

Value.interface: Fix typo

Just a typo fix in the description of volts enum.

Change-Id: I9601408aa020e68c9cc26276207dc3879e95edac
Signed-off-by: Roger G. Coscojuela <roger.gili-coscojuela@sipearl.co

Value.interface: Fix typo

Just a typo fix in the description of volts enum.

Change-Id: I9601408aa020e68c9cc26276207dc3879e95edac
Signed-off-by: Roger G. Coscojuela <roger.gili-coscojuela@sipearl.com>

show more ...

Sensors: Add Frequency namespace

This patch adds the frequency namespace.

Change-Id: Id8d1d8ec2e410561785b31f9e1b378a1b18ab6d4
Signed-off-by: Aditya Kurdunkar <akurdunkar@nvidia.com>

fix description for Sensor.Value interface

Since [1] was merged, the 'Value' property may be written to in some
situations. Update the documentation for this interface.

References:
[1] https://gerr

fix description for Sensor.Value interface

Since [1] was merged, the 'Value' property may be written to in some
situations. Update the documentation for this interface.

References:
[1] https://gerrit.openbmc.org/c/openbmc/phosphor-dbus-interfaces/+/36333

Change-Id: I534267bb3068c658929b48ca25ff0bb2e646e4f7
Signed-off-by: Alexander Hansen <alexander.hansen@9elements.com>

show more ...

Add new interface to define sensor purpose

A chassis can have a sensor which tracks the total power consumption.
Clients such as bmcweb need a programmatic approach to finding the
unique sensor from

Add new interface to define sensor purpose

A chassis can have a sensor which tracks the total power consumption.
Clients such as bmcweb need a programmatic approach to finding the
unique sensor from the chassis.

A design discussion [1] in development channel of Discord settled on the
following approach:
- Define a D-Bus interface for defining a special purpose for a
sensor.
- Use the existing all_sensors/chassis association to connect the
sensor to its Chassis.
- Clients such as bmcweb use object mapper to find all_sensors
associated with the Chassis. They then filter to
find the sensor implementing the specific purpose required.

This initial implementation only defines a single special purpose. The
expectation is others will be added as needed in the future.

The openpower-occ-control repo implemented a total_power association.[2]
This will be modified to implement this new interface on the total_power
sensor.

There is a commit for bmcweb which will be modified to use this new
approach for finding the total_power sensor.[3]

Note: There is technical debt to convert all_sensors/chassis
associations to use the monitoring/monitored_by association instead.[4]
That change would also need to convert the association used to find
objects implementing this interface.

[1] https://discord.com/channels/775381525260664832/867820390406422538/1326612654852280433
[2] https://gerrit.openbmc.org/c/openbmc/openpower-occ-control/+/75572
[3] https://gerrit.openbmc.org/c/openbmc/bmcweb/+/57717
[4] https://discord.com/channels/775381525260664832/867820390406422538/1326609419022372916

Change-Id: Ic8b509c9b2b17e823243f7b784ef941ec461cddb
Signed-off-by: Janet Adkins <janeta@us.ibm.com>

show more ...

events: switch metadata to CamelCase

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ib307621f7b6ad6b04f3c1b331cebda3d2c37f746

Add enum value "LPM"

Add the necessary sensor units for the flowmeter in the liquid cooling
system: LPM (L/min).

The "dbus-sensors" package now implements the liquidflow sensor, and
the "xyz.openbm

Add enum value "LPM"

Add the necessary sensor units for the flowmeter in the liquid cooling
system: LPM (L/min).

The "dbus-sensors" package now implements the liquidflow sensor, and
the "xyz.openbmc_project.Sensor.Value" should provide the
"LPM" at enum's of "Unit"-property.

End-user-impact:
The "xyz.openbmc_project.Sensor.Value.Unit" now represents the
"LPM" type of liquidflow sensor values.

Change-Id: Ia6f5d30734472d336abe7bac4b05741f557c8807
Signed-off-by: P.K. Lee <p.k.lee@quantatw.com>

show more ...

sensors: Add threshold event log definitions

Add threshold event logs as defined in the Redfish SensorEvent.1.0.1.
It is expected that services use the new interface to log threshold
events while ma

sensors: Add threshold event log definitions

Add threshold event logs as defined in the Redfish SensorEvent.1.0.1.
It is expected that services use the new interface to log threshold
events while maintaining the state.

We are leaving out the implementation of ReadingCritical,
ReadingNoLongerCritical, ReadingWarning since these are equivalents
but do not specify the threshold values.

More information:

[1] https://lore.kernel.org/openbmc/SJ2PR15MB5801EA7FA684D3B21EE32CE3AB8D2@SJ2PR15MB5801.namprd15.prod.outlook.com/

Change-Id: I6159dd9c1f3f9dc6e3e5d697c2b9b4a131c9ce2e
Signed-off-by: Amithash Prasasd <amithash@meta.com>

show more ...

Sensor.Value: add path constants

Add path constants that allow code to avoid hard-coding strings.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I9e93017572933ffd920dd13c301867b33cb

Sensor.Value: add path constants

Add path constants that allow code to avoid hard-coding strings.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I9e93017572933ffd920dd13c301867b33cbb0203

show more ...

Sensor.Value: fix minor spelling mistake

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I4da4cd939804b21bc6117c790af552afca761aee

reformat with latest settings

Reformat with the latest settings from openbmc-build-scripts (and
copy latest config files where appropriate). Fix a few minor
markdownlint issues.

Signed-off-by: Pat

reformat with latest settings

Reformat with the latest settings from openbmc-build-scripts (and
copy latest config files where appropriate). Fix a few minor
markdownlint issues.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I55205817c29dc3f182a165ddf9cd5d4e07b90063

show more ...

Item: Add description for associations involving Bmc

Change-Id: I9aa0fe58c5ab0c47f168c1340fd8c328ad7f6e9e
Signed-off-by: Sui Chen <suichen@google.com>

inventory: sensors: Document related inventory association

This change just adds the associations that are already
documented here to the YAML:
https://github.com/openbmc/docs/blob/master/architectu

inventory: sensors: Document related inventory association

This change just adds the associations that are already
documented here to the YAML:
https://github.com/openbmc/docs/blob/master/architecture/sensor-architecture.md#association-type-2-linking-a-low-level-hardware-item-to-its-sensors

Change-Id: I4dd23e842a6dd7e702f372efd0f192d28bfbf13b
Signed-off-by: Shounak Mitra <shounak@google.com>

show more ...

Require ObjectManager on Sensors and Inventory

Require that any daemon publishing inventory items implement
ObjectManager, specifically on the inventory path. For Sensors (which
already documents t

Require ObjectManager on Sensors and Inventory

Require that any daemon publishing inventory items implement
ObjectManager, specifically on the inventory path. For Sensors (which
already documents this requirement) make the required path more clear.

Longer discussion available on lore.

https://lore.kernel.org/openbmc/CAOLfGj6DWfmhxzSQx9PaU1awppsExrgJodFu8JrSgkbQZbnStA@mail.gmail.com/T/#t

This commit amounts to step 1.

Tested: Documentation only.

Signed-off-by: Ed Tanous <edtanous@google.com>
Signed-off-by: Nan Zhou <nanzhoumails@gmail.com>
Change-Id: Iaad5cf101d6a8361e8905f88e09648ae615efd33

show more ...

sensor: Add new Accuracy interface

This will express the +/- percentage accuracy of the Value read. Default
to NaN (not a number).

Tested:
Local CI build against phosphor-dbus-interfaces clean.

sensor: Add new Accuracy interface

This will express the +/- percentage accuracy of the Value read. Default
to NaN (not a number).

Tested:
Local CI build against phosphor-dbus-interfaces clean.
Built p10bmc obmc-phosphor-image (devtool modify ...)
Find and view client.hpp and server.hpp for Accuracy, looks good.

Change-Id: I42b93c0267cf6ce397c922a0c161c41a56c8b30e
Signed-off-by: Brandon Wyman <bjwyman@gmail.com>

show more ...

prettier: reformat YAML

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ib7050ca82a9826efbd5ef356f546f3c33d7a2186

yaml: format with prettier

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I193f690f3612fe72ec69030f81f4d5096a761601

sensor: add relative humidity

Change-Id: I84f37194adbcaf99b4c426a8d51afc738bd6a799

sensor: sort units and document all types

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I9f227d4c670cb03a704855bb0cca9f3920b3e098

threshold: fix up documentation per sensor.value

The Sensor.Value has a list of "recognized hierarchies" which is
similarly replicated in all of the Threshold interfaces. The lists
in the Threshold

threshold: fix up documentation per sensor.value

The Sensor.Value has a list of "recognized hierarchies" which is
similarly replicated in all of the Threshold interfaces. The lists
in the Threshold objects were incomplete, so update them.

Also, make trivial whitespace / formatting changes to ensure linewrap
is at the appropriate (80) columns.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I6bd76ca423e1ea3c2e0c7ce59e10dce1125eb6d1

show more ...

Fix for missing airflow in interface description

Added airflow in top-level interface description.

Tested:
verified using YAML editor, Compiles correctly

Signed-off-by: Basheer Ahmed Muddebihal

Fix for missing airflow in interface description

Added airflow in top-level interface description.

Tested:
verified using YAML editor, Compiles correctly

Signed-off-by: Basheer Ahmed Muddebihal <basheerx.muddebihal@intel.com>
Change-Id: Idc546ba27049f244a07d0e443bc57b1f8e335ad3

show more ...

Add sensor value mutability interface

This adds and documents the new sensor value mutability interface. IPMI
will check the mutability interface before overriding a sensor value.

Signed-off-by: Jo

Add sensor value mutability interface

This adds and documents the new sensor value mutability interface. IPMI
will check the mutability interface before overriding a sensor value.

Signed-off-by: Josh Lehan <krellan@google.com>
Change-Id: I4e90800a79469a87ef63f7395dbfc402976c73aa
Signed-off-by: Jie Yang <jjy@google.com>

show more ...

treewide: Create yaml directory

This allows the propagated yamldir paramter to work correctly in
subproject style builds. We don't want other files in the project
conflicting with tools that scan th

treewide: Create yaml directory

This allows the propagated yamldir paramter to work correctly in
subproject style builds. We don't want other files in the project
conflicting with tools that scan the yamldir.

Change-Id: Ie2759c7f3baf399392cdda0e507055ceb262d2e1
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...