Logging.Entry: switch 'AdditionalData' to dict of metadata

All client users of AdditionalData have moved to AdditionalData2,
which is already a dict. Switch AdditionalData to be a dict as
the next

Logging.Entry: switch 'AdditionalData' to dict of metadata

All client users of AdditionalData have moved to AdditionalData2,
which is already a dict. Switch AdditionalData to be a dict as
the next part of the migration.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ic18c8f9eb9804a1221482a96dd682817816d76d9

show more ...

Logging.Entry: Add 'AdditionalData2' as a dict of metadata

In order to ease transition from vector to dict, add a new property
for the time being. Existing code can transition to using the dict
and

Logging.Entry: Add 'AdditionalData2' as a dict of metadata

In order to ease transition from vector to dict, add a new property
for the time being. Existing code can transition to using the dict
and then we can rename the property once everyone has moved to the
dict format.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I4c918cb25021fd5434f6a50da7bbe3e0b2c2a4fb

show more ...

Logging.Create: return result path from create call

When a daemon creates an event or error entry it is sometimes helpful
to be able to look up that entry later, for example to mark it as
resolved.

Logging.Create: return result path from create call

When a daemon creates an event or error entry it is sometimes helpful
to be able to look up that entry later, for example to mark it as
resolved. Add a return to the method call for this.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ia010e53fda55cef8b9cfc948482e133f20040320

show more ...

Logging: Entry: Add errors to Resolved Property

Add the error 'xyz.openbmc_project.Common.Error.Unavailable' to the
'Resolved' property of the Entry interface.

This change helps in notifying the us

Logging: Entry: Add errors to Resolved Property

Add the error 'xyz.openbmc_project.Common.Error.Unavailable' to the
'Resolved' property of the Entry interface.

This change helps in notifying the users when the attempt to set the
Resolved property is prevented until the corresponding error log is
addressed.

For example, if the error log is associated with a HardwareIsolation
entry (which indicates the faulty hardware) and has not been resolved
yet; in this case, we need to prevent setting the 'Resolved' flag.

Change-Id: I64da52e572ba33f888d33039ac604c57b86d84de
Signed-off-by: Arya K Padman <aryakpadman@gmail.com>

show more ...

Logging: IPMI: Add SELDelete Method

Add the SELDelete method to xyz.openbmc_project.Logging.IPMI interface
to support the deletion of SEL entries. This method has a record ID
parameter which is used

Logging: IPMI: Add SELDelete Method

Add the SELDelete method to xyz.openbmc_project.Logging.IPMI interface
to support the deletion of SEL entries. This method has a record ID
parameter which is used to determine which entry should be
deleted. If the record ID parameter provided does not exist in the SEL,
then a ResourceNotFound error is thrown.

Change-Id: Id4a703ef814ad75ad2cbfb75569aa80ea5c85fc4
Signed-off-by: Jonico Eustaquio <jonico.eustaquio@fii-na.com>

show more ...

Logging: add default path and service names

Add default paths and service names from the reference implementation
in phosphor-logging. The service for logging is expected to be a
singleton and the

Logging: add default path and service names

Add default paths and service names from the reference implementation
in phosphor-logging. The service for logging is expected to be a
singleton and the manager object resides at a fixed path.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ia8d4ec354dbbe234109562bd76f1f779922da4e0

show more ...

Logging.Entry: fix old documentation

`org.openbmc` interfaces were removed years and years ago but the
description still referenced it.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id

Logging.Entry: fix old documentation

`org.openbmc` interfaces were removed years and years ago but the
description still referenced it.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I8b2994a053e137f7478a9b78c5ebfeec7d68ffec

show more ...

reformat with latest settings

Reformat with the latest settings from openbmc-build-scripts (and
copy latest config files where appropriate). Fix a few minor
markdownlint issues.

Signed-off-by: Pat

reformat with latest settings

Reformat with the latest settings from openbmc-build-scripts (and
copy latest config files where appropriate). Fix a few minor
markdownlint issues.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I55205817c29dc3f182a165ddf9cd5d4e07b90063

show more ...

Convert ServiceProviderNotify to enum

Converted ServiceProviderNotify to an enum.
Supported options are - "NotSupported", "Notify" and "Inhibit".

Changes in phosphor-logging are at the link below
h

Convert ServiceProviderNotify to enum

Converted ServiceProviderNotify to an enum.
Supported options are - "NotSupported", "Notify" and "Inhibit".

Changes in phosphor-logging are at the link below
https://gerrit.openbmc.org/c/openbmc/phosphor-logging/+/58815

For more details on the discussion look at the link below.
https://gerrit.openbmc-project.xyz/c/openbmc/bmcweb/+/46886/7/redfish-core/lib/log_services.hpp#1411

Signed-off-by: Vijay F Lobo <vflobo@us.ibm.com>
Change-Id: Iefe95a5531792bc79e363923deb7fc894774ee67
Signed-off-by: Lakshmi Yadlapati <lakshmiy@us.ibm.com>

show more ...

treewide: use more specific object_path type

The sdbus++ tool allows the YAML to specify either "path" or
"object_path". Switch to "object_path" everywhere for consistency
and clarity.

Signed-off-

treewide: use more specific object_path type

The sdbus++ tool allows the YAML to specify either "path" or
"object_path". Switch to "object_path" everywhere for consistency
and clarity.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I60c51b2ece5fc4cb23d05ce5151301db3dcddf3a

show more ...

prettier: reformat YAML

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ib7050ca82a9826efbd5ef356f546f3c33d7a2186

Syslog: introduce interfaces for e-mail sending

Interfaces to configure multiple e-mail destinations, each with an
individual threshold for the priority level of the syslog messages.

The idea is to

Syslog: introduce interfaces for e-mail sending

Interfaces to configure multiple e-mail destinations, each with an
individual threshold for the priority level of the syslog messages.

The idea is to provide facilities to implement a minimally useful subset
of Redfish Event Destinations for e-mail with ability to add additional
properties if the need arises.

D-Bus object path for each destination contains 8 digits of a mailto
hash, so Level can be changed later but for another URI a new object
needs to be created.

Current set of properties is made on assumption that organisation has an
SMTP smarthost (that BMC is allowed to use without authentication) which
takes care of dispatching messages; rsyslog's ommail module is
considered for the initial implementation.

Example session:

root@qemuarm:~# busctl tree xyz.openbmc_project.Syslog.Config
└─/xyz
└─/xyz/openbmc_project
└─/xyz/openbmc_project/logging
└─/xyz/openbmc_project/logging/config
├─/xyz/openbmc_project/logging/config/mail
│ ├─/xyz/openbmc_project/logging/config/mail/2dc1e699
│ ├─/xyz/openbmc_project/logging/config/mail/5d43d672
│ ├─/xyz/openbmc_project/logging/config/mail/b4dc9055
│ ├─/xyz/openbmc_project/logging/config/mail/d5d4db03
│ └─/xyz/openbmc_project/logging/config/mail/e0974603
└─/xyz/openbmc_project/logging/config/remote
root@qemuarm:~# busctl introspect xyz.openbmc_project.Syslog.Config /xyz/openbmc_project/logging/config/mail
NAME TYPE SIGNATURE RESULT/VALUE FLAGS
org.freedesktop.DBus.Introspectable interface - - -
.Introspect method - s -
org.freedesktop.DBus.Peer interface - - -
.GetMachineId method - s -
.Ping method - - -
org.freedesktop.DBus.Properties interface - - -
.Get method ss v -
.GetAll method s a{sv} -
.Set method ssv - -
.PropertiesChanged signal sa{sv}as - -
xyz.openbmc_project.Collection.DeleteAll interface - - -
.DeleteAll method - - -
xyz.openbmc_project.Logging.Syslog.Destination.Mail interface - - -
.From property s "from@some.domain" emits-change writable
xyz.openbmc_project.Logging.Syslog.Destination.Mail.Create interface - - -
.Create method ss o -
xyz.openbmc_project.Network.Client interface - - -
.Address property s "smarthost.lan" emits-change writable
.Port property q 25 emits-change writable
xyz.openbmc_project.Object.Enable interface - - -
.Enabled property b true emits-change writable
root@qemuarm:~# busctl introspect xyz.openbmc_project.Syslog.Config /xyz/openbmc_project/logging/config/mail/d5d4db03
NAME TYPE SIGNATURE RESULT/VALUE FLAGS
org.freedesktop.DBus.Introspectable interface - - -
.Introspect method - s -
org.freedesktop.DBus.Peer interface - - -
.GetMachineId method - s -
.Ping method - - -
org.freedesktop.DBus.Properties interface - - -
.Get method ss v -
.GetAll method s a{sv} -
.Set method ssv - -
.PropertiesChanged signal sa{sv}as - -
xyz.openbmc_project.Logging.Syslog.Destination.Mail.Entry interface - - -
.Level property s "xyz.openbmc_project.Logging.Entry.Leve… emits-change writable
.Mailto property s "mailto://someone2@otherdomain.test" emits-change
xyz.openbmc_project.Object.Delete interface - - -
.Delete method - - -

Signed-off-by: Paul Fertser <fercerpav@gmail.com>
Change-Id: Ic78fc2bf3608c1dd7ec0c962412e69062dde48d4

show more ...

Logging: README.md: Fix broken links

Do to some refactoring in phosphor-dbus-interfaces and phosphor-logging,
a few of the links in the README.md were broken, resulting in 404
errors. Fix up those b

Logging: README.md: Fix broken links

Do to some refactoring in phosphor-dbus-interfaces and phosphor-logging,
a few of the links in the README.md were broken, resulting in 404
errors. Fix up those broken links to the new locations.

Signed-off-by: Brandon Wyman <bjwyman@gmail.com>
Change-Id: I3aa54fe57c650727ce18447ad2d176d23348ca16

show more ...

doc: format with markdownlint

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Id1efc27791e219e5fbfe08023143be2f59037307

yaml: format with prettier

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I193f690f3612fe72ec69030f81f4d5096a761601

SEL: add record with custom Sensor/Event Type

The existing `IpmiSelAdd` method is suited only to add limited range of
internal SEL record types since it lack some important SEL record
fields.

BMC s

SEL: add record with custom Sensor/Event Type

The existing `IpmiSelAdd` method is suited only to add limited range of
internal SEL record types since it lack some important SEL record
fields.

BMC system may want to support more event types and/or adding external
records with IPMI Add SEL Entry Command. In order to implement this
extended version of the method was added: `AddExtended`.

The method is similar to existing `IpmiSelAdd` except it accept
additional data fields: `eventType`, `sensorType`, `sensorNum` and don't
need `Assert` field since it is part of `eventType`.
`Path` field was not excluded to support case where software want to
define custom eventType but still use internal sensor lookup mechanism.
Empty string can be used when there is no dbus sensor for the record.

Signed-off-by: Andrei Kartashev <a.kartashev@yadro.com>
Change-Id: I595ae9409ef695368e94eca837f9bdc1ad93c0e3

show more ...

Logging: IPMI: Add Clear method

Add the Clear method to xyz.openbmc_project.Logging.IPMI interface
to support clearing the IPMI SEL in phosphor-sel-logger. This method
does not have any arguments or

Logging: IPMI: Add Clear method

Add the Clear method to xyz.openbmc_project.Logging.IPMI interface
to support clearing the IPMI SEL in phosphor-sel-logger. This method
does not have any arguments or return.

Signed-off-by: Charles Boyer <Charles.Boyer@fii-usa.com>
Change-Id: Ib4e4c178ee06cf17c0dc0e789e57483b96e2f436

show more ...

Entry: Add Resolution property

This property can be used to provide suggestions on how to resolve the
situation that caused the log entry. This property is to support
Redfish API version v1_9_0 for

Entry: Add Resolution property

This property can be used to provide suggestions on how to resolve the
situation that caused the log entry. This property is to support
Redfish API version v1_9_0 for LogEntry.

Signed-off-by: Vijay Lobo <vijaylobo@gmail.com>
Change-Id: I6ce909f81c5ed2fd742f95297f07fe6b77021eec

show more ...

Entry: Add ServiceProviderNotify property

Add a ServiceProviderNotify property that can be used to indicate that
this event log should be notified to the service provider, if that is
implemented on

Entry: Add ServiceProviderNotify property

Add a ServiceProviderNotify property that can be used to indicate that
this event log should be notified to the service provider, if that is
implemented on the system.

Signed-off-by: Vijay Lobo <vijaylobo@gmail.com>
Change-Id: I65029020aed35c069d10058159792a75ba188048

show more ...

treewide: Create yaml directory

This allows the propagated yamldir paramter to work correctly in
subproject style builds. We don't want other files in the project
conflicting with tools that scan th

treewide: Create yaml directory

This allows the propagated yamldir paramter to work correctly in
subproject style builds. We don't want other files in the project
conflicting with tools that scan the yamldir.

Change-Id: Ie2759c7f3baf399392cdda0e507055ceb262d2e1
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...