2e8fa88e | 27-Jul-2023 |
Michal Orzel <michalx.orzel@intel.com> |
config: Change authority D-Bus names
Initially CA certificate management service was intended to support only LDAP usecases. However since some time this has become outdated, as certificates stored
config: Change authority D-Bus names
Initially CA certificate management service was intended to support only LDAP usecases. However since some time this has become outdated, as certificates stored there might serve more purposes, such as SSL handshakes or mTLS connections. Therefore, I'm proposing to change service endpoint name from 'ldap' to something more generic, in order to avoid any confusion, that could come up when developing applications would like to utilize this feature.
Tested: Service present on DBus under new name, along with proper object paths.
root@bmc-maca4bf018cd442:~# busctl list | grep phosphor-cert ... xyz.openbmc_project.Certs.Manager.Authority.Truststore 256 phosphor-certif root :1.15 phosphor-certificate-manager@authority.service - - ...
root@bmc-maca4bf018cd442:~# busctl tree xyz.openbmc_project.Certs.Manager.Authority.Truststore `-/xyz `-/xyz/openbmc_project `-/xyz/openbmc_project/certs `-/xyz/openbmc_project/certs/authority `-/xyz/openbmc_project/certs/authority/truststore
Change-Id: I1d2c4ef9e7b4846951ce4dd52f869d7c64f3902d Signed-off-by: Michal Orzel <michalx.orzel@intel.com>
show more ...
|
75111af1 | 12-Apr-2023 |
Patrick Williams <patrick@stwcx.xyz> |
meson: remove deprecated get_pkgconfig_variable
Since meson 0.56, the `get_pkgconfig_variable` has been deprecated. In meson 0.58 the `get_variable` was enhanced to no longer require the `pkgconfig
meson: remove deprecated get_pkgconfig_variable
Since meson 0.56, the `get_pkgconfig_variable` has been deprecated. In meson 0.58 the `get_variable` was enhanced to no longer require the `pkgconfig` keyword argument. Ensure meson 0.58 is required and update the usage of all `get_pkgconfig_variable` and `get_variable` to be the modern variant.
Change-Id: I02322901951608cb3348060f076be10a2a52d022 Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
show more ...
|
332ce8b0 | 31-May-2022 |
Brad Bishop <bradleyb@fuzziesquirrel.com> |
systemd: drop SyslogIdentifier
This is the default behavior, so specifing it is unnecessary.
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com> Change-Id: I3d89bca11b4ad0dab3bf7ae2e06504db096
systemd: drop SyslogIdentifier
This is the default behavior, so specifing it is unnecessary.
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com> Change-Id: I3d89bca11b4ad0dab3bf7ae2e06504db0964b212
show more ...
|
d8b37907 | 26-May-2022 |
Nan Zhou <nanzhoumails@gmail.com> |
systemd: use qualified path
Inspired by https://gerrit.openbmc.org/c/openbmc/phosphor-certificate-manager/+/54051
Tested: on real hardware, these binaries are in /usr/bin
Signed-off-by: Nan Zhou <
systemd: use qualified path
Inspired by https://gerrit.openbmc.org/c/openbmc/phosphor-certificate-manager/+/54051
Tested: on real hardware, these binaries are in /usr/bin
Signed-off-by: Nan Zhou <nanzhou@google.com> Change-Id: I7892cc0d416ca66bcda9ea6d58485dd66fb806a9
show more ...
|
6aef160f | 26-May-2022 |
Brad Bishop <bradleyb@fuzziesquirrel.com> |
systemd: use qualified path
Fix a documented anti-pattern: https://github.com/openbmc/docs/blob/master/anti-patterns.md#use-of-usrbinenv-in-systemd-service-files
Signed-off-by: Brad Bishop <bradley
systemd: use qualified path
Fix a documented anti-pattern: https://github.com/openbmc/docs/blob/master/anti-patterns.md#use-of-usrbinenv-in-systemd-service-files
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com> Change-Id: Ief24dc4a695bc2330243406a7457c518664964be
show more ...
|
7047be67 | 10-Mar-2022 |
Nan Zhou <nanzhoumails@gmail.com> |
argument parser: use CLI11 and add unit tests
CLI11 is one of the most commonly use argument parser in OpenBMC. It can save ~150 lines of codes in this project.
We are hitting argument related bugs
argument parser: use CLI11 and add unit tests
CLI11 is one of the most commonly use argument parser in OpenBMC. It can save ~150 lines of codes in this project.
We are hitting argument related bugs that not covered in unit tests. This test adds a test for argument parsing.
Tested: QEMU IPMI/Redfish worked.
Signed-off-by: Nan Zhou <nanzhoumails@gmail.com> Change-Id: Ib409c7e6a82ad31049f2da3e32727ebdf185f0fc
show more ...
|
1f54ad17 | 13-Dec-2021 |
Patrick Williams <patrick@stwcx.xyz> |
build: remove autotools
Build is switched to meson now, including in the meta-phosphor recipe, so remove all autotools support.
Signed-off-by: Patrick Williams <patrick@stwcx.xyz> Change-Id: I05fb6
build: remove autotools
Build is switched to meson now, including in the meta-phosphor recipe, so remove all autotools support.
Signed-off-by: Patrick Williams <patrick@stwcx.xyz> Change-Id: I05fb6c507369355757831891e3d990c3600b9d86
show more ...
|
bb939ea4 | 03-Dec-2021 |
Patrick Williams <patrick@stwcx.xyz> |
build: add meson support
Port the existing autotools build system to meson, add meson wrap files for all openbmc dependencies, and add appropriate meson rules to gitignore.
Tested:
Verified execut
build: add meson support
Port the existing autotools build system to meson, add meson wrap files for all openbmc dependencies, and add appropriate meson rules to gitignore.
Tested:
Verified executables all build, test cases pass, and executables install. Checked configuration files are all installed into the same locations as a Yocto-built autotools version of the package. Manually checked the symlinks for the systemd service files.
``` $ DESTDIR=/tmp/certificate_test ninja install $ find /tmp/certificate_test/lib /tmp/certificate_test/usr/local/share/phosphor-certificate-manager/ /tmp/certificate_test/lib /tmp/certificate_test/lib/systemd /tmp/certificate_test/lib/systemd/system /tmp/certificate_test/lib/systemd/system/multi-user.target.wants /tmp/certificate_test/lib/systemd/system/multi-user.target.wants/phosphor-certificate-manager@authority.service /tmp/certificate_test/lib/systemd/system/multi-user.target.wants/phosphor-certificate-manager@bmcweb.service /tmp/certificate_test/lib/systemd/system/bmc-vmi-ca-manager.service /tmp/certificate_test/lib/systemd/system/phosphor-certificate-manager@.service /tmp/certificate_test/usr/local/share/phosphor-certificate-manager/ /tmp/certificate_test/usr/local/share/phosphor-certificate-manager/authority /tmp/certificate_test/usr/local/share/phosphor-certificate-manager/bmcweb $ ls -n /tmp/certificate_test/lib/systemd/system/multi-user.target.wants total 0 lrwxrwxrwx 1 1000 1000 40 Dec 3 15:37 phosphor-certificate-manager@authority.service -> ../phosphor-certificate-manager@.service lrwxrwxrwx 1 1000 1000 40 Dec 3 15:37 phosphor-certificate-manager@bmcweb.service -> ../phosphor-certificate-manager@.service ```
Signed-off-by: Patrick Williams <patrick@stwcx.xyz> Change-Id: Ib9700b5a3bb437ccc157a2d060067b8e2b777981
show more ...
|
6dd1c2ad | 02-Apr-2021 |
Anton D. Kachalov <gmouse@google.com> |
Supply service & busconfig ACLs from the repo.
This change required as a part of privilege separation work: https://github.com/openbmc/openbmc/issues/3383
Dependant meta-phosphor change: https:
Supply service & busconfig ACLs from the repo.
This change required as a part of privilege separation work: https://github.com/openbmc/openbmc/issues/3383
Dependant meta-phosphor change: https://gerrit.openbmc-project.xyz/c/openbmc/openbmc/+/41430
Signed-off-by: Anton D. Kachalov <gmouse@google.com> Change-Id: Ic0b1b57f8a088defe096f1ab793efa1f015ca5be
show more ...
|