| a2f68d8b | 16-Aug-2024 |
Patrick Williams <patrick@stwcx.xyz> |
clang-format: re-format for clang-18
clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda forma
clang-format: re-format for clang-18
clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda formatting also changed, so we have made changes to the
organization default style format to better handle lambda formatting.
See I5e08687e696dd240402a2780158664b7113def0e for updated style.
See Iea0776aaa7edd483fa395e23de25ebf5a6288f71 for clang-18 enablement.
Change-Id: Ic1ad64722b2368169dfb0e62c37f7f3c1ff20fe8
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
show more ...
|
| f2646271 | 30-Sep-2023 |
Ravi Teja <raviteja28031990@gmail.com> |
logging: switch to lg2
It is recommended to use `phosphor::lg2` to format log,
and the correct `CODE_LINE` and `CODE_FUNC` values
can be used in log tracking.
Tested By: Built CertificateManager su
logging: switch to lg2
It is recommended to use `phosphor::lg2` to format log,
and the correct `CODE_LINE` and `CODE_FUNC` values
can be used in log tracking.
Tested By: Built CertificateManager successfully and Unit Test passes.
Change-Id: Ib2ff946febfe0335d4ecf5fa932683d3a0f117bb
Signed-off-by: Ravi Teja <raviteja28031990@gmail.com>
show more ...
|
| 223e4604 | 10-May-2023 |
Patrick Williams <patrick@stwcx.xyz> |
clang-format: copy latest and re-format
clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest
clang-format: copy latest and re-format
clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.
Change-Id: Ie4138afe359d52b9f1a32fdff6890a90dd31efa8
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
show more ...
|
| 8dd31c80 | 29-Nov-2022 |
Adriana Kobylak <anoo@us.ibm.com> |
bmc-vmi-ca: Fix executable name
The executable name expected by the bmc-vmi-ca-manager.service file is
bmc-vmi-ca, but when the repo was updated to use meson, the file name
was mistakenly set to bmc
bmc-vmi-ca: Fix executable name
The executable name expected by the bmc-vmi-ca-manager.service file is
bmc-vmi-ca, but when the repo was updated to use meson, the file name
was mistakenly set to bmc_vmi_ca.
Tested: Verified the service started successfully in p10bmc:
```
root@p10bmc:~# systemctl status bmc-vmi-ca-manager
* bmc-vmi-ca-manager.service - BMC VMI CA authority manager
Loaded: loaded
(8;;file://p10bmc/lib/systemd/system/bmc-vmi-ca-manager.service/lib/systemd/system/bmc-vmi-ca-manager.service8;;;
enabled; preset: enabled)
Active: active (running) since Thu 2022-12-01 20:45:46 UTC; 1min
44s ago
Main PID: 236 (bmc-vmi-ca)
CPU: 6ms
CGroup: /system.slice/bmc-vmi-ca-manager.service
`-236 /usr/bin/bmc-vmi-ca
Dec 01 20:45:45 p10bmc systemd[1]: Starting BMC VMI CA authority
manager...
Dec 01 20:45:46 p10bmc systemd[1]: Started BMC VMI CA authority manager.
```
Change-Id: Id32c79a470255e6818d46e27cab82e17fc10c4f4
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>
show more ...
|
| 6f45ce04 | 19-Sep-2022 |
Nan Zhou <nanzhoumails@gmail.com> |
bmc-vmi-ca: use processs_loop
In reference [1], sdbusplus introduces its own process loop. This patch
removed the unncesssary sdeventplus dependency from bmc-vmi-ca, and uses
the sdbusplus built-in
bmc-vmi-ca: use processs_loop
In reference [1], sdbusplus introduces its own process loop. This patch
removed the unncesssary sdeventplus dependency from bmc-vmi-ca, and uses
the sdbusplus built-in process loop instead.
[1] https://gerrit.openbmc.org/c/openbmc/sdbusplus/+/56891
Tested:
1. The daemon starts correctly
2. Tested several dbus commands via busctl (introspect, DeleteAll, etc)
Signed-off-by: Nan Zhou <nanzhoumails@gmail.com>
Change-Id: I802f18f077e7b0bd3bf0b910c56b1f560fe342e7
show more ...
|
| b3dbfb37 | 22-Jul-2022 |
Patrick Williams <patrick@stwcx.xyz> |
sdbusplus: use shorter type aliases
The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are
sdbusplus: use shorter type aliases
The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are for:
* bus_t
* exception_t
* manager_t
* match_t
* message_t
* object_t
* slot_t
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I9bb7b9a430d029ddaf2a08ea26acb775b9b2b152
show more ...
|
| ebd21ba4 | 05-Apr-2022 |
Patrick Williams <patrick@stwcx.xyz> |
sdbusplus: object: don't use 'bool' argument constructor
`sdbusplus::server::object_t` has long had an enum-based parameter for
signal action, but maintained a backwards compatible boolean mapping.
sdbusplus: object: don't use 'bool' argument constructor
`sdbusplus::server::object_t` has long had an enum-based parameter for
signal action, but maintained a backwards compatible boolean mapping.
It is time to remove this boolean to make it more observable which
actions are being used in applications. Map all `true` occurrences to
`action::defer_emit`.
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I4137ab812650afc09073d7b110254de87d5e5710
show more ...
|
| cf06ccdc | 28-Dec-2021 |
Nan Zhou <nanzhoumails@gmail.com> |
clean up using directives and type alias
Most C++ style guides try to avoid using directives in headers and also
suggest using type alias carefully, according to which, this change does
the followin
clean up using directives and type alias
Most C++ style guides try to avoid using directives in headers and also
suggest using type alias carefully, according to which, this change does
the following clean up:
1. used Enum class to represent Certificate type
2. removed all using directives: e.g. the phosphor logging namespace;
instead, this change uses using declarations
3. removed unnecessary type alias; in existing codes, we only support
strings as types of UnitToRestart, InstallPath, UploadPath, etc; this
change uses std::string directly
4. moved all alias outside any class scope into source files or an
internal namespace
5. renamed types, constants, classes as per OpenBMC style guide
6. fixed all compilation errors and some warnings after the refactoring;
built with both Clang & GCC
Reference:
https://docs.microsoft.com/en-us/cpp/cpp/header-files-cpp?view=msvc-170#what-to-put-in-a-header-file
https://google.github.io/styleguide/cppguide.html#Namespaces
Tested:
Unit tests
Signed-off-by: Nan Zhou <nanzhoumails@gmail.com>
Change-Id: I58e026934a4e969f4d8877801c8f3c671990468a
show more ...
|
| 718eef37 | 28-Dec-2021 |
Nan Zhou <nanzhoumails@gmail.com> |
config.h.in: use const variables instead of macros
Most style guides try to avoid preprocessor macros, especially the use
case here: const objects. This change replaced them with const
variables. Th
config.h.in: use const variables instead of macros
Most style guides try to avoid preprocessor macros, especially the use
case here: const objects. This change replaced them with const
variables. Their names are also changed according to the OpenBMC style
guide.
Reference:
https://google.github.io/styleguide/cppguide.html#Preprocessor_Macros
Signed-off-by: Nan Zhou <nanzhoumails@gmail.com>
Change-Id: I0786c7c83f3a0d892c14f1cb813d0aa16d627b3e
show more ...
|
| e1289adf | 28-Dec-2021 |
Nan Zhou <nanzhoumails@gmail.com> |
Use nested namespace
Nested namespace is introduced in C++ 17. This saves nearly 50 lines.
This change also puts tests into a nested namespace, which saves
unnecessary using directives.
Signed-off-
Use nested namespace
Nested namespace is introduced in C++ 17. This saves nearly 50 lines.
This change also puts tests into a nested namespace, which saves
unnecessary using directives.
Signed-off-by: Nan Zhou <nanzhoumails@gmail.com>
Change-Id: I7c3e38588fd5c2cbd83ac13ee24327318e8c06a4
show more ...
|
| 1f54ad17 | 13-Dec-2021 |
Patrick Williams <patrick@stwcx.xyz> |
build: remove autotools
Build is switched to meson now, including in the meta-phosphor recipe,
so remove all autotools support.
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I05fb6
build: remove autotools
Build is switched to meson now, including in the meta-phosphor recipe,
so remove all autotools support.
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I05fb6c507369355757831891e3d990c3600b9d86
show more ...
|
| bb939ea4 | 03-Dec-2021 |
Patrick Williams <patrick@stwcx.xyz> |
build: add meson support
Port the existing autotools build system to meson, add meson wrap files
for all openbmc dependencies, and add appropriate meson rules to
gitignore.
Tested:
Verified execut
build: add meson support
Port the existing autotools build system to meson, add meson wrap files
for all openbmc dependencies, and add appropriate meson rules to
gitignore.
Tested:
Verified executables all build, test cases pass, and executables
install. Checked configuration files are all installed into the same
locations as a Yocto-built autotools version of the package. Manually
checked the symlinks for the systemd service files.
```
$ DESTDIR=/tmp/certificate_test ninja install
$ find /tmp/certificate_test/lib /tmp/certificate_test/usr/local/share/phosphor-certificate-manager/
/tmp/certificate_test/lib
/tmp/certificate_test/lib/systemd
/tmp/certificate_test/lib/systemd/system
/tmp/certificate_test/lib/systemd/system/multi-user.target.wants
/tmp/certificate_test/lib/systemd/system/multi-user.target.wants/phosphor-certificate-manager@authority.service
/tmp/certificate_test/lib/systemd/system/multi-user.target.wants/phosphor-certificate-manager@bmcweb.service
/tmp/certificate_test/lib/systemd/system/bmc-vmi-ca-manager.service
/tmp/certificate_test/lib/systemd/system/phosphor-certificate-manager@.service
/tmp/certificate_test/usr/local/share/phosphor-certificate-manager/
/tmp/certificate_test/usr/local/share/phosphor-certificate-manager/authority
/tmp/certificate_test/usr/local/share/phosphor-certificate-manager/bmcweb
$ ls -n /tmp/certificate_test/lib/systemd/system/multi-user.target.wants
total 0
lrwxrwxrwx 1 1000 1000 40 Dec 3 15:37 phosphor-certificate-manager@authority.service -> ../phosphor-certificate-manager@.service
lrwxrwxrwx 1 1000 1000 40 Dec 3 15:37 phosphor-certificate-manager@bmcweb.service -> ../phosphor-certificate-manager@.service
```
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ib9700b5a3bb437ccc157a2d060067b8e2b777981
show more ...
|
| 7e2797ee | 03-Dec-2021 |
Patrick Williams <patrick@stwcx.xyz> |
fix unused parameter warnings
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ic045f61b3657f1a21afd82b9975619a8fb440863 |
| a7846b39 | 02-Sep-2021 |
Patrick Williams <patrick@stwcx.xyz> |
cleanup sdbus CAMELCASE define
The transition from e129be3b566a187f42e4ab45bccfb10d35dc3d71 is
complete, so clean up the old defines.
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id:
cleanup sdbus CAMELCASE define
The transition from e129be3b566a187f42e4ab45bccfb10d35dc3d71 is
complete, so clean up the old defines.
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ia1570296370970999171cfa7c2c3aa7b16a8f32e
show more ...
|
| 6dd1c2ad | 02-Apr-2021 |
Anton D. Kachalov <gmouse@google.com> |
Supply service & busconfig ACLs from the repo.
This change required as a part of privilege separation work:
https://github.com/openbmc/openbmc/issues/3383
Dependant meta-phosphor change:
https:
Supply service & busconfig ACLs from the repo.
This change required as a part of privilege separation work:
https://github.com/openbmc/openbmc/issues/3383
Dependant meta-phosphor change:
https://gerrit.openbmc-project.xyz/c/openbmc/openbmc/+/41430
Signed-off-by: Anton D. Kachalov <gmouse@google.com>
Change-Id: Ic0b1b57f8a088defe096f1ab793efa1f015ca5be
show more ...
|
| e129be3b | 30-Apr-2021 |
Patrick Williams <patrick@stwcx.xyz> |
use new sdbus++ camelcase for CSR.
Change I17a8d7479556596a3cf252b3f4eae9c8df547189 will change
how sdbus++ generates names which start with an acronym.
Prepare for this by keying off the SDBUSPP_NE
use new sdbus++ camelcase for CSR.
Change I17a8d7479556596a3cf252b3f4eae9c8df547189 will change
how sdbus++ generates names which start with an acronym.
Prepare for this by keying off the SDBUSPP_NEW_CAMELCASE
define to use the new format.
Changes:
cSR() -> csr()
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I9adb628d7d064af9f65d37aebe99e06532690163
show more ...
|
| 86a31ba5 | 23-Apr-2021 |
Ravi Teja <raviteja28031990@gmail.com> |
CA Cert: Fix D-bus object path
Modify object path as static const char
Signed-off-by: Ravi Teja <raviteja28031990@gmail.com>
Change-Id: I49cbd086dca38f30b103a5a3077f613c50c8520b |
| 11d09066 | 20-Apr-2021 |
Ravi Teja <raviteja28031990@gmail.com> |
CA Certs: Modify object entry path to fix object sub-tree hierarchy
Currently there is no interface added signal generated as object
path is not following hierarchy.
to fix this behaviour, this com
CA Certs: Modify object entry path to fix object sub-tree hierarchy
Currently there is no interface added signal generated as object
path is not following hierarchy.
to fix this behaviour, this commit modifies object entry path
to /xyz/openbmc_project/certs/ca/entry/<id>
InterfacesAdded signal:
signal time=1619111735.917791 sender=:1.660 -> destination=(null destination)
serial=68 path=/xyz/openbmc_project/certs/ca; interface=org.freedesktop.DBus.ObjectManager;
member=InterfacesAdded
object path "/xyz/openbmc_project/certs/ca/entry/6"
Tested by:
D-bus monitor while Creating dbus objects
Signed-off-by: Ravi Teja <raviteja28031990@gmail.com>
Change-Id: I3ce8aa2b2ec5da321557ea40f484ea2947d57442
show more ...
|
| ea7c3f0c | 15-Sep-2020 |
Ravi Teja <raviteja28031990@gmail.com> |
Add unit testcases for CA certificate authority manager
This test cases can be enabled by using below feature flag
"--enable-ca-cert-extension"
Testcases:
testObjectCreation
testInvalidArgument
Del
Add unit testcases for CA certificate authority manager
This test cases can be enabled by using below feature flag
"--enable-ca-cert-extension"
Testcases:
testObjectCreation
testInvalidArgument
DeleteAllCSRObjects
DeleteObjectEntry
Signed-off-by: Ravi Teja <raviteja28031990@gmail.com>
Change-Id: I9e30f28ef73ecdc377ae357e9c73c42063f85137
show more ...
|
| a49895ee | 16-Jun-2020 |
Ravi Teja <raviteja28031990@gmail.com> |
Implementation of BMC VMI certificate manager
This manager is to create and manage entries
for each host CSR request which needs to shared
with host.
this commits implements dbus interfaces
https:/
Implementation of BMC VMI certificate manager
This manager is to create and manage entries
for each host CSR request which needs to shared
with host.
this commits implements dbus interfaces
https://gerrit.openbmc-project.xyz/c/openbmc/phosphor-dbus-interfaces/+/31808
This feature can be enabled by using below feature flag
"--enable-ca-cert-extension"
Testby:
Creating CSR entries
Deleting entries
Setting properties
Signed-off-by: Ravi Teja <raviteja28031990@gmail.com>
Change-Id: I24829b839feac6264f32053b9be63daef6599379
show more ...
|