clang-tidy: Customize Configuration

The .clang-tidy file has been updated to align with the recommended
clang-tidy categories for C++ projects in OpenBMC. All recommended
categories are enabled, and

clang-tidy: Customize Configuration

The .clang-tidy file has been updated to align with the recommended
clang-tidy categories for C++ projects in OpenBMC. All recommended
categories are enabled, and failing checks are disabled by prefixing
them with a '-'.

This approach allows to improve coverage by enabling failing checks
and making necessary code changes to fix failures over time.

Tested: Build and unit tests verified.

Change-Id: I2b71e48baf4f7dd00c977996f93d6aebc41a35c3
Signed-off-by: Jayanth Othayoth <ojayanth@gmail.com>

show more ...

clang-tidy: Enable modernize-use-nullptr

Modified code to address issues flagged by this check.

Tested: Build and unit tests passed successfully.

Change-Id: Idd4daacdcb998d49b938b1d2a194084781d11e

clang-tidy: Enable modernize-use-nullptr

Modified code to address issues flagged by this check.

Tested: Build and unit tests passed successfully.

Change-Id: Idd4daacdcb998d49b938b1d2a194084781d11e96
Signed-off-by: Jayanth Othayoth <ojayanth@gmail.com>

show more ...

clang-tidy: Add modernize checks

These changes improve code readability, maintainability, and
performance by leveraging modern C++ features and best practices.

Tested: Build and unit tests passed s

clang-tidy: Add modernize checks

These changes improve code readability, maintainability, and
performance by leveraging modern C++ features and best practices.

Tested: Build and unit tests passed successfully.

Change-Id: Ia87cc327ec421e1166d6dc6a7e6c2a456aefa20c
Signed-off-by: Jayanth Othayoth <ojayanth@gmail.com>

show more ...

clang-tidy: Enable readability checks on repo

The readability-* checks in Clang-Tidy focus on improving code
readability by enforcing guidelines and suggesting improvements
that can enhance the clar

clang-tidy: Enable readability checks on repo

The readability-* checks in Clang-Tidy focus on improving code
readability by enforcing guidelines and suggesting improvements
that can enhance the clarity and maintainability of C++ code.

Tested: Build and unit tests passed successfully.

Change-Id: Iad54f281139883d9d535a6951571e4fdc978fd8b
Signed-off-by: Jayanth Othayoth <ojayanth@gmail.com>

show more ...

clang-tidy: Add performance checks

The checks are valuable for improving the runtime efficiency and
resource utilization of your programs.

Tested: Build and unit tests passed successfully.

Change-

clang-tidy: Add performance checks

The checks are valuable for improving the runtime efficiency and
resource utilization of your programs.

Tested: Build and unit tests passed successfully.

Change-Id: I83a26416f2ce057ac5ae1d58bb5a8bdd989df4b1
Signed-off-by: Jayanth Othayoth <ojayanth@gmail.com>

show more ...

clang-tidy: clang-tidy: Add few misc checks

Checks that encompass various miscellaneous guidelines and rules
that don't fall into more specific categories like readability,
performance, or correctne

clang-tidy: clang-tidy: Add few misc checks

Checks that encompass various miscellaneous guidelines and rules
that don't fall into more specific categories like readability,
performance, or correctness. These checks often focus on code
quality, stylistic preferences, or potential pitfalls that are
not covered by other specific checks.

Tested: Build and unit tests passed successfully.

Change-Id: I62baa5723a550edf540a9b399f808a5e526f8058
Signed-off-by: Jayanth Othayoth <ojayanth@gmail.com>

show more ...

clang-tidy: Add few cppcoreguidelines check

These checks cover a wide range of best practices and
recommendations aimed at improving the safety, readability,
maintainability, and performance of our

clang-tidy: Add few cppcoreguidelines check

These checks cover a wide range of best practices and
recommendations aimed at improving the safety, readability,
maintainability, and performance of our C++ codebase according
to the C++ Core Guidelines.

Tested: Build and unit tests passed successfully.

Change-Id: Ia815f391419ff4e5d80b3793c760dcbce689c734
Signed-off-by: Jayanth Othayoth <ojayanth@gmail.com>

show more ...

clang-tidy: Add clang-analyzer checks

This checks primary purpose is to identify potential bugs,security
vulnerabilities, and adherence to coding standards by examining
the source code without execu

clang-tidy: Add clang-analyzer checks

This checks primary purpose is to identify potential bugs,security
vulnerabilities, and adherence to coding standards by examining
the source code without executing it.

Tested: Build and unit tests passed successfully.

Change-Id: If17acfe556e5fd98b6ac34df0f65991435e4ed0f
Signed-off-by: Jayanth Othayoth <ojayanth@gmail.com>

show more ...

clang-tidy: Enable cert-env33-c

Modified code to address issues flagged by this check.

Tested: Build and unit tests completed successfully.

Change-Id: Ic84d34ce664870988054284ecba4903805037210
Sig

clang-tidy: Enable cert-env33-c

Modified code to address issues flagged by this check.

Tested: Build and unit tests completed successfully.

Change-Id: Ic84d34ce664870988054284ecba4903805037210
Signed-off-by: Jayanth Othayoth <ojayanth@gmail.com>

show more ...

clang-tidy: Add cert checks

This update enhances code security by incorporating CERT guideline
checks using clang-tidy. These checks are designed to identify
potential security vulnerabilities and e

clang-tidy: Add cert checks

This update enhances code security by incorporating CERT guideline
checks using clang-tidy. These checks are designed to identify
potential security vulnerabilities and ensure compliance with
secure coding standards.

Tested: Build and unit tests passed successfully.

Change-Id: I303cd24bef6eb8a83eb6a320121db2ff8ab076d6
Signed-off-by: Jayanth Othayoth <ojayanth@gmail.com>

show more ...

clang-tidy: Enable bugprone-unused-local-non-tri

Modified code to address issues flagged by
bugprone-unused-local-non-trivial-variable check.

Tested: Build and unit tests passed successfully.

Chan

clang-tidy: Enable bugprone-unused-local-non-tri

Modified code to address issues flagged by
bugprone-unused-local-non-trivial-variable check.

Tested: Build and unit tests passed successfully.

Change-Id: I21eca96e7582d24af398fb502540e0b51b0ca7fa
Signed-off-by: Jayanth Othayoth <ojayanth@gmail.com>

show more ...

clang-tidy: Enable bugprone-implicit-widening-of

Modified code to address issues flagged by
bugprone-implicit-widening-of-multiplication-result check.

Tested: Build and unit tests passed successful

clang-tidy: Enable bugprone-implicit-widening-of

Modified code to address issues flagged by
bugprone-implicit-widening-of-multiplication-result check.

Tested: Build and unit tests passed successfully.

Change-Id: I68bae8863c9e2d57154588bfda8c1e235637dffe
Signed-off-by: Jayanth Othayoth <ojayanth@gmail.com>

show more ...

clang-tidy: Enable bugprone-narrowing-conversions

Modified code to address issues flagged by this check.

Tested: Build and unit tests passed successfully.

Change-Id: I17111e3f00ad0dbf5d0d72d5ccd37

clang-tidy: Enable bugprone-narrowing-conversions

Modified code to address issues flagged by this check.

Tested: Build and unit tests passed successfully.

Change-Id: I17111e3f00ad0dbf5d0d72d5ccd374367e4cca36
Signed-off-by: Jayanth Othayoth <ojayanth@gmail.com>

show more ...

clang-tidy: Enable bugprone-assignment-in-if

Modified code to address issues flagged by this check.

Tested: Build and unit tests passed successfully.

Change-Id: I3b5f7c29fa38fc39da06e27488d7086600

clang-tidy: Enable bugprone-assignment-in-if

Modified code to address issues flagged by this check.

Tested: Build and unit tests passed successfully.

Change-Id: I3b5f7c29fa38fc39da06e27488d70866006695c9
Signed-off-by: Jayanth Othayoth <ojayanth@gmail.com>

show more ...

clang-tidy: Add bugprone checks

Enable bugprone checks to identify problematic patterns that could
lead to bugs or undefined behavior.

Tested: Build and unit tests passed successfully.

Change-Id:

clang-tidy: Add bugprone checks

Enable bugprone checks to identify problematic patterns that could
lead to bugs or undefined behavior.

Tested: Build and unit tests passed successfully.

Change-Id: I27ba4998b4ae86d8148b82f73917222debf96159
Signed-off-by: Jayanth Othayoth <ojayanth@gmail.com>

show more ...

clang-tidy: enable clang-tidy

Enable the first check: readability-identifier-naming

Also fixed all check failures. The renaming is done by clang-tidy
automatically.

Tested:
1. compiles, no clang-t

clang-tidy: enable clang-tidy

Enable the first check: readability-identifier-naming

Also fixed all check failures. The renaming is done by clang-tidy
automatically.

Tested:
1. compiles, no clang-tidy failures
2. tested on QEMU, Redfish is working correctly
3. tested on s7106, Redfish is working correctly; certificates can be
retrieved.

Signed-off-by: Nan Zhou <nanzhoumails@gmail.com>
Change-Id: I3c5c9ca734146a94f4e0433ed8c1ae84173288c5

show more ...